github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity
25,465 Commits 34 Branches 105 Tags
d2db917841cacbdd6320460fd6fa3d07cd972139
Commit Graph

2655 Commits

Author SHA1 Message Date
Vijay Dev
0d3d9a150a closes #3241 - partial doc fix 2011-10-07 23:53:12 +05:30
Vijay Dev
46ce7f1f77 Merge branch 'master' of github.com:lifo/docrails 2011-10-05 18:42:18 +05:30
José Valim
87c57bb88f Fix the lame config.action_controller.present? check scattered throughout assets_path. 
Conflicts:

	actionpack/test/template/sprockets_helper_test.rb
 2011-10-05 02:35:43 +02:00
José Valim
5711a35ad8 Ensure default_asset_host_protocol is respected, closes #2980. 2011-10-05 02:08:02 +02:00
Alexey Vakhov
f51cb36fe9 missed underscore in AV::TestCase helper_method documentation 2011-10-03 10:36:13 +04:00
Wen-Tien Chang
3058d13a06 Make button_to helper support "form" option which is the form attributes. 2011-09-29 01:40:15 +08:00
Alexey Vakhov
5ffa69793f escape options for the stylesheet_link_tag method 2011-09-25 09:40:49 +04:00
José Valim
e8987c30d0 Use safe_constantize where possible. 2011-09-23 16:46:33 +02:00
Nick Sutterer
552df29cc8 Using #extract_details in PartialRenderer, too! 2011-09-23 00:36:17 +02:00
Nick Sutterer
2e3eb2560b Allow both sym and array for details options in #render. using LC#registered_details to extract options. 2011-09-23 00:36:14 +02:00
José Valim
43d27e9105 Deprecate passing the template handler in the template name. 
For example, calling hello.erb is now deprecated. Since Rails 3.0
passing the handler had no effect whatsover. This commit simply
deprecates such cases so we can clean up the code in later releases.
 2011-09-22 15:37:38 +02:00
José Valim
c3fa2e9bf8 Make handlers a registered detail. 2011-09-22 15:06:04 +02:00
José Valim
119e9e2daf Get rid of update_details in favor of passing details to find_template. 2011-09-22 15:03:05 +02:00
Nick Sutterer
cbaad674f1 it is now possible to pass details options (:formats, :details, :locales, ...) to #render, #find_template and friends. this doesn't change anything in global context. 2011-09-22 14:12:36 +02:00
José Valim
1ca3fbfbf2 No need to recalculate the @details_key after update_details. 2011-09-22 12:26:37 +02:00
José Valim
f373f296d0 Slightly reorganize lookup context modules in order to better isolate cache responsibilities. 2011-09-21 15:37:10 -07:00
Santiago Pastorino
da7f0426ec Allow asset tag helper methods to accept :digest => false option in order to completely avoid the digest generation. 2011-09-14 15:02:17 -07:00
Santiago Pastorino
ae04fbfee9 Fix asset_path relative_url_root method 2011-09-13 02:45:05 -07:00
Santiago Pastorino
5bad79d930 always rewrite_relative_url_root 2011-09-13 00:27:29 -07:00
Guillermo Iguaran
f746927889 Remove odd asignation 2011-09-12 13:16:55 -05:00
Vijay Dev
0d25491581 Merge branch 'master' of github.com:lifo/docrails 2011-09-08 18:06:43 +05:30
Santiago Pastorino
a23e3855c5 Merge pull request #2872 from sikachu/content_tag_html_safe 
Make sure that result from content_tag_for with collection is html_safe
 2011-09-05 07:08:39 -07:00
Santiago Pastorino
f4a690dae7 Merge pull request #2815 from avakhov/current-page-non-get-requests 
current_page? returns false for non-GET requests
 2011-09-05 06:13:14 -07:00
Santiago Pastorino
c255e0eed5 Merge pull request #2799 from tomstuart/3-1-stable 
Never return stored content from content_for when a block is given
 2011-09-05 10:11:43 -03:00
Prem Sichanugrist
ffe56f3b8c Make sure that result from content_tag_for with collection is html_safe 
Thank you @spastorino for catching the empty test in b84cee0, as I totally forgot that I still have to make it html_safe.
 2011-09-05 20:04:37 +07:00
Hendy Tanata
0a2ea92efa Fix grammar for content_tag_for and div_for docs. 2011-09-05 08:08:38 +08:00
Milan Dobrota
9b08afd2f4 if ... nil? is more expensive than unless 2011-09-04 10:44:08 -05:00
Prem Sichanugrist
b84cee08c6 Make content_tag_for and div_for accepts the array of records 
So instead of having to do this:

   @items.each do |item|
     content_tag_for(:li, item) do
        Title: <%= item.title %>
     end
   end

You can now do this:

   content_tag_for(:li, @items) do |item|
     Title: <%= item.title %>
   end
 2011-09-04 11:55:12 +07:00
Alexey Vakhov
fddf7ea1c1 current_page? returns false for non-GET requests 2011-09-02 18:20:10 +04:00
Gabe Berke-Williams
de6660b5ec Improve examples: use each instead of for...in 2011-08-31 20:52:35 -04:00
Santiago Pastorino
eb6906890e Tiny refactor 2011-08-25 11:40:59 -03:00
Santiago Pastorino
67274ca162 Merge pull request #2491 from waynn/fix_symbol 
fix destructive stringify_keys for label_tag
 2011-08-25 07:39:31 -07:00
Santiago Pastorino
289540e4ff Revert "Simplify JavaScriptHelper#escape_javascript" 
This commit broke the build without any improvement.

This reverts commit eb0b71478a.
 2011-08-24 13:22:37 -03:00
Daniel Schierbeck
eb0b71478a Simplify JavaScriptHelper#escape_javascript 
Use the Linus-style conditional. Also fix the documentation slightly.

Signed-off-by: Andrew White <andyw@pixeltrix.co.uk>
 2011-08-24 11:36:45 +01:00
Andrew White
13400ac289 Ensure regexp and hash key are UTF-8 2011-08-23 14:56:04 +01:00
Teng Siong Ong
f6ceb944ea fix escape_javascript for unicode character \u2028. 2011-08-21 15:14:45 -05:00
asmega
ebe9155313 Use typewriter styling on url_for in documentation 2011-08-21 16:40:56 +01:00
Xavier Noria
cc90adfd2a minor details revised in a gsub 
Regexps have a construct to express alternation of characters, which
is character classes. In addition to being the most specific idiom to
write this pattern, it reads better without the backslashes. Also, it
is better not to use a capture if none is needed. As a side-effect of
these changes, the gsub is marginally faster, but speed is not the
point of this commit.
 2011-08-18 03:09:18 -07:00
Aaron Patterson
5f94b93279 Properly escape glob characters. 2011-08-16 15:28:27 -07:00
Arun Agrawal
5bc87cc2ee We need [] method here. previously it's an array. 2011-08-13 13:13:05 +05:30
Waynn Lue
895d64531d fix destructive stringify_keys for label_tag 2011-08-11 00:30:45 -07:00
Gonzalo Rodriguez and Leonardo Capillera
9e81bfd8fc Remove 'parameters_for_url' parameter from 'form_tag' method signature 
If you use that parameter it will end calling to url_for with two
arguments, which fails because url_for expects only one
 2011-08-10 23:14:56 -03:00
Aaron Patterson
f9f423fa18 deprecating process_view_paths 2011-08-09 12:10:25 -07:00
Aaron Patterson
26e53a16c4 just use map and case / when rather than modifying the iterating array 2011-08-09 11:30:43 -07:00
Aaron Patterson
7cd3772fe6 only typecast what we need to typecast 2011-08-09 11:26:44 -07:00
Aaron Patterson
b14f1c3ad7 Favor composition over inheritance. 2011-08-09 11:23:02 -07:00
Aaron Patterson
14a8fd146a Just remove the sort_locals method 2011-08-09 10:13:02 -07:00
Aaron Patterson
1fbc4704df the freeze trick does nothing on arrays used as hash keys. 2011-08-09 10:09:46 -07:00
Aaron Patterson
233696a027 use functional style to build a list of template objects 2011-08-09 09:32:16 -07:00
Aaron Patterson
37b77c6ae7 refactor the optimized build_query a bit 2011-08-08 22:16:52 -07:00