Aaron Patterson
8c511c0b3c
swap out some n^2 for some n
2010-10-19 20:53:53 -07:00
Aaron Patterson
8d5829f149
dup rather than create so many arrays
2010-10-19 17:51:46 -07:00
Aaron Patterson
dc16163d06
use array math rather than looping through the array
2010-10-19 17:46:54 -07:00
Aaron Patterson
c56fea2be4
use shortened version to generate a sql literal
2010-10-19 17:44:33 -07:00
Aaron Patterson
08636527b5
avoid cloning if we do not need to clone
2010-10-19 17:44:07 -07:00
Aaron Patterson
78b6f64105
avoid creating a proc object when possible
2010-10-19 17:37:55 -07:00
Aaron Patterson
d2898d4ef8
scopes can take an object that responds to call
2010-10-19 17:29:25 -07:00
Aaron Patterson
56be4c897a
avoid creating the proc object if possible
2010-10-19 17:29:25 -07:00
Aaron Patterson
e68f339aae
default scope can accept any object that responds to #call
2010-10-19 15:07:44 -07:00
Tim Morgan
b1b26af9a2
Allow default_scope to accept a Proc.
2010-10-19 14:43:31 -07:00
Aaron Patterson
1856e975c3
"instance_methods" includes public and protected
2010-10-19 08:30:45 -07:00
Michał Łomnicki
4120e95dce
Use ALTER INDEX syntax to rename an index
2010-10-19 08:40:28 +08:00
Santiago Pastorino
67df21f895
No need for parenthesis here
2010-10-17 12:34:51 -02:00
Neeraj Singh
f527f9097b
no need to check for nil
...
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com >
2010-10-17 12:26:47 -02:00
Neeraj Singh
ea14396c45
replace if ! with unless
...
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com >
2010-10-17 12:26:32 -02:00
Xavier Noria
21ff8849bb
in regexps, the dot in a character class is not a metacharacter
2010-10-15 16:31:00 +02:00
Carl Lerche
69789c3b29
#transaction on the instance level should take options as well
2010-10-14 21:27:40 -07:00
Michael Koziarski
9ebe582830
Revert 0c0b0aa0f2 which introduced a security vulnerability.
...
This addresses CVE-2010-3933
Conflicts:
activerecord/lib/active_record/nested_attributes.rb
2010-10-15 10:27:33 +13:00
Xavier Noria
13f7f89bda
Merge branch 'master' of git://github.com/lifo/docrails
2010-10-14 23:15:23 +02:00
Piotr Sarnacki
f07cbec865
Do not treat information about skipped migrations as WARNINGs but as a NOTEs, also puts to stdin
2010-10-14 07:46:12 +02:00
Carl Lerche
91ba75806f
Update the ActiveRecord tests to not set unused options
...
This makes a test fail, but it is revealing a bug in Arel master.
2010-10-13 12:32:52 -07:00
Rafael Mendonça França
aec5ef243a
Remove doc for debugging callbacks. Methods don't exist in Rails master
2010-10-13 15:59:57 -03:00
Carl Lerche
0b6af35ef0
Update the PostgreSQL adapter documentation
2010-10-13 11:49:32 -07:00
Carl Lerche
941844cbe5
rb_thread_select should always be used in DB drivers when available.
2010-10-13 11:40:47 -07:00
Jon Leighton
1ddbb216ea
Delete unused methods in JoinAssociation
2010-10-13 08:24:19 -07:00
Jon Leighton
19304a9758
Renaming and formatting changes in JoinDependency
2010-10-13 08:24:19 -07:00
Jon Leighton
7dcb633427
Refactor JoinDependency and friends so that a JoinAssociation can produce an arbitrary number of joins, which will be needed in order to support nested through associations.
2010-10-13 08:24:19 -07:00
Aaron Patterson
603406dc53
stop using deprecated arel API
2010-10-12 14:33:16 -07:00
Aaron Patterson
25a2909355
dry up column type testing
2010-10-12 13:13:19 -07:00
Aaron Patterson
4b2e16ed24
all columns respond to string_to_binary, so no need to check respond_to?
2010-10-12 13:10:52 -07:00
Aaron Patterson
5b5ae01f29
drying up true and false cases
2010-10-12 11:59:20 -07:00
Aaron Patterson
01893f43f6
reducing comparisons in when statements
2010-10-12 11:55:52 -07:00
Aaron Patterson
9852a72417
removing intermediate variables
2010-10-12 11:48:41 -07:00
Aaron Patterson
c882154cd1
reduce the number of times we test for the column variable
2010-10-12 11:45:59 -07:00
Aaron Patterson
31b132aa9b
refactoring date / time / datetime when statement
2010-10-12 11:41:23 -07:00
Aaron Patterson
ef11ce2af8
fixing case / when indentation
2010-10-12 11:38:40 -07:00
Aaron Patterson
cecccf1156
we should always cast the value based on the column
2010-10-11 13:35:58 -07:00
Aaron Patterson
bef5b826e3
removing freeze
2010-10-11 13:02:36 -07:00
Marcelo Giorgi
1c9022de21
Honor distinct option when used with count operation after group clause [ #5721 state:resolved]
2010-10-11 09:39:34 -07:00
Santiago Pastorino
e0b76d6151
reorder removed in favor of except(:order).order
2010-10-11 11:54:46 -02:00
José Valim
a8b1780410
Updated DOCS for engines and added a couple TODOs. Also, commented internal railties rake tasks description.
2010-10-11 10:29:31 +02:00
wycats
cc8e386d08
Always pull in version for frameworks (standardize autoload / require / none)
2010-10-10 16:12:04 -07:00
Piotr Sarnacki
8636f64def
Rename rake railties:copy_migrations to rake railties:install:migrations and fix it to work with new copying strategy
2010-10-09 21:32:34 +02:00
Piotr Sarnacki
022205be1d
Add callback on skipped migration while copying migrations
2010-10-09 21:32:34 +02:00
Piotr Sarnacki
4377f8eba2
Change the method for copying migrations, do not add scope.
...
The purpose of this change is to allow copying fail on the same names.
Migrations change database and they should be treated with caution,
if 2 migrations are named the same it's much better to skip migration
and allow user decide if it should be copied or not.
2010-10-09 21:32:34 +02:00
Aaron Patterson
740d7e5aa2
removing false comment
2010-10-07 16:40:15 -06:00
Xavier Noria
db520042b3
Merge branch 'master' of git://github.com/lifo/docrails
2010-10-06 23:16:13 +02:00
Hemant Kumar
2a04110f26
fix ruby 1.9 deadlock problem, fixes #5736 add connection pool tests
2010-10-06 14:45:56 -06:00
José Valim
d649bf158b
Provide a cleaner syntax for paths configuration that does not rely on method_missing.
2010-10-06 17:20:15 +02:00
Aaron Patterson
e7d860c6be
create fewer objects, call fewer methods in extract_pg_identifier_from_name
2010-10-04 15:25:20 -07:00
