Commit Graph

442 Commits

Author SHA1 Message Date
Jamis Buck
46c4fd4177 ActionController documentation update #2051 [fbeausoleil@ftml.net]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2095 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-01 21:54:29 +00:00
Nicholas Seckar
87b6800282 Add option to specify the singular name used by pagination. Closes #1960
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2078 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-08-31 00:13:10 +00:00
Nicholas Seckar
34e795ff0e Use string key to set action_name for controllers. Closes #1968
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2077 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-08-30 23:52:53 +00:00
David Heinemeier Hansson
b80f0e2ff3 Made Upload Progress work with Prototype 1.4.0 and add some documentation for it #1847, #1876 [Thomas Fuchs/Sean Treadway]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2059 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-08-27 06:30:33 +00:00
Nicholas Seckar
1cbd1f9698 Fix routing to handle :some_param => nil better
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2054 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-08-26 10:57:43 +00:00
Jamis Buck
c5ff810572 Add support for :include with pagination (subject to existing constraints for :include with :limit and :offset) #1478 [michael@schubert.cx]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2041 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-08-23 14:24:15 +00:00
Jamis Buck
211617191e Prevent the benchmark module from blowing up if a non-HTTP/1.1 request is processed
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2039 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-08-23 09:43:36 +00:00
Jamis Buck
c031a01633 Add an :if option to session management, to allow programmatically enabling or disabling the session
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2031 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-08-17 21:05:31 +00:00
Jamis Buck
50e2474433 Make assert_redirected_to properly check URL's passed as strings #1910 [Scott Barron]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1971 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-08-06 08:37:25 +00:00
Jamis Buck
a3469cadad Make sure :layout => false is always used when rendering inside a layout
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1970 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-08-05 20:51:03 +00:00
Jamis Buck
44c64a612d Use raise instead of assert_not_nil in Test::Unit::TestCase#process to ensure that the test variables (controller, request, response) have been set
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1963 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-08-01 21:28:17 +00:00
Jamis Buck
08ebab5d20 Make sure assigns are built for every request when testing #1866
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1961 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-31 12:16:21 +00:00
Jamis Buck
020ed6fa1f Allow remote_addr to be queried on TestRequest #1668
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1960 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-31 10:31:47 +00:00
David Heinemeier Hansson
0ea1375d75 Really fix the syntax error issue
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1952 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-28 17:41:19 +00:00
David Heinemeier Hansson
9fad3251d3 More fixes, but still broken
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1948 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-27 14:17:47 +00:00
David Heinemeier Hansson
5b52b716b7 Fixing the fix, but not quite
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1945 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-27 13:55:39 +00:00
David Heinemeier Hansson
eec7cc004b Fixed dynamic scaffolding [Stefan Kaes]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1940 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-27 11:44:18 +00:00
David Heinemeier Hansson
d876daf51f Fixed #1774 again
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1936 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-27 08:02:26 +00:00
David Heinemeier Hansson
4b8d156ca5 Removed unused statement
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1934 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-26 18:39:05 +00:00
David Heinemeier Hansson
d440cf6483 Fixed snag in status reporting
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1933 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-26 18:35:38 +00:00
David Heinemeier Hansson
65e4e5e337 Only log status if there is one different from 200 set
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1930 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-26 12:38:50 +00:00
David Heinemeier Hansson
36fee9c02e Fixed broken error handling #1827 [Stefan Kaes]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1920 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-25 09:39:57 +00:00
David Heinemeier Hansson
e9cfe955cc Add a catch-all eraser
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1918 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-25 08:49:19 +00:00
David Heinemeier Hansson
4f40b2d8fb Improved performance of test app req/sec with ~10% refactoring the render method #1823 [Stefan Kaes]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1915 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-24 16:45:39 +00:00
David Heinemeier Hansson
eddd7c453b Fix that env_qs might be nil
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1907 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-23 09:18:16 +00:00
David Heinemeier Hansson
d554227411 Fix that env_qs might be nil
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1906 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-23 09:16:35 +00:00
David Heinemeier Hansson
b366dbd952 Improved performance with 5-30% through a series of Action Pack optimizations #1811 [Stefan Kaes]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1905 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-23 09:00:05 +00:00
David Heinemeier Hansson
d172592985 Added test for template to layout variable transfer
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1904 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-23 08:43:01 +00:00
David Heinemeier Hansson
0223565a4d Expiring a cache that doesnt exist is bliss not bad
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1895 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-22 20:08:29 +00:00
David Heinemeier Hansson
3835f6ab25 Changed caching/expiration/hit to report using the DEBUG log level and errors to use the ERROR log level instead of both using INFO
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1889 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-22 11:28:58 +00:00
Jamis Buck
06843f8794 Added support for per-action session management #1763
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1886 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-22 10:37:09 +00:00
David Heinemeier Hansson
1aab0e2c30 Doc fixes #1775, #1776 [jon@instance-design.co.uk]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1878 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-22 06:27:07 +00:00
David Heinemeier Hansson
bd558ef98e Improved rendering speed on complicated templates by up to 25% #1234 [Stephan Kaes]. This did necessasitate a change to the internals of ActionView#render_template that now has four parameters. Developers of custom view handlers (like Amrita) need to update for that.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1874 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-21 07:14:35 +00:00
Nicholas Seckar
2e175d35cd Fix last changeset to pass unittests
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1858 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-18 03:25:53 +00:00
Nicholas Seckar
741316dc71 Fixed construction of get parameters for arrays
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1857 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-18 03:12:45 +00:00
David Heinemeier Hansson
e51221871c Fix doc typos #1734 [moriq@moriq.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1853 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-17 10:03:47 +00:00
David Heinemeier Hansson
e69924ecdc Log if filters return false and halt execution #1735 [Michael Koziarski]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1848 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-17 09:25:24 +00:00
David Heinemeier Hansson
d2d38f6700 Added Base#expires_in(seconds)/Base#expires_now to control HTTP content cache headers #1755 [Thomas Fuchs]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1845 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-17 09:20:20 +00:00
David Heinemeier Hansson
45804e2c86 More pagination speed #1334 [Stefan Kaes]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1839 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-15 20:27:38 +00:00
Nicholas Seckar
c0771fe7d8 Fix assert_routing with nested controllers. Closes #1582 and #1386.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1837 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-15 15:00:39 +00:00
Nicholas Seckar
bf0b7588ee Add RouteSet#named_route so that RouteSet instance methods do not shadow available route names
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1834 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-14 10:32:37 +00:00
Nicholas Seckar
6ed16ff602 Provide correct defaults for Named Routes which do not specify :action
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1833 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-14 09:09:39 +00:00
David Heinemeier Hansson
16595c93b2 Made pagination faster #1334 [Stefan Kaes]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1832 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-14 08:02:01 +00:00
Nicholas Seckar
fe0c7f4f76 Fix rescue handling to erase both render and redirect results
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1827 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-14 00:34:27 +00:00
Nicholas Seckar
2bd4ff11f8 Generate URLs for :action => index when :action => nil is supplied.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1826 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-14 00:13:06 +00:00
Nicholas Seckar
9314793239 Named routes should not provide nil values to url_for. Includes factoring and extra testcases.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1825 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-13 23:13:15 +00:00
Jeremy Kemper
f29ce1f356 r3023@asus: jeremy | 2005-07-12 23:43:39 -0700
Remove superfluous inherited override in Dependencies.
 r3024@asus:  jeremy | 2005-07-12 23:54:28 -0700
 Make test the default railties rake target.
 r3025@asus:  jeremy | 2005-07-12 23:55:27 -0700
 Encapsulate dispatch call in dispatcher test.
 r3026@asus:  jeremy | 2005-07-12 23:56:14 -0700
 Expand dispatcher mock to match full method signature for process.
 r3027@asus:  jeremy | 2005-07-12 23:57:24 -0700
 Look for app-specific generators in RAILS_ROOT/generators instead of RAILS_ROOT/script/generators.
 r3028@asus:  jeremy | 2005-07-13 00:00:47 -0700
 Update changelog.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1819 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-13 02:12:00 +00:00
David Heinemeier Hansson
cb0f8fda96 Worked around a Safari bug where it wouldn't pass headers through if the response was zero length by having render :nothing return ' ' instead of ''
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1818 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-12 19:31:48 +00:00
Jamis Buck
847f738cfd Make Request#subdomains handle "foo.foo.com" correctly
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1817 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-12 16:16:13 +00:00
David Heinemeier Hansson
fae7311b9c Fixed that auto_complete_for didn't force the input string to lower case even as the db comparison was
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1815 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-11 07:49:56 +00:00