github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity
21,877 Commits 34 Branches 105 Tags
dab96a267eeccd7380ad99fa19cefdfd3cd5ad2b
Commit Graph

588 Commits

Author SHA1 Message Date
Xavier Noria
9b423ac0b7 let this regexp be stricter 
The purpose of this regexp is to detect strings that
are valid identifiers to be used as method names.
The anchor $ allows a trailing newline, and both ^
and $ may be bypassed because Ruby regexps are
multiline always. The anchors \A and \z are the
proper ones to ensure string boundaries.
 2011-04-19 18:16:38 +02:00
José Valim
dca31b9224 Let's not dup because value may not always be duplicable. 2011-04-19 18:06:01 +02:00
José Valim
30472d4244 Avoid define_method if possible. 2011-04-19 17:58:06 +02:00
Aaron Patterson
3e23752236 bcrypt will encrypt anything, so validate_presence_of would not catch nil / blank passwords. Thank you to Aleksander Kamil Modzelewski for reporting this 2011-04-14 14:54:25 -07:00
Brian Cardarella
a8365ab9ad Declaring the attr_accessor for password_confirmation is not necessary 
as the confirmation validation already adds that attr_accessor
 2011-04-14 16:43:51 +08:00
Prem Sichanugrist
733bfa63f5 Remove #among? from Active Support 
After a long list of discussion about the performance problem from using varargs and the reason that we can't find a great pair for it, it would be best to remove support for it for now.

It will come back if we can find a good pair for it. For now, Bon Voyage, `#among?`.
 2011-04-13 20:25:28 +08:00
Xavier Noria
3366479a9a Merge branch 'master' of git://github.com/lifo/docrails 2011-04-12 22:45:33 +02:00
David Heinemeier Hansson
d1575ae1b9 Change Object#either? to Object#among? -- thanks to @jamesarosen for the suggestion! 2011-04-12 00:23:07 +02:00
Oge Nnadi
a43abfafd2 Rewording 2011-04-11 12:54:46 -07:00
José Valim
7379114c2f Remove code duplication. 2011-04-11 18:01:10 +02:00
José Valim
df5691aa94 No need to rescue here. Invoking the wrong method in an object can happen anywhere if you are not careful. In other words, test your shit. 2011-04-11 17:47:59 +02:00
José Valim
5bf3d46bec Revert "Add :use_include option to allow user to explicitly use Range#include? method in Ruby 1.9" 
Use :with => range.to_a instead.

This reverts commit f6540211b5.
 2011-04-11 17:41:33 +02:00
Prem Sichanugrist
a9f3c9da01 Using Object#in? and Object#either? in various places 
There're a lot of places in Rails source code which make a lot of sense to switching to Object#in? or Object#either? instead of using [].include?.
 2011-04-11 03:17:09 +08:00
Prem Sichanugrist
f6540211b5 Add :use_include option to allow user to explicitly use Range#include? method in Ruby 1.9 
In Ruby 1.9 we're currently use `Range#cover?` to fix the performance problem. However, there might be the case that you want to use `Range#include?` instead. This patch will give you that option.
 2011-04-10 18:49:28 +08:00
Prem Sichanugrist
58594be680 Add support for proc or lambda as an option for InclusionValidator, ExclusionValidator, and FormatValidator 
You can now use a proc or lambda in :in option for InclusionValidator and ExclusionValidator, and :with, :without option for FormatValidator
 2011-04-10 18:49:28 +08:00
John Firebaugh
d907f3cb5c Rename test directory to match code directory 
Hopefully "serializeration" is not an in joke that I missed.
 2011-04-06 01:50:35 +08:00
Xavier Noria
3e24e9ebc2 Merge branch 'master' of git://github.com/lifo/docrails 2011-04-03 22:22:03 +02:00
Santiago Pastorino
99da42c299 Gem::Specification#has_rdoc= is deprecated since rubygems 1.7.0 2011-04-02 00:35:33 -03:00
Santiago Pastorino
4f90b28e06 Bring back AMo#i18n_key method 2011-03-30 16:29:43 -03:00
John Firebaugh
b671e4d86a Fix formatting and broken markup 2011-03-28 22:31:05 -07:00
Santiago Pastorino
450f7cf01b use class_eval with a string when it's possible 2011-03-22 20:11:36 -03:00
Santiago Pastorino
da6c7bd4b4 Do not in place modify what table_name returns 2011-03-22 19:36:16 -03:00
Santiago Pastorino
445241d713 define_attr_method should be able to define methods that returns nil 2011-03-17 23:17:20 -03:00
Aaron Patterson
4532b39f5f remove misleading comment 2011-03-17 10:31:12 -07:00
Aaron Patterson
00f0879367 dup strings on return so that in place modifications do not break anything. I am looking at you "compute_table_name" 2011-03-17 10:26:11 -07:00
Santiago Pastorino
c834a751d2 define_attr_method correctly defines methods with invalid identifiers 2011-03-16 21:20:44 -03:00
Santiago Pastorino
fda45f4fc4 Add a define_attr_method test 2011-03-16 21:08:02 -03:00
Santiago Pastorino
5232077517 Add test for define_attr_method using as name an invalid identifier 2011-03-16 21:01:49 -03:00
Santiago Pastorino
cb44e99de4 Add test for define_attribute_method using as name an invalid identifier 2011-03-16 21:01:04 -03:00
Andrew White
e8458d37c5 Fix typo in assertion message 2011-03-16 10:28:40 +00:00
Norman Clarke
7bd70dcd6c Add messages to plain assertions. 
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2011-03-15 10:44:14 -03:00
Santiago Pastorino
157c37f558 Refactor length validation 2011-03-12 21:12:44 -02:00
Andriy Tyurnikov
f48d3d4df6 length validation for fixnums 
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2011-03-12 21:12:44 -02:00
Mike Gehard
58de03f077 Add additional text to NotImplementedErrors [#6328 state:resolved] 
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2011-03-12 13:43:23 -02:00
Xavier Noria
89ecc0a5dc Merge branch 'master' of git://github.com/lifo/docrails 2011-03-07 22:11:47 +01:00
Vijay Dev
f99db5a6a8 formatting changes 2011-03-07 23:56:16 +05:30
Paco Guzman
8e0affbd86 Configuration options are symbols 2011-03-06 22:35:26 +01:00
Paco Guzman
14c254aba3 Remove Example headers. Code just flows with the text. 6ce844a3 2011-03-06 22:34:01 +01:00
Paco Guzman
7e9d45cc7f remove unused assigned variable 2011-03-06 22:24:22 +01:00
R.T. Lechow
86c15d8b89 Active Model typos. 2011-03-05 11:56:34 +01:00
Alexander Uvarov
24faddd60c Move ActiveModel::AttributeMethods#attribute_methods_generated? to ActiveRecord, so it's flexible now 
[#6428 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
 2011-03-01 20:22:45 +01:00
Santiago Pastorino
a00bed0c48 Revert "Properly interpolate i18n keys in modules [#5572 state:resolved]" 
This breaks #6448, you should use :"module/class" as key for namespacing
[#6448 state:committed]

This reverts commit 8d30193b08.
 2011-02-27 21:30:03 -02:00
Santiago Pastorino
acf0688fdd failing test for i18n key collision with namespaced models 2011-02-27 21:23:52 -02:00
Prem Sichanugrist
839d06f5f2 We're in 2011, let's update our license 
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2011-02-22 18:24:20 -02:00
Xavier Noria
f826e05835 Merge branch 'master' of git://github.com/lifo/docrails 2011-02-21 11:42:26 +01:00
Xavier Noria
b481574a33 copy-edits 8d96b89 2011-02-21 11:37:08 +01:00
Xavier Noria
9297027e08 copy-edits 6d7a826 2011-02-21 11:01:26 +01:00
Xavier Noria
843a5b9a3a copy-edits 34316d8 2011-02-21 11:00:03 +01:00
Nicholas Rowe
34316d8b7e Docs: Update to_xml documentation to match as_json docuemntation 2011-02-20 21:35:43 -05:00
Nicholas Rowe
6d7a8267b9 Documentation: Added small comments to Observering module 2011-02-20 21:05:41 -05:00