Pratik Naik
6577942b61
Deprecate render_component.
...
Please install render_component plugin from http://github.com/rails/render_component/tree/master
if your application uses this functionality.
2008-08-29 13:43:30 +01:00
Brennan Dunn
9cc8c0a0a1
Routes may be restricted to lists of HTTP methods instead of a single method or :any.
...
[#407 state:resolved]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2008-08-28 12:29:49 -07:00
Brennan Dunn
7bdd5b768e
Accept an array of method symbols for collection/member actions of resources
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2008-08-28 12:23:39 -07:00
Michael S. Klishin
e42a235dd1
Request#remote_ip handles the uncommon case that REMOTE_ADDR is a comma-separated list.
...
[#523 state:resolved]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2008-08-27 23:03:11 -07:00
Tim Haines
82778351a8
Add TestUploadFile.content_type= to match Request.UploadedFile
...
[#920 state:resolved]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2008-08-27 18:50:29 -07:00
Joshua Peek
6ec07e0737
Store application and other context specific helper modules in ActionView::Base#helpers
2008-08-26 16:17:58 -05:00
Joshua Peek
9853134b4f
Require missing libraries and check for defined ActionController constant so ActionView can be used standalone
2008-08-26 15:13:28 -05:00
Joshua Peek
0096f55869
Removed template_public? because it will always be true since the default template is never a partial
2008-08-21 21:34:03 -05:00
Ryan Bates
1129a24caf
Cleanup around partial rendering
...
Signed-off-by: Joshua Peek <josh@joshpeek.com >
2008-08-21 21:03:33 -05:00
Jeremy Kemper
b99442933d
deprecate Base#assign_default_content_type_and_charset
2008-08-21 18:14:32 -07:00
Jeremy Kemper
f8f077945f
Move default content type and charset from Base to Response. Handle charset = nil.
2008-08-21 18:11:09 -07:00
Tarmo Tänav
98fb161dbb
Allow polymorphic_url helper to take url options. [ #880 state:resolved]
...
All *_polymorphic_url, *_polymorphic_path helpers can now accept
an options hash which will be passed on to the named route
making it possible to generate polymorphic routes with additional
url parameters.
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2008-08-21 20:26:00 +01:00
Joshua Peek
6be8251ec8
Simplified and renamed CallbackChain union method to replace_or_append!
2008-08-21 00:51:06 -05:00
Joshua Peek
47cd8b81cc
Switched integration test runner to use Rack processor instead of CGI
2008-08-20 13:37:18 -05:00
Joshua Peek
3a2ff17af6
Don't shadow query string method
2008-08-19 20:24:34 -05:00
Ryan Bates
a8ece12fe2
Return nil instead of a space when passing an empty collection or nil to 'render :partial' [ #791 state:resolved]
...
Signed-off-by: Joshua Peek <josh@joshpeek.com >
2008-08-19 19:09:04 -05:00
Joshua Peek
71c4ff07ab
Delegate xhr helper method to integration session
2008-08-19 18:53:46 -05:00
Jamis Buck
6e4ea66dc0
Make AbstractRequest.if_modified_sense return nil if the header could not be parsed
2008-08-19 16:07:17 -06:00
Joshua Peek
977317da55
hack around CGI session close
2008-08-19 16:29:02 -05:00
Joshua Peek
c1a8690d58
Consistently use the framework's configured logger and avoid reverting to RAILS_DEFAULT_LOGGER unless necessary.
2008-08-18 23:36:13 -05:00
Joshua Peek
f245658495
Use Response status accessor instead of the Status header
2008-08-17 19:13:49 -05:00
Joshua Peek
b8e930aa01
Merge RackProcess#normalize_headers logic into AbstractResponse#prepare!
2008-08-17 19:09:38 -05:00
Jeremy Kemper
8aad8cb390
Set cache control to require revalidation if cache freshness response headers are set. Don't set Content-Length header if 304 status.
2008-08-14 21:45:14 -07:00
Jeremy Kemper
c7e09a8fb2
TestRequest#recycle! uses unmemoize_all to reset cached request method, accepts, etc.
2008-08-13 17:26:27 -07:00
Josh Susser
2561be005b
Refactor Filter predicate methods to use inheritance. [ #815 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2008-08-13 21:48:37 +01:00
Jeremy Kemper
45b79d933c
Merge branch 'conditional-get'
2008-08-12 17:03:17 -07:00
Jeremy Kemper
ba2d61dd81
Update tests for request memoization
2008-08-08 02:31:12 -07:00
Jeremy Kemper
c24a7cdd23
Don't shadow host method
2008-08-08 02:29:37 -07:00
James Rosen
14cf9a8991
dryed up resources; fixed small formatting issue in resources rdoc
...
Signed-off-by: Michael Koziarski <michael@koziarski.com >
2008-08-08 10:47:26 +02:00
Jeremy Kemper
b7529ed1cc
Simplifying usage of ETags and Last-Modified and conditional GET requests
2008-08-07 23:43:12 -07:00
Jeremy Kemper
e43d1c226d
Inherit these from AbstractRequest instead
2008-08-07 23:34:36 -07:00
Jeremy Kemper
165120a606
Be more careful about deducing action_methods
2008-08-06 15:23:57 -07:00
Jeremy Kemper
29a06f10e8
Strip newlines from cookie session data
2008-08-05 19:28:52 -07:00
Jeremy Kemper
69e9cbb99a
Ensure public superclass methods don't shadow public controller methods. Case in point, ruby-debug's Kernel#start shadowing a controller's start action.
2008-08-05 17:35:08 -07:00
Jeffrey Hardy
8d72b82b8d
Make assert_template failure message more friendly
...
Signed-off-by: Joshua Peek <josh@joshpeek.com >
2008-08-05 16:29:56 -05:00
Jeremy Kemper
ddd552504b
Expose Routing::Segment::SAFE_PCHAR list of path characters that don't need escaping
2008-08-04 18:37:53 -07:00
Jeremy Kemper
ad4553587e
List available actions in UnknownAction exception message
2008-07-31 17:50:53 -07:00
Tarmo Tänav
0b9bfbdebf
Use "/usr/bin/env ruby" instead of "/usr/local/bin/ruby"
...
Signed-off-by: Joshua Peek <josh@joshpeek.com >
2008-07-31 16:39:48 -05:00
Tarmo Tänav
656f0e7c6c
Fix file permissions
...
Signed-off-by: Joshua Peek <josh@joshpeek.com >
2008-07-31 16:36:23 -05:00
miloops
eaab895f83
Prototype helpers should generate Element.insert instead of Insertion.new, which has been deprecated in Prototype 1.6.
2008-07-30 01:42:32 -07:00
Jeremy Kemper
eb256718c3
Remove send! usage, relic of reverted 1.9 behavior
2008-07-28 13:54:10 -07:00
Joshua Peek
19db0b7324
Added back ActionController::Base.allow_concurrency flag and moved lock down to controller processing.
2008-07-28 14:31:40 -05:00
Joshua Peek
a5db148825
Prepare Route#generate and Route#recognize early. Also refactor segments a bit to try to make immutable.
2008-07-28 13:41:42 -05:00
Joshua Peek
e0513e33c4
Routing whitespace cleanup
2008-07-28 13:38:20 -05:00
Pratik Naik
6e75455125
Merge docrails changes
2008-07-28 12:33:24 +01:00
Joshua Peek
f48b9ab5c2
ActionController::Base.relative_url_root falls back to ENV['RAILS_RELATIVE_URL_ROOT']
2008-07-24 14:06:22 -05:00
Joshua Peek
a87462afcb
AbstractRequest.relative_url_root is no longer automatically configured by a HTTP header. It can now be set in your configuration environment with config.action_controller.relative_url_root
2008-07-24 13:41:51 -05:00
Joshua Peek
bc5896e708
Memoize ActionView::Base pick_template and find_partial_path for rendering duration
2008-07-22 10:27:32 -05:00
Tom Ward
d39485078e
Raise ArgumentError if an invalid method is specified as part of a route's conditions. Also raise an error if HEAD is specified as the method, as rails routes all HEAD requests through the equivalent GET, though doesn't return the response body [ #182 state:resolved]
...
Signed-off-by: Joshua Peek <josh@joshpeek.com >
2008-07-18 20:19:03 -05:00
Jeremy Kemper
57a2780f14
etag! and last_modified! conditional GET helpers
2008-07-17 23:18:10 -07:00