github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-02-08 13:15:23 -05:00
Code Issues Packages Projects Releases Wiki Activity
7,303 Commits 34 Branches 105 Tags
dc2d754d60378b529c239e1291932503d4d8fca5
Commit Graph

1355 Commits

Author SHA1 Message Date
Michael Koziarski
efd18066a2 Tighten the rescue clause here to prevent hiding strange mock related errors behind the line offset test 2008-07-03 19:21:04 +03:00
Michael Koziarski
e358b1fce8 Remove old method of including javascripts define_javascript_functions. 
javascript_include_tag and friends do a much better job.
 2008-07-03 19:21:04 +03:00
Tarmo Tänav
a37d065f85 Use :namespace instead of :path_prefix for finding controller. [#544 state:resolved] 
:namespace is supposed to be the module where controller exists.
:path_prefix can contain anything, including variables, which
makes it unsuitable for determining the module for a controller.

Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2008-07-03 16:11:50 +01:00
Joshua Peek
3b3790a435 Deprecate :use_full_path render option. The supplying the option no longer has an effect. 2008-07-02 21:38:58 -05:00
Mike Subelsky
8f640c381d Added application/jsonrequest as a synonym for application/json 
[#536 state:resolved]
 2008-07-02 11:39:42 -07:00
rick
a4138d4632 use mocha for TimeZone mocking in Form Options helper tests 2008-07-02 11:09:10 -07:00
Pratik Naik
267d3964eb Make sure render :collection doesnt set nil local when :as is absent 2008-07-02 17:19:41 +01:00
Pratik Naik
2b43620e3c Add :as option to render a collection of partials with a custom local variable name. [#509 state:resolved] [Simon Jefford, Pratik Naik] 2008-07-02 16:40:42 +01:00
Tim Haines
f5052dd8a3 Make sure render :template works with :locals. [#524 state:resolved] 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2008-07-02 04:30:34 +01:00
Joshua Peek
aff2d33172 Improved test coverage and added RackRequest support for CGI environment variables. 2008-07-01 21:53:55 -05:00
Scott Stewart
7378e23734 Ensure proper output when submit_tag is used with :disabled_with. [#388 state:resolved] 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2008-07-02 01:39:30 +01:00
Ernie Miller
d0092dc44d Added support for regexp matching of priority zones in time_zone_select [#195 state:resolved] 2008-06-29 13:37:07 -05:00
Pratik Naik
029a745584 Ensure FormBuilder date helpers respects html_options. [#506 state:resolved] [Pascal Ehlert] 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2008-06-29 00:36:31 +01:00
Cheah Chu Yeow
3c1e8ab0fe Allow single quote (the ' character) in the middle of URL when auto_link-ing. [#471 state:resolved] 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2008-06-27 13:46:17 +01:00
Joshua Peek
339491a6b3 Set precompiled fixture load path constant to speed up tests 2008-06-25 15:24:12 -05:00
Joshua Peek
ad772402c4 Made ActionView::Base#render_file private 2008-06-25 05:57:24 -05:00
Joshua Peek
6f5327013d Consolidate CustomHandlerTest, TemplateFileTest, and TemplateObjectTest and test them at a higher level of abstraction in ViewRenderTest. 2008-06-25 05:49:38 -05:00
Jimmy Baker
670e22e372 Patched HTML::Document#initialize call to Node.parse so that it includes the strict argument. [#330] 2008-06-24 23:11:35 -07:00
Tammer Saleh
bb6e8eea5a Fixed polymorphic_url to be able to handle singleton resources. 
Example usage:
polymorphic_url([:admin, @user, :blog, @post]) # => admin_user_blog_post_url(@user, @post)

[#461 state:resolved]
 2008-06-22 18:58:47 -07:00
Jeremy Kemper
72f93b581f Check whether blocks are called from erb using a special __in_erb_template variable visible in block binding. 2008-06-19 22:21:56 -07:00
Joshua Peek
40557e17dd Improved test coverage for integration test's api 2008-06-17 21:25:51 -05:00
Joshua Peek
bec4b69a3b Replaced TemplateFinder abstraction with ViewLoadPaths 2008-06-17 21:21:07 -05:00
David Heinemeier Hansson
8190bce8bc Added block-call style to link_to [Sam Stephenson/DHH] 2008-06-17 17:37:29 -05:00
Luke Redpath
7650ff892c Fix url_for with no arguments when default_url_options is not explicitly defined. [#339 state:resolved] 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2008-06-17 20:53:41 +01:00
Amos King
1b4b8fbbd9 verify :redirect_to => :back should redirect to the referrer. [#280 state:resolved] 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2008-06-17 18:08:56 +01:00
David Heinemeier Hansson
6573f6a4bc Revert "Lazy load cache and session stores" 
This reverts commit 19895f087c.
 2008-06-12 19:52:33 -05:00
Pratik Naik
65bc8f33de Silence TimeZone warning 2008-06-11 17:11:34 +01:00
Jan De Poorter
ca9641f8a7 Fix FormOptionsHelper tests. 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2008-06-11 13:17:40 +01:00
Jonathan del Strother
3e07f320c1 Improve ActionCaching's format-handling 
Make ActionCaching more aware of different mimetype formats.
It will now use request.format to look up the cache type, in addition to the path extension.
When expiring caches, the request format no longer affects which cache is expired.

Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2008-06-11 13:15:01 +01:00
Pratik Naik
0ad0bdc01c Delegate ActionView::Base#controller_name to controller 2008-06-10 23:55:04 +01:00
Pratik Naik
19895f087c Lazy load cache and session stores 2008-06-10 10:29:25 +01:00
Joshua Peek
2336430471 Removed TemplateFinder.update_extension_cache_for since view path cache will be updated on boot. 2008-06-09 10:21:30 -05:00
Jeremy Kemper
057768cd2c Process view paths passed to AV::Base#initialize instead of raising. 2008-06-08 21:21:54 -07:00
Jeremy Kemper
c88f2b5e23 with_output_buffer returns the temporary buffer instead of the result of the block 2008-06-08 20:35:30 -07:00
Jeremy Kemper
ff5f155f8d Use output_buffer reader and writer methods exclusively instead of hitting the instance variable so others can override the methods. 2008-06-08 20:05:39 -07:00
Jeremy Kemper
b336ce9e06 Revert "Missed add: deprecated erb_variable test" 
This reverts commit 56f5c5582c.
 2008-06-08 13:04:00 -04:00
Jeremy Kemper
56f5c5582c Missed add: deprecated erb_variable test 2008-06-08 01:32:57 -07:00
Joshua Peek
d5539958a8 Wrap CGIResponse, LegacyRouteSet, Route, RouteSet and RouteLoading tests inside mocha block. 2008-06-07 23:42:05 -05:00
Jeremy Kemper
fe9d2ad6e8 Remove some internal dead code that supported content_for 2008-06-06 18:01:14 -07:00
Jeremy Kemper
26ec1be24a concat should ignore nil 2008-06-06 18:00:01 -07:00
Jeremy Kemper
e732a405ab javascript_tag should only concat when block_given? 2008-06-06 17:59:41 -07:00
Jeremy Kemper
9c9da5d927 Merge branch 'master' into erbout 2008-06-05 17:34:14 -07:00
Pratik Naik
1dbfe9766e Ensure render :file works inside templates 2008-06-05 23:33:10 +01:00
Frederick Cheung
2e0765a003 Make partial counter start from 0. 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2008-06-05 22:11:40 +01:00
Jeremy Kemper
e7f1556d0e Merge branch 'master' into erbout 2008-06-05 13:25:33 -07:00
Joshua Peek
c4d570c2eb Use CGI::Cookie::parse for request cookies until we officially deprecated CGI. 2008-06-04 22:32:09 -05:00
Sean Huber
30a0ebb3eb Add RJS#page.reload. [#277 state:resolved] 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2008-06-04 13:32:53 +01:00
Jeremy Kemper
53bcbfbdc1 Merge branch 'master' into erbout 2008-06-03 22:38:27 -07:00
David Heinemeier Hansson
885453537e Merge branch 'master' of git@github.com:rails/rails 2008-06-03 18:12:56 -05:00
David Heinemeier Hansson
edfa195e2a Fixed Request#remote_ip to only raise hell if the HTTP_CLIENT_IP and HTTP_X_FORWARDED_FOR doesnt match (not just if theyre both present) [Mark Imbriaco, Bradford Folkens] 2008-06-03 18:11:47 -05:00