Jeremy Kemper
|
c302cdfcc4
|
Fix scope typo in add_lock! Closes #6482. [zubek]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5907 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-01-12 10:18:11 +00:00 |
|
Jeremy Kemper
|
c62e5e1a3a
|
Demonstrate that a value's required. References #6156.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5903 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-01-12 08:52:08 +00:00 |
|
Jeremy Kemper
|
a66ad97dac
|
Oops. References #6156.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5902 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-01-12 08:50:35 +00:00 |
|
Jeremy Kemper
|
dbd7b5e111
|
Test MySQL implicit NULL for integer columns. Closes #6156.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5901 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-01-12 08:46:01 +00:00 |
|
Jeremy Kemper
|
9073cef866
|
SQLServer: handle [quoted] table names. Closes #6635.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5891 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-01-12 05:44:28 +00:00 |
|
Jeremy Kemper
|
8d3ff3abc7
|
acts_as_nested_set works with single-table inheritance. Closes #6030.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5889 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-01-12 05:33:09 +00:00 |
|
Jeremy Kemper
|
ef4ac31de3
|
PostgreSQL: use a subselect to correctly perform eager finds with :limit and :order. Closes #4668.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5887 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-01-12 05:14:55 +00:00 |
|
Jeremy Kemper
|
3b6555acd4
|
Fix new_record? and id rollback. Closes #6910.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5886 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-01-12 05:10:06 +00:00 |
|
Jeremy Kemper
|
353238b6a4
|
Inline primary keys.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5885 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-01-12 04:58:08 +00:00 |
|
Jamis Buck
|
8dd08f98c7
|
dry up some duplicated code
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5883 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-01-11 18:19:23 +00:00 |
|
Jamis Buck
|
0d34c28199
|
treat create! like create and make sure the target is loaded first
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5882 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-01-11 18:10:42 +00:00 |
|
Jamis Buck
|
c398e83893
|
fix regression in has_one#create, that caused instances thus created to be orphaned
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5881 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-01-11 18:04:47 +00:00 |
|
Jeremy Kemper
|
28767075f4
|
Pass a range in :conditions to use the SQL BETWEEN operator. Closes #6974.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5876 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-01-10 10:13:18 +00:00 |
|
Michael Koziarski
|
b4282df966
|
Fix the Oracle adapter for serialized attributes stored in CLOBs. Closes #6825 [mschoen, tdfowler]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5866 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-01-05 23:42:03 +00:00 |
|
Rick Olson
|
1400e7f864
|
[DOCS] Apply more documentation for ActiveRecord Reflection. Closes #4055 [Robby Russell]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5855 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-01-05 20:22:41 +00:00 |
|
Rick Olson
|
606376bd44
|
[DOCS] Document :allow_nil option of #validate_uniqueness_of. Closes #3143 [Caio Chassot]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5853 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-01-05 20:17:37 +00:00 |
|
Michael Koziarski
|
84481dd3b4
|
Sybase adapter fixes. Closes #6926 [jsheets]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5839 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-01-05 00:12:06 +00:00 |
|
Rick Olson
|
1af2022cc3
|
Rollback #new_record? and #id values for created records that rollback in an after_save callback. Closes #6910 [Ben Curren]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5830 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-01-02 05:36:30 +00:00 |
|
Jamis Buck
|
6a5388b654
|
try to appease the angry Oracle
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5808 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2006-12-29 19:05:53 +00:00 |
|
Jamis Buck
|
0bfabaa048
|
make sure query attributes on custom fields works as it used to
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5807 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2006-12-29 17:24:35 +00:00 |
|
Michael Koziarski
|
3b4450bb80
|
Docs fix for columns_hash [bradediger]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5797 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2006-12-27 20:41:55 +00:00 |
|
Michael Koziarski
|
58edaaad0b
|
Ensure dynamic finders are anchored to the beginning of the method name to prevent
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5795 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2006-12-27 20:35:19 +00:00 |
|
Jeremy Kemper
|
4cf8bf7312
|
Pushing a record on an association collection doesn't unnecessarily load all the associated records.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5769 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2006-12-21 23:28:12 +00:00 |
|
Jeremy Kemper
|
a8b53f1dbb
|
Oracle: fix connection reset failure. Closes #6846.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5761 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2006-12-20 21:14:41 +00:00 |
|
Jeremy Kemper
|
7277c51891
|
Partially revert [5660] - makes more trouble than it resolves. References #5704, closes #6766.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5753 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2006-12-19 19:47:21 +00:00 |
|
Jeremy Kemper
|
8732ce291b
|
Subclass instantiation doesn't try to explicitly require the corresponding subclass. Closes #6840.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5751 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2006-12-19 19:23:56 +00:00 |
|
Jeremy Kemper
|
55d248ba72
|
use RAILS_DEFAULT_LOGGER in debug mode so we can log Dependencies activity
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5750 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2006-12-19 18:44:04 +00:00 |
|
Jeremy Kemper
|
5f18fd93de
|
utf8 mysql topics table
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5749 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2006-12-19 18:04:42 +00:00 |
|
Rick Olson
|
41466a4c83
|
fix faulty inheritance tests and that eager loading grabs the wrong inheritance column when the class of your association is an STI subclass. Closes #6859 [protocool]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5744 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2006-12-19 03:10:39 +00:00 |
|
Tobias Lütke
|
906bd93f4f
|
Remove side effects of [5684]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5705 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2006-12-08 21:41:15 +00:00 |
|
Jeremy Kemper
|
50c98942a5
|
Don't do introspection queries during locking tests [Michael Schoen]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5689 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2006-12-06 20:28:26 +00:00 |
|
Tobias Lütke
|
cdad2d41e1
|
Consolidated different create and create! versions to call through to the base class with scope. This fixes inconsistencies, especially related to protected attribtues.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5684 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2006-12-06 00:13:31 +00:00 |
|
Jeremy Kemper
|
8dea60b0c3
|
find supports :lock with :include. Check whether your database allows SELECT ... FOR UPDATE with outer joins before using. Closes #6764.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5682 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2006-12-05 22:07:55 +00:00 |
|
Jeremy Kemper
|
eb300f8428
|
AssociationCollection#any? takes a block [Michael Schoen]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5681 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2006-12-05 21:49:36 +00:00 |
|
Tobias Lütke
|
0ee0c1b2aa
|
Add AssociationCollection#create! to be consistent with AssociationCollection#create when dealing with a foreign key that is a protected attribute
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5677 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2006-12-05 17:55:44 +00:00 |
|
David Heinemeier Hansson
|
22f095be23
|
Added counter optimization for AssociationCollection#any? so person.friends.any? won't actually load the full association if we have the count in a cheaper form [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5676 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2006-12-05 03:26:56 +00:00 |
|
Jeremy Kemper
|
8ffb22056c
|
Subclasses of an abstract class work with single-table inheritance. Closes #5704.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5660 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2006-12-01 21:24:47 +00:00 |
|
David Heinemeier Hansson
|
2e2bf2d149
|
If only life was that simple (it didnt help)
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5658 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2006-12-01 05:56:51 +00:00 |
|
David Heinemeier Hansson
|
e8eb743ba6
|
Replace the elaborate reloading connection checking scheme, just fix the Ruby-based MySQL adapter, ye?
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5656 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2006-12-01 05:37:56 +00:00 |
|
David Heinemeier Hansson
|
0a86122a24
|
Only reload connections in development mode that supports (and requires that) -- in other words, only do it for SQLite (closes #6687, #6700) [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5637 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2006-11-26 22:10:55 +00:00 |
|
Michael Koziarski
|
a2e826dc0f
|
Change fixture_path to a class inheritable accessor allowing test cases to have their own custom set of fixtures. Closes #6672 [zdennis]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5604 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2006-11-21 22:28:24 +00:00 |
|
Jeremy Kemper
|
9104d63f99
|
Quote ActiveSupport::Multibyte::Chars. Closes #6653.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5597 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2006-11-20 12:02:04 +00:00 |
|
Jeremy Kemper
|
cd6beacfb3
|
Test for forged '' default before it's typecast. Closes #6156.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5596 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2006-11-20 11:44:31 +00:00 |
|
Jeremy Kemper
|
6e1012fc9c
|
Test has_one :dependent => :nullify with missing association. Closes #4848.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5595 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2006-11-20 11:29:21 +00:00 |
|
Jeremy Kemper
|
ced5d89425
|
Test has_one :dependent => :nullify with missing association. Closes #4828.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5594 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2006-11-20 11:28:35 +00:00 |
|
Jeremy Kemper
|
427fb035a3
|
Simplify query_attribute by typecasting the attribute value and checking whether it's nil, false, zero or blank. Closes #6659.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5593 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2006-11-20 11:22:38 +00:00 |
|
Jeremy Kemper
|
9594832a8d
|
validates_numericality_of uses \A \Z to ensure the entire string matches rather than ^ $ which may match one valid line of a multiline string. Closes #5716.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5589 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2006-11-20 10:51:50 +00:00 |
|
Jeremy Kemper
|
88bd86e8bc
|
Run validations in the order they were declared. Closes #6657.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5588 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2006-11-20 10:12:38 +00:00 |
|
Jeremy Kemper
|
19c99acfbc
|
MySQL: detect when a NOT NULL column without a default value is misreported as default ''. Can't detect for string, text, and binary columns since '' is a legitimate default. Closes #6156.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5586 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2006-11-20 08:54:42 +00:00 |
|
Jeremy Kemper
|
02adc49d72
|
Simplify association proxy implementation by factoring construct_scope out of method_missing. Closes #6643.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5564 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2006-11-19 11:16:12 +00:00 |
|