github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-02-10 06:04:55 -05:00
Code Issues Packages Projects Releases Wiki Activity
7,119 Commits 34 Branches 105 Tags
def594b92d1e68db68a27d53dec7ae4e6246f5a5
Commit Graph

1323 Commits

Author SHA1 Message Date
Jeremy Kemper
057768cd2c Process view paths passed to AV::Base#initialize instead of raising. 2008-06-08 21:21:54 -07:00
Jeremy Kemper
c88f2b5e23 with_output_buffer returns the temporary buffer instead of the result of the block 2008-06-08 20:35:30 -07:00
Jeremy Kemper
ff5f155f8d Use output_buffer reader and writer methods exclusively instead of hitting the instance variable so others can override the methods. 2008-06-08 20:05:39 -07:00
Jeremy Kemper
b336ce9e06 Revert "Missed add: deprecated erb_variable test" 
This reverts commit 56f5c5582c.
 2008-06-08 13:04:00 -04:00
Jeremy Kemper
56f5c5582c Missed add: deprecated erb_variable test 2008-06-08 01:32:57 -07:00
Joshua Peek
d5539958a8 Wrap CGIResponse, LegacyRouteSet, Route, RouteSet and RouteLoading tests inside mocha block. 2008-06-07 23:42:05 -05:00
Jeremy Kemper
fe9d2ad6e8 Remove some internal dead code that supported content_for 2008-06-06 18:01:14 -07:00
Jeremy Kemper
26ec1be24a concat should ignore nil 2008-06-06 18:00:01 -07:00
Jeremy Kemper
e732a405ab javascript_tag should only concat when block_given? 2008-06-06 17:59:41 -07:00
Jeremy Kemper
9c9da5d927 Merge branch 'master' into erbout 2008-06-05 17:34:14 -07:00
Pratik Naik
1dbfe9766e Ensure render :file works inside templates 2008-06-05 23:33:10 +01:00
Frederick Cheung
2e0765a003 Make partial counter start from 0. 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2008-06-05 22:11:40 +01:00
Jeremy Kemper
e7f1556d0e Merge branch 'master' into erbout 2008-06-05 13:25:33 -07:00
Joshua Peek
c4d570c2eb Use CGI::Cookie::parse for request cookies until we officially deprecated CGI. 2008-06-04 22:32:09 -05:00
Sean Huber
30a0ebb3eb Add RJS#page.reload. [#277 state:resolved] 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2008-06-04 13:32:53 +01:00
Jeremy Kemper
53bcbfbdc1 Merge branch 'master' into erbout 2008-06-03 22:38:27 -07:00
David Heinemeier Hansson
885453537e Merge branch 'master' of git@github.com:rails/rails 2008-06-03 18:12:56 -05:00
David Heinemeier Hansson
edfa195e2a Fixed Request#remote_ip to only raise hell if the HTTP_CLIENT_IP and HTTP_X_FORWARDED_FOR doesnt match (not just if theyre both present) [Mark Imbriaco, Bradford Folkens] 2008-06-03 18:11:47 -05:00
Gabe da Silveira
025515b234 Fix assert_redirected_to for nested controllers and named routes 
[#308 state:resolved]

Signed-off-by: Michael Koziarski <michael@koziarski.com>
 2008-06-04 11:08:58 +12:00
josevalim
d54d90f2b5 Allow caches_action to accept a layout option [#198 state:resolved] 
Signed-off-by: Joshua Peek <josh@joshpeek.com>
 2008-06-03 14:02:51 -05:00
Joshua Peek
c08547d226 Namespace Inflector, Dependencies, OrderedOptions, and TimeZone under ActiveSupport [#238 state:resolved] 2008-06-03 13:32:53 -05:00
Jeremy Kemper
f55ad960d2 Stack @output_buffer for nested rendering 2008-06-03 01:10:00 -07:00
Jeremy Kemper
0bdb7d353b Work with @output_buffer instead of _erbout 2008-06-02 21:32:50 -07:00
Joshua Peek
92050f6c6f Ensure Rack processor reads CGI output_cookies for the session cookie. 2008-06-02 21:02:51 -05:00
Ezra Zygmuntowicz
06cb20708b Added Rack processor 
Signed-off-by: Joshua Peek <josh@joshpeek.com>
 2008-06-01 11:25:11 -07:00
Michael Koziarski
ef21e01333 Remove dead code, and the tests for it. 2008-05-31 16:59:03 -07:00
Jeremy Kemper
888a2927b6 Remove superfluous tests directive 2008-05-26 01:39:21 -07:00
Kevin Glowacz
1a73e98660 Fix auto_link helper for already linked urls. [#72 state:resolved] 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2008-05-22 21:10:40 +01:00
Adam
314e556e6f Parentheses should be acceptable characters for auto_link_urls. [#234 state:resolved] 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2008-05-22 11:16:02 +01:00
Erkki Eilonen
6e3521e613 Improve check_box_checked? to use include? for Array values. [#193 state:resolved] 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2008-05-21 20:23:58 +01:00
Jeremy Kemper
b43309328a Ruby 1.9 compat: ensure binary encoding for post body parsing 2008-05-19 16:24:26 -07:00
Jeremy Kemper
b5c8433a6f Ruby 1.9 compat: qualify module name within module_evaled block 2008-05-19 12:57:42 -07:00
Chris Hapgood
e6f5079a48 Test for assert_response for failure response without an exception. [#141 state:resolved] 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2008-05-19 11:20:36 +01:00
José Valim
99860b72ae Add fragment_exist? and exist? methods to cache stores. [#203 state:resolved] 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2008-05-19 10:38:59 +01:00
Frederick Cheung
17d1319c48 Ensure observe_field encodes value parameter. [#216 state:resolved] 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2008-05-19 10:30:56 +01:00
gbuesing
e30a263bf1 InstanceTag#default_time_from_options overflows to DateTime 2008-05-18 10:59:24 -05:00
Sven Fuchs
345f030c5b Ensure routing generator works with non-string keys. [#172 state:resolved] 
Make sure that (with recent correction to globbed parameter escaping) non-string
values can still be passed route generation helpers for globbed route segments.

For example, foo_path([1, 2, 3]) should still work for a route like map.foo "*globbed"
by implicitely calling to_s on the Fixnums.

Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2008-05-16 17:36:09 +01:00
Eugene Pimenov
150717344a auto_link helper fails to recognize links separated by space. [#72 state:resolved] 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2008-05-16 13:00:39 +01:00
Robby Russell
6df995bbf2 Adding an example test case for pluralize for (y) -> (ies) 2008-05-14 17:17:24 -07:00
Joshua Peek
603c853a34 Don't fallback to just adding "'s" in TextHelper#pluralize, because the Inflector is always loaded. 2008-05-14 14:34:28 -05:00
Joshua Peek
bc3cc91a3f One last fix to test_filter_parameters_is_protected. 2008-05-14 14:14:23 -05:00
Joshua Peek
f32b974338 Clean up previously commited test. 2008-05-14 13:55:14 -05:00
Joshua Peek
1066b16237 Improve test coverage for filter_parameters [José Valim] 2008-05-14 13:38:02 -05:00
Joshua Peek
8d37bd08ee Protect #filter_parameters created by filter_parameter_logging [José Valim] [#196 state:resolved] 2008-05-14 13:00:09 -05:00
Joshua Peek
7708650f73 Added conditional support to caches_action [José Valim] [#166 state:resolved] 2008-05-14 12:33:54 -05:00
Rich Cavanaugh
d8bcec6ce6 make CGI::Cookie handle deleting a cookie properly 
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2008-05-13 10:51:55 -07:00
Andre Arko
d16fbe53b2 Fix remote_function to escape apostrophes inside the remote url passed to Ajax.Update. [#180 state:resolved] 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2008-05-13 18:33:33 +01:00
rick
74fd17346f Merge branch 'master' of git@github.com:rails/rails 2008-05-13 09:41:10 -07:00
Rich Cavanaugh
a425cd1473 Don't double-escape cookie store data. Don't split cookie values with newlines into an array. [#130 state:resolved] 
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2008-05-12 15:26:19 -07:00
Peter Jones
2a986200b9 Bug: Earlier Check for Session in Forgery Protection 
The session is used by the form_authenticity_token method before it is
tested to be valid.  This patch moves a few lines around so that the
session is validated first.

Without this patch, if you try to use forgery protection with sessions
turned off, you get this exception message:

  undefined method `session_id' for {}:Hash

The patch includes a test that can be used to see this behavior before
the request_forgery_protection.rb file is patched to fix it.
 2008-05-11 13:27:34 -05:00