github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity
18,075 Commits 34 Branches 105 Tags
e119aaecd62e50d63cbfaac62eecf0d8a0034fb8
Commit Graph

4928 Commits

Author SHA1 Message Date
Jesse Storimer
730af48963 Ensure that inherited helper_methods are available after calling clear_helpers [#5348 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-08-28 18:07:01 -03:00
yury
3e22e0b025 Micro optimization for build_named_route_call in PolymorphicRoutes: 
1. use map instead of inject
2. use [].join("_") instead of '<<'. It is a little bit faster for ruby 1.9.2 and x2 faster for ruby 1.8.7. http://gist.github.com/548143

[#5450 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-08-28 17:54:50 -03:00
Santiago Pastorino
1851af84c1 password_field renders with nil value by default 
This makes the use of passwords secure by default if you want to render
the value of the password_field you have to do for instance
f.password_field(:password, :value => @user.password) # =>
<input type=password id=user_password name=user[password]
value=#{@user.password} />
 2010-08-28 05:23:34 -03:00
Santiago Pastorino
d630c76f3f type="password" for password_fields 2010-08-28 04:53:50 -03:00
Xavier Noria
dda515fc26 Merge remote branch 'docrails/master' 2010-08-28 00:01:55 +02:00
Joost Baaij
279c395723 Use common terminology 2010-08-27 23:50:23 +02:00
Xavier Noria
27d42a56b9 Revert "call-seq directive makes rdoc cry and replaces method names with a curly brace; besides it doesn't add anything when you only list one call example since this is obviously documented already" 
Reason: Part of this commit touches vendorized stuff, the rest is fine, could you please repatch?

This reverts commit 60de0e56b7.
 2010-08-27 23:30:52 +02:00
Joost Baaij
4a56f8f314 escape constants that should not be linked to 2010-08-27 22:47:11 +02:00
Joost Baaij
76c569344b mention the alert and notice accessors on the flash 2010-08-27 22:45:35 +02:00
Joost Baaij
9f4d3a1ebe expand cookie examples with signed and permanent methods 2010-08-27 22:31:02 +02:00
Joost Baaij
60de0e56b7 call-seq directive makes rdoc cry and replaces method names with a curly brace; besides it doesn't add anything when you only list one call example since this is obviously documented already 2010-08-27 22:20:53 +02:00
José Valim
d0e067f61b Add missing require. 2010-08-27 14:56:58 -03:00
Santiago Pastorino
f95ba5c262 Make InstanceTagMethods#value_before_type_cast raise if the model don't respond to attr_before_type_cast or attr method 
[#3374] [#5471 state:committed]
 2010-08-27 09:08:04 -03:00
Carlos Antonio da Silva
0aefbe52a0 Removing some unuseful begin/end and refactor prompt_option_tag a bit 
[#5469 state:committed]

Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2010-08-27 01:18:42 -03:00
José Valim
625f7b5a5b Be sure to call helper :all just on direct children. (Tests by Jesse Storimer) 2010-08-26 18:20:22 -03:00
José Valim
737abf25bb Doh, be sure to store the string modification. 2010-08-26 18:20:14 -03:00
Joost Baaij
6eed7b36a2 escape constant names 2010-08-26 23:10:00 +02:00
Joost Baaij
c28d46a92d Reflect how CSRF protection now works and refer to the Security Guide for more information 2010-08-26 23:03:30 +02:00
Joost Baaij
ca36326706 cleanup of ActionController::Metal inline documentation 2010-08-26 22:32:40 +02:00
Joost Baaij
930102968a Escape 'caching' when used in a sentence; remove unnessesary quotes 2010-08-26 21:58:57 +02:00
Joost Baaij
80ae74dea7 Prevent any warnings from being printed during RDoc generation 2010-08-26 21:31:32 +02:00
José Valim
818858ac1d Do not modify frozen strings in place. 2010-08-26 16:25:53 -03:00
José Valim
66ef92272c Add clear_helpers as a way to clean up all helpers added to this controller, maintaing just the helper with the same name as the controller. 2010-08-26 16:07:54 -03:00
José Valim
84cab320bc Ensure templates like template.html are found but still uses the proper virtual path. 2010-08-26 16:07:54 -03:00
Jaime Iniesta
d9f6e16937 Fix capture_helper.rb api documentation, unescaped script tag was breaking it on the content_for explanation 2010-08-26 14:23:58 +02:00
Xavier Noria
fa8e17b5c2 Merge remote branch 'docrails/master' 2010-08-26 01:39:16 +02:00
Joost Baaij
a68919ec84 Restored top-level documentation for ActionController::Base. 
This information was lost in commit bd6b61be88.
This might have been intentional, but this class does represent the starting
point for all things related to actions, and as such should document it.

I couldn't find any trace of this documentation, which seems like a waste.
Updated parts here and there to conform to current best practices.
 2010-08-25 23:28:56 +02:00
Joost Baaij
e9eaae1a05 fixed capitalization 2010-08-25 19:51:20 +02:00
Joost Baaij
eaeda503e8 change rdoc to conform to api guidelines 2010-08-25 18:57:27 +02:00
Rémy Coutable
43532f6b25 Restore consistency with the rest of the doc. 2010-08-25 15:55:53 +02:00
Rémy Coutable
58e2fa3695 Fixed a missing simple quote. 2010-08-25 15:52:43 +02:00
Andrew White
1847d33b4b Use nested scope for routes defined at the :resources scope level (as in Rails 2.3) 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-08-24 21:15:13 -03:00
José Valim
80e1f730a2 Allow format to be skipped. This is used internally by mount. 2010-08-24 16:58:32 -03:00
José Valim
e197d6f34b Finally fix the bug where symbols and strings were not having the same behavior in the router. 
If you were using symbols before for methods like match/get/post/put/delete, it is likely that this commit will break your routes.
Everything should behave the same if you are using strings, if not, please open up a ticket.
 2010-08-24 16:58:25 -03:00
José Valim
4a90ecb3ad Ensure shortcuts inside resources also generates helpers. 2010-08-24 16:58:12 -03:00
José Valim
2916521da8 Fix how routes inside namespaces are generated. 2010-08-24 13:05:29 -03:00
Santiago Pastorino
4df19b3f27 Allow actions which start with A-Za-z_ only 2010-08-24 12:43:43 -03:00
Andrew White
11f6179f55 Reset symbolized path parameters when a test request is recycled [#5437 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-08-24 11:24:32 -03:00
José Valim
542878304d Ensure prefix in routes are generated properly. 2010-08-24 11:24:31 -03:00
José Valim
b4f304b7b6 Fix a bug where symbols and strings were not behaving the same in the router. [#5431 state:resolved] 2010-08-24 10:26:25 -03:00
Andrew White
2fb0cbec02 When custom resource actions are specified using strings add the default name and action if the string is a valid ruby method name. 
[#5431 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-08-24 10:26:25 -03:00
David Heinemeier Hansson
21b1f29720 Master is now targeting 3.1.0.beta 2010-08-23 21:44:57 -05:00
Andrew White
ae2c60734a Cache the symbolized path parameters using a instance variable in the request object rather than the environment hash. This it to prevent stale parameters in later routing constraints/redirects as only the normal path parameters are set by Rack::Mount. 
Also if a constraint proc arity is more than one, pass the symbolized path parameters
as the first argument to match redirect proc args and provide easier access.

[#5157 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-08-22 16:17:26 -03:00
Nick Sieger
2277c51555 Fix hash modification during iteration in Mapper [#5420] 
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2010-08-20 18:27:02 -03:00
Andrew White
7c9bf45b0d Support routing constraints in functional tests 
Extend assert_recognizes and assert_generates to support passing
full urls as the path argument. This allows testing of routing
constraints such as subdomain and host within functional tests.

[#5005 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-08-20 14:51:25 -03:00
Andrew White
0d0fbf1e64 Don't add the standard https port when using redirect in routes.rb and ensure that request.scheme returns https when using a reverse proxy. 
[#5408 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-08-20 10:40:34 -03:00
Andrew White
771d2f918f Allow symbols for :path resource(s) option [#5306 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-08-20 09:32:48 -03:00
José Valim
de0f47afb2 Use attribute readers as they are faster in general. 2010-08-19 15:16:11 -03:00
Andrew White
c019db8ca1 Move regexps in options hash to :constraints hash so that they are pushed into the scope [#5208 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-08-19 15:05:57 -03:00
Andrew White
0cc483aa14 Move edit route before show route so that it will have precedence if the :id parameter allows slashes [#5409 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-08-19 15:05:33 -03:00