github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity
19,741 Commits 34 Branches 105 Tags
e1d0d5ae81d2b02eebb1afbfb79edf0a2da2d48e
Commit Graph

4816 Commits

Author SHA1 Message Date
Xavier Noria
9332cc582e removes a couple of redundant selfs 2010-11-26 00:35:23 +01:00
Santiago Pastorino
438c0188f8 nil check unneeded ht. exviva 2010-11-25 20:00:40 -02:00
Emilio Tagua
a3bd62e1ba Remove explicit return. 
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2010-11-25 17:35:24 -02:00
Emilio Tagua
c91a13f8f5 Use ternary instead explicit return. 
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2010-11-25 17:35:09 -02:00
Emilio Tagua
ac6e9447e5 Remove return, we are already returning self. 
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2010-11-25 17:33:38 -02:00
Emilio Tagua
1b6b80355c Remove explicit return. 
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2010-11-25 17:33:18 -02:00
Emilio Tagua
c4d31d0f13 Reuse lock_col variable instead calling locking_column class method. 
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2010-11-25 17:32:16 -02:00
raggi
cb1570936d Rakefiles are executables, and rake loads rake, not rakefile code 2010-11-25 06:49:55 +08:00
raggi
d8692985fe Don't depend on rubygems loading thread (for Mutex) 2010-11-25 06:47:27 +08:00
Aaron Patterson
ee74f2c623 alias should be a SQL literal 2010-11-24 14:16:38 -08:00
Aaron Patterson
38eb01863c initialize instance variables in initialize... o_O 2010-11-24 14:11:12 -08:00
Aaron Patterson
34d21b87bb adding a factory method to the join part for generating a table alias 2010-11-24 13:55:56 -08:00
Aaron Patterson
cdf6cf01cb use ARel rather than generate SQL strings 2010-11-24 13:55:55 -08:00
Aaron Patterson
afe51afcc6 remove useless join 2010-11-24 13:55:55 -08:00
Aaron Patterson
d4b8d3bafa moving column_aliases to JoinDependency 2010-11-24 13:55:55 -08:00
Aaron Patterson
a3ba60fd81 reduce method calls 2010-11-24 13:54:08 -08:00
Neeraj Singh
66212f69ac If a nested_attribute is being marked for destruction and at the same time an attr_accessor value is being assigned then the value being assigned is being ignored. This patch is a fix for that issue. 
[#5939 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-11-24 22:08:36 +01:00
Franck Verrot
7f8ce38b0d Document the behavior of the dup method: does not preserve timestamps 2010-11-25 03:01:30 +08:00
Franck Verrot
7b77a1fc71 Typo in the comments of the clear_timestamp_attributes method 2010-11-25 03:01:30 +08:00
Franck Verrot
c17cb7326d Dup should reset the timestamps as it is considered a new record 2010-11-25 01:18:43 +08:00
Franck Verrot
47f39d26a7 Testing that dup is resetting the timestamps 2010-11-25 01:18:43 +08:00
Aaron Patterson
0687b21de8 removing ternary 2010-11-23 17:52:51 -08:00
Aaron Patterson
1aaa8edeb9 breaking classes up in to respective files 2010-11-23 17:42:49 -08:00
Aaron Patterson
a551d2ec62 fixing variable names. oops! 2010-11-23 17:42:49 -08:00
Aaron Patterson
8e8fb8a429 just wrap as a sql literal 2010-11-23 14:42:55 -08:00
Neeraj Singh
d33dcba72d Do not send id for quoting twice if the primary key is string. 
[#6022 state:resolved]
 2010-11-23 14:33:00 -08:00
Aaron Patterson
0456feab11 updating changelog for dup and clone semantics 2010-11-23 14:29:05 -08:00
Aaron Patterson
d717cb2913 clone and dup are working on 1.8 2010-11-23 14:29:05 -08:00
Aaron Patterson
fe4388eb15 converting clone test to dup test 2010-11-23 14:29:05 -08:00
Aaron Patterson
064c28d6c2 fixing dup regressions 2010-11-23 14:29:05 -08:00
Aaron Patterson
93d78b8318 fixing more dup tests 2010-11-23 14:29:05 -08:00
Aaron Patterson
6a8f1b8b40 renaming duplication test to dup test 2010-11-23 14:29:04 -08:00
Aaron Patterson
c5858a6df3 adding a specific case for clone testing 2010-11-23 14:29:04 -08:00
Aaron Patterson
28f4df0908 testing duped attributes are independent 2010-11-23 14:29:04 -08:00
Aaron Patterson
4c1f76eaab initialize_clone can go away 2010-11-23 14:29:04 -08:00
Aaron Patterson
035d00b665 making sure changes to dup will not touch original 2010-11-23 14:29:04 -08:00
Aaron Patterson
5badf60d12 dup keeps changes 2010-11-23 14:29:04 -08:00
Aaron Patterson
ca7b0a0d1a dup is working better 2010-11-23 14:29:03 -08:00
Xavier Noria
85d64316a4 Merge branch 'master' of git://github.com/lifo/docrails 2010-11-23 21:59:50 +01:00
Emilio Tagua
9f35799221 Refactor && simplify count_records. 2010-11-23 09:51:07 -08:00
Emilio Tagua
e2bad8a2e7 No need to create a variables to use them once. 2010-11-24 01:37:02 +08:00
Emilio Tagua
d29d793c90 Don't create local vars. 2010-11-24 01:37:01 +08:00
Emilio Tagua
6ffe0ef55b Avoid creating local var. 2010-11-24 01:37:01 +08:00
Emilio Tagua
63c9185b62 Remove explicit return and avoid creating local var. 2010-11-24 01:37:01 +08:00
Emilio Tagua
1b531b7ee2 Remove explicit return. 2010-11-24 01:37:00 +08:00
Emilio Tagua
b8df3a9197 Use params default. 2010-11-24 01:37:00 +08:00
Emilio Tagua
861cdc4c59 Remove unneeded local var. 2010-11-24 01:36:59 +08:00
Emilio Tagua
9c161599ac Remove uneeded local var definition. 2010-11-24 01:36:59 +08:00
Emilio Tagua
a9e963d51d Remove confusing parenthesis. 2010-11-24 01:36:59 +08:00
Emilio Tagua
14055ea282 No need to define a local var here. 2010-11-24 01:36:59 +08:00