github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity
17,470 Commits 34 Branches 105 Tags
e1d4e78b15141cf940be7a84ca856425484a98be
Commit Graph

77 Commits

Author SHA1 Message Date
José Valim
c3c349ec3e Remove assert_valid. It was already deprecated on Rails 2.3. 2010-07-19 22:35:17 +02:00
Paco Guzman
ec37452f68 Remove unused variable on assert_recognizes [#4912 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-22 17:37:18 +02:00
Josh Kalderimis
dad71c6099 removed 'unless const_defined?' code smell 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-21 23:34:45 +02:00
Evgeniy Dolzhenko
ccf9577aee Fix a bunch of minor spelling mistakes 2010-06-11 14:15:34 +04:00
wycats
d6953cbfd3 regular expressions are usually ASCII-encoded, so force_encoding the content of a Node to the encoding of the regular expression is wrong. 2010-06-07 18:06:08 -04:00
Paco Guzman
cdf700147c fix assert_select messages to its declaration behaviour 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-05-15 16:31:36 +02:00
Santiago Pastorino
961aa70e4a Some require indifferent_access added 
Signed-off-by: Xavier Noria <fxn@ubuntu.(none)>
 2010-04-21 07:45:29 -07:00
David Chelimsky
4327ad51ab access assigns as a method or hash, with strings or symbols [#4431 state:resolved] 2010-04-17 15:59:10 -04:00
Joshua Peek
570c54c39a Fix cookie access in integration tests with other host names 2010-04-05 15:22:09 -07:00
Xavier Noria
89978f10af moves Object#singleton_class to Kernel#singleton_class to match Ruby also there, same for #class_eval to simplify, and adds coverage for class_eval 2010-04-05 12:15:08 -07:00
José Valim
6690d66292 Rename config.cookie_secret to config.secret_token and pass it as configuration in request.env. This is another step forward removing global configuration. 2010-04-05 12:00:24 +02:00
wycats
ab8bf9e152 * Change the object used in routing constraints to be an instance of 
ActionDispatch::Request rather than Rack::Request.

* Changed ActionDispatch::Request#method to return a String, to be
  compatible with the Rack::Request superclass.

* Changed ActionDispatch::Request#method to return the original
  method in the case of methodoverride and #request_method not to,
  to be compatible with Rack::Request
 2010-04-03 20:24:30 -07:00
José Valim
997e22c275 Add a test which ensures action_dispatch.show_exceptions is properly disabled. 2010-04-02 20:54:10 +02:00
Joshua Peek
cdf8c35ffd Consistent routing language 2010-03-30 14:05:42 -05:00
Joshua Peek
17f0c1e9e8 Fix stack overflow bug in integration test router helpers 2010-03-30 13:58:18 -05:00
wycats
c99194c7be Merge remote branch 'rizwan/restrict' 2010-03-28 11:06:46 -07:00
Xavier Noria
76f024ac8d adds missing requires for Object#blank? and Object#present? 2010-03-28 14:15:02 +02:00
Rizwan Reza
835f5d0269 Rails 3 application can run performance tests now. [#4171 state:resolved] 2010-03-28 15:03:25 +04:30
wycats
15c31c7639 open_session can just return the a dup of the current context. 
At this point, its entire purpose in the open_session {} case was to
delegate back to the IntegrationTest anyway.
 2010-03-22 17:14:28 -07:00
Carlhuda
a5d80f84d2 Each controller class has it's own view context subclass. This removes the need for ActionView::Base.for_controller 2010-03-18 18:14:54 -07:00
Carlhuda
71c9337f45 All tests pass without memoizing view_context 2010-03-18 15:52:43 -07:00
Carlhuda
0e15f07b75 Get modules back into integration tests 2010-03-17 17:52:21 -07:00
Mathias Biilmann Christensen
6c0c0f41a3 Fix for missing dependency in ActionDispatch::Integration 
When running cucumber features from a new rails 3 app requiring
'cucumber/rails/world' would raise:

uninitialized constant ActionDispatch::Integration::Session::Test (NameError)

Fixed by requiring 'test/unit/assertions' in action_dispatch/integration

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-03-17 16:53:42 -07:00
Carlhuda
947f86c699 Modify assert_template to use instrumentation 2010-03-17 14:29:18 -07:00
Carl Lerche
23b6def0eb Do not always include the named URL helpers into AC::Base and AV::Base. 2010-03-16 15:47:49 -07:00
Jeremy Kemper
2a50eabf45 Integration test url options should account for :protocol not just https? 2010-03-15 19:52:41 -07:00
Jeremy Kemper
9f83cdc38e No longer add missing leading / on path args to assert_redirected_to. Deprecated in 2.3.6. 2010-03-02 14:16:25 -08:00
Yehuda Katz
3f0ed205e7 Remind us that RoutingAssertions should work in an integration context 2010-02-26 22:47:36 -08:00
Carlhuda
050831803a If IntegrationSession is initialized with an objects that responds to #routes, automatically extend the URL helpers from the RouteSet onto it 2010-02-26 17:18:45 -08:00
Carlhuda
ab0cc7286f Setting UrlFor in with_routing is no longer needed now that it's not global 2010-02-26 15:56:38 -08:00
Carlhuda
3bad24c85d Remove traces of SharedTestRoutes from user code; leave it as a standin for Rails.application.routes in Rails internal tests 2010-02-26 15:44:22 -08:00
Carlhuda
bae691f61a Change the API for setting global options for #url_for to self.url_options = { ... } 
This attr_accessor can be set in a before filter or in the action itself.
    Overwriting default_url_options still works but will output a deprecation notice.
 2010-02-26 15:20:41 -08:00
Carlhuda
98f77e0827 Rename named_url_helpers to url_helpers and url_helpers to url_for 2010-02-26 15:04:50 -08:00
Carlhuda
f863045c45 Rename metaclass to singleton_class 2010-02-25 17:56:58 -08:00
Carlhuda
8760add31a Get URL helpers working again in integration tests. 2010-02-25 17:53:30 -08:00
Carlhuda
fc4582fb66 Final pass at removing the router from a global constant 2010-02-25 17:53:29 -08:00
Carlhuda
226dfc2681 WIP: Remove the global router 2010-02-25 17:53:00 -08:00
Jeremy Kemper
f7b0a857e9 Use Object#singleton_class instead of #metaclass. Prefer Ruby's choice. 2010-02-25 09:32:29 -08:00
Martin Schürrer
6bc24d40d5 Use ActionDispatch::Routing everywhere 2010-02-21 13:43:51 -08:00
Carlhuda
a3c6ad7d5e Fix a bunch of pending tests by providing an introspection mode for the Response object that does up-front parsing of the headers to populate things like @etag 2010-02-19 19:19:20 -08:00
José Valim
47a236e291 AD::TestProcess relies on request.flash, so let's load it. 2010-02-16 22:54:56 +01:00
Joshua Peek
1bd8a50a99 Deprecation notice for TestResponse#redirected_to 2010-01-30 12:26:49 -06:00
Joshua Peek
909443eab6 Expose last controller in rack env["action_controller.instance"] 2010-01-20 09:00:23 -06:00
Joshua Peek
88ffba2329 Disable ShowExceptions during integration tests 2010-01-19 09:06:21 -06:00
Pratik Naik
dba196cb7f Merge docrails 2010-01-17 03:26:20 +05:30
José Valim
0cf190001e Remove CGI.escape in function of Rack::Mount.escape 2010-01-06 00:33:17 +01:00
Joshua Peek
8ff4faf66a assert_template depends on AV::Template monkey patches in action_view/test_case 2010-01-05 11:48:06 -06:00
Joshua Peek
2601a16ede Autoload AS test case 2010-01-04 16:22:46 -06:00
David Heinemeier Hansson
e7ef57dd0d Merge 2009-12-22 17:31:29 -08:00
David Heinemeier Hansson
fe5f660413 Dont encourage __FILE__ bullshit 2009-12-22 17:25:34 -08:00