github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity
17,470 Commits 34 Branches 105 Tags
e1d4e78b15141cf940be7a84ca856425484a98be
Commit Graph

3353 Commits

Author SHA1 Message Date
Aaron Patterson
5ebc1d88d3 testing sqlbypass destroy. caching connection during destroy 2010-07-23 08:36:58 -07:00
Aaron Patterson
9b48a94c0a brrrrr! freeze is not needed 2010-07-23 08:30:14 -07:00
Aaron Patterson
5e6382e607 fixing space error 2010-07-22 23:45:07 -07:00
Aaron Patterson
34ff74f448 refactoring more methods to a class methods module 2010-07-22 23:44:58 -07:00
Aaron Patterson
da37716c35 refactoring class methods to a module 2010-07-22 23:40:39 -07:00
Jeremy Kemper
3ec6759552 Session data will exceed 255 bytes. Use TEXT. 2010-07-22 13:34:07 -07:00
Santiago Pastorino
24f303b677 Makes current adapter decide the syntax of PRIMARY KEY column definition 2010-07-22 15:49:05 -03:00
Santiago Pastorino
7113f207c3 This is a VARCHAR not a TEXT 2010-07-22 15:48:57 -03:00
Santiago Pastorino
1b8cd5fb53 MySQL can't index a TEXT column 2010-07-22 15:48:55 -03:00
Aaron Patterson
97f3c7387e refactor to use instance methods and be kind to subclasses 2010-07-22 09:38:56 -07:00
Aaron Patterson
a78547a9c6 testing loaded? method and reducing funcalls 2010-07-21 16:59:23 -07:00
Aaron Patterson
87a319cd0c testing new_record? and converting to an attribute 2010-07-21 16:55:04 -07:00
Aaron Patterson
f5de56f537 reducing function calls in the session store 2010-07-21 16:52:15 -07:00
Aaron Patterson
4e6cf429a1 readability is hip 2010-07-21 16:45:38 -07:00
Aaron Patterson
ba0d2a9ce3 starting sql bypass test, fixing create_table and drop_table! 2010-07-21 16:36:28 -07:00
Aaron Patterson
bdbe390a98 initializing instance variables 2010-07-21 16:36:28 -07:00
Aaron Patterson
1f8edb996b adding tests for sessions and clearing up warnings 2010-07-21 16:36:28 -07:00
Neeraj Singh
5c137939a7 expanded comment for update_attribute method 2010-07-22 01:28:30 +02:00
Santiago Pastorino
ef5ae60a07 Make use of tap to return a previously used var 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-21 17:17:23 +02:00
Subba Rao Pasupuleti
d77c3b669c eagerly loaded association records should respect default_scope [#2931 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-21 15:01:40 +02:00
Neeraj Singh
992711a86b update_attribute should not update readonly attributes 
[#5106 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-21 14:55:57 +02:00
Thiago Pradi
c96a505391 rake db:seed should check if the database have pending migrations [#5163 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-21 14:55:26 +02:00
José Valim
f3e42292a5 Ensure all join table attributes will be in the same timestamp. 2010-07-21 14:51:15 +02:00
Neeraj Singh
8bb3b634c0 Timestamp columns of HABTM join table should record timestamps 
[#5161 state:resolved]
 2010-07-21 14:45:36 +02:00
José Valim
01add55d6a Revert "save on parent should not cascade to child unless child changed [#3353 state:open]" 
Please check Lighthouse for more information.

This reverts commit 4a0d7c1a43.
 2010-07-21 14:44:46 +02:00
Szetobo
0057d2df71 association load target shouldn't replace records 
from db if it is already loaded by nested attributes assignment

[#5053 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-21 14:25:27 +02:00
Subba Rao Pasupuleti
c0bfa0bfc1 In nested_attributes when association is not loaded and association 
record is saved and then in memory record attributes should be saved

[#5053 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-21 14:25:19 +02:00
Santiago Pastorino
fa8b290496 id is a public method 2010-07-21 08:19:53 +08:00
Neeraj Singh
f576d7cf84 Ensure that primary_keys of HABTM records is not double quoted 
[#5152 state:reslved]
 2010-07-20 16:45:42 -07:00
Aaron Patterson
e1df4b9568 adding a reader for loaded, initializing @loaded to false 2010-07-20 09:15:09 -07:00
Aaron Patterson
202fb79e86 reusing the time instrumentation from the instrumenter rather than Benchmark. [#5098 state:open] 2010-07-19 13:44:11 -07:00
Daniel Guettler
38f0161aab Minor performance improvment in notifications/fanout and active_record/log_subscriber [#5098 state:open] 2010-07-19 11:45:50 -07:00
Aaron Patterson
ad4ef4226f avoid const lookup. we know what these constants are in advance 2010-07-19 10:31:24 -07:00
Łukasz Strzałkowski
bd4b3d8b2f Added missing require of remove_method 2010-07-19 23:44:50 +08:00
Łukasz Strzałkowski
661fd98aad Make use of redefine_method, removed some more redefining warnings 2010-07-19 23:44:50 +08:00
Łukasz Strzałkowski
010eda2eb5 Removed warnings about method redefining 2010-07-19 23:44:48 +08:00
Łukasz Strzałkowski
247886e1b4 Removed warnings when a variable is shadowed 2010-07-19 23:44:45 +08:00
Subba Rao Pasupuleti
4a0d7c1a43 save on parent should not cascade to child unless child changed [#3353 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-18 11:31:29 +02:00
José Valim
e210895ba9 Avoid uneeded queries in session stores if sid is not given. 2010-07-18 11:02:08 +02:00
José Valim
fa98eca75b Add console hook to force ActiveRecord::Base to be loaded when console starts avoiding reference loops. 2010-07-18 11:02:07 +02:00
Aaron Patterson
42be67e8d4 unfactoring clear_stale_cached_connections! 2010-07-16 14:48:50 -07:00
Aaron Patterson
04ef434b21 only test for existence of +pool+ once 2010-07-16 11:44:29 -07:00
Aaron Patterson
b952470cc2 use an attr_reader for performance 2010-07-16 11:44:29 -07:00
David Genord II
1fcf4e8ecb JoinDependency#graft does not properly set parent join [#5124 state:resolved] 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2010-07-16 08:28:49 +01:00
Pratik Naik
0c2c893434 Revert "Style fixes" 
This reverts commit 3c300b3121.
 2010-07-15 13:17:35 +01:00
Aaron Patterson
62dd1d8d23 clean up ||= with an initialized variable and attr_reader 2010-07-14 17:53:20 -07:00
wycats
3c300b3121 Style fixes 2010-07-14 17:33:07 -07:00
Aaron Patterson
955b26ac6e primary_key_name already checks for the model_class 2010-07-14 17:11:52 -07:00
Aaron Patterson
d41a28bcca use array intersection for dry / faster code 2010-07-14 17:09:14 -07:00
Aaron Patterson
6a534455f6 remove useless ternary in PostgreSQL adapter 2010-07-14 15:44:15 -07:00