github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity
17,992 Commits 34 Branches 105 Tags
e1e712227197bcfb9564113eb3dd8ef6ffac243f
Commit Graph

3496 Commits

Author SHA1 Message Date
Aaron Patterson
e1e7122271 mark SQL literals as SQL literals 2010-08-25 05:17:49 -07:00
Xavier Noria
3ac6646d6f :nodoc:s #unscoped until its behavior is more clear, now sometimes works, sometimes not 2010-08-25 01:05:51 +02:00
Xavier Noria
a820bd9df6 edit pass to a recent doc patch 2010-08-25 00:22:53 +02:00
Xavier Noria
036f090df1 Merge remote branch 'docrails/master' 2010-08-25 00:17:02 +02:00
Neeraj Singh
747e0744dd @user.touch should not fail if User does not have updated_at/updated_on column. 
[#5439 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-08-24 11:24:32 -03:00
Neeraj Singh
f460de1d23 touch operationg if used along with belongs_to will also be invoked on associated objects 2010-08-24 10:21:58 -04:00
Joost Baaij
20333be581 fix broken relative links [#5415 state:committed] 
Signed-off-by: Xavier Noria <fxn@hashref.com>
 2010-08-24 16:20:32 +02:00
José Valim
6ef60bd9ff Ensure timestamps are not generated when explicitly set to false [#5440 state:resolved] 2010-08-24 10:45:16 -03:00
David Heinemeier Hansson
21b1f29720 Master is now targeting 3.1.0.beta 2010-08-23 21:44:57 -05:00
Aaron Patterson
6f4d100761 marking sql literals as sql literals 2010-08-23 18:48:29 -07:00
Aaron Patterson
2e8e6e581f we should mark sql strings as sql literals 2010-08-23 14:28:15 -07:00
Aaron Patterson
5931a1dbd3 sql literal strings should be marked as sql literal strings 2010-08-23 13:57:22 -07:00
Aaron Patterson
ee9e1570be we should mark strings as SQL Literal values 2010-08-23 13:30:12 -07:00
Brian Lopez
6d796a71d2 mysql2 adapter is being maintained in the mysql2 gem itself 
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2010-08-23 15:59:51 -03:00
Neeraj Singh
13ebf69ae4 unscoped does not work when chained with named_scope 2010-08-23 05:45:11 -04:00
Aaron Patterson
cdef4450e5 removing unused code 2010-08-22 17:15:56 -07:00
Xavier Noria
b587bfd589 Merge remote branch 'rails/master' 2010-08-23 01:21:43 +02:00
Evgeniy Dolzhenko
c0549ed2e5 Fix docs to reference ActiveRecord::LogSubscriber 
since Rails::LogSubscriber doesn't seem to be defined anymore
 2010-08-21 09:39:37 +04:00
Jeremy Kemper
c211d904ba Revert "Just add connection management middleware if running in a concurrent environment." 
This reverts commit 6b29dc876f.
 2010-08-20 18:55:02 -07:00
Aaron Patterson
0420fb5647 adding FOUND_ROWS to the connect flags for mysql2 2010-08-20 10:16:22 -07:00
Xavier Noria
0c75ec51a9 Merge remote branch 'rails/master' 2010-08-20 17:18:57 +02:00
Neeraj Singh
87398e531d Patch for Lighthouse ticket #5419 has been been applied. So reverting this one. 
Revert "documentation regarding after_validation"

This reverts commit c24aa2f2dc.
 2010-08-20 11:08:25 -04:00
Neeraj Singh
c24aa2f2dc documentation regarding after_validation 2010-08-20 09:48:07 -04:00
Aaron Patterson
949c7e2d0e fisting after_rollback and after commit callbacks 2010-08-20 00:06:49 -07:00
Aaron Patterson
bfd8be7fab updates return number of rows matched rather than number of rows affected 2010-08-19 19:13:50 -07:00
Andrew White
0b73f2af0e Optimize find_sti_class when store_full_sti_class is true 
[#5403]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-08-19 16:03:15 -05:00
Trevor Turk
99c092d4e8 Note about validates_presence_of and nested attributes 2010-08-19 14:49:10 -05:00
Trevor Turk
e6b6d3adad Note about using attr_accessible with nested attributes 2010-08-19 14:25:15 -05:00
Neeraj Singh
2e45542942 While creating a new record using has_many create method default scope of child should be respected. 
author.posts.create should take into account default_scope
defined on post.

[#3939: state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-08-19 14:52:15 -03:00
Aaron Patterson
a4458f5d21 removing useless ternary 2010-08-19 10:46:10 -07:00
Aaron Patterson
a70248c3d8 we should wrap strings as sql literals 2010-08-19 10:35:09 -07:00
Jeremy Kemper
d3e30a18b2 Memoize STI class lookups for the duration of a request 2010-08-19 11:07:09 -05:00
Aaron Patterson
072cd60379 refactor if / else to ||= 2010-08-18 23:37:37 -07:00
Aaron Patterson
e4f424d577 refactoring to remove duplicate logic 2010-08-18 12:10:48 -07:00
Aaron Patterson
93f335b6fb call to present? is not necessary 2010-08-18 11:51:59 -07:00
Carlos Antonio da Silva
0dfb8ff347 Use COALESCE in update_counters docs to reflect the implementation 2010-08-18 10:15:26 -03:00
Jeff Lawson
c017041e68 Bug Fix -- clean up connection after stored procedure [#3151 state:resolved] 2010-08-17 13:16:03 -07:00
Jeff Lawson
7ce1539934 Bug Fix -- clean up connection after stored procedure [#3151 state:resolved] 2010-08-17 13:15:58 -07:00
Raimonds Simanovskis
c7dd49eb2a Replaced hardcoded SessionStore table creation SQL with calls to ActiveRecord adapter migration methods 
Otherwise hardcoded table creation SQL was failing on Oracle database
 2010-08-16 15:21:58 -07:00
Santiago Pastorino
3c8b50020a Revert "Makes AR use AMo to_key implementation" 
This reverts commit 36a84a4f15.
 2010-08-15 11:33:21 -03:00
Santiago Pastorino
a81c956bf1 remove already defined method to avoid warnings 2010-08-15 07:59:40 -03:00
Santiago Pastorino
69de30d01f Revert "connection reader is defined later" 
This reverts commit f4cce71d96.
 2010-08-15 07:47:52 -03:00
Santiago Pastorino
f4cce71d96 connection reader is defined later 2010-08-15 07:19:53 -03:00
Santiago Pastorino
b451de0d6d Deletes trailing whitespaces (over text files only find * -type f -exec sed 's/[ \t]*$//' -i {} \;) 2010-08-14 04:12:33 -03:00
Santiago Pastorino
1590377886 Makes AR use AMo to_key implementation 
[#5249]
 2010-08-13 22:26:44 -03:00
Santiago Pastorino
27fb88aa22 This method is actually not used, it's implemented on the concrete adapters 
[#5331 state:committed]
 2010-08-13 21:19:47 -03:00
Aaron Patterson
be5d1608cb converting to a symbol is not necessary 2010-08-13 16:50:31 -07:00
Prem Sichanugrist
a7eb8d97a4 Removing most of the symbol to proc usage in Active Record 
This will hopefully make Active Record run a bit more faster.
 2010-08-13 16:24:49 -07:00
Aaron Patterson
b9eec677c4 avoid direct use of arel constants 2010-08-13 13:33:08 -07:00
Aaron Patterson
af3e39358c removing references to arel constants 2010-08-13 12:37:18 -07:00