Commit Graph

2943 Commits

Author SHA1 Message Date
Aaron Patterson
6054c092dc oops! remove debugging codes 2011-06-27 14:46:56 -07:00
Aaron Patterson
997aed24be default create_with_value to a hash so we can eliminate conditionals, add test surrounding create_with(nil) behavior 2011-06-27 14:18:49 -07:00
Santiago Pastorino
d6413f043c Merge pull request #1848 from raviolicode/postgresql_order_multiple_params
Fix for complex ordering of multiple columns on postgresql
2011-06-24 13:09:33 -07:00
Lucia Escanellas
9734a416fa Improve ordering of multiple columns on postgresql
* Only on postgresql, order("first asc, second asc") was invalid
* Closes #1720
2011-06-24 13:37:08 -03:00
Jon Leighton
87d6865bf7 Apply the default scope earlier when doing calculations. Fixes #1682. 2011-06-23 19:57:49 +01:00
Aaron Patterson
09866cef17 Merge pull request #1790 from ernie/reverse_sql_order_fix
Support reversal of ARel orderings in reverse_sql_order
2011-06-22 08:30:52 -07:00
Aaron Patterson
ceb5bbbafc Merge pull request #1632 from tardate/pg_schema_fu
Improving PostgreSQL adapter schema-awareness
2011-06-21 10:22:20 -07:00
Ernie Miller
08f3f30994 Support reversal of ARel orderings in reverse_sql_order 2011-06-20 14:15:19 -04:00
José Valim
7d4606156b Merge pull request #1763 from grantneufeld/schema_column_exists_options_hash
Fix default options argument on ActiveRecord::ConnectionAdaptors::Table#column_exists?
2011-06-18 19:34:39 -07:00
Paul Gallagher
2b3d67fdaf Merge remote branch 'rails/master' into pg_schema_fu 2011-06-19 10:21:15 +08:00
Paul Gallagher
b0d59907f7 Make PostgreSQL adapter view-compatible
* amongst other things, allows meta_search to run against view-backed models
2011-06-19 10:14:17 +08:00
Steve Hodgkiss
50444204cc Fix inconsistencies by being polite to the wrapped body. Needed for Rack::Sendfile to function properly. See issue #1761. 2011-06-18 22:30:01 +01:00
Grant Neufeld
3cc83a8f24 Changed the default value for the options argument on ActiveRecord::ConnectionAdapters::Table#column_exists? from nil to an empty Hash {}.
That method calls through to ActiveRecord::ConnectionAdapters::SchemaStatements##column_exists? expects options to be a Hash.

When options was nil, an error would occur in cases where the column did exist because the called method attempted to perform a key lookup on options.
2011-06-18 14:38:38 -06:00
Jon Leighton
e510c2c642 Add require 'pathname' as it has not already been required in some circumstances 2011-06-17 14:55:34 +01:00
Andrew White
5d655aabcb Pass mass-assignment options to nested models - closes #1673. 2011-06-13 13:02:51 +01:00
Andrew White
987afa583e Rename tests to reflect associations 2011-06-13 10:01:38 +01:00
Jon Leighton
86bbba1ffb Add support for using an ARCONFIG environment variable to specify the location of the config.yml file for running the tests 2011-06-12 19:08:16 +01:00
Jon Leighton
15e289147e Oops, this should have been in the last commit 2011-06-12 19:05:29 +01:00
Jon Leighton
c52520166b Make assert_no_queries literally enforce that there are no queries. As in, not a single line of SQL should be sent to the database, not even stuff that is ignored by assert_queries. The argument being that if you write assert_no_queries, you really do not want there to be any queries. 2011-06-12 18:50:24 +01:00
Jon Leighton
232c66a1ba If we're going to use a global variable, let's at least namespace it 2011-06-12 18:38:39 +01:00
Jon Leighton
14e6bbb149 Refactor tests to be less brittle 2011-06-12 18:19:21 +01:00
Jon Leighton
de01a64102 Move BEGIN and COMMIT into IGNORED_SQL rather than having them as a special case in assert_queries 2011-06-12 18:19:21 +01:00
benedikt
fa8dfad765 Don't wrap operations on collection associations in transactions when they are not needed, so the connection adapter does not send empty BEGIN COMMIT transactions blocks to the database. 2011-06-12 18:19:21 +01:00
Paul Gallagher
f8c4b374c8 make extract_schema_and_table a private method 2011-06-11 18:34:09 +08:00
Paul Gallagher
1d7c751bf7 remove table quoting in primary_key method
* add/cleanup tests
2011-06-11 02:21:24 +08:00
Paul Gallagher
019c263633 apply private method indentation convention
* tidy test code and fix my typo
2011-06-10 22:48:58 +08:00
Paul Gallagher
5c7f8c929b Improve PostgreSQL adapter schema-awareness
* table_exists? scoped by schema search path unless schema is explicitly named. Added tests and doc to clarify the behaviour
* extract_schema_and_table tests and implementation extended to cover all cases
* primary_key does not ignore schema information
* add current_schema and schema_exists? methods
* more robust table referencing in insert_sql and sql_for_insert methods
2011-06-10 21:52:25 +08:00
Jon Leighton
4b371b602b Print out information about whether the identity map is on or off when running unit tests 2011-06-09 20:20:51 +01:00
Sebastian Martinez
9af4e803ec Remove unused 'y' variable. 2011-06-08 23:13:59 -03:00
Raimonds Simanovskis
e58ee1dccc Do not hardcode :id as it was ignored by mass assignment filter
As a result test was failing on Oracle where ids are assigned by default from 1000
2011-06-08 11:56:23 +03:00
Jon Leighton
7d1782a2c1 Allow polymorphic has_one to work when the association is set before the owner has been saved. Fixes #1524. 2011-06-08 00:32:49 +01:00
Jon Leighton
4f5f6a3257 When you add a record to a polymorphic has_one, you should be able to access the owner from the associated record 2011-06-08 00:32:49 +01:00
Alexandr Zykov
4c3ec9889a fix typo 2011-06-08 03:31:33 +06:00
Dmitriy Kiriyenko
8aabefb0b7 This way asserting that updated_at was changed in touch look more obvious. 2011-06-07 18:42:40 +01:00
Dmitriy Kiriyenko
7c1f73c843 Do not use default_scope in ActiveRecord::Persistence#touch. 2011-06-07 18:42:40 +01:00
Jon Leighton
ad9586bf38 Fix a couple of helper requires that were missed. This was causing the tests to fail to run on 1.8.7. 2011-06-07 08:35:55 +01:00
José Valim
e32e8ed966 Merge pull request #1474 from ganeshkumar/update_column_changes
added  tests for update_column
2011-06-07 00:14:42 -07:00
Aaron Patterson
8392f10b58 set the environment variable from the rake file 2011-06-06 16:51:45 -07:00
Aaron Patterson
424cf3b050 more oracle fixes 2011-06-06 15:47:29 -07:00
Aaron Patterson
517ca8771c do not muck with the load path, that is the test task responsibility 2011-06-06 15:47:26 -07:00
Aaron Patterson
841d29639b updating configs for oracle 2011-06-06 15:47:22 -07:00
Aaron Patterson
61774e0d49 please use ruby -I lib:test path/to/test.rb, or export RUBY_OPT 2011-06-06 15:47:13 -07:00
Jon Leighton
523c7c2330 Fix adapter_test.rb to make no assumptions about the database name 2011-06-05 11:28:17 +01:00
Jon Leighton
3b7d100b51 Fix typo 2011-06-05 11:28:17 +01:00
José Valim
b5b31658bc Merge pull request #1462 from arunagw/test_added_for_namedscope
Test added for namedscope target.
2011-06-05 00:12:05 -07:00
Jon Leighton
75e56101d4 Bring back oracle specific crap 2011-06-04 23:49:54 +01:00
Jon Leighton
253bb6b926 Refactor Active Record test connection setup. Please see the RUNNING_UNIT_TESTS file for details, but essentially you can now configure things in test/config.yml. You can also run tests directly via the command line, e.g. ruby path/to/test.rb (no rake needed, uses default db connection from test/config.yml). This will help us fix the CI by enabling us to isolate the different Rails versions to different databases. 2011-06-04 23:47:03 +01:00
ganesh
5f66f7a9a2 added more tests for update_column 2011-06-04 00:04:59 +05:30
Arun Agrawal
0695eb6dac Test added for namedscope target. 2011-06-03 08:28:00 +05:30
Jon Leighton
f064664de7 Fix broken test. You know, the merge button will be the end of us... 2011-06-01 23:13:40 +01:00