github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-02-10 14:15:00 -05:00
Code Issues Packages Projects Releases Wiki Activity
3,700 Commits 34 Branches 105 Tags
e34de4dc24fbfad3a80a063b0127242c83e485a3
Commit Graph

779 Commits

Author SHA1 Message Date
Jeremy Kemper
71234daef1 r4487@asus: jeremy | 2006-04-29 12:21:39 -0700 
Check whether @flash is defined? for warnings-safety.
 r4488@asus:  jeremy | 2006-04-29 12:23:15 -0700
 Check whether @flash is defined? for warnings-safety. Obviates nil? check.
 r4489@asus:  jeremy | 2006-04-29 12:45:18 -0700
 Check whether @session is defined? for warnings-safety.
 r4490@asus:  jeremy | 2006-04-29 12:50:41 -0700
 Check whether @rendering_runtime is defined? for warnings-safety.
 r4491@asus:  jeremy | 2006-04-29 12:55:01 -0700
 Check whether @_cycles is defined? for warnings-safety.
 r4492@asus:  jeremy | 2006-04-29 12:59:19 -0700
 Check whether instance variables are defined? for warnings-safety.
 r4493@asus:  jeremy | 2006-04-29 13:14:09 -0700
 Add nil @template to PrototypeHelperTest to suppress unitialized instance variable warning.
 r4494@asus:  jeremy | 2006-04-29 13:31:34 -0700
 Check whether @auto_index defined? for warnings-safety.
 r4495@asus:  jeremy | 2006-04-29 13:32:24 -0700
 Wrap content_columns redefinitions with silence_warnings.
 r4496@asus:  jeremy | 2006-04-29 13:35:28 -0700
 Wrap more redefinitions with silence_warnings.
 r4829@asus:  jeremy | 2006-07-08 10:59:20 -0700
 abstract unit, fix warnings
 r4830@asus:  jeremy | 2006-07-08 11:06:12 -0700
 Use parens to silence warning.
 r4831@asus:  jeremy | 2006-07-08 11:06:48 -0700
 Use parens to silence warning.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4595 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-07-08 18:14:49 +00:00
Jeremy Kemper
eede40bcf0 Reset @html_document between requests so assert_tag works. Closes #4810. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4591 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-07-08 04:58:55 +00:00
Jeremy Kemper
e5cbb849f9 Update render :partial documentation. Closes #5646. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4590 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-07-08 01:50:58 +00:00
Jeremy Kemper
c396c5ab31 Integration tests behave well with render_component. Closes #4632. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4582 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-07-08 00:18:42 +00:00
Jeremy Kemper
cf965cda5c Clarify partial filename constraints. Closes #1161. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4581 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-07-07 22:53:46 +00:00
David Heinemeier Hansson
11c715a53f Added exception handling of missing layouts (closes #5373) [chris@ozmm.org] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4550 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-07-05 02:38:55 +00:00
David Heinemeier Hansson
40f50fd7e5 Doc fix (closes #5429) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4547 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-07-05 02:18:34 +00:00
David Heinemeier Hansson
f780bb8f58 Doc fix (closes #5576) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4541 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-07-05 01:16:41 +00:00
David Heinemeier Hansson
28ef328baa Fixed that the flash should be reset when reset_session is called (closes #5584) [shugo@ruby-lang.org] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4540 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-07-05 01:14:53 +00:00
Jeremy Kemper
d0526ede40 r4748@asus: jeremy | 2006-06-29 22:40:35 -0700 
Loosen urlencoded content type check.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4524 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-30 05:41:03 +00:00
David Heinemeier Hansson
bdac94e990 Fixed proper form-encoded parameter parsing for requests with "Content-Type: application/x-www-form-urlencoded; charset=utf-8" (note the presence of a charset directive) [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4522 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-30 05:19:15 +00:00
Nicholas Seckar
e494b0a441 Add route_name_path method to generate only the path for a named routes. For example, map.person will add person_path. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4518 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-30 02:36:17 +00:00
Marcel Molina
c02d1f7d9b Fix CGI extensions when they expect string but get nil in Windows. Closes #5276 [mislav@nippur.irb.hr] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4499 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-28 13:51:25 +00:00
Rick Olson
a28817948d documentation fixes for ActionController::Verification::ClassMethods verify method. Closes #4310. [oleg.frolov@gmail.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4479 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-21 02:19:40 +00:00
Rick Olson
6ba9a1eac1 Fix indent in pagination documentation. Closes #4990. [Kevin Clark] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4476 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-21 02:16:11 +00:00
Jeremy Kemper
bbc1351344 Determine the correct template_root for deeply nested components. Closes #2841. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4474 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-21 00:31:43 +00:00
Rick Olson
2bbcff8cf4 Fix that routes with *path segments in the recall can generate URLs. [Rick] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4454 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-17 00:25:24 +00:00
David Heinemeier Hansson
36dc94a6a1 Added Hash.create_from_xml(string) which will create a hash from a XML string and even typecast if possible [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4453 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-16 10:07:13 +00:00
Jamis Buck
38efc32529 Remove problematic control chars in rescue template. (closes #5316) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4445 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-08 16:18:10 +00:00
Jamis Buck
816d67b104 Make sure passed routing options are not mutated by routing code. (closes #5314) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4444 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-07 16:27:14 +00:00
Jamis Buck
ae7029ddd1 Do some path normalization to prevent the possible_controllers list from containing invalid entries 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4443 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-07 16:16:37 +00:00
Jamis Buck
4e3543b467 Make sure named routes are never generated relative to some containing module 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4442 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-06 19:09:56 +00:00
Jamis Buck
e768dc694d Improve parameter expiry handling to fix sticky-id issue. Add a more informative Route#to_s method. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4441 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-06 17:59:54 +00:00
Jamis Buck
5ced402393 Remove dependency on Pathname in new routes 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4439 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-05 16:01:50 +00:00
Jamis Buck
6c04eb2115 Make sure changing the controller from foo/bar to bing/bang does not change relative to foo. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4438 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-05 15:48:29 +00:00
Jamis Buck
149f5cad85 Escape the entire path before trying to recognize it (closes #3671) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4436 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-05 15:30:09 +00:00
Jamis Buck
2ffc84d23f Make sure :id and friends are properly unescaped (closes #5275). 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4435 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-05 14:51:27 +00:00
Jamis Buck
332fcfaf6b Make sure regexp chunks are grouped when the segment has a regexp constraint so that captures are counted correctly (closes #5267) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4434 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-05 14:31:38 +00:00
Jamis Buck
7d88146e9e Fix documentation for with_routing to reflect new reality (closes #5281) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4433 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-05 14:14:32 +00:00
Jeremy Kemper
8cdf9126d3 Rewind readable CGI params so others may reread them (such as CGI::Session when passing the session id in a multipart form). Closes #210. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4410 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-02 06:30:23 +00:00
David Heinemeier Hansson
6dea52c54e Finish custom handling [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4409 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-02 04:38:28 +00:00
David Heinemeier Hansson
180edf4146 Make new mime types first class [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4408 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-02 04:30:43 +00:00
David Heinemeier Hansson
5e998d1ea0 Make new mime types first class [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4407 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-02 04:29:34 +00:00
David Heinemeier Hansson
5240d7a84b Added Mime::TEXT (text/plain) and Mime::ICS (text/calendar) as new default types [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4406 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-02 04:16:03 +00:00
David Heinemeier Hansson
984aa7eeb9 Added Mime::Type.register(string, symbol, synonyms = []) for adding new custom mime types [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4405 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-02 04:11:56 +00:00
David Heinemeier Hansson
5c30352328 Added support for Mime objects in render :content_type option [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4404 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-02 03:39:56 +00:00
Jeremy Kemper
ace2a66f0c Excise the headache-prone syswrite in send_file. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4403 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-02 03:34:38 +00:00
Jeremy Kemper
ac66cf1289 Add :status option to send_data and send_file. Defaults to '200 OK'. Closes #5243. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4400 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-02 00:51:56 +00:00
David Heinemeier Hansson
9e7e89a561 Dont keep nothing as a lookup [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4399 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-01 23:23:24 +00:00
Jamis Buck
ef5317f74f Tweaks to integration tests and url rewriter for further compatibility with new routes 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4397 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-01 16:20:26 +00:00
Jamis Buck
ba4d4ad4a8 Add RouteSet::Mapper#named_route for compatibility with adding programmatically named routes 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4395 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-01 16:00:15 +00:00
Jamis Buck
b20c575ac0 New routes implementation. Simpler, faster, easier to understand. The published API for config/routes.rb is unchanged, but nearly everything else is different, so expect breakage in plugins and libs that try to fiddle with routes. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4394 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-01 15:42:08 +00:00
Jeremy Kemper
ce99c87551 Cope with missing content type and length headers. Parse parameters from multipart and urlencoded request bodies only. Accept multipart PUT parameters. Closes #5235. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4388 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-01 00:01:48 +00:00
David Heinemeier Hansson
f9cd92f4ee Added interrogation of params[:format] to determine Accept type. If :format is specified and matches a declared extension, like "rss" or "xml", that mime type will be put in front of the accept handler. This means you can link to the same action from different extensions and use that fact to determine output [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4384 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-05-31 18:52:24 +00:00
David Heinemeier Hansson
bf1b06e90a Easy way to set accepting for functional tests 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4382 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-05-31 04:49:18 +00:00
David Heinemeier Hansson
4a98cbe2dd If not passing a hash, assume :id => whatever 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4381 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-05-31 04:48:46 +00:00
Jeremy Kemper
6ce3bf70a2 follow_redirect doesn't complain about being redirected to the same controller. Closes #5153. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4361 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-05-22 22:59:56 +00:00
Jeremy Kemper
0cd883e1e1 Change the request.env example in AC::Base docs to a var that exists (REMOTE_IP doesn't) and isn't already wrapped by a request method (i.e. request.remote_ip). Closes #5113. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4347 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-05-17 19:52:06 +00:00
Marcel Molina
7252666b74 Add layout attribute to response object with the name of the layout that was rendered, or nil if none rendered. [Kevin Clark kevin.clark@gmail.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4346 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-05-17 07:25:36 +00:00
Michael Koziarski
ff96498848 performance enhancement for previous patch [skaes] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4344 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-05-16 21:09:41 +00:00