github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity
18,184 Commits 34 Branches 105 Tags
e4bd7ed2fa60a0dbb03bbdea6fa532c6ea0ee704
Commit Graph

4950 Commits

Author SHA1 Message Date
Piotr Sarnacki
f7af75976a require 'active_support/dependencies' in action_dispatch/middleware/stack 2010-09-03 22:59:03 +02:00
Xavier Noria
93acbf6bf3 Merge remote branch 'docrails/master' 2010-09-03 21:30:22 +02:00
José Valim
599e46bf24 Revert "Setup explicit requires for files with exceptions. Removed them from autoloading." 
Booting a new Rails application does not work after this commit [#5359 state:open]

This reverts commit 38a421b34d.
 2010-09-02 21:11:03 +02:00
José Valim
48bf667a8b Ensure routes are loaded only after the initialization process finishes, ensuring all configuration options were applied. 2010-09-02 12:54:21 +02:00
Łukasz Strzałkowski
38a421b34d Setup explicit requires for files with exceptions. Removed them from autoloading. 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-09-02 11:54:04 +02:00
Łukasz Strzałkowski
c5c839f75f Cleaned up autoload definitions. 
Now it's more transparent, and readable

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-09-02 11:53:58 +02:00
Thiago Pradi
df7f441c6e Removing RJS hack 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-09-02 11:51:07 +02:00
Andrew White
02480a897b Move implicit nested call before options handling so that nested constraints work [#5513 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-09-01 10:09:14 +02:00
Alex Chrome
dbf82557e4 Added :format option for form_for helper and spec for this [#5226 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-09-01 09:59:54 +02:00
yury
9a6e3ae763 Remove unnecessary code from UrlHelper#link_to. 
convert_options_to_data_attributes always returns not nil stringified html_options [#5445 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-09-01 09:57:04 +02:00
Thiago Pradi
46c14a6b03 Use join instead of looping and calling to_s [#5492 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-09-01 09:46:30 +02:00
Akira Matsuda
37e0c153de fix typo(?) 2010-09-01 16:00:55 +09:00
Xavier Noria
8b2e4fddbf Merge remote branch 'docrails/master' 2010-09-01 00:01:26 +02:00
wycats
58d3b90423 Speed up form_for by specializing extract_options! (at asakusa.rb) 2010-08-31 20:33:28 +09:00
wycats
c05f24c824 Speed up content_tag_for by simplifying needed logic 2010-08-31 19:52:26 +09:00
Jaime Iniesta
c2ed4a9f88 Fix API docs for button_to options 2010-08-31 09:19:43 +02:00
Xavier Noria
3805d01c9b resolves merge conflict 2010-08-31 00:24:05 +02:00
José Valim
3c8e1f99b9 Remove NonConcattingString. 2010-08-29 21:15:00 -03:00
José Valim
ba52748d05 Remove deprecated support to <% form_for %> and several ActionController::Base methods. 2010-08-29 21:08:14 -03:00
Joost Baaij
591e87fe7b Expanded routing documentation with current best practices 2010-08-29 00:04:14 +02:00
Joost Baaij
5ead15b075 Rework the routing documentation. 
Move the default route to the bottom, as this practise should be discouraged.
Add documentation for resources, external redirects and Rack applications.
 2010-08-28 23:24:02 +02:00
Jesse Storimer
730af48963 Ensure that inherited helper_methods are available after calling clear_helpers [#5348 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-08-28 18:07:01 -03:00
yury
3e22e0b025 Micro optimization for build_named_route_call in PolymorphicRoutes: 
1. use map instead of inject
2. use [].join("_") instead of '<<'. It is a little bit faster for ruby 1.9.2 and x2 faster for ruby 1.8.7. http://gist.github.com/548143

[#5450 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-08-28 17:54:50 -03:00
Santiago Pastorino
1851af84c1 password_field renders with nil value by default 
This makes the use of passwords secure by default if you want to render
the value of the password_field you have to do for instance
f.password_field(:password, :value => @user.password) # =>
<input type=password id=user_password name=user[password]
value=#{@user.password} />
 2010-08-28 05:23:34 -03:00
Santiago Pastorino
d630c76f3f type="password" for password_fields 2010-08-28 04:53:50 -03:00
Joost Baaij
4b14de72e1 The call-seq directive has no useful effect on our documentation and is not used anywhere else. 
Worse still, its use breaks some rdoc, replacing method names with a curly brace.
Having just one call-seq directive doesn't add anything since this is covered by regular rdoc.
Having multiple might make sense, but these are already documented with examples.

This partly re-reverts 60de0e56b7 but does not
touch the vendorized code in html-scanner.
 2010-08-28 00:50:50 +02:00
Xavier Noria
dda515fc26 Merge remote branch 'docrails/master' 2010-08-28 00:01:55 +02:00
Joost Baaij
279c395723 Use common terminology 2010-08-27 23:50:23 +02:00
Xavier Noria
27d42a56b9 Revert "call-seq directive makes rdoc cry and replaces method names with a curly brace; besides it doesn't add anything when you only list one call example since this is obviously documented already" 
Reason: Part of this commit touches vendorized stuff, the rest is fine, could you please repatch?

This reverts commit 60de0e56b7.
 2010-08-27 23:30:52 +02:00
Joost Baaij
4a56f8f314 escape constants that should not be linked to 2010-08-27 22:47:11 +02:00
Joost Baaij
76c569344b mention the alert and notice accessors on the flash 2010-08-27 22:45:35 +02:00
Joost Baaij
9f4d3a1ebe expand cookie examples with signed and permanent methods 2010-08-27 22:31:02 +02:00
Joost Baaij
60de0e56b7 call-seq directive makes rdoc cry and replaces method names with a curly brace; besides it doesn't add anything when you only list one call example since this is obviously documented already 2010-08-27 22:20:53 +02:00
José Valim
d0e067f61b Add missing require. 2010-08-27 14:56:58 -03:00
Santiago Pastorino
f95ba5c262 Make InstanceTagMethods#value_before_type_cast raise if the model don't respond to attr_before_type_cast or attr method 
[#3374] [#5471 state:committed]
 2010-08-27 09:08:04 -03:00
Carlos Antonio da Silva
0aefbe52a0 Removing some unuseful begin/end and refactor prompt_option_tag a bit 
[#5469 state:committed]

Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2010-08-27 01:18:42 -03:00
José Valim
625f7b5a5b Be sure to call helper :all just on direct children. (Tests by Jesse Storimer) 2010-08-26 18:20:22 -03:00
José Valim
737abf25bb Doh, be sure to store the string modification. 2010-08-26 18:20:14 -03:00
Joost Baaij
6eed7b36a2 escape constant names 2010-08-26 23:10:00 +02:00
Joost Baaij
c28d46a92d Reflect how CSRF protection now works and refer to the Security Guide for more information 2010-08-26 23:03:30 +02:00
Joost Baaij
ca36326706 cleanup of ActionController::Metal inline documentation 2010-08-26 22:32:40 +02:00
Joost Baaij
930102968a Escape 'caching' when used in a sentence; remove unnessesary quotes 2010-08-26 21:58:57 +02:00
Joost Baaij
80ae74dea7 Prevent any warnings from being printed during RDoc generation 2010-08-26 21:31:32 +02:00
José Valim
818858ac1d Do not modify frozen strings in place. 2010-08-26 16:25:53 -03:00
José Valim
66ef92272c Add clear_helpers as a way to clean up all helpers added to this controller, maintaing just the helper with the same name as the controller. 2010-08-26 16:07:54 -03:00
José Valim
84cab320bc Ensure templates like template.html are found but still uses the proper virtual path. 2010-08-26 16:07:54 -03:00
Jaime Iniesta
d9f6e16937 Fix capture_helper.rb api documentation, unescaped script tag was breaking it on the content_for explanation 2010-08-26 14:23:58 +02:00
Xavier Noria
fa8e17b5c2 Merge remote branch 'docrails/master' 2010-08-26 01:39:16 +02:00
Joost Baaij
a68919ec84 Restored top-level documentation for ActionController::Base. 
This information was lost in commit bd6b61be88.
This might have been intentional, but this class does represent the starting
point for all things related to actions, and as such should document it.

I couldn't find any trace of this documentation, which seems like a waste.
Updated parts here and there to conform to current best practices.
 2010-08-25 23:28:56 +02:00
Joost Baaij
e9eaae1a05 fixed capitalization 2010-08-25 19:51:20 +02:00