Commit Graph

2008 Commits

Author SHA1 Message Date
Jeremy Kemper
43c6d7ee95 Deprecation: remove pagination. Install the classic_pagination plugin for forward compatibility, or move to the superior will_paginate plugin. Closes #8157.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6992 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-11 00:51:11 +00:00
Jeremy Kemper
160af194e4 Routing: improve static segment test coverage. #7117 [Kevin Clark]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6979 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-09 04:39:01 +00:00
Jeremy Kemper
a308ff0cdd Test javascript_tag. Closes #7239.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6977 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-08 22:20:18 +00:00
Jeremy Kemper
7de21cc1c5 Fix typo in resources documentation. Closes #8607 [yon]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6971 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-08 18:00:11 +00:00
Jeremy Kemper
c9397e684c Action caching is limited to GET requests returning 200 OK status. Closes #3335.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6970 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-08 05:01:35 +00:00
Jeremy Kemper
b195ed61c8 Improve Text Helper test coverage. Closes #7274.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6968 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-08 04:05:35 +00:00
Jeremy Kemper
34b94de8b8 Improve Action View test coverage. Closes #7241, #7243, #7244.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6967 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-08 04:00:15 +00:00
Jeremy Kemper
bab8966064 Test periodically_call_remote with frequency. Closes #7244 [Rich Collins]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6963 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-08 01:30:47 +00:00
Jeremy Kemper
c7df5bd6ac More nested polymorphic url helper fixes. Closes #6432, references #8601.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6960 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-07 21:35:01 +00:00
Jeremy Kemper
5600776e30 Fix incomplete work from [6951] that was hidden by test stubs. Closes #6432.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6959 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-06 16:52:37 +00:00
Jeremy Kemper
5dd3db8615 Resources: url_for([parent, child]) generates /parents/1/children/2 for the nested resource. Likewise with the other simply helpful methods like form_for and link_to. Closes #6432.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6951 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-05 19:10:59 +00:00
Rick Olson
b83efadb32 Assume html format when rendering partials in RJS. #8076 [Rick]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6950 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-05 16:51:49 +00:00
Jeremy Kemper
7709df5f17 Don't double-escape url_for in views. Closes #8144.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6942 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-05 04:29:19 +00:00
Jeremy Kemper
f80468c3c3 Remove junk form helper test. Closes #8416 [eric_oconnell]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6941 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-05 04:09:39 +00:00
Thomas Fuchs
3cfb894bac Allow JSON-style values for the :with option of observe_field. Closes #8557 [kommen]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6930 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-03 14:27:43 +00:00
Jeremy Kemper
83ce4c59be Remove RAILS_ROOT from backtrace paths. Closes #8540.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6923 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-01 05:18:21 +00:00
Jeremy Kemper
8ce5479307 Routing: map.resource :logo routes to LogosController so the controller may be reused for multiple nestings or namespaces.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6922 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-01 04:40:30 +00:00
Jeremy Kemper
a6a1dc967c render :partial recognizes Active Record associations as Arrays. Closes #8538.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6920 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-01 03:53:39 +00:00
Jeremy Kemper
6435ecc68a Missing helper load error shouldn't shadow load errors within the helper itself.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6914 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-31 19:07:57 +00:00
David Heinemeier Hansson
0cf79f07b0 Fixed that DateHelper#date_select should set the day to the 1st when its a hidden option and the month is visible (or invalid dates can be produced) [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6911 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-31 16:38:36 +00:00
Jeremy Kemper
186ac4cdaa Don't choke on nested helpers.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6899 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-29 22:06:13 +00:00
Rick Olson
32b307bc32 fix test cases to match new json output. Closes #8371
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6894 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-29 09:42:13 +00:00
Jeremy Kemper
8139de2812 Routing: drop semicolon and comma as route separators.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6888 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-29 06:40:33 +00:00
Jeremy Kemper
d3017e225f Correct flash discard rdoc. Closes #8502 [kampers]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6887 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-29 02:42:31 +00:00
Jeremy Kemper
d8b67f7fe1 Generate rdoc with utf-8 charset. Closes #7188 [manfred, jferris]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6881 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-28 22:55:14 +00:00
Jeremy Kemper
e5b3d4b3b5 request.remote_ip understands X-Forwarded-For addresses with nonstandard whitespace. Closes #7386.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6877 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-28 00:10:13 +00:00
Jeremy Kemper
0aed1d629e Don't croak if ruby-debug isn't installed.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6876 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-28 00:00:07 +00:00
Jeremy Kemper
3f336ad5cc Don't prepare response when rendering a component. Closes #8493.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6875 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-27 23:48:28 +00:00
Jeremy Kemper
3c356aa9ff Reduce file stat calls when checking for template changes. Closes #7736.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6871 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-27 19:16:09 +00:00
David Heinemeier Hansson
d3b5db8919 Added custom path cache_page/expire_page parameters in addition to the options hashes [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6868 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-27 16:38:02 +00:00
Rick Olson
cd599aad71 Action Caching speedup. #8231 [skaes]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6867 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-27 07:38:09 +00:00
Michael Koziarski
62455f56b4 Ensure compiled template tests pass on windows where there are no symlinks. [skaes]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6866 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-27 07:21:01 +00:00
Jeremy Kemper
2a253d488e Wordsmith resources documentation. Closes #8484.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6865 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-27 05:00:53 +00:00
Marcel Molina
404a357013 Fix syntax error in code example for routing documentation. #8377. [norbert]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6863 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-26 20:29:05 +00:00
Jeremy Kemper
dcaa074abf Routing: respond with 405 Method Not Allowed status when the route path matches but the HTTP method does not. Closes #6953.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6862 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-26 20:07:34 +00:00
Marcel Molina
42ebf559cc Add support for assert_select_rjs with :show and :hide. #7780 [dchelimsky]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6861 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-26 17:29:23 +00:00
Marcel Molina
dc4d23f2d7 Make assert_select's failure messages clearer about what failed. #7779 [dchelimsky]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6860 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-26 17:25:19 +00:00
Jeremy Kemper
40860e9852 Missed svn add from [6856]. References #8174.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6857 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-26 03:18:57 +00:00
Jeremy Kemper
672941decb Introduce a default respond_to block for custom types. Closes #8174.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6856 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-26 03:11:34 +00:00
Jeremy Kemper
9dac6b759f auto_complete_field takes a :method option so you can GET or POST. Closes #8120.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6851 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-26 00:32:52 +00:00
Jeremy Kemper
06f325f478 Add multipart request parsing test with bracketed parameter key. References #8449.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6831 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-24 23:37:37 +00:00
David Heinemeier Hansson
74d1512b99 Added option to suppress :size when using :maxlength for FormTagHelper#text_field #3112 [rails@tpope.info]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6830 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-24 20:47:03 +00:00
Jeremy Kemper
b290bc6b2f Don't alias local var
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6829 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-24 20:42:03 +00:00
Rick Olson
4b9e67c5b9 catch possible WSOD when trying to render a missing partial. Closes #8454 [Catfish]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6826 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-24 16:42:10 +00:00
Jeremy Kemper
4bd3e3aa1b Set RAW_POST_DATA when request parameters are parsed.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6823 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-23 19:09:37 +00:00
Jeremy Kemper
301b92370a Extend the view instance directly instead of mucking with anonymous subclasses.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6821 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-23 08:00:35 +00:00
Jeremy Kemper
27ff573290 Don't play with fire (anonymous class and returning block).
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6820 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-23 07:44:57 +00:00
Jeremy Kemper
ba7dc5d421 Revert [6811]. Should be fixed instead of selectively reintroducing the deprecated environment variable.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6816 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-23 06:11:48 +00:00
Jeremy Kemper
b0d01921d8 Rewind request body after reading it, if possible. Closes #8438.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6815 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-23 05:43:00 +00:00
Tobias Lütke
d418b7d391 Set RAW_POST_DATA in integration tests as expected
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6811 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-22 22:26:00 +00:00