Andy Jeffries
71d769e3b5
Named Routes shouldn't override existing ones (currently route recognition goes with the earliest match, named routes use the latest match)
2011-12-05 15:41:38 +00:00
José Valim
2ab2077235
Fix failing cascade exception.
2011-12-03 11:38:25 +01:00
José Valim
76a3ec7f6e
Try to play nice with plugins doing monkey patches.
2011-12-02 09:57:43 +01:00
José Valim
f9edc079e0
Split and improve show and debug exceptions middlewares.
2011-12-01 21:15:42 +01:00
José Valim
750bb5c865
Split ShowExceptions responsibilities in two middlewares.
2011-12-01 20:46:18 +01:00
José Valim
956ecff833
Add a deprecation to old show exceptions API (even though it was not public).
2011-12-01 20:16:12 +01:00
José Valim
0b677b18ff
Add an ExceptionWrapper that wraps an exception and provide convenience helpers.
2011-12-01 20:02:00 +01:00
José Valim
b4359bc723
Allow rescue responses to be configured through a railtie.
2011-12-01 19:21:35 +01:00
Vijay Dev
88daf08258
Merge branch 'master' of github.com:lifo/docrails
2011-11-30 23:32:01 +05:30
Aviv Ben-Yosef
e3bc1385f1
Fixing incorrect documentation
...
`path_names` can only be used for affecting `new` and `edit`
2011-11-30 06:55:34 +02:00
Travis Pew
237272e049
Fix ActionDispatch::Request method explanations
...
The methods, "post?", "put?", "head?", etc. contain an incorrect
explanation. They state that they are equivalent to request_method ==
:type, but this is not accurate because the methods convert the string
to a symbol. They are actually equivalent to:
request_method_symbol == :type
2011-11-28 15:46:09 -05:00
lest
fe7d4f09ef
put backtrace_cleaner to env
2011-11-28 19:25:37 +03:00
Vijay Dev
1d89540686
Merge branch 'master' of github.com:lifo/docrails
2011-11-26 19:14:39 +05:30
Uģis Ozols
a607a9d978
what's -> that's
2011-11-25 14:24:14 +02:00
Uģis Ozols
9a45867b09
Remove unnecessary comment.
2011-11-25 14:22:36 +02:00
lest
cd9d28d6fd
middlewares should use logger from env
2011-11-25 13:09:46 +03:00
lest
98a1717e7c
configuration option to always write cookie
2011-11-23 23:50:04 +03:00
kennyj
ea70e027b6
Remove unreachable code, and add additional testcases.
2011-11-24 00:25:34 +09:00
lest
3a1d51959b
deprecation warning, changelog entry
2011-11-22 17:36:58 +03:00
lest
a9e8cf78fd
add ActionController::Metal#show_detailed_exceptions?
2011-11-22 11:38:24 +03:00
Aaron Patterson
3d2bd69385
Revert "copy options keys to the right place so that undo will work correctly"
...
This reverts commit 3178cc9a80
2011-11-19 20:35:54 -08:00
Arun Agrawal
d806ea2050
Warning removed for shadowing variable
2011-11-19 11:29:29 +05:30
Aaron Patterson
396ef44be4
Revert "make sure to require the right deprecation warning file"
...
This reverts commit 9d725e3df502a07222f35576108eb2df2bd88259.
2011-11-18 10:51:12 -08:00
Aaron Patterson
99d94f126d
Refactoring the redirect method for the router api.
2011-11-18 10:51:12 -08:00
Aaron Patterson
d34efdd260
moving redirection to objects
2011-11-18 10:51:12 -08:00
Aaron Patterson
0809c675ef
remove the :path feature to redirects, since it cannot work
2011-11-18 10:51:11 -08:00
Aaron Patterson
a8a4264858
make sure to require the right deprecation warning file
2011-11-18 10:51:11 -08:00
Aaron Patterson
163b645472
arity check has been pushed up, so no need for proc wrapping
2011-11-18 10:51:11 -08:00
Aaron Patterson
4589b2419b
require that all blocks have arity of 2
2011-11-18 10:51:11 -08:00
Aaron Patterson
3178cc9a80
copy options keys to the right place so that undo will work correctly
2011-11-18 10:51:11 -08:00
Aaron Patterson
ecbae99478
no need for type checking
2011-11-18 10:51:11 -08:00
Aaron Patterson
636405d2a6
cleaning up variable names to match method parameter names
2011-11-18 10:51:10 -08:00
Aaron Patterson
33543ac871
stop doing is_a? checks on the resource type
2011-11-18 10:51:10 -08:00
Aaron Patterson
648f6113d1
move constants to methods since nothing else is using them
2011-11-18 10:51:10 -08:00
Aaron Patterson
7459ba4f6c
pushing hash validation up
2011-11-18 10:51:10 -08:00
Aaron Patterson
494ab25772
breaking match down to smaller methods
2011-11-18 10:51:10 -08:00
Aaron Patterson
76780c34f5
some refactoring of the match method
2011-11-18 10:51:09 -08:00
Arun Agrawal
c3ae1d2aec
It should be @calculated_ip not @calculate_ip
...
We are using @calculated_ip.
@calculate_ip is no where used
2011-11-17 12:50:19 +05:30
Aaron Patterson
e367142255
Initialize our instance variables.
2011-11-16 16:55:11 -08:00
Aaron Patterson
70f9b74a49
Merge pull request #3649 from indirect/remote_ip
...
Fixes for Request#remote_ip (no middleware, all proxies)
2011-11-16 16:44:09 -08:00
Jon Leighton
272f2b778f
Merge pull request #3500 from olivierlacan/error-whitespace
...
CSS fix to prevent error output from being breaking out of body element.
2011-11-16 15:26:31 -08:00
Andre Arko
a9044d0117
the object itself isn't the IP, #to_s is the IP
2011-11-16 13:13:22 -10:00
Andre Arko
5621abd569
🤦 Request#remote_ip has to work without the middleware
2011-11-16 12:54:18 -10:00
Andre Arko
f05ccf805a
Revert "Revert "Merge pull request #3640 from indirect/remote_ip""
...
This reverts commit 8d1a2b3ecd
2011-11-16 12:53:43 -10:00
Jon Leighton
8d1a2b3ecd
Revert "Merge pull request #3640 from indirect/remote_ip"
...
This reverts commit 6491aadc5283bf0b626chttps://github.com/rails/rails/pull/3640#issuecomment-2752761 for
explanation.
2011-11-15 22:47:18 +00:00
Andre Arko
d743954792
GetIp#to_s should never return nil. That's icky.
2011-11-14 16:43:21 -10:00
Andre Arko
4f2bf6491c
Return the calculated remote_ip or ip
...
This was an especially nasty bug introduced in 317f4e2
2011-11-14 11:23:33 -10:00
Andre Arko
cda1a5d5fe
memoize the relatively expensive remote IP code
2011-11-14 11:20:57 -10:00
Andre Arko
00a0a4ddeb
cleaner names
2011-11-14 11:20:20 -10:00
Andre Arko
9c4532bf74
remove ignored flag, fixes warnings
2011-11-13 10:22:12 -10:00
