github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity
25,547 Commits 34 Branches 105 Tags
e5d0bb22ef6284430fecb608836c8d2b77b56c8d
Commit Graph

6491 Commits

Author SHA1 Message Date
Vijay Dev
e9413b5de3 Merge pull request #3274 from arunagw/warning_removed_mysql2 
ambiguous first argument; put parentheses or even spaces Warning removed!
 2011-10-10 04:39:18 -07:00
Josef Šimánek
ceb65a639c Active Record changelog mistakes 2011-10-10 12:19:31 +03:00
Arun Agrawal
af7eeaafdb ambiguous first argument; put parentheses or even spaces Warning removed! 2011-10-10 14:16:45 +05:30
Jon Leighton
3456ef1119 Use broken YAML that will fail with Syck as well as Psych. Fixes test_broken_yaml_exception in fixtures_test.rb on Ruby 1.8.7. 
Cherry-pick from 3-1-stable: b8d46924e7
 2011-10-09 16:47:53 -07:00
Jeremy Kemper
8dba127188 Remove stray whitespace 2011-10-09 14:21:12 -07:00
Joseph Palermo
c90e5ce779 Only use LOWER for mysql case insensitive uniqueness check when column has a case sensitive collation. 2011-10-09 13:14:07 -07:00
Jeremy Kemper
bedd6dcd43 Merge pull request #500 from cyril/patch-1 
Use quotes for command substitution
 2011-10-08 20:29:56 -07:00
Arun Agrawal
34d950b066 Fixed BodyProxy.new for tests! for wrong argument 2011-10-08 10:01:58 +05:30
Mark J. Titorenko
f41b58d3b2 use thread locals and an instance variable within QueryCache#BodyProxy to maintain appropriate linkage with AR database connection across threads 2011-10-07 10:05:51 +01:00
Aaron Patterson
3088d23647 Merge pull request #3232 from Juanmcuello/pg_prepared_statements 
Use the schema_search_path in prepared statements.
 2011-10-06 20:08:05 -07:00
Vijay Dev
33799c8fc3 Merge pull request #3203 from jrmehle/fix_clone_structure 
db:test:clone_structure if path to .sql file contains spaces or dashes
 2011-10-06 02:13:36 -07:00
Jeremy Kemper
999b7ed94d Transactional fixtures enlist all active database connections. 
You can use multiple databases in your tests without disabling transactional fixtures.
 2011-10-05 19:10:18 -07:00
Jon Leighton
2e9e647fee Raise an exception on unknown primary key inside AssociationReflection. 
An association between two models cannot be made if a relevant key is
unknown, so fail fast rather than generating invalid SQL. Fixes #3207.
 2011-10-05 20:21:21 +01:00
Jon Leighton
64747654ca Revert "Raise error on unknown primary key." 
This reverts commit ee2be435b1.
 2011-10-05 20:21:21 +01:00
Juan M. Cuello
ac659b8ed3 refs #3232. Prepared statements and postgreSQL schemas. 
Add tests for prepared statements with multiple schemas in
postgreSQL.
 2011-10-05 14:44:50 -03:00
Juan M. Cuello
cfc95d89ae Use the schema_search_path in prepared statements. 
To allow the use of prepared statements when changing schemas in
postgres, the schema search path is added to the sql key.
 2011-10-05 11:43:03 -03:00
Jon Leighton
ee2be435b1 Raise error on unknown primary key. 
If we don't have a primary key when we ask for it, it's better to fail
fast. Fixes GH #2307.
 2011-10-05 01:11:40 +01:00
Ben Woosley
88f60fd1a7 Changing rake db:schema:dump to run :environment as well as :load_config, as running :load_config alone will lead to the dumper being run without including extensions such as those included in foreigner and spatial_adapter. 
This reverses a change made here: 5df72a238e (L0L324)

I'm assuming here that :load_config needs to be invoked separately from :environment, as it is elsewhere in the file for db operations, if not the alternative is to go back to "task :dump => :environment do".

Signed-off-by: José Valim <jose.valim@gmail.com>
 2011-10-04 11:25:20 +02:00
Jared Mehle
80e0cd3290 Quoted path to <Rails.env>_structure.sql file in db:test:clone_structure task. 
Leaving the path unquoted causes errors in paths containing spaces or dashes.
 2011-10-03 14:50:40 -05:00
Yasuo Honda
b564ffcad4 To support ActiveRecord unit tests for IBM DB2 2011-10-02 22:51:01 -04:00
Santiago Pastorino
d2888de598 Add CHANGELOG entries 2011-09-29 16:49:31 -03:00
Jon Leighton
adb8ac153f Don't call self.class unless necessary. Closes #3171. 2011-09-29 18:00:30 +01:00
Rocky Jaiswal
aefc40324d Fixed failed test under 1.8.7 as map.keys order in indeterminable 2011-09-28 11:57:34 +05:30
Vijay Dev
33b55cfbdb Merge branch 'master' of github.com:lifo/docrails 2011-09-28 00:04:45 +05:30
Diego Plentz
aafd4c0452 fixing docs for delete_sql where quotes should be used in this example. 2011-09-26 20:06:17 -03:00
Jon Leighton
b3407c86cf Don't require a DB connection when setting primary key. 
Closes #2807.
 2011-09-26 18:15:09 +01:00
Jon Leighton
89e98e278a Merge pull request #3030 from htanata/fix_habtm_select_query_method 
Fix: habtm doesn't respect select query method
 2011-09-26 16:52:23 +01:00
Jon Leighton
3b87c38d02 Fix belongs_to polymorphic with custom primary key on target. 
Closes #3104.
 2011-09-26 15:42:34 +01:00
Jon Leighton
b838059817 CollectionProxy#replace should change the DB records rather than just mutating the array. Fixes #3020. 2011-09-26 10:41:58 +01:00
Vijay Dev
caa95ab6d8 Merge branch 'master' of github.com:lifo/docrails 2011-09-21 19:35:09 +05:30
Vijay Dev
ed1ada84ac copy edits 908f2616 2011-09-20 19:46:59 +05:30
Arun Agrawal
d589d9f160 fix test error when running with postgresql. 
This Sqlite3 should be in if block.
Was giving error because sqlite3 is not loaded
 2011-09-18 23:20:09 +05:30
José Valim
51bef9d8fb to_xml should also rely on serializable hash. 2011-09-18 09:09:01 -07:00
Ryan Bigg
908f2616d5 Document ActiveRecord::QueryMethods#select 2011-09-17 16:08:58 -07:00
Arun Agrawal
afa78fe327 Fixed test for JRuby. 
for Sqlite3 in AR-JDBC.It's Jdbc::SQLite3::VERSION
 2011-09-18 00:23:48 +05:30
Vijay Dev
49476eee78 Merge branch 'master' of github.com:lifo/docrails 2011-09-15 00:32:52 +05:30
Vijay Dev
dcd70773fc minor edit 2011-09-14 23:15:18 +05:30
Vijay Dev
823e16f57c update 3.1 release date in changelogs 2011-09-14 22:46:12 +05:30
Ryan Bigg
681c4dbb02 Add documentation for the extending method in ActiveRecord:QueryMethods 2011-09-14 09:43:31 +10:00
Jon Leighton
3b8a7cf2a7 Stop trying to be clever about when to define attribute methods. 
There is no meaningful performance penalty in defining attribute
methods, since it only happens once.

There is also no reason *not* to define them, since they get thrown in
an included module, so they will not 'overwrite' anything. In fact, this
is desirable, since it allows us to call super.
 2011-09-14 00:00:37 +01:00
Jon Leighton
55da28dd2f We don't need to build a set for DangerousAttributeError. 
We can just use method_defined? and private_method_defined?
 2011-09-14 00:00:37 +01:00
Erik Behrends
3777d4217b [:class_name] option in belongs_to should mention belongs_to and not has_one 2011-09-13 22:42:39 +03:00
Jon Leighton
11870117c6 Rename first_or_new to first_or_initialize. 
For consistency with find_or_initialize_by. Also remove first_or_build
alias.
 2011-09-13 19:09:01 +01:00
Jon Leighton
1a421ceccb Deprecate using method_missing for attributes that are columns. 
This shouldn't ever happen unless people are doing something
particularly weird, but adding a deprecation in case there are bugs not
caught by our tests.
 2011-09-13 00:03:09 +01:00
Jon Leighton
ac687ed651 Let Ruby deal with method visibility. 
Check respond_to_without_attributes? in method_missing. If there is any
method that responds (even private), let super handle it and raise
NoMethodError if necessary.
 2011-09-13 00:01:58 +01:00
Jon Leighton
cf115d2f8e Reset column info when messing with columns. 
We are subclassing Session here, but messing with the columns will
affect the attribute methods defined on the Session superclass, and
therefore other tests, unless we properly isolate it by resetting column
info before and after the test run.
 2011-09-13 00:01:58 +01:00
Jon Leighton
eecfa84a90 Always generate attribute methods on the base class. 
This fixes a situation I encountered where a subclass would cache the
name of a generated attribute method in @_defined_class_methods. Then,
when the superclass has it's attribute methods undefined, the subclass
would always have to dispatch through method_missing, because the
presence of the attribute in @_defined_class_methods would mean that it
is never generated again, even if undefine_attribute_methods is called
on the subclass.

There various other confusing edge cases like this. STI classes share
columns, so let's just keep all the attribute method generation state
isolated to the base class.
 2011-09-13 00:01:58 +01:00
Jon Leighton
50d395f96e Raise error when using write_attribute with a non-existent attribute. 
Previously we would just silently write the attribute. This can lead to
subtle bugs (for example, see the change in AutosaveAssociation where a
through association would wrongly gain an attribute.

Also, ensuring that we never gain any new attributes after
initialization will allow me to reduce our dependence on method_missing.
 2011-09-13 00:01:58 +01:00
Jon Leighton
8667d3aeb6 Make protected method public so we avoid method_missing. 2011-09-13 00:01:58 +01:00
Jon Leighton
3386a089ef Fix warnings. 
Make sure we don't redefine an already-defined attribute method.
 2011-09-13 00:01:57 +01:00