github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-01-30 08:48:06 -05:00
Code Issues Packages Projects Releases Wiki Activity
3,596 Commits 34 Branches 105 Tags
e5fc5aaffe0d97b73678d7edfcaca222f01aba69
Commit Graph

962 Commits

Author SHA1 Message Date
Nicholas Seckar
e5fc5aaffe Change AR::Base#to_param to return a String instead of a Fixnum. Closes #5320. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4459 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-19 16:45:34 +00:00
Jamis Buck
f97978ad91 Use explicit delegation instead of method aliasing for AR::Base.to_param -> AR::Base.id. (closes #5299) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4437 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-05 15:41:24 +00:00
David Heinemeier Hansson
2e65e8ccc6 Refactored ActiveRecord::Base.to_xml to become a delegate for XmlSerializer, which restores sanity to the mega method. This refactoring also reinstates the opinions that type="string" is redundant and ugly and nil-differentiation is not a concern of serialization [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4431 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-04 00:33:52 +00:00
David Heinemeier Hansson
c5ec16e583 Added simple hash conditions to find that'll just convert hash to an AND-based condition string (closes #5143) [hcatlin@gmail.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4425 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-03 22:15:06 +00:00
David Heinemeier Hansson
cb62f06dcf Fixed issues with BLOB limits, charsets, and booleans for Firebird (closes #5194, #5191, #5189) [kennethkunz@gmail.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4424 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-03 21:57:03 +00:00
David Heinemeier Hansson
d016d9a6d4 Fixed usage of :limit and with_scope when the association in scope is a 1:m (closes #5208) [alex@purefiction.net] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4422 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-03 21:51:57 +00:00
David Heinemeier Hansson
2fbcae1912 Added disconnect! to Firebird adapter (closes #5210) [kennethkunz@gmail.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4421 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-03 21:48:30 +00:00
David Heinemeier Hansson
7f00f51239 Fixed migration trouble with SQLite when NOT NULL is used in the new definition (closes #5215) [greg@lapcominc.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4419 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-03 21:41:40 +00:00
David Heinemeier Hansson
3e67e0b3b2 Fixed problems with eager loading and counting on SQL Server (closed #5212) [kajism@yahoo.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4418 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-03 21:27:16 +00:00
David Heinemeier Hansson
4394e402b7 Fixed that count distinct should use the selected column even when using :include (closes #5251) [anna@wota.jp] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4417 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-03 21:19:36 +00:00
David Heinemeier Hansson
1671609063 Fixed that has_many.create ended up with duplicate objects (closes #5250) [daniel@nouvelles-solutions.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4416 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-03 21:16:50 +00:00
David Heinemeier Hansson
01a52dd1ad Fixed that :includes merged from with_scope won't cause the same association to be loaded more than once if repetition occurs in the clauses (closes #5253) [alex@purefiction.net] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4415 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-03 21:11:48 +00:00
Jeremy Kemper
48052d70ec to_xml fixes, features, and speedup. Closes #4989. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4413 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-03 00:01:08 +00:00
Jeremy Kemper
6aaa08d85b PostgreSQL: don't ignore port when host is nil since it's often used to label the domain socket. Closes #5247. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4401 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-02 01:25:11 +00:00
Rick Olson
c9eb5a083f delegate AssociationProxy#to_param to the association target so that associated models can be used in routes. [Rick] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4398 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-01 22:01:40 +00:00
Jeremy Kemper
74b7bfa6d2 Mind the order of things. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4393 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-01 02:04:35 +00:00
Jeremy Kemper
97f4a5aa14 Quell warnings. Closes #5245. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4392 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-01 02:02:42 +00:00
Jeremy Kemper
b09d02c9e8 Records and arrays of records are bound as quoted ids. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4391 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-01 01:43:20 +00:00
David Heinemeier Hansson
9fcc0654c3 Fixed that Base.find :all, :conditions => [ "id IN (?)", collection ] would fail if collection was empty [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4390 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-01 00:43:02 +00:00
Rick Olson
06075a9eb5 Fix the has_and_belongs_to_many #create doesn't populate the join for new records. Closes #3692 [josh@hasmanythrough.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4379 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-05-29 03:48:17 +00:00
Rick Olson
ea51d72edb Provide Association Extensions access to the instance that the association is being accessed from. Closes #4433 [josh@hasmanythrough.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4372 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-05-28 21:33:34 +00:00
Marcel Molina
c9ef5ac7c7 Update OpenBase adaterp's maintainer's email address. Closes #5176. [Derrick Spell] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4366 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-05-24 17:20:51 +00:00
Rick Olson
0b41d088dc Add a quick note about :select and eagerly included associations. [Rick] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4363 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-05-23 14:16:52 +00:00
Rick Olson
213992195d Add docs for the :as option in has_one associations. Closes #5144 [cdcarter@gmail.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4358 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-05-22 08:00:05 +00:00
David Heinemeier Hansson
b5a6ba6833 Minor style tweaks 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4355 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-05-21 19:20:14 +00:00
David Heinemeier Hansson
66586bc168 Fixed that has_many collections shouldn't load the entire association to do build or create [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4354 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-05-21 19:17:37 +00:00
David Heinemeier Hansson
59c8c63ecd Added :allow_nil option for aggregations (closes #5091) [ian.w.white@gmail.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4353 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-05-21 17:32:37 +00:00
Marcel Molina
d22f9c9488 Fix Oracle boolean support and tests. Closes #5139. [schoenm@earthlink.net] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4351 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-05-21 15:13:28 +00:00
Jeremy Kemper
c50113bc61 create! no longer blows up when no attributes are passed and a :create scope is in effect (e.g. foo.bars.create! failed whereas foo.bars.create!({}) didn't.) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4348 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-05-19 01:05:20 +00:00
Rick Olson
be3a4849a9 Call Inflector#demodulize on the class name when eagerly including an STI model. Closes #5077 [info@loobmedia.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4342 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-05-15 14:08:51 +00:00
Marcel Molina
9c5591da2d Preserve MySQL boolean column defaults when changing a column in a migration. Closes #5015. [pdcawley@bofh.org.uk] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4340 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-05-14 18:37:22 +00:00
Jeremy Kemper
491b4a3c84 PostgreSQL: migrations support :limit with :integer columns by mapping limit < 4 to smallint, > 4 to bigint, and anything else to integer. Closes #2900. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4335 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-05-12 03:59:43 +00:00
Jeremy Kemper
d08d89c092 Dates and times interpret empty strings as nil rather than 2000-01-01. Closes #4830. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4327 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-05-07 07:52:08 +00:00
Jeremy Kemper
d59f3a78a4 uniq preserves order. References [4325]. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4326 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-05-07 02:03:25 +00:00
Jeremy Kemper
50f538b72b Allow :uniq => true with has_many :through associations. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4325 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-05-06 23:37:56 +00:00
Rick Olson
325cb1269c Namespaced OrderedHash so the Rails implementation does not clash with any others. (fixes #4911) [Julian Tarkhanov] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4318 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-04-30 20:36:37 +00:00
Marcel Molina
68ab908716 Ensure that StringIO is always available for the Schema dumper. [Marcel Molina Jr.] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4315 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-04-30 02:40:06 +00:00
Marcel Molina
3fec943aca Allow AR::Base#to_xml to include methods too. Closes #4921. [johan@textdrive.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4314 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-04-29 23:00:47 +00:00
Marcel Molina
aa72c465ec Replace superfluous name_to_class_name variant with camelize. [Marcel Molina Jr.] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4313 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-04-29 20:34:31 +00:00
Marcel Molina
9f92dd3984 Replace alias method chaining with Module#alias_method_chain. [Marcel Molina Jr.] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4312 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-04-29 20:20:22 +00:00
Marcel Molina
6186490962 Replace Ruby's deprecated append_features in favor of included. [Marcel Molina Jr.] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4310 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-04-29 18:10:14 +00:00
Marcel Molina
f26e9b6861 Update FrontBase adapter to check binding version. Closes #4920. [mlaster@metavillage.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4304 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-04-28 20:04:47 +00:00
Marcel Molina
bb875172e2 New Frontbase connections don't start in auto-commit mode. Closes #4922. [mlaster@metavillage.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4302 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-04-28 19:43:41 +00:00
Marcel Molina
0dc53a8f6f When grouping, use the appropriate option key. [Marcel Molina Jr.] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4297 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-04-28 01:12:18 +00:00
Marcel Molina
2ec1527c47 Only modify the sequence name in the FrontBase adapter if the FrontBase adapter is actually being used. [Marcel Molina Jr.] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4296 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-04-28 00:56:15 +00:00
Marcel Molina
1eade4137a Don't require the frontbase adapter until you need to 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4293 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-04-27 22:54:34 +00:00
Marcel Molina
b2c0ddf033 Add support for FrontBase (http://www.frontbase.com/) with a new adapter thanks to the hard work of one Mike Laster. Closes #4093. [mlaster@metavillage.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4291 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-04-27 22:39:45 +00:00
Marcel Molina
3ba7c53b5a Add warning about the proper way to validate the presence of a foreign key. Closes #4147. [Francois Beausoleil <francois.beausoleil@gmail.com>] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4285 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-04-26 22:06:28 +00:00
Marcel Molina
24e3759f86 Fix column type check error in changeset [4280]. [Michael A. Schoen] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4284 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-04-26 21:53:43 +00:00
Marcel Molina
ca2eb16bf9 Fix syntax error in documentation. Closes #4679. [mislav@nippur.irb.hr] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4281 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-04-26 21:29:10 +00:00