José Valim
7d4606156b
Merge pull request #1763 from grantneufeld/schema_column_exists_options_hash
...
Fix default options argument on ActiveRecord::ConnectionAdaptors::Table#column_exists?
2011-06-18 19:34:39 -07:00
Steve Hodgkiss
50444204cc
Fix inconsistencies by being polite to the wrapped body. Needed for Rack::Sendfile to function properly. See issue #1761 .
2011-06-18 22:30:01 +01:00
Grant Neufeld
3cc83a8f24
Changed the default value for the options argument on ActiveRecord::ConnectionAdapters::Table#column_exists? from nil to an empty Hash {}.
...
That method calls through to ActiveRecord::ConnectionAdapters::SchemaStatements##column_exists? expects options to be a Hash.
When options was nil, an error would occur in cases where the column did exist because the called method attempted to perform a key lookup on options.
2011-06-18 14:38:38 -06:00
Xavier Noria
146ec2d1df
Merge branch 'master' of git://github.com/lifo/docrails
2011-06-18 10:11:47 +02:00
Lucia Escanellas
144a388dec
Update remove_index documentation
...
* Changes should better reflect present code behavior
* Related to issue: https://github.com/rails/rails/issues/1624
2011-06-17 16:30:40 -03:00
Guillermo Iguaran
301cad4476
Bump to mysql2 0.3.6
2011-06-17 11:27:37 -05:00
Jon Leighton
e510c2c642
Add require 'pathname' as it has not already been required in some circumstances
2011-06-17 14:55:34 +01:00
Aaron Patterson
ba1b88fda6
Merge pull request #1636 from metaskills/upstream/3-1-stable
...
Allow the connection pool's #table_exists? method to give the connections
2011-06-17 00:02:45 -07:00
Jon Leighton
be99ae78c9
Perf fix - Use an instance variable instead of a class_attribute. Thanks @josevalim and @jhawthorn for the prompting.
2011-06-16 21:13:56 +01:00
Arun Agrawal
536e1566b6
Bump mysql2 to 0.3.5
2011-06-16 10:45:58 +05:30
Santiago Pastorino and José Ignacio Costa
e445a79562
Bump mysql2 up
2011-06-16 01:05:45 -03:00
Andrew White
5d655aabcb
Pass mass-assignment options to nested models - closes #1673 .
2011-06-13 13:02:51 +01:00
Andrew White
987afa583e
Rename tests to reflect associations
2011-06-13 10:01:38 +01:00
Jon Leighton
86bbba1ffb
Add support for using an ARCONFIG environment variable to specify the location of the config.yml file for running the tests
2011-06-12 19:08:16 +01:00
Jon Leighton
15e289147e
Oops, this should have been in the last commit ⚡
2011-06-12 19:05:29 +01:00
Jon Leighton
c52520166b
Make assert_no_queries literally enforce that there are no queries. As in, not a single line of SQL should be sent to the database, not even stuff that is ignored by assert_queries. The argument being that if you write assert_no_queries, you really do not want there to be any queries.
2011-06-12 18:50:24 +01:00
Jon Leighton
232c66a1ba
If we're going to use a global variable, let's at least namespace it
2011-06-12 18:38:39 +01:00
Jon Leighton
b09bbdb8bf
Replace inline lambdas with named methods
2011-06-12 18:19:22 +01:00
Jon Leighton
14e6bbb149
Refactor tests to be less brittle
2011-06-12 18:19:21 +01:00
Jon Leighton
de01a64102
Move BEGIN and COMMIT into IGNORED_SQL rather than having them as a special case in assert_queries
2011-06-12 18:19:21 +01:00
benedikt
fa8dfad765
Don't wrap operations on collection associations in transactions when they are not needed, so the connection adapter does not send empty BEGIN COMMIT transactions blocks to the database.
2011-06-12 18:19:21 +01:00
Guillermo Iguaran
657ba2a9f0
Remove trailing whitespaces
2011-06-12 10:31:21 -05:00
Ken Collins
c791e2d034
Allow the connection pool's #table_exists? method to give the connections #table_exists? method a chance.
2011-06-10 13:15:58 -04:00
Brian Quinn
9f2e91414f
Ensure engine migrations are copied in the same sequence that they are required.
2011-06-10 12:11:45 +01:00
Damien Mathieu
84f71e42b7
don't reinitialize the arel_table unless the table_name changes
2011-06-09 14:56:07 -07:00
Jon Leighton
4b371b602b
Print out information about whether the identity map is on or off when running unit tests
2011-06-09 20:20:51 +01:00
Jon Leighton
e48829946d
Update the RUNNING_UNIT_TESTS file
2011-06-09 20:20:51 +01:00
José Valim
af3f0b6204
Merge pull request #1591 from smartinez87/unused
...
Fix "warning: assigned but unused variable" on AR tests
2011-06-08 23:36:49 -07:00
Sebastian Martinez
9af4e803ec
Remove unused 'y' variable.
2011-06-08 23:13:59 -03:00
Sebastian Martinez
0b86ac244c
Remove unused 'quoted_column_names' variable.
2011-06-08 23:13:43 -03:00
Rodrigo Navarro
8166e4b0c3
No need to create a new Arel::Table, as the arel_table method already creates a new one
2011-06-08 16:56:01 -03:00
Raimonds Simanovskis
e58ee1dccc
Do not hardcode :id as it was ignored by mass assignment filter
...
As a result test was failing on Oracle where ids are assigned by default from 1000
2011-06-08 11:56:23 +03:00
Santiago Pastorino
1d3618a9b4
remove warning: assigned but unused variable
2011-06-08 00:26:09 -03:00
Jon Leighton
7d1782a2c1
Allow polymorphic has_one to work when the association is set before the owner has been saved. Fixes #1524 .
2011-06-08 00:32:49 +01:00
Jon Leighton
4f5f6a3257
When you add a record to a polymorphic has_one, you should be able to access the owner from the associated record
2011-06-08 00:32:49 +01:00
Alexandr Zykov
4c3ec9889a
fix typo
2011-06-08 03:31:33 +06:00
Dmitriy Kiriyenko
8aabefb0b7
This way asserting that updated_at was changed in touch look more obvious.
2011-06-07 18:42:40 +01:00
Dmitriy Kiriyenko
7c1f73c843
Do not use default_scope in ActiveRecord::Persistence#touch.
2011-06-07 18:42:40 +01:00
Jon Leighton
ad9586bf38
Fix a couple of helper requires that were missed. This was causing the tests to fail to run on 1.8.7.
2011-06-07 08:35:55 +01:00
José Valim
e32e8ed966
Merge pull request #1474 from ganeshkumar/update_column_changes
...
added tests for update_column
2011-06-07 00:14:42 -07:00
Aaron Patterson
80451a1fa6
make sure AR isolated tests set the environment variable
2011-06-06 18:01:45 -07:00
Aaron Patterson
cd27cd5e49
oops! add parens so the block is properly bound
2011-06-06 17:00:08 -07:00
Aaron Patterson
8392f10b58
set the environment variable from the rake file
2011-06-06 16:51:45 -07:00
Aaron Patterson
424cf3b050
more oracle fixes
2011-06-06 15:47:29 -07:00
Aaron Patterson
517ca8771c
do not muck with the load path, that is the test task responsibility
2011-06-06 15:47:26 -07:00
Aaron Patterson
841d29639b
updating configs for oracle
2011-06-06 15:47:22 -07:00
Aaron Patterson
c8d124c0fc
add test to the include path
2011-06-06 15:47:17 -07:00
Aaron Patterson
61774e0d49
please use ruby -I lib:test path/to/test.rb, or export RUBY_OPT
2011-06-06 15:47:13 -07:00
Jon Leighton
499dec0102
Make sure that the build/drop database rake tasks take account of the test/config.yml config
2011-06-06 21:27:28 +01:00
Xavier Noria
5e21247131
Merge branch 'master' of git://github.com/lifo/docrails
...
Conflicts:
activerecord/RUNNING_UNIT_TESTS
2011-06-06 22:23:30 +02:00
