github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity
17,537 Commits 34 Branches 105 Tags
e87e3db200e5b711237da8bcdc873044a984ad90
Commit Graph

4136 Commits

Author SHA1 Message Date
Neeraj Singh
a44652baed No need to check for :uniq 
[#5170 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-26 17:41:04 +02:00
Thiago Pradi
f70c0b348d Removing unnecessary code [#5192 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-26 17:13:52 +02:00
Santiago Pastorino
963c71edfa Don't interpolate a blank string, avoid warnings 2010-07-26 06:42:44 +08:00
Xavier Noria
6aa1253588 Merge remote branch 'docrails/master' 2010-07-26 00:23:57 +02:00
Aaron Patterson
df95948d45 do not execute the session tests within transactions 2010-07-25 15:17:03 -07:00
Xavier Noria
dcb7832ed5 APIs for individual components are no longer published 2010-07-26 00:05:14 +02:00
Santiago Pastorino
b0b9bf3204 Object#returning removed 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-25 23:30:27 +02:00
José Valim
f4200b0cd5 Cache instrumenter again as per Aaron's patch. 2010-07-25 23:00:15 +02:00
José Valim
331df84cc9 Cache connection access. 2010-07-25 21:01:49 +02:00
José Valim
304c49b146 Move runtime back to connection. 2010-07-25 20:59:37 +02:00
José Valim
ff0d842454 Revert the previous three commits. 
* AS::Notifications#instrument should not measure anything, it is not its responsibility;

* Adding another argument to AS::Notifications#instrument API needs to be properly discussed;
 2010-07-25 20:46:42 +02:00
Aaron Patterson
0d0e793983 look up connection once 2010-07-25 11:16:13 -07:00
Aaron Patterson
fc088d4e8f cache the instrumentor for a speed gain 2010-07-25 11:11:51 -07:00
Aaron Patterson
b7e0408ca9 use a hash to collect optional statistics about the instrumentation 2010-07-25 11:11:23 -07:00
José Valim
d02f2d2fb2 runtime should be properly initialized. 2010-07-25 18:26:42 +02:00
José Valim
82c7ef837d Move runtime to log subscriber. 2010-07-25 16:42:05 +02:00
Arkadiusz Holko
7fb7a2bd69 Fixes syntax error in "with_scope" example 2010-07-25 05:29:40 -07:00
José Valim
834bd23a07 Get rid of instrumenter.elapsed. 2010-07-24 10:22:22 +02:00
Neeraj Singh
082ca51d65 bringing consistency in comments 2010-07-24 00:45:53 -04:00
Aaron Patterson
b50635a59f update Rakefiles for RDoc 2.5 2010-07-23 21:11:29 +02:00
Aaron Patterson
5ebc1d88d3 testing sqlbypass destroy. caching connection during destroy 2010-07-23 08:36:58 -07:00
Aaron Patterson
9b48a94c0a brrrrr! freeze is not needed 2010-07-23 08:30:14 -07:00
Aaron Patterson
5e6382e607 fixing space error 2010-07-22 23:45:07 -07:00
Aaron Patterson
34ff74f448 refactoring more methods to a class methods module 2010-07-22 23:44:58 -07:00
Aaron Patterson
da37716c35 refactoring class methods to a module 2010-07-22 23:40:39 -07:00
Santiago Pastorino
b378b19430 Makes Rakefile activate rdoc >= 2.5.9 
Signed-off-by: Xavier Noria <fxn@hashref.com>
 2010-07-23 00:04:06 +02:00
Santiago Pastorino
227680f415 session_id is a VARCHAR 2010-07-22 13:34:27 -07:00
Jeremy Kemper
3ec6759552 Session data will exceed 255 bytes. Use TEXT. 2010-07-22 13:34:07 -07:00
Santiago Pastorino
24f303b677 Makes current adapter decide the syntax of PRIMARY KEY column definition 2010-07-22 15:49:05 -03:00
Santiago Pastorino
7113f207c3 This is a VARCHAR not a TEXT 2010-07-22 15:48:57 -03:00
Santiago Pastorino
1b8cd5fb53 MySQL can't index a TEXT column 2010-07-22 15:48:55 -03:00
Aaron Patterson
97f3c7387e refactor to use instance methods and be kind to subclasses 2010-07-22 09:38:56 -07:00
Aaron Patterson
38734aff20 adding a test for session save 2010-07-22 09:35:50 -07:00
Mislav Marohnić
d5ee17ed20 improve Active Record README 
- revise introductory text
 - improve examples
 - don't claim that Oracle, SQL Server, or DB2 are supported
 - remove lengthy "simple example"
 2010-07-22 10:03:55 +02:00
Mislav Marohnić
89b5e79632 revise download/installation/support sections in READMEs 
- don't reference ancient gem versions
 - don't link to old API doc subdomains
 - point to GitHub instead of RubyForge
 - point to Lighthouse account for support
 2010-07-22 09:17:19 +02:00
Aaron Patterson
a78547a9c6 testing loaded? method and reducing funcalls 2010-07-21 16:59:23 -07:00
Aaron Patterson
87a319cd0c testing new_record? and converting to an attribute 2010-07-21 16:55:04 -07:00
Aaron Patterson
f5de56f537 reducing function calls in the session store 2010-07-21 16:52:15 -07:00
Aaron Patterson
4e6cf429a1 readability is hip 2010-07-21 16:45:38 -07:00
Aaron Patterson
ba0d2a9ce3 starting sql bypass test, fixing create_table and drop_table! 2010-07-21 16:36:28 -07:00
Aaron Patterson
bdbe390a98 initializing instance variables 2010-07-21 16:36:28 -07:00
Aaron Patterson
1f8edb996b adding tests for sessions and clearing up warnings 2010-07-21 16:36:28 -07:00
Neeraj Singh
5c137939a7 expanded comment for update_attribute method 2010-07-22 01:28:30 +02:00
Subba Rao Pasupuleti
b0c7dee4f2 removing unused models from tests 
[#5153 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-21 22:08:07 +02:00
Santiago Pastorino
d16c5cc99b Change some missing README -> README.rdoc 2010-07-22 01:47:06 +08:00
Santiago Pastorino
ef5ae60a07 Make use of tap to return a previously used var 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-21 17:17:23 +02:00
Neeraj Singh
659e3b02ab renaming tests by removing proxy_options from names 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-21 15:25:39 +02:00
José Valim
7131244313 Ensure default_scope can be overwriten by association conditions. 2010-07-21 15:06:23 +02:00
Subba Rao Pasupuleti
d77c3b669c eagerly loaded association records should respect default_scope [#2931 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-21 15:01:40 +02:00
Neeraj Singh
992711a86b update_attribute should not update readonly attributes 
[#5106 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-21 14:55:57 +02:00