Commit Graph

4237 Commits

Author SHA1 Message Date
Santiago Pastorino
9a7e7e5fdb Add missing model 2010-08-14 18:49:04 -03:00
Santiago Pastorino
59a0700b56 Both tests are using the same model, move the model to another file and add the missing require 2010-08-14 18:48:06 -03:00
Santiago Pastorino
b451de0d6d Deletes trailing whitespaces (over text files only find * -type f -exec sed 's/[ \t]*$//' -i {} \;) 2010-08-14 04:12:33 -03:00
Santiago Pastorino
1590377886 Makes AR use AMo to_key implementation
[#5249]
2010-08-13 22:26:44 -03:00
Santiago Pastorino
27fb88aa22 This method is actually not used, it's implemented on the concrete adapters
[#5331 state:committed]
2010-08-13 21:19:47 -03:00
Aaron Patterson
be5d1608cb converting to a symbol is not necessary 2010-08-13 16:50:31 -07:00
Prem Sichanugrist
a7eb8d97a4 Removing most of the symbol to proc usage in Active Record
This will hopefully make Active Record run a bit more faster.
2010-08-13 16:24:49 -07:00
Aaron Patterson
b9eec677c4 avoid direct use of arel constants 2010-08-13 13:33:08 -07:00
Aaron Patterson
af3e39358c removing references to arel constants 2010-08-13 12:37:18 -07:00
Aaron Patterson
e18bd86314 avoiding symbol to proc again 2010-08-13 12:37:07 -07:00
Aaron Patterson
4439e57ee0 do not use arel constants directly 2010-08-13 12:37:03 -07:00
Aaron Patterson
5651e4c835 symbol to proc is slow, we should avoid it 2010-08-13 12:36:59 -07:00
Xavier Noria
fddcd21bd1 be more precise re :validate and :autosave 2010-08-12 19:31:47 +02:00
Neeraj Singh
6ed1ba472e Ensure we can nest include calls [#5285 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-08-12 13:10:58 -03:00
Xavier Noria
4134d7db34 Merge remote branch 'docrails/master' 2010-08-12 17:36:09 +02:00
Xavier Noria
8af2186d26 revises some autosave docs, style and content 2010-08-12 17:31:04 +02:00
Paco Guzman
8a2b69b727 applied guidelines to "# =>" 2010-08-12 17:09:58 +02:00
José Valim
e4943e93c2 Make update_attribute behave as in Rails 2.3 and document the behavior intrinsic to its implementation. 2010-08-12 12:04:16 -03:00
Xavier Noria
599c505837 commit review: applies guidelines to "# =>" 2010-08-12 16:41:34 +02:00
Neeraj Singh
cfad74cfef updating documentation for named_scope and default_scope 2010-08-12 10:23:20 -04:00
Mark Turner
1049bae132 fixed indentation in test cases
Signed-off-by: wycats <wycats@gmail.com>
2010-08-11 23:55:53 -07:00
Paul Hieromnimon
007c4da9ae Raising exception if fixture file can't be found 2010-08-11 15:47:34 -07:00
Aaron Patterson
7de03ec765 subtracting blank strings is slightly faster than blank? 2010-08-11 15:45:06 -07:00
Aaron Patterson
06dc884454 avoid multiple hash lookups 2010-08-11 15:00:08 -07:00
Aaron Patterson
ce529b4759 dry up the hash dup and avoid sending nil values 2010-08-11 15:00:02 -07:00
Aaron Patterson
0f502ab88f avoiding tap saves us time 2010-08-11 11:44:08 -07:00
Aaron Patterson
2b8f24998e unless Array#empty? is faster than if Array#present? 2010-08-11 11:44:04 -07:00
Aaron Patterson
3c11e92616 stop using private methods 2010-08-11 11:43:57 -07:00
Tobias Lütke
cb9295c8a1 Added test case to verify that transaction callbacks are correctly propagated to class observers 2010-08-09 21:36:06 -04:00
Brian Lopez
188855501b move mysql2 adapter into core 2010-08-09 14:52:00 -07:00
Brian Lopez
94cff67bd1 ignore this test for mysql2 2010-08-09 12:50:09 -07:00
Brian Lopez
ee9c950f2f bringing over latest from master 2010-08-09 12:43:49 -07:00
Neeraj Singh
190e270db2 adding more documentation for autosave option 2010-08-09 13:37:51 -04:00
Xavier Noria
4f7565c4de adds missing requires for Object#try 2010-08-09 15:25:21 +02:00
Xavier Noria
b7c4523a94 Merge remote branch 'docrails/master' 2010-08-08 18:33:55 +02:00
Aaron Patterson
334452098e reduce the number of times current_connection_id is called in with_connection() 2010-08-06 16:39:12 -07:00
Aaron Patterson
e1596be323 test to ensure that respond_to? delegates to arel 2010-08-06 15:23:25 -07:00
Aaron Patterson
d082a9a2b8 sorry AR, my privates are none of your business 2010-08-06 14:53:01 -07:00
Neeraj Singh
74dde5951a updating documentation for method configure_dependency_for_has_many 2010-08-06 15:24:53 -04:00
Aaron Patterson
12b3eca420 do not rely on arel class structure 2010-08-06 11:31:05 -07:00
Aaron Patterson
1ca18a6f85 fixing whitespace errors 2010-08-05 08:15:22 -07:00
Aaron Patterson
117b096d0a avoid passing lists of lists to the group clause 2010-08-04 16:24:01 -07:00
Xavier Noria
3cbe111439 Merge remote branch 'docrails/master' 2010-08-05 01:15:57 +02:00
Xavier Noria
d191db76e0 standarizes the use of the article "an" for "SQL" and "SQLite" 2010-08-05 01:09:09 +02:00
Aaron Patterson
ec736dff7b call to_a since we are not passing anything to all() 2010-08-04 14:22:29 -07:00
Aaron Patterson
30abb01d07 fisting indentation 2010-08-04 14:11:30 -07:00
Aaron Patterson
cff7f53fbc do not pass AR objects to ARel 2010-08-04 08:44:53 -07:00
wycats
c25c3879ce I'm unsure how cloning was working in Rails 3 before 2010-08-04 04:05:54 -07:00
Aaron Patterson
6d6ed55324 avoid passing AR::Base objects to Arel when we can 2010-08-03 17:58:56 -07:00
RainerBlessing
7e4e1f0ca5 query value is converted to_s instead of to_yaml
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
2010-08-03 21:08:43 -03:00