github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-01-31 09:18:17 -05:00
Code Issues Packages Projects Releases Wiki Activity
5,242 Commits 34 Branches 105 Tags
ea07212d9780841fbfb3368247ccc0b4bdee5bf5
Commit Graph

610 Commits

Author SHA1 Message Date
Rick Olson
bdcbfa9944 Allow you to set custom :conditions on resource routes. [Rick] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7234 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-07-25 02:47:21 +00:00
David Heinemeier Hansson
937a7abe45 Fixed that file.content_type for uploaded files would include a trailing \r #9053 [bgreenlee] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7212 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-07-24 01:20:18 +00:00
Tobias Lütke
9014bf3f26 * url_for now accepts a series of symbols representing the namespace of the record [Josh Knowles]. Closes #8640 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7197 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-07-19 13:42:11 +00:00
Michael Koziarski
b549366216 Introduce fake_models.rb to avoid platform-specific code. [mpalmer] Closes #8714 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7190 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-07-17 09:44:03 +00:00
Michael Koziarski
5476a6a6c7 Make :trailing_slash work with query parameters for url_for. Closes #4004 [nov] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7186 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-07-14 09:28:56 +00:00
Michael Koziarski
d4d4a08f6b Make sure missing template exceptions actually say which template they were looking for. Closes #8683 [dasil003] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7181 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-07-11 23:32:02 +00:00
Michael Koziarski
e80fabbbf4 Fix errors with around_filters which do not yield, restore 1.1 behaviour with after filters. Closes #8891 [skaes] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7177 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-07-11 02:29:25 +00:00
Michael Koziarski
fd65d89e07 Allow you to delete cookies with options. Closes #3685 [josh, Chris Wanstrath] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7160 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-07-01 23:27:59 +00:00
Rick Olson
a450e769f1 Allow you to render views with periods in the name. Closes #8076 [norbert] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7158 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-07-01 00:04:03 +00:00
David Heinemeier Hansson
20045df260 Temporary fix for formatted_polymorphic_urls and other polys that have additional options (need better testing!) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7152 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-06-28 22:27:59 +00:00
Jeremy Kemper
557e19346a Prefix nested resource named routes with their action name, e.g. new_group_user_path(@group) instead of group_new_user_path(@group). The old nested action named route is deprecated in Rails 1.2.4. Closes #8558. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7138 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-06-27 08:38:55 +00:00
Jeremy Kemper
a72fe4ea45 Give the legacy X-POST_DATA_FORMAT header greater precedence during params parsing for backward compatibility. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7126 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-06-26 01:19:18 +00:00
David Heinemeier Hansson
73fba4faf1 Fixed that HTTP authentication should work if the header is called REDIRECT_X_HTTP_AUTHORIZATION as well (closes #6754) [mislaw] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7091 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-06-23 16:43:08 +00:00
Jeremy Kemper
9159489872 Don't mistakenly interpret the request uri as the query string. Closes #8731. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7084 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-06-23 00:13:40 +00:00
Rick Olson
7f517348db Make ActionView#view_paths an attr_accessor for real this time. Also, don't perform an unnecessary #compact on the @view_paths array in #initialize. Closes #8582 [dasil003, julik, rick] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7034 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-06-15 23:52:37 +00:00
Jeremy Kemper
17927cbddc Improve UrlRewriter tests. Improve helper test coverage. Closes #7207, #7208, #7212. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7013 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-06-13 01:34:16 +00:00
Jeremy Kemper
c0c001839c Take advantage of Mocha support for sequenced returns. Closes #8639 [Josh Peek] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7010 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-06-13 00:55:11 +00:00
Jeremy Kemper
979c22444d Tolerate missing content type on multipart file uploads. Fix for Safari 3. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7005 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-06-12 07:44:23 +00:00
Jeremy Kemper
160af194e4 Routing: improve static segment test coverage. #7117 [Kevin Clark] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6979 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-06-09 04:39:01 +00:00
Jeremy Kemper
c9397e684c Action caching is limited to GET requests returning 200 OK status. Closes #3335. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6970 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-06-08 05:01:35 +00:00
Jeremy Kemper
c7df5bd6ac More nested polymorphic url helper fixes. Closes #6432, references #8601. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6960 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-06-07 21:35:01 +00:00
Rick Olson
b83efadb32 Assume html format when rendering partials in RJS. #8076 [Rick] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6950 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-06-05 16:51:49 +00:00
Jeremy Kemper
8ce5479307 Routing: map.resource :logo routes to LogosController so the controller may be reused for multiple nestings or namespaces. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6922 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-06-01 04:40:30 +00:00
Jeremy Kemper
8139de2812 Routing: drop semicolon and comma as route separators. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6888 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-29 06:40:33 +00:00
Jeremy Kemper
e5b3d4b3b5 request.remote_ip understands X-Forwarded-For addresses with nonstandard whitespace. Closes #7386. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6877 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-28 00:10:13 +00:00
Jeremy Kemper
3f336ad5cc Don't prepare response when rendering a component. Closes #8493. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6875 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-27 23:48:28 +00:00
David Heinemeier Hansson
d3b5db8919 Added custom path cache_page/expire_page parameters in addition to the options hashes [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6868 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-27 16:38:02 +00:00
Rick Olson
cd599aad71 Action Caching speedup. #8231 [skaes] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6867 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-27 07:38:09 +00:00
Jeremy Kemper
dcaa074abf Routing: respond with 405 Method Not Allowed status when the route path matches but the HTTP method does not. Closes #6953. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6862 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-26 20:07:34 +00:00
Marcel Molina
42ebf559cc Add support for assert_select_rjs with :show and :hide. #7780 [dchelimsky] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6861 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-26 17:29:23 +00:00
Marcel Molina
dc4d23f2d7 Make assert_select's failure messages clearer about what failed. #7779 [dchelimsky] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6860 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-26 17:25:19 +00:00
Jeremy Kemper
672941decb Introduce a default respond_to block for custom types. Closes #8174. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6856 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-26 03:11:34 +00:00
Jeremy Kemper
06f325f478 Add multipart request parsing test with bracketed parameter key. References #8449. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6831 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-24 23:37:37 +00:00
Rick Olson
4b9e67c5b9 catch possible WSOD when trying to render a missing partial. Closes #8454 [Catfish] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6826 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-24 16:42:10 +00:00
Jeremy Kemper
4bd3e3aa1b Set RAW_POST_DATA when request parameters are parsed. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6823 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-23 19:09:37 +00:00
Jeremy Kemper
b0d01921d8 Rewind request body after reading it, if possible. Closes #8438. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6815 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-23 05:43:00 +00:00
Tobias Lütke
19fbd84e12 Rescuing in around_filters works as expected again [codahale, Stephan Kaes]. Closes #8341 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6810 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-22 19:17:43 +00:00
Jeremy Kemper
def8f101b8 Strip junk whitespace from [6806]. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6807 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-22 09:38:54 +00:00
Jeremy Kemper
5a3b4cf0bc Resource namespaces are inherited by their has_many subresources. Closes #8280. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6806 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-22 09:37:07 +00:00
Jeremy Kemper
8ba22a690c Fix filtered parameter logging with nil parameter values. Closes #8422. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6802 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-21 23:01:17 +00:00
Jeremy Kemper
d1c957d067 Integration tests: alias xhr to xml_http_request and add a request_method argument instead of always using POST. Closes #7124. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6796 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-21 09:15:16 +00:00
Jeremy Kemper
055ff9f418 Fix incorrent content type lookup in request parsing. Closes #8407. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6786 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-19 21:34:36 +00:00
Tobias Lütke
1008535905 Allow routes to be declared off namespaces 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6783 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-19 16:26:44 +00:00
Jeremy Kemper
c597e7d9ac Include location header in args. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6774 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-18 21:23:07 +00:00
Jeremy Kemper
d2ed32d592 Parse url-encoded and multipart requests ourselves instead of delegating to CGI. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6764 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-18 06:24:50 +00:00
Jeremy Kemper
f7bb3ddce8 Fix render :location => ... test. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6762 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-18 05:25:17 +00:00
David Heinemeier Hansson
ebee0a742d Added url_for usage on render :location, which allows for record identification [DHH] (still need to figure out why that test doesnt pass, seems like a test issue) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6750 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-17 20:48:47 +00:00
Tobias Lütke
04823ff48f Allow nested namespaces in routing 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6748 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-17 01:27:54 +00:00
Jeremy Kemper
73fbf7771b Add multipart and url-encoded form mime types. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6744 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-15 23:57:16 +00:00
Jeremy Kemper
f73e1c2ec0 Move request parameter parsing from CGI to AbstractRequest. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6742 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-15 22:10:03 +00:00