github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity
10,136 Commits 34 Branches 105 Tags
eaef1ee09c4bd2ed11722660fddf9b4e7e1384cc
Commit Graph

3452 Commits

Author SHA1 Message Date
Yehuda Katz
4417a19b03 Small changes to get 1.9 passing (for the most part) 2009-06-23 14:06:22 -07:00
=?utf-8?q?Mislav=20Marohni=C4=87?=
21cd4c0e93 Fix polymorphic_path doesn't modify options hash [#2099 state:resolved] 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2009-06-21 17:53:07 +01:00
Darragh Curran
9cb8c812f2 Add content_for?(:name) helper to check if content_for(:name) is present [#1311 state:resolved] 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2009-06-21 17:07:22 +01:00
Yehuda Katz + Carl Lerche
9f7eaea201 Minor ActionView cleanup 2009-06-18 12:08:50 -07:00
Yehuda Katz + Carl Lerche
497554fd10 Fix typo 2009-06-18 11:14:44 -07:00
Jeremy Kemper
5267addd4f Use errors[field] instead of errors.on(field) 2009-06-17 19:37:56 -07:00
Yehuda Katz + Carl Lerche
b4a91db441 Extract the layout proc into a method, and write documentation explaining what the proc does in various cases. 2009-06-17 18:55:10 -07:00
Yehuda Katz + Carl Lerche
ca8f8fb031 Remove one more note about deprecated behavior 2009-06-17 18:15:41 -07:00
Yehuda Katz + Carl Lerche
a9ad763c86 Drive the final stake through @content_for_*'s heart! 2009-06-17 18:08:45 -07:00
Yehuda Katz + Carl Lerche
65102c8f1a Cleaning up more tests and code that needed to work in both old and new base 2009-06-17 16:51:51 -07:00
Yehuda Katz + Carl Lerche
55ee0ba7f5 Cleaning up if defined?(ActionController::Http) blocks from the pre new base era. 2009-06-17 16:23:11 -07:00
Yehuda Katz + Carl Lerche
8fdf3d7890 Remove some defined?(Http) checks 2009-06-17 16:14:05 -07:00
Yehuda Katz + Carl Lerche
251a6e492c Rename path.rb to resolver.rb 2009-06-17 15:39:41 -07:00
Yehuda Katz + Carl Lerche
d8f352e970 Rename ActionView::Template::Path ActionView::Resolver 2009-06-17 15:32:55 -07:00
Yehuda Katz + Carl Lerche
487312515c RJS doesn't render with an HTML layout by default 2009-06-17 12:54:19 -07:00
Yehuda Katz + Carl Lerche
4fad953f90 Fixing pending tests and fixed some formats / partial rendering semantics 2009-06-17 12:54:19 -07:00
Yehuda Katz + Carl Lerche
315147fcb5 Move the exceptions for missing template into Compatibility in prep for moving it into a "not-production" module 2009-06-16 13:54:55 -07:00
Yehuda Katz + Carl Lerche
dd58f4021d An exception is raised if a layout is missing only if the layout is missing for all mimes 2009-06-16 13:44:51 -07:00
Yehuda Katz + Carl Lerche
01a4bc84b8 Exceptions now in an exceptions module 2009-06-16 11:32:38 -07:00
Yehuda Katz + Carl Lerche
a6e803bee1 Remove exceptions from AbstractUnit so they work in real life 2009-06-16 11:20:28 -07:00
Yehuda Katz + Carl Lerche
18c3b77b23 Merge process2 into process to people's regular tests run :P 2009-06-16 10:46:03 -07:00
Yehuda Katz + Carl Lerche
3c15cba175 Whoops, I guess we broke layouts ;) 2009-06-15 17:32:10 -07:00
Yehuda Katz + Carl Lerche
19c3495a67 rm -r controller/base! 2009-06-15 16:29:45 -07:00
Yehuda Katz + Carl Lerche
7b1f483fda Get all of rake tests to pass 2009-06-15 16:14:45 -07:00
Yehuda Katz + Carl Lerche
5314abed18 Keep ActionMailer using the old layouts code until it gets refactored. 2009-06-15 11:59:28 -07:00
Yehuda Katz + Carl Lerche
a63caa4c0c Get tests to run (with failures) without old base around 2009-06-15 11:44:45 -07:00
Yehuda Katz + Carl Lerche
5a8a550a45 Finish making things pass with updated internal content_type semantics 2009-06-15 11:21:08 -07:00
Joshua Peek
c50b03b754 Add :concat option to asset tag helpers to force concatenation. 
This is useful for working around IE's stylesheet limit.

  stylesheet_link_tag :all, :concat => true
 2009-06-15 10:23:23 -05:00
Xavier Noria
b56169c262 moves reopening of core classes to add generic stuff from Action Pack to AS/core_ext and adds tests 
[#2798 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2009-06-13 15:01:14 -07:00
Xavier Noria
d32965399c uses Object#metaclass and Object#class_eval in a few spots 
[#2797 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2009-06-12 16:14:06 -07:00
Andrew Kaspick
59c83af18b allow absolute paths for the asset caches 
Signed-off-by: Michael Koziarski <michael@koziarski.com>
 2009-06-11 16:33:32 +12:00
Yehuda Katz + Carl Lerche
47ff57f6d1 Document and clean up HideActions and Http 2009-06-10 15:27:53 -07:00
Yehuda Katz + Carl Lerche
82a10ce9f6 Removed unnecessary code 2009-06-10 14:43:43 -07:00
Yehuda Katz + Carl Lerche
fbb6b936e9 Document ActionController::Helpers 2009-06-10 14:28:58 -07:00
Yehuda Katz + Carl Lerche
316fab7de6 Cleaned up the #default_helper_module method to make better use of #helper instead of duplicating code. 2009-06-10 14:15:21 -07:00
Yehuda Katz + Carl Lerche
4fc0778123 Simplify helper use of ActiveSupport::Dependencies, and use super better for in #helpers 2009-06-10 12:15:30 -07:00
Yehuda Katz + Carl Lerche
b6fde6b480 Clean up AbstractController::Logger and write documentation 2009-06-09 17:03:02 -07:00
Yehuda Katz + Carl Lerche
f35f47b8c0 Cleaning up and documenting AbstractController::Layouts 2009-06-09 16:47:40 -07:00
Yehuda Katz + Carl Lerche
acb2447785 Write documentation for AbstractController::Helpers 2009-06-09 16:47:39 -07:00
Stephen Anderson
a94e7d7897 Sanitized the id generated by text_area_tag helper method. text_area_tag('item[description]') should return: <textarea id="item_description" name="item[description]"></textarea> instead of: <textarea id="item[description]" name="item[description]"></textarea> The old id was causing HTML validation failures. 
Signed-off-by: Michael Koziarski <michael@koziarski.com>
 2009-06-09 20:36:45 +12:00
David Stevenson
a14df8c9b2 Made label target radio button tags with values. Radio button now respects inherited :index options when generating id. 
Signed-off-by: Michael Koziarski <michael@koziarski.com>
 2009-06-09 20:28:43 +12:00
Michael Koziarski
99803b7cdb Pull autoload fix from 2-3-stable 2009-06-09 20:10:21 +12:00
nate
f68cc639f5 A test to show that http_authentication needs to fail authentication if the password procedure returns nil. Also includes a fix to validate_digest_response to fail validation if the password procedure returns nil. 
Signed-off-by: Michael Koziarski <michael@koziarski.com>
 2009-06-09 19:47:53 +12:00
Jeremy Kemper
23f3b567e2 Uses Hash#symbolize_keys 2009-06-08 19:37:52 -07:00
Yehuda Katz + Carl Lerche
be371993b7 More documentation work on AbstractController 
This is still not completely done and there might be pointers to things that don't exist yet.
 2009-06-08 17:41:08 -07:00
Yehuda Katz + Carl Lerche
38b608ecab Writing comments to AbstractController 2009-06-08 16:15:14 -07:00
Yehuda Katz + Carl Lerche
a470bb3612 Remove extraneous response_obj 2009-06-08 16:15:13 -07:00
Jeremy Kemper
d3078b540e Explicitly qualify constants in BasicObjects 2009-06-08 15:07:52 -07:00
Jeremy Kemper
a6bf6f275c Use as_json instead of rails_to_json 2009-06-08 14:08:04 -07:00
Yehuda Katz + Carl Lerche
86fc43fd58 ActionPack components should no longer have undeclared dependencies. 
* Tests can be run in isolation
  * Dependencies added
  * A few tests modified to avoid depending on AS deps 
    not depended on my files they were testing
 2009-06-08 13:34:07 -07:00