Commit Graph

468 Commits

Author SHA1 Message Date
David Heinemeier Hansson
ebb7bd7835 Added easy assignment of fragment cache store through use of symbols for included stores (old way still works too)
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2230 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-13 08:31:32 +00:00
David Heinemeier Hansson
48018bf4b5 Moved session options to SessionManagement
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2229 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-13 07:48:12 +00:00
David Heinemeier Hansson
53ee2c9633 Added ActionController::Base.session_store=, session_store, and session_options to make it easier to tweak the session options (instead of going straight to ActionController::CgiRequest::DEFAULT_SESSION_OPTIONS)
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2228 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-13 07:46:57 +00:00
David Heinemeier Hansson
33e2ccfb26 Dont log creation of view class
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2225 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-12 18:14:16 +00:00
David Heinemeier Hansson
c259ed9e02 Use session_id instead of deprecated sessid
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2221 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-12 17:35:17 +00:00
Nicholas Seckar
c0e84b811e Ensure that request.path never returns nil. Closes #1675
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2206 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-11 14:10:20 +00:00
Nicholas Seckar
27962ead03 Add ability to specify Route Regexps for controllers. Closes #1917.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2205 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-11 13:56:43 +00:00
Nicholas Seckar
9e5d64b3bb Provide Named Route's hash methods as helper methods. Closes #1744.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2204 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-11 13:45:55 +00:00
David Heinemeier Hansson
2fc5cf78be Use send instead of module_eval #1873 [shugo]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2197 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-11 09:14:22 +00:00
David Heinemeier Hansson
c1007377ba Added in-place editing support in the spirit of auto complete with ActionController::Base.in_place_edit_for, JavascriptHelper#in_place_editor_field, and Javascript support from script.aculo.us #2038 [Jon Tirsen] Moved auto-completion and in-place editing into the Macros module and their helper counterparts into JavaScriptMacrosHelper
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2191 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-11 07:52:53 +00:00
David Heinemeier Hansson
dc2a3af133 Dont encourage custom url options to be called with symbol #2047
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2190 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-11 07:25:08 +00:00
David Heinemeier Hansson
0439769324 Refactored away all the legacy validate_options calls and replaced them with Hash#assert_valid_keys
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2167 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-09 08:32:47 +00:00
David Heinemeier Hansson
c8e0e10e28 Added documentation for overwrite_params #2146 [Michael Shuerig]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2162 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-09 07:50:14 +00:00
David Heinemeier Hansson
e3c02d8c66 Fixed that render :partial would fail when :object was a Hash (due to backwards compatibility issues) #2148 [Sam Stephenson]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2160 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-09 07:27:44 +00:00
David Heinemeier Hansson
febc24dee7 An explicit include ClassInheritableAttributes is no longer needed #1948 [Caleb Tennis]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2154 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-08 16:28:10 +00:00
Nicholas Seckar
bf92aacf40 Avoid extending view instance with helper modules each request. Closes #1979
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2152 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-08 12:08:24 +00:00
Nicholas Seckar
689cca132a Performance improvements to CGI methods. Closes #1980
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2151 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-08 11:28:54 +00:00
Nicholas Seckar
2f66e873b0 Symbolize the keys of overwritten parameters. Really closes #1909.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2147 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-07 08:59:33 +00:00
Nicholas Seckar
3108764367 Fix overwrite params. Closes #1909
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2144 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-06 22:06:11 +00:00
David Heinemeier Hansson
f86276b305 Fix fragment benchmark calls and limit timings to 5 decimals
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2142 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-06 17:33:11 +00:00
David Heinemeier Hansson
291c667d66 Only do benchmarking if log level matches and log caching
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2141 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-06 17:07:08 +00:00
David Heinemeier Hansson
5e8e8d6564 Added use_silence parameter to ActiveRecord::Base.benchmark that can be passed false to include all logging statements during the benchmark block. Added ActionController::Base.benchmark and ActionController::Base.silence to allow for easy benchmarking and turning off the log
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2140 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-06 16:48:18 +00:00
Jamis Buck
bfdb437508 Updated vendor copy of html-scanner to support better xml parsing
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2131 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-05 09:44:22 +00:00
Jamis Buck
89550ee7e9 Use chop! instead of chop! for efficiency
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2109 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-02 18:01:26 +00:00
Jamis Buck
62ec1a5373 Drop trailing \000 if present on RAW_POST_DATA (works around bug in Safari Ajax implementation) #918
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2106 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-02 14:40:33 +00:00
Jamis Buck
6c44d35268 AbstractRequest#domain returns nil when host is an ip address #2012 [kevin.clark@gmail.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2098 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-02 09:10:31 +00:00
Jamis Buck
46c4fd4177 ActionController documentation update #2051 [fbeausoleil@ftml.net]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2095 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-01 21:54:29 +00:00
Nicholas Seckar
87b6800282 Add option to specify the singular name used by pagination. Closes #1960
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2078 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-08-31 00:13:10 +00:00
Nicholas Seckar
34e795ff0e Use string key to set action_name for controllers. Closes #1968
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2077 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-08-30 23:52:53 +00:00
David Heinemeier Hansson
b80f0e2ff3 Made Upload Progress work with Prototype 1.4.0 and add some documentation for it #1847, #1876 [Thomas Fuchs/Sean Treadway]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2059 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-08-27 06:30:33 +00:00
Nicholas Seckar
1cbd1f9698 Fix routing to handle :some_param => nil better
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2054 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-08-26 10:57:43 +00:00
Jamis Buck
c5ff810572 Add support for :include with pagination (subject to existing constraints for :include with :limit and :offset) #1478 [michael@schubert.cx]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2041 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-08-23 14:24:15 +00:00
Jamis Buck
211617191e Prevent the benchmark module from blowing up if a non-HTTP/1.1 request is processed
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2039 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-08-23 09:43:36 +00:00
Jamis Buck
c031a01633 Add an :if option to session management, to allow programmatically enabling or disabling the session
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2031 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-08-17 21:05:31 +00:00
Jamis Buck
50e2474433 Make assert_redirected_to properly check URL's passed as strings #1910 [Scott Barron]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1971 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-08-06 08:37:25 +00:00
Jamis Buck
a3469cadad Make sure :layout => false is always used when rendering inside a layout
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1970 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-08-05 20:51:03 +00:00
Jamis Buck
44c64a612d Use raise instead of assert_not_nil in Test::Unit::TestCase#process to ensure that the test variables (controller, request, response) have been set
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1963 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-08-01 21:28:17 +00:00
Jamis Buck
08ebab5d20 Make sure assigns are built for every request when testing #1866
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1961 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-31 12:16:21 +00:00
Jamis Buck
020ed6fa1f Allow remote_addr to be queried on TestRequest #1668
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1960 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-31 10:31:47 +00:00
David Heinemeier Hansson
0ea1375d75 Really fix the syntax error issue
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1952 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-28 17:41:19 +00:00
David Heinemeier Hansson
9fad3251d3 More fixes, but still broken
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1948 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-27 14:17:47 +00:00
David Heinemeier Hansson
5b52b716b7 Fixing the fix, but not quite
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1945 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-27 13:55:39 +00:00
David Heinemeier Hansson
eec7cc004b Fixed dynamic scaffolding [Stefan Kaes]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1940 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-27 11:44:18 +00:00
David Heinemeier Hansson
d876daf51f Fixed #1774 again
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1936 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-27 08:02:26 +00:00
David Heinemeier Hansson
4b8d156ca5 Removed unused statement
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1934 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-26 18:39:05 +00:00
David Heinemeier Hansson
d440cf6483 Fixed snag in status reporting
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1933 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-26 18:35:38 +00:00
David Heinemeier Hansson
65e4e5e337 Only log status if there is one different from 200 set
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1930 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-26 12:38:50 +00:00
David Heinemeier Hansson
36fee9c02e Fixed broken error handling #1827 [Stefan Kaes]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1920 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-25 09:39:57 +00:00
David Heinemeier Hansson
e9cfe955cc Add a catch-all eraser
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1918 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-25 08:49:19 +00:00
David Heinemeier Hansson
4f40b2d8fb Improved performance of test app req/sec with ~10% refactoring the render method #1823 [Stefan Kaes]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1915 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-24 16:45:39 +00:00