github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity
17,143 Commits 34 Branches 105 Tags
ec3bfa2ead7337fe99ff036d4b8b5ae0a321f8cd
Commit Graph

2590 Commits

Author SHA1 Message Date
Jeremy Kemper
f8011e67b0 Use caller for helpers_dir deprecation warnings 2010-06-28 14:48:44 -07:00
Bruno Michel
2002e5877e Strip_tags never ending attribute should not raise a TypeError [#4870 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-28 11:40:27 +02:00
José Valim
7eb5766bd1 Small changes to responder: 
* resources is always an array;
* Lazy retrieve request and formats;
* Alias api_location and navigation_location to resource_location, making easier to change its behavior without affecting each other and without a need to reimplement any of the behavior methods.
 2010-06-26 15:48:47 +02:00
José Valim
6788db824a Move Rails::LogSubscriber to ActiveSupport::LogSubscriber, allowing frameworks like ActiveRecord and ActiveResource to log outsude Rails::Application [#4816 state:resolved] 2010-06-24 13:23:43 +02:00
Michael Lovitt
49f52c3d91 Sessions should not be created until written to and session data should be destroyed on reset. 
[#4938]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-06-23 11:56:35 -07:00
knapo
995b1a243c Fix controller_name for non default controller paths [#4901 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-23 01:37:52 +02:00
David Chelimsky
0576ec4ddd Add support for specifying locals in view tests with assert template [#4927 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-22 14:51:22 +02:00
Xavier Noria
207fa59675 Merge remote branch 'rails/master' 
Conflicts:
	actionpack/lib/abstract_controller/base.rb
 2010-06-20 23:13:19 +02:00
Andrew White
ed3f042e99 Make polymorphic_url and scaffolding work with uncountable resources [#3930 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-20 00:15:41 +02:00
wycats
f368b21cb6 Remove a relic of #request being in RackDelegation 2010-06-19 08:19:15 -07:00
Evgeniy Dolzhenko
ef404c771d Fix a bunch of minor spelling mistakes 2010-06-15 12:04:22 +04:00
Xavier Noria
f17159b029 edit pass: the names of Rails components have a space, ie, "Active Record", not "ActiveRecord" 2010-06-14 23:22:04 +02:00
Evgeniy Dolzhenko
ccf9577aee Fix a bunch of minor spelling mistakes 2010-06-11 14:15:34 +04:00
José Valim
b67ec8ba20 class_attribute is not a direct replacement of class_inheritable_*. 
If you are setting a hash or an array in class_attribute or you need
to freeze it, to ensure people won't modify it in place or you need
to dup it on inheritance.
 2010-06-10 19:39:09 +02:00
Neeraj Singh
db23a95a61 cache_sweeper yields blank output 
[#3914 state:open]

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-08 23:20:04 +02:00
wycats
d6953cbfd3 regular expressions are usually ASCII-encoded, so force_encoding the content of a Node to the encoding of the regular expression is wrong. 2010-06-07 18:06:08 -04:00
wycats
eebac02606 Make named helpers unprotected without becoming actions [#4696 state:resolved] 2010-06-07 15:29:55 -04:00
Jeremy Kemper
9f93de9d3d Reset request.parameters after assigning params for functional tests 2010-06-06 12:07:40 -07:00
wycats
ff4c218095 Memoizing methods on request means we need to clear them out on recycle! 2010-06-04 20:11:05 -07:00
José Valim
71375c8936 Add an asset_host accessor for consistency. 2010-06-02 14:53:56 -07:00
David Heinemeier Hansson
631dc61885 Extract assets paths and make them available to Action Mailer as well 2010-06-02 16:49:02 -05:00
wycats
ffe001f19d Changes made while working on upgrading cells to Rails 3 2010-06-02 22:56:41 +02:00
José Valim
9a93844aba Add :only and :except to controllers MiddlewareStack. This allows 
you to do the following:

  class PostsController < ApplicationController
    use AutheMiddleware, :except => [:index, :show]
  end
 2010-05-30 15:53:14 +02:00
José Valim
59d1c418be Fix a bug where responders were not working properly on method override. 2010-05-24 13:12:40 +02:00
Jeremy Kemper
a06e9b4602 Ruby 1.9: helper path may be a pathname, so convert to a string before quoting for regexp 2010-05-16 18:03:27 -07:00
David Chelimsky
849ab92942 Eliminate false positives when passing symbols to assert_template 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-05-03 13:46:12 +02:00
Justin George
731d4392e4 Change event namespace ordering to most-significant first [#4504 state:resolved] 
More work still needs to be done on some of these names
(render_template.action_view and render_template!.action_view particularly)
but this allows (for example) /^sql/ to subscribe to all
the various ORMs without further modification

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-05-02 22:45:54 +02:00
rick
8d236ccb84 add HTTP Token Authorization support to complement Basic and Digest Authorization. 2010-04-30 07:46:30 -07:00
Neeraj Singh
d793d30776 ActionCachingTestController rescues from all exceptions. Making sure that all the tests check for valid response. [#4468 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-04-29 12:48:34 +02:00
David Chelimsky
176fbfd66f extract ActionController::TestCase::Behavior 
- this makes it possible for other test frameworks
  to hook into testing facilities provided by Rails
  without having to subclass AC::TestCase.

[#4474 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-04-26 09:52:38 +02:00
David Chelimsky
864bd9c21f allow unsubscribe by name or subscription [#4433 state:resolved] 
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-04-24 22:06:24 -07:00
José Valim
81fb742488 Always downstream given options in :json, :xml and :js renderers and add tests for it. 2010-04-22 12:12:38 +02:00
José Valim
4163ccec23 Clean up the config object in ActionPack. Create config_accessor which just delegates to the config object, reducing the number of deprecations and add specific tests. 2010-04-22 12:00:13 +02:00
wycats
62916ecbbe It should be possible to render :json with options 2010-04-20 22:29:00 -07:00
Santiago Pastorino
4309c1fda3 perform_caching is now delegated to config on instance and class level 2010-04-17 23:40:03 -03:00
Carl Lerche
ac015b1d07 Revert "Avoid deprecation warnings and potential TypeErrors [#4404 state:resolved]" 
Revert "protected instance variables added to the deprecated config accessor

This reverts commit 4bce5ba600 and 0ee2d3c89a.
 2010-04-16 15:39:00 -07:00
Santiago Pastorino
9c08ccd889 page_cache_extension is delegating to config so no need to deprecate 2010-04-16 11:03:16 -03:00
Santiago Pastorino and Carl Lerche
0ea434e2f4 Make perform_caching work again, with the tests passing and backward compatible 2010-04-15 18:25:08 -03:00
Santiago Pastorino and Carl Lerche
005c2bac46 Revert "logger added to the deprecated config accessor" we need a major refactor to get this working 
This reverts commit 68f4e046a7.
 2010-04-15 16:58:31 -03:00
Santiago Pastorino
68f4e046a7 logger added to the deprecated config accessor 2010-04-14 22:49:53 -07:00
Santiago Pastorino
0ee2d3c89a protected instance variables added to the deprecated config accessor 2010-04-14 22:49:53 -07:00
Santiago Pastorino
ab808a9d71 asset and helper path added to the deprecated config accessor 2010-04-14 22:49:53 -07:00
Santiago Pastorino
eb8c7b4639 page_cache added to the deprecated config accessor 2010-04-14 22:49:53 -07:00
Santiago Pastorino
a618ad358a Make use of config.perform_caching 2010-04-14 22:35:13 -07:00
Santiago Pastorino
399d5338ac Fix missing dependency on Hash#to_query 
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-04-14 17:14:50 -07:00
Xavier Noria
9a4fdff0af Merge commit 'docrails/master' 2010-04-14 01:00:03 -07:00
Santiago Pastorino
0ab2ba336f config.perform_caching added to the deprecated config accessor [#4383 state:committed] 
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-04-13 16:20:49 -07:00
Anil Wadghule
84e46437fa Replace 'RAILS_ROOT' to 'Rails.root' and 'RAILS_ENV' to 'Rails.env' in significant places. 2010-04-12 22:53:49 +05:30
José Valim
ece157e950 Move verification to a plugin as well: http://github.com/rails/verification.git 2010-04-10 11:47:20 +02:00
Santiago Pastorino
13e00ce606 fix stack trace lines on class_eval 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-04-09 21:28:49 +02:00