John Firebaugh
57bc25c5f8
Use run_callbacks; the generated _run_<name>_callbacks method is not a public interface.
...
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com >
2011-01-31 19:45:53 -02:00
Neeraj Singh
806e6f80dc
render_to_string must ensure that response_body
...
is nil
[ #5875 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com >
2011-01-25 20:14:03 +01:00
Neeraj Singh
c1145d9281
If I want to set respond_body to nil then it
...
should be nil and not [nil]. If anything other
than nil then wrap it in array
Signed-off-by: José Valim <jose.valim@gmail.com >
2011-01-25 20:13:56 +01:00
Doug Fales
7927fc2ff7
A patch so that http status codes are still included in logs even during an exception [ #6333 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2011-01-25 20:12:22 +01:00
brainopia
8491f16e12
Add tld_length option when using domain :all in cookies
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2011-01-21 13:13:51 +01:00
brainopia
91a4193ee0
Support list of possible domains for cookies
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2011-01-21 13:13:43 +01:00
José Valim
262b2ea8cd
Solve SystemStackError when changing locale inside ActionMailer [ #5329 state:resolved]
2011-01-19 23:42:10 +01:00
Aaron Patterson
54de7048a5
Merge branch 'template_error' into merge
...
* template_error:
Ensure original exception message is present in both Template::Error#message and Template::Error#inspect.
ActiveSupport::Deprecation.silence no longer needed.
2011-01-18 10:52:37 -08:00
Christos Trochalakis
7dab186fde
Issue one Cache#read command instead of two in the case of a fragment cache hit
2011-01-18 09:52:11 -08:00
Aaron Patterson
6a8f7f0e04
minitest added @__io__, so we should ignore it too
2011-01-17 14:53:44 -08:00
Aaron Patterson
9702159373
removing more unused variables
2011-01-17 14:33:34 -08:00
Santiago Pastorino
1de47a0d56
button_tag should escape it content
2011-01-12 22:05:52 -02:00
Aaron Patterson
16ae08fff0
use raise to create exceptions and to set the backtrace
2011-01-12 11:15:11 -08:00
Aaron Patterson
1d9c555297
reraising should be in the rescue block
2011-01-12 11:15:10 -08:00
Santiago Pastorino
daada51d10
Reuse the view_context from the controller, this make the test environment more similar to the code applications uses
2011-01-12 16:47:56 -02:00
Santiago Pastorino
6062d434f1
Allow view in AV::TestCase to access it's controller helpers methods
2011-01-12 12:14:00 -02:00
Santiago Pastorino
a61e3acef2
html_safe.to_str makes no sense
2011-01-11 18:57:35 -02:00
Krekoten' Marjan
366e7854ac
Refactor to handle the X-Cascade without having to raise an exception
2011-01-09 16:08:54 -08:00
Jakub Kuźma
5106ce88e4
authenticity_token option for form_tag [ #2988 state:resolved]
2011-01-09 15:55:26 -08:00
John Allison
5d1d9bfb05
Improve select helpers by allowing a selected value of false. This is useful when using a select helper with a boolean attribute, and the attribute is false. (e.g. f.select :allow_comments)
2011-01-09 15:45:55 -08:00
Rizwan Reza
18605adec3
HTML5 button_tag helper
...
This tag is similar in nature to submit_tag, but allows more control.
It also doesn't submit if submit type isn't used, allowing JavaScript to
control the flow where required.
For more information: http://www.whatwg.org/specs/web-apps/current-work/multipage/the-button-element.html#the-button-element
2011-01-09 15:22:23 -08:00
Santiago Pastorino
14198d84a9
Remove InstanceTagMethods module and define the methods inside the InstanceTag class
2011-01-09 13:35:38 -02:00
Santiago Pastorino
171172f324
render :template is faster than render :file
2011-01-01 13:44:34 -02:00
Santiago Pastorino
9bc879d42a
This is not needed anymore
2011-01-01 13:20:00 -02:00
Timothy N. Tsvetkov
e5b84fd723
ActionController::Base.helpers.sanitize ignores case in protocol
...
[#6044 state:committed]
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com >
2010-12-30 22:43:43 -02:00
Nick Sutterer
db24701abe
process_action accepts multiple args, even with Callbacks.
2010-12-29 16:37:10 -08:00
Xavier Noria
69765aad8b
Merge branch 'master' of git://github.com/lifo/docrails
2010-12-29 23:46:03 +01:00
José Valim
ecc83c1e6e
Clean up PathSet.
2010-12-27 10:15:54 +01:00
José Valim
6b099975fa
No need to symbolize these.
2010-12-27 09:30:36 +01:00
José Valim
51a7d9acdd
Final tidy up on templates inheritance.
2010-12-27 09:14:13 +01:00
wycats
e03e1fdbc8
Speed up template inheritance and remove template inheritance option
2010-12-26 23:56:09 -08:00
wycats
7c568fda6b
A bunch of cleanup on the inherited template patch
2010-12-26 23:44:51 -08:00
artemave
6c5a3bb312
all tests pass
2010-12-26 22:32:15 -08:00
artemave
ce21ea7832
#948 make template inheritance optional
2010-12-26 22:32:15 -08:00
artemave
ddd85ef9c6
#948 template_inheritance
2010-12-26 22:32:15 -08:00
Akira Matsuda
4e50c6c08a
.erb => .html.erb
2010-12-25 04:58:11 +09:00
Akira Matsuda
0a1f5f7511
for ... in => each ... do
2010-12-25 04:46:41 +09:00
Xavier Noria
8cdb758081
Merge branch 'master' of github.com:rails/rails
2010-12-24 01:55:35 +01:00
José Valim
d6efd3cfc2
Don't deprecate to_prepare.
2010-12-23 19:21:14 +01:00
José Valim
819b8cae40
Clean up callbacks should also be called on exceptions.
2010-12-23 19:17:02 +01:00
Rizwan Reza
9dfa06acb4
Edits to caching/fragments.
2010-12-23 16:29:40 +03:30
Rizwan Reza
0997d5a12d
More minor edits.
2010-12-23 16:13:36 +03:30
Rizwan Reza
5fb2f0c07f
Revised documentation for cache_helper.
2010-12-23 16:06:53 +03:30
Santiago Pastorino
5853583f9b
Allow registering javascript/stylesheet_expansions to existing symbols
2010-12-22 21:53:24 -02:00
Xavier Noria
8a3132b8a9
Merge branch 'master' of git://github.com/lifo/docrails
2010-12-23 00:15:10 +01:00
Piotr Sarnacki
09195f10bd
Do not use the same hash instance for expansions [ #6114 state:resolved]
...
Using the same hash instance makes using the same expansions for
both javascripts and stylesheets.
2010-12-22 09:44:46 +01:00
John Firebaugh
0b0e6f13c0
Typo (request -> response)
2010-12-21 19:32:34 -08:00
John Firebaugh
d4afde9ab0
Expand ActionDispatch::Reloader docs
2010-12-21 19:26:33 -08:00
Xavier Noria
880f8419c4
Merge branch 'master' of git://github.com/lifo/docrails
2010-12-20 20:13:34 +01:00
José Valim
0cbfd6c28d
Small changes on AD::Reloader.
2010-12-20 12:43:02 +01:00