github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-02-04 11:15:08 -05:00
Code Issues Packages Projects Releases Wiki Activity
1,292 Commits 34 Branches 105 Tags
ed7bfc96625d47ba5905628d458c2daef238f32a
Commit Graph

92 Commits

Author SHA1 Message Date
Jamis Buck
75fb0a32a8 Support :render option to :verify #1440 [TobiasLuetke] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1418 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-14 13:23:55 +00:00
Jamis Buck
b2b757be39 Fix broken test case caused by change of testing address from 127.0.0.1 to 0.0.0.0 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1417 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-14 10:31:31 +00:00
Jamis Buck
f6ec9e3d66 Arrays sent via multipart posts are converted to strings #1032 [dj@omelia.org] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1397 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-10 12:21:25 +00:00
Jamis Buck
e4c047e489 render(:action) and render() are the only two render calls to use a layout by default. All others default to :layout => false. Also, allow :layout => true to be a synonym for :layout => nil. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1378 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-01 13:39:58 +00:00
Jamis Buck
6ce58318f5 render(:inline) defaults to :layout => false 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1372 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-30 09:12:12 +00:00
Jamis Buck
f8542a64b3 Make sure the benchmarking render method always returns the result of the render, regardless of whether logging is enabled or not. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1371 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-30 09:00:46 +00:00
Jamis Buck
f57ee365e1 render(:text), render(:partial), and render(:nothing) always default to :layout => false. This also fixes send_file, which was applying a layout if one existed for the current action. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1369 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-30 07:51:02 +00:00
Jamis Buck
613260606b verify with :redirect_to won't redirect if a redirect or render has already been performed #1350 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1367 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-30 07:24:46 +00:00
Jamis Buck
00db6f0faa render(:partial => "...") uses an empty hash for the local assigns #1365. render(:partial => true) is identical to the older render_partial() 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1366 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-30 07:20:37 +00:00
David Heinemeier Hansson
79d9794f09 Updated unit test style 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1355 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-22 17:12:29 +00:00
David Heinemeier Hansson
c41f0cc720 Test for no layout on nothing 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1354 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-22 16:59:55 +00:00
David Heinemeier Hansson
da0c4c5c96 Deprecated all render_* methods in favor of consolidating all rendering behavior in Base#render(options). This enables more natural use of combining options, such as layouts 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1350 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-22 08:58:43 +00:00
David Heinemeier Hansson
0367317dd6 Deprecated redirect_to_path and redirect_to_url in favor of letting redirect_to do the right thing when passed either a path or url. Introduced r as a unified method for render (still under construction) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1349 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-22 07:43:05 +00:00
David Heinemeier Hansson
d3704f888b Fixed assert_redirect_to to work with redirect_to_path #869 [Nicholas Seckar] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1332 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-19 19:19:58 +00:00
David Heinemeier Hansson
dd8c92ea5b Fixed Request#remote_ip in testing #1251 [bitsweat] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1322 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-19 18:24:52 +00:00
David Heinemeier Hansson
aa20834222 Added accessors to logger, params, response, session, and headers from the view, so you can write <% logger.info "stuff" %> instead of <% @logger.info "others" %> -- more consistent with the preferred way of accessing these attributes and collections from the controller 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1307 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-19 16:00:04 +00:00
David Heinemeier Hansson
e6f3e5d900 Fixed action/fragment caching using the filestore when a directory and a file wanted to to use the same name. Now there's a .cache prefix that sidesteps the conflict #1188 [imbcmdth@hotmail.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1260 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-30 15:29:27 +00:00
David Heinemeier Hansson
b4fe4daa84 Fixed assert_redirected_to to work with :only_path => false #1204 [Alisdair McDiarmid] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1251 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-30 08:34:02 +00:00
David Heinemeier Hansson
3b9bf64130 Added support for web servers that use PATH_INFO instead of REQUEST_URI like IIS #1014 [BradG/Nicholas Seckar] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1211 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-18 15:43:07 +00:00
David Heinemeier Hansson
806cf6d76a Added assert_tag and assert_no_tag as a much improved alternative to the deprecated assert_template_xpath_match #1126 [Jamis Buck] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1195 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-17 16:43:48 +00:00
David Heinemeier Hansson
dca7efa67e Deprecated the majority of all the testing assertions and replaced them with a much smaller core and access to all the collections the old assertions relied on. That way the regular test/unit assertions can be used against these. Added documentation about how to use it all. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1189 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-17 11:38:01 +00:00
David Heinemeier Hansson
e5b3d08a0a Added that render_partial called from a controller will use the action name as default #828 [Dan Peterson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1182 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-17 09:25:54 +00:00
David Heinemeier Hansson
68dfe3e046 Clean up load paths to avoid unit test interaction #1113 [alles@atomicobject.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1174 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-17 06:16:00 +00:00
David Heinemeier Hansson
7f558cbd05 Fixed that *rest parameter in map.connect couldn't accept an empty list #1037 [Dee.Zsombor@gmail.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1158 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-13 05:35:51 +00:00
David Heinemeier Hansson
4ab40059b7 Added simulation of @request.request_uri in functional tests #1038 [Jamis Buck] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1103 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-07 06:22:19 +00:00
David Heinemeier Hansson
7c8d2f28e1 Removed broken attempt to DRY module ClassMethod #970 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1069 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-02 09:29:43 +00:00
David Heinemeier Hansson
ce96c5b30b Added assert_no_cookie and fixed assert_cookie_equal to deal with non-existing cookies #979 [bitsweat] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1065 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-02 08:54:25 +00:00
David Heinemeier Hansson
00121b2ca2 Added :method option to verify for ensuring that either GET, POST, etc is allowed #984 [Jamis Buck] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1060 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-02 08:33:30 +00:00
David Heinemeier Hansson
9fb6a54a16 Added fourth option to process in test cases to specify the content of the flash #949 [Jamis Buck] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1009 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-03-26 21:43:25 +00:00
David Heinemeier Hansson
f569a14318 Added Verifications that allows you to specify preconditions to actions in form of statements like <tt>verify :only => :update_post, :params => "admin_privileges", :redirect_to => { :action => "settings" }</tt>, which ensure that the update_post action is only called if admin_privileges is available as a parameter -- otherwise the user is redirected to settings. #897 [Jamis Buck] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1008 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-03-26 21:41:10 +00:00
David Heinemeier Hansson
a5b55c6b9f Removed old UrlWriter methods that are no longer in use after Routes #942 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@999 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-03-26 13:31:01 +00:00
David Heinemeier Hansson
b88fa4d1df Routes: *path items should use arrays #883 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@954 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-03-21 00:40:51 +00:00
David Heinemeier Hansson
0919dbf6b6 Routes: Convert results of #to_param to strings #879 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@947 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-03-20 22:44:12 +00:00
David Heinemeier Hansson
a61360688c Changed .htaccess to allow dispatch.* to be called from a sub-directory as part of the push with Action Pack to make Rails work on non-vhost setups #826 [Nicholas Seckar/Tobias Luetke] Fixed routing and helpers to make Rails work on non-vhost setups #826 [Nicholas Seckar/Tobias Luetke] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@945 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-03-20 22:02:22 +00:00
David Heinemeier Hansson
a35cf348bf Added a much improved Flash module that allows for finer-grained control on expiration and allows you to flash the current action #839 [Caio Chassot] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@942 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-03-20 19:12:53 +00:00
David Heinemeier Hansson
37a46151ec Added path collection syntax for Routes that will gobble up the rest of the url and pass it on to the controller #830 [rayners] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@927 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-03-20 14:04:33 +00:00
David Heinemeier Hansson
193edfbfdb Removed the reliance on PATH_INFO as it was causing problems for caching and inhibited the new non-vhost support #822 [Nicholas Seckar] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@901 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-03-14 00:25:24 +00:00
David Heinemeier Hansson
688f0f6712 Fixed that map.connect should convert arguments to strings #780 [Nicholas Seckar] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@855 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-03-06 14:16:25 +00:00
David Heinemeier Hansson
28a11969ce Fix request.path_info and clear up LoadingModule behavior #754 [Nicholas Seckar] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@817 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-03-01 02:04:54 +00:00
David Heinemeier Hansson
630638b00e Fixed that Routes would raise NameErrors if a controller component contains characters that are not valid constant names #733 [Nicholas Seckar] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@803 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-02-27 17:12:35 +00:00
David Heinemeier Hansson
8cddbf0d37 Added PATH_INFO access from the request that allows urls like the following to be interpreted by rails: http://www.example.com/dispatcher.cgi/controller/action -- that makes it possible to use rails as a CGI under lighttpd and would also allow (for example) Rublog to be ported to rails without breaking existing links to Rublog-powered blogs. #728 [Jamis Buck] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@802 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-02-27 17:11:05 +00:00
David Heinemeier Hansson
02df588cf7 Fixed tests 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@786 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-02-24 11:50:59 +00:00
David Heinemeier Hansson
b7889524bf Fix empty url_for with nested modules #707 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@782 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-02-24 01:38:10 +00:00
David Heinemeier Hansson
11a2bb91f5 Added some unit tests #706 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@775 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-02-23 23:53:55 +00:00
David Heinemeier Hansson
41ea6963a3 Added Base#render_to_string to parse a template and get the result back as a string #479 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@766 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-02-23 14:57:08 +00:00
David Heinemeier Hansson
cd689cf22b Fixed some tests 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@757 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-02-23 12:52:38 +00:00
David Heinemeier Hansson
f153f42469 Never end generated paths with a '/' #683 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@717 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-02-20 20:54:40 +00:00
David Heinemeier Hansson
acb3d2cf75 Fixed internal calling 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@707 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-02-20 00:02:02 +00:00
David Heinemeier Hansson
cf6d77600a Tests and tweaks for components 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@706 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-02-19 23:51:59 +00:00
David Heinemeier Hansson
0011116592 Unit tests for rendering components 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@705 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-02-19 23:49:12 +00:00