github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-01-30 16:58:15 -05:00
Code Issues Packages Projects Releases Wiki Activity
4,347 Commits 34 Branches 105 Tags
ee8121fc7691eea954fb431bc604e82eeb982bf5
Commit Graph

69 Commits

Author SHA1 Message Date
Jeremy Kemper
0342393b30 Multipart form values may have a content type without being treated as uploaded files if they do not provide a filename. Closes #6401. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5473 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-11-09 18:52:19 +00:00
David Heinemeier Hansson
f366eb4b2d GET parameter keys can be escaped too [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5318 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-17 22:06:54 +00:00
David Heinemeier Hansson
54c393f5fa Hash.create_from_xml has been renamed to Hash.from_xml, alias will exist until Rails 2.0 [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5149 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-20 09:34:29 +00:00
Jeremy Kemper
7661c2b50a Skip params with empty names, such as the &=Save query string from <input type=submit/>. Closes #2569. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5094 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-12 20:57:09 +00:00
Jeremy Kemper
f1b639cffb Update descriptive messages for exceptions thrown by cgi_methods. Closes #6103. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5070 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-08 07:25:14 +00:00
Nicholas Seckar
9d9ac01c7d Add descriptive messages to the exceptions thrown by cgi_methods. Closes #6091. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5066 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-07 20:10:14 +00:00
Jeremy Kemper
12ff554cd4 Tighten rescue clauses. Closes #5985. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4885 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-08-31 03:16:28 +00:00
Nicholas Seckar
d34a346d9d Switch to using FormEncodedPairParser for parsing request parameters. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4866 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-08-30 05:50:02 +00:00
David Heinemeier Hansson
d164d09649 FormEncodedStringParser needs a tad more work before it can handle POST data (like file handling), so were backing out for a bit 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4833 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-08-28 14:05:05 +00:00
David Heinemeier Hansson
7b34d0f8c5 Actually, indifferent access mattered in the bowels (hashes hidden in arrays) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4823 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-08-26 03:09:32 +00:00
David Heinemeier Hansson
a78519071c Result is made indifferent on the way out 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4822 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-08-26 02:58:55 +00:00
David Heinemeier Hansson
04fda65306 Changed the POST parameter processing to use the new QueryStringParser and make the result a indifferent hash [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4821 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-08-26 02:49:09 +00:00
David Heinemeier Hansson
6b5ef885d9 The white space inquisition is coming for you! 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4661 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-08-04 16:47:48 +00:00
Nicholas Seckar
f39180eded Fix broken query parameter tests 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4660 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-08-04 16:03:21 +00:00
Jeremy Kemper
71234daef1 r4487@asus: jeremy | 2006-04-29 12:21:39 -0700 
Check whether @flash is defined? for warnings-safety.
 r4488@asus:  jeremy | 2006-04-29 12:23:15 -0700
 Check whether @flash is defined? for warnings-safety. Obviates nil? check.
 r4489@asus:  jeremy | 2006-04-29 12:45:18 -0700
 Check whether @session is defined? for warnings-safety.
 r4490@asus:  jeremy | 2006-04-29 12:50:41 -0700
 Check whether @rendering_runtime is defined? for warnings-safety.
 r4491@asus:  jeremy | 2006-04-29 12:55:01 -0700
 Check whether @_cycles is defined? for warnings-safety.
 r4492@asus:  jeremy | 2006-04-29 12:59:19 -0700
 Check whether instance variables are defined? for warnings-safety.
 r4493@asus:  jeremy | 2006-04-29 13:14:09 -0700
 Add nil @template to PrototypeHelperTest to suppress unitialized instance variable warning.
 r4494@asus:  jeremy | 2006-04-29 13:31:34 -0700
 Check whether @auto_index defined? for warnings-safety.
 r4495@asus:  jeremy | 2006-04-29 13:32:24 -0700
 Wrap content_columns redefinitions with silence_warnings.
 r4496@asus:  jeremy | 2006-04-29 13:35:28 -0700
 Wrap more redefinitions with silence_warnings.
 r4829@asus:  jeremy | 2006-07-08 10:59:20 -0700
 abstract unit, fix warnings
 r4830@asus:  jeremy | 2006-07-08 11:06:12 -0700
 Use parens to silence warning.
 r4831@asus:  jeremy | 2006-07-08 11:06:48 -0700
 Use parens to silence warning.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4595 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-07-08 18:14:49 +00:00
Jeremy Kemper
d0526ede40 r4748@asus: jeremy | 2006-06-29 22:40:35 -0700 
Loosen urlencoded content type check.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4524 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-30 05:41:03 +00:00
David Heinemeier Hansson
bdac94e990 Fixed proper form-encoded parameter parsing for requests with "Content-Type: application/x-www-form-urlencoded; charset=utf-8" (note the presence of a charset directive) [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4522 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-30 05:19:15 +00:00
Marcel Molina
c02d1f7d9b Fix CGI extensions when they expect string but get nil in Windows. Closes #5276 [mislav@nippur.irb.hr] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4499 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-28 13:51:25 +00:00
David Heinemeier Hansson
36dc94a6a1 Added Hash.create_from_xml(string) which will create a hash from a XML string and even typecast if possible [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4453 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-16 10:07:13 +00:00
Jeremy Kemper
8cdf9126d3 Rewind readable CGI params so others may reread them (such as CGI::Session when passing the session id in a multipart form). Closes #210. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4410 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-02 06:30:23 +00:00
Jeremy Kemper
ce99c87551 Cope with missing content type and length headers. Parse parameters from multipart and urlencoded request bodies only. Accept multipart PUT parameters. Closes #5235. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4388 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-01 00:01:48 +00:00
Michael Koziarski
ff96498848 performance enhancement for previous patch [skaes] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4344 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-05-16 21:09:41 +00:00
Michael Koziarski
d153525c53 Fix NoMethodError when parsing params like &&. [Adam Greenfield]. Closes #4955 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4343 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-05-16 20:56:41 +00:00
Jamis Buck
79a82e3a97 Make sure xml_simple requests don't blow up if an empty request body is recieved 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3936 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-18 18:56:19 +00:00
Jamis Buck
459559a8bc XML-formatted requests are typecast according to "type" attributes for :xml_simple 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3915 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-18 05:07:27 +00:00
Jamis Buck
1340eb1a7e Be sure to look at array elements when dasherizing keys of a formatted request 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3904 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-17 23:15:20 +00:00
Jamis Buck
2429074075 Underscore dasherized keys in formatted requests 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3878 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-15 21:46:41 +00:00
Jamis Buck
4ba5aa257b use "mime_type" instead of "format" 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3874 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-15 18:04:24 +00:00
David Heinemeier Hansson
de37f7df4f Mime types are separated by a comma, not semicolon, in the Accept header. Also switch all internal configuration of mime types away from strings and over to Mime::Type [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3847 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-12 16:03:44 +00:00
David Heinemeier Hansson
6fd737b76b Proper options for XmlSimple 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3808 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-07 04:52:49 +00:00
David Heinemeier Hansson
dc4b5cff39 XmlSimple _should_ be the default since XmlNode is not compatible with regular parameters -- also known as Why Did My Etech Demo Not Work? [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3806 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-07 04:42:13 +00:00
Tobias Lütke
0635f633cc ActionController::Base.param_parsers now accept symbols. currently supported are :xml_node, :xml_simple and :yaml 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3778 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-05 19:16:55 +00:00
Tobias Lütke
03d37a2d68 Added new infrastructure support for REST webservices. 
By default application/xml posts are handled by creating a XmlNode object with the same name as the root element of the submitted xml. M$

 ActionController::Base.param_parsers['application/atom+xml'] = Proc.new do |data|
    node = REXML::Document.new(post)
   { node.root.name => node.root }
 end

 XmlSimple and Yaml web services were retired, ActionController::Base.param_parsers carries an example which shows how to get this functio$
 request.[formatted_post?, xml_post?, yaml_post? and post_format] were all deprecated in favor of request.content_type [Tobias Luetke]

Closes #4081


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3777 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-05 18:59:58 +00:00
Marcel Molina
489ace60fb Remove Upload Progress. Closes #2871. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3406 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-01-13 04:27:53 +00:00
Sam Stephenson
ede2a222ee Strip out trailing &_= for raw post bodies #2868 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3137 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-21 08:04:28 +00:00
Jeremy Kemper
08fd13d17c Handle cookie parsing irregularity for certain Nokia phones. Closes #2530. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3039 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-15 07:51:09 +00:00
Nicholas Seckar
0b1abc3360 Undo condition change made in [2345] to prevent normal parameters arriving as StringIO. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2379 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-27 23:39:56 +00:00
Jeremy Kemper
17d2732b1c Ticket #2295 - Tolerate consecutive delimiters in query parameters 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2375 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-27 22:23:37 +00:00
Jeremy Kemper
9852197f83 r3573@asus: jeremy | 2005-09-26 11:38:44 -0700 
Ticket 1507 - IE file uploads give the filename as a full Windows path, but Ruby on UNIX doesn't know how to File.basename('C:\\blah\blah.foo').
 r3574@asus:  jeremy | 2005-09-26 14:32:11 -0700
 Get rid of constant redefine warning.
 r3575@asus:  jeremy | 2005-09-26 14:33:07 -0700
 Override the file upload's original_filename singleton method in CGIMethods.get_typed_value.
 r3576@asus:  jeremy | 2005-09-26 14:33:49 -0700
 Unit test overridden original_filename against normal filenames and full Windows paths.
 r3577@asus:  jeremy | 2005-09-26 14:33:57 -0700
 Update change log.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2345 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-26 17:59:46 +00:00
David Heinemeier Hansson
b37d7a70f9 Speed up cookie use by decreasing string copying #2194 [skae] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2245 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-15 05:30:56 +00:00
Nicholas Seckar
689cca132a Performance improvements to CGI methods. Closes #1980 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2151 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-08 11:28:54 +00:00
Jamis Buck
89550ee7e9 Use chop! instead of chop! for efficiency 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2109 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-02 18:01:26 +00:00
Jamis Buck
62ec1a5373 Drop trailing \000 if present on RAW_POST_DATA (works around bug in Safari Ajax implementation) #918 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2106 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-02 14:40:33 +00:00
David Heinemeier Hansson
eddd7c453b Fix that env_qs might be nil 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1907 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-23 09:18:16 +00:00
David Heinemeier Hansson
d554227411 Fix that env_qs might be nil 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1906 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-23 09:16:35 +00:00
David Heinemeier Hansson
b366dbd952 Improved performance with 5-30% through a series of Action Pack optimizations #1811 [Stefan Kaes] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1905 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-23 09:00:05 +00:00
David Heinemeier Hansson
128e352614 Fixed that hashes was not working properly when passed by GET to lighttpd #849 [Nicholas Seckar] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1677 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-04 19:21:48 +00:00
Jamis Buck
fcdcd9b9fa Hashes sent via multipart post should be converted to strings #1032 [me@julik.nl] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1664 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-04 15:31:37 +00:00
David Heinemeier Hansson
5651a69130 Load models and frequency typo on upoad progress #1555 [Sean Treadway] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1580 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-01 08:31:30 +00:00
David Heinemeier Hansson
beffb77e05 Added support for upload progress indicators in Apache and lighttpd 1.4.x (won't work in WEBrick or lighttpd 1.3.x) #1475 [Sean Treadway] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1553 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-28 17:44:16 +00:00