github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity
24,246 Commits 34 Branches 105 Tags
f445bb26715406a5718bbf4652bbfa4d8be0b60d
Commit Graph

7291 Commits

Author SHA1 Message Date
Aaron Patterson
f445bb2671 fixing wildcard path matching when wildcard is inside parenthesis 2011-08-13 16:22:19 -07:00
Santiago Pastorino
1d64041d59 Remove blank line 2011-08-13 16:22:19 -07:00
thoefer
39183f4ede refactored 'assert_redirected_to': local call to validate_request! will be called in assert_response already. changed names of local variables in order to recognize the semantics a bit easier. 2011-08-13 16:22:18 -07:00
Dan Gebhardt
28daa8bd4b added test case for fix to issue #2094 2011-08-13 16:22:18 -07:00
Dan Gebhardt
f87b33daaf fixed problem in which options[:html][:remote] would be overridden in form_for() - fixes #2094 2011-08-13 16:22:18 -07:00
Damien Mathieu
838ec4b645 use sprocket's append_path and assert_match 2011-08-13 16:22:17 -07:00
Santiago Pastorino
16e3c40426 use_sprockets is not used anymore 2011-08-13 16:22:16 -07:00
Santiago Pastorino
33ee3898ef Bump sprockets up 2011-08-13 16:22:16 -07:00
Santiago Pastorino
cd5f54cfb6 Bump rack up. Closes #2107 2011-08-13 16:22:16 -07:00
Erik Michaels-Ober
710c5eaf2f Allow a route to have :format => true 
When format is true, it is mandatory (as opposed to :format => false).
This is currently not possible with resource routes, which automatically
make format optional by default.
 2011-08-13 16:22:15 -07:00
Santiago Pastorino
5b5b22acb5 Remove unused use_sprockets config 2011-08-13 16:22:15 -07:00
Rashmi Yadav
111347f0cc The trailing '/' isn't being picked up by Github anyway, and the link works as is. 2011-08-13 16:22:15 -07:00
Vijay Dev
b57773c738 document meta method 2011-07-29 01:13:58 +05:30
Santiago Pastorino
8e0061128e Merge pull request #2245 from davidtrogers/constraints_block_passed_to_following_routes_in_same_scope 
Memoizing @blocks & disposing of constraints options properly
 2011-07-25 10:32:31 -07:00
Dave Rogers
4dc42f5353 Ensure the constraints block is only applied to the correct route 
addresses issue #1907 - any routes that follow a route with a constraints
  block are inheriting the previous route's constraints.
 2011-07-25 09:59:53 -07:00
Aaron Patterson
36fd3fdf46 no need for an anonymous class on every setup call 2011-07-25 09:07:46 -07:00
José Valim
b033a24814 Merge pull request #2258 from thedarkone/no-file-stat 
Use shorter class-level File methods instead of going through File.stat
 2011-07-25 08:13:21 -07:00
thedarkone
624b118616 Use shorter class-level File methods instead of going through File.stat. 2011-07-25 17:02:28 +02:00
thedarkone
036f77574d Make polymorphic_url calls go through application helpers again. 
This brings back the ability to overwrite/extend url generating methods in application heleprs.
 2011-07-25 13:43:02 +02:00
Xavier Noria
12034516e2 Merge pull request #2243 from dmathieu/comment 
Help the next guy with explanations - See bb3b3e306
 2011-07-24 14:02:36 -07:00
Andrew White
0599e16dd9 Use top level Rails constant 2011-07-24 21:48:56 +01:00
Xavier Noria
4bb0a8bcbd Merge branch 'master' of git://github.com/lifo/docrails 2011-07-24 21:02:51 +02:00
Damien Mathieu
ee56f7b8df help the next guy with explanations - See bb3b3e306 2011-07-24 20:52:08 +02:00
Oemuer Oezkir
ee5cfdf120 Missed a few instances of British English spelling in the last commit 
oh and obviously I meant according to Webster, not Weber
 2011-07-24 10:40:40 +00:00
Oemuer Oezkir
71d18ce48e Changed a few instances of of words in the API docs written in British English to 
American English(according to Weber)
 2011-07-24 10:21:42 +00:00
Aaron Patterson
d33eb07543 Merge pull request #2233 from gramos/fix-issue-1951-master 
Fix issue 1951 master Namespaced model partial_path is wrong in namespaced controllers
 2011-07-23 21:00:11 -07:00
Aaron Patterson
d89a33d162 just use normal ruby for stubbing 2011-07-23 20:55:29 -07:00
Gaston Ramos
dc1b0fd957 - added ActionView::PartialRenderer#merge_path_into_partial(path, partial) 
fix issues/1951
 2011-07-24 00:54:58 -03:00
Gaston Ramos
7621d131d2 - added test case for issue: 
https://github.com/rails/rails/issues/1951
  Namespaced model partial_path is wrong in namespaced controllers
 2011-07-24 00:54:45 -03:00
Aaron Patterson
9327b4de58 Merge pull request #2228 from Empact/helper_tags_in_mailers 
Simple fix to the NoMethodError noted in #2177.
 2011-07-23 20:40:12 -07:00
Ben Woosley
1f89898175 Simple fix to the NoMethodError noted in #2177. 
Unfortunately #respond_to?(:controller) won't work as suggested, nor will respond_to?(:params), as #controller is present and #params is delegated to #controller. #delegate makes respond_to? return true regardless whether the target responds to it.
 2011-07-23 17:31:48 -07:00
Damien Mathieu
bb3b3e3062 rake assets:precompile should always perform caching - Closes #2199 2011-07-24 01:32:14 +02:00
gnagno
72df64b4e1 now the documentation reflects the actual returned value for a missing translation 2011-07-23 08:26:18 -07:00
Xavier Noria
d352e0dff2 checked all .rb files in the project tree for missing magic comments, one was missing 
Came with this one-liner for this:

    find . -name '*.rb' | \
    xargs chardet | \
    grep -v ascii | \
    cut -d: -f1 -s | \
    xargs -n1 ruby -0777 -ne 'puts $FILENAME if $_ !~ /#.*coding:\s*utf/i'

Welcome $_.
 2011-07-23 14:50:29 +02:00
Xavier Noria
ace3723d2f Merge branch 'master' of git://github.com/lifo/docrails 2011-07-23 12:15:41 +02:00
Xavier Noria
38310ab1a6 little details seen while doing a pass through what's new in docrails 2011-07-23 12:14:10 +02:00
Aaron Patterson
5b6121aa34 use rake tasks to set the default environment variables. fixes #2126 2011-07-21 15:30:28 -07:00
Ray Baxter
18792069ab use the doc conventions for arguments in all cases 
See 5c71a4e768 (commitcomment-485675)
 2011-07-20 23:33:42 -07:00
ogeidix
1ac802fe3c Check Accept and Content-Type headers before evaluating them in xhr requests. Closes #2119 
An xhr request must have an "Accept" or "Content-type" header in order to be considered a request with valid_accept_header.
 2011-07-19 22:05:16 +02:00
Paul Battley
01c2a989f1 Update form helper documentation to match code. 
Change d3cfee11 removed the automatically generated object_name_submit id attributes on form submit elements. This makes the documentation match.
 2011-07-19 20:31:19 +01:00
Vijay Dev
d275a98446 add entry for submit helper change removing object_name_id 2011-07-20 00:39:23 +05:30
Vijay Dev
4719543c80 reword select_date's behaviour clearly when an incomplete options array is passed 2011-07-20 00:03:28 +05:30
Vijay Dev
4885e5d3eb minor corrections in form helpers guide and api docs 2011-07-20 00:03:28 +05:30
Jesse Storimer
ac81af40c0 Ensure that status codes are logged properly 
Needed to move AC::Metal::Instrumentation before AM::Metal::Rescue
so that status codes rendered from rescue_from blocks are logged
properly.
 2011-07-18 13:42:07 -04:00
Aaron Patterson
1e452f1840 make tzinfo a development dependency 2011-07-18 14:28:14 +09:00
Santiago Pastorino
adc7097dc0 Merge pull request #2124 from arunagw/render_partial_invalid_check_fix 
Checking with to_s. As regexp fail with 1.8.7
 2011-07-17 20:14:12 -07:00
Jon Leighton
fcbde454f6 Don't do remove_possible_method when delegate is used. Two reasons: 1) warnings should be shown, and fixed at the source and 2) the code is slow. Fixes #1937. 2011-07-18 00:22:26 +01:00
Ray Baxter
82569b3827 examples for telephone_field, url_field and email_field 2011-07-17 13:10:17 -07:00
Ray Baxter
65b19c3633 document options to search_field 2011-07-17 13:08:02 -07:00
Arun Agrawal
d4f4626940 Checking with to_s. As regexp fail with 1.8.7 2011-07-18 01:27:38 +05:30