Joshua Peek
3dd3ffde06
Depend on rack 0.4.0 instead of vendoring it
2008-11-25 13:20:12 -06:00
Joshua Peek
d4754677a3
Deprecate assert_valid
2008-11-25 12:32:14 -06:00
Joshua Peek
759183c822
Ensure ActionView will be available to ActionMailer if ActionController is not loaded
2008-11-25 10:38:20 -06:00
Craig Davey
f8558798d4
Ensure all HTML:: constants are available to autoload [ #1462 state:resolved]
...
Signed-off-by: Joshua Peek <josh@joshpeek.com >
2008-11-25 10:05:59 -06:00
Jeremy Kemper
565fad350e
Ruby 1.9 compat: explicitly require delegate for cookie's DelegateClass
2008-11-24 12:05:17 -08:00
Geoff Garside
eac16d0ee1
Reorder the way in which map.resource routes are added to the set. This prevents the singular named route from hitting :create instead of :show.
...
Signed-off-by: Michael Koziarski <michael@koziarski.com >
2008-11-24 19:19:55 +01:00
Joshua Peek
a76351093c
helpers require dependencies
2008-11-24 12:17:07 -06:00
Joshua Peek
426a86ab1e
prefer autoloaded html scanner
2008-11-24 10:20:41 -06:00
Joshua Peek
5ffd1e0c02
Ensure integration test is load in script/console [ #1452 state:resolved]
2008-11-24 09:58:52 -06:00
Jeremy Kemper
2dd0ec48a5
Autoload HTML::Document and sanitizers
2008-11-23 19:12:00 -08:00
Jeremy Kemper
fb4bb93d43
Drop unneeded drb require
2008-11-23 18:29:38 -08:00
Joshua Peek
31ce92f7b5
Use autoload instead of explicit requires for ActionController
2008-11-23 16:35:47 -06:00
Michael Koziarski
04d2d043ca
Move the cookie store to use the MessageVerifier class.
...
This removes support for ancient cookie-store generated cookies which were double escaped.
2008-11-23 16:42:15 +01:00
Michael Koziarski
9fdb15e60f
Change the forgery token implementation to just be a simple random string.
...
This deprecates the use of :secret and :digest which were only needed when we were hashing session ids.
2008-11-23 14:28:34 +01:00
Sam Pohlenz
5ea9f2cac6
Allow helpers directory to be overridden via ActionController::Base.helpers_dir (Sam Pohlenz) [ #1424 state:committed]
...
Signed-off-by: David Heinemeier Hansson <david@loudthinking.com >
2008-11-23 13:42:53 +01:00
Jeremy Kemper
4d2ccbb364
Use a relative require for bundled rack lib
2008-11-22 22:40:32 -08:00
Joshua Peek
cc67272cba
Vendor rack 0.4.0
2008-11-22 14:33:00 -06:00
Joshua Peek
20d6fdd256
write_fragment returns content if caching is disabled [ #846 state:resolved]
2008-11-22 13:19:11 -06:00
Lance Ivy
cd1a9ed991
Add TestResponse#client_error? to check for 4xx status codes [ #851 state:resolved]
...
Signed-off-by: Joshua Peek <josh@joshpeek.com >
2008-11-22 13:10:12 -06:00
David Heinemeier Hansson
f42c77f927
Added ActiveSupport::BacktraceCleaner and Rails::BacktraceCleaner for cutting down on backtrace noise (inspired by the Thoughtbot Quiet Backtrace plugin) [DHH]
2008-11-22 18:06:08 +01:00
David Heinemeier Hansson
a026b4c983
Let ApplicationController stay unloaded for as long as possible
2008-11-22 13:24:37 +01:00
Jeremy Kemper
ebdbd854a9
Fix straggling references to Test::Unit::TestCase
2008-11-20 13:47:36 -08:00
Pratik Naik
dbbaccbcda
Revert "Simplify benchmarking and rescue". Need a different approach.
...
This reverts commit 3be9134d1c
2008-11-20 04:50:34 +05:30
Pratik Naik
3be9134d1c
Simplify benchmarking and rescue
2008-11-20 04:17:48 +05:30
Pratik Naik
aeae79dc45
Remove deprecated ActionController::Base#assign_default_content_type_and_charset
2008-11-19 22:25:08 +05:30
Pratik Naik
27c03e69e9
Remove deprecated render_component. Please use the plugin from http://github.com/rails/render_component/tree/master
2008-11-19 17:48:57 +05:30
Hiroshi Saito
291d199de1
Let polymorphic_path treat an array contains single name as without array [ #1386 state:committed]
...
Signed-off-by: David Heinemeier Hansson <david@loudthinking.com >
2008-11-19 12:07:12 +01:00
Gabe da Silveira
917428bcce
Make optimized named routes respect all reserved options and tie it into UrlRewriter::RESERVED_OPTIONS so it's DRY
...
Signed-off-by: Michael Koziarski <michael@koziarski.com >
2008-11-18 22:47:33 +01:00
David Heinemeier Hansson
fcce1f17ea
BACKWARDS INCOMPATIBLE: Renamed application.rb to application_controller.rb and removed all the special casing that was in place to support the former. You must do this rename in your own application when you upgrade to this version [DHH]
2008-11-17 19:27:35 +01:00
Michael Koziarski
8c197fb4ab
Add text/plain to the browser_generated_types array as webkit and gecko can submit them.
...
For more information see:
http://pseudo-flaw.net/content/web-browsers/form-data-encoding-roundup/
2008-11-16 20:24:46 +01:00
Jeremy Kemper
eeea1a26ec
Merge branch 'master' into testing
2008-11-15 12:21:04 -08:00
Pratik Naik
c70b993a9e
Merge docrails.
2008-11-14 17:47:21 +05:30
Tom Stuart
2ecec6052f
Make inheritance of map.resources :only/:except options behave more predictably
...
Signed-off-by: Michael Koziarski <michael@koziarski.com >
2008-11-14 12:26:43 +01:00
hiroshi
94d6716324
Make polymorphic_url compact given array [ #1317 state:committed]
...
Signed-off-by: David Heinemeier Hansson <david@loudthinking.com >
2008-11-14 12:07:52 +01:00
Tom Stuart
4c09210244
Fix map.resources to always generate named routes if they're needed
...
Signed-off-by: Michael Koziarski <michael@koziarski.com >
2008-11-13 17:49:09 +01:00
Michael Koziarski
f1ad8b48aa
Instead of overriding html_types, base the verification on browser_generated_types.
...
Also Deprecate the old unverifiable types.
[#1145 state:committed]
2008-11-13 11:23:34 +01:00
rick
00c46b5eeb
fix two MimeType failing test cases
...
Signed-off-by: Michael Koziarski <michael@koziarski.com >
2008-11-13 11:23:34 +01:00
Jeff Cohen
fbbcd6f29a
Changed request forgery protection to only worry about HTML-formatted content requests.
...
Signed-off-by: Michael Koziarski <michael@koziarski.com >
2008-11-13 11:23:21 +01:00
Tom Stuart
44a3009ff0
Add :only/:except options to map.resources
...
This allows people with huge numbers of resource routes to cut down on the memory consumption caused by the generated code.
Signed-off-by: Michael Koziarski <michael@koziarski.com >
[#1215 state:committed]
2008-11-12 12:57:58 +01:00
Jeremy Kemper
5d2b5ba23e
Merge branch 'master' into testing
2008-11-11 10:22:09 -08:00
Jeremy Kemper
278b6cd952
Eliminate excess Regexp creation due to capture counting
2008-11-10 22:21:09 -08:00
Jeremy Kemper
5db9f9b3ad
Pare down object creation during route building
2008-11-10 22:21:09 -08:00
Jeremy Kemper
0994d11f26
Merge branch 'master' into testing
2008-11-07 19:55:29 -05:00
Nick Sieger
529c271699
Simplify dispatcher callbacks to eliminate unnecessary stale thread purging. [Nick Sieger, Pratik Naik]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2008-11-08 03:49:54 +05:30
Jeremy Kemper
c82e8e1f48
Move controller assertions from base TestCase to AC:: and AV::TestCase
2008-11-07 15:42:34 -05:00
Jeremy Kemper
d355921709
Remove controller assertions from Test::Unit::TestCase. Use ActionController::TestCase.
2008-11-07 13:27:06 -05:00
Aliaksey Kandratsenka
099f10679e
Don't eval recognize_optimized use __FILE__ and __LINE__ in the optimised recognition code.
...
It produces meaningless line numbers. This also easily produces line numbers greater than recognition_optimization.rb have, which causes rcov to trash memory outside of it's coverage counting arrays.
[#1319 state:committed]
Signed-off-by: Michael Koziarski <michael@koziarski.com >
2008-11-06 19:52:44 +00:00
Michael Koziarski
af5b304a40
Fix stupid typo
2008-11-06 18:52:02 +00:00
David Heinemeier Hansson
a358d87e16
Fixed the sanitize helper to avoid double escaping already properly escaped entities [ #683 state:committed]
2008-11-06 13:02:32 +01:00
David Heinemeier Hansson
55707da1a1
Dont bother logging the parameters hash if there are no parameters
2008-11-06 09:59:11 +01:00
