github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity
24,732 Commits 34 Branches 105 Tags
f7f9003cd54a697fbacebb01675dc6a7467fbf88
Commit Graph

6182 Commits

Author SHA1 Message Date
Andrew White
14cf4b2e35 Don't modify params in place - fixes #2624 2011-08-23 11:07:37 +01:00
Santiago Pastorino
0b6da0c654 Merge pull request #2411 from ai/debug_assets_by_config 
Debug assets by config
 2011-08-22 11:50:27 -07:00
Guillermo Iguaran
e1f11ff37f Fix Sprockets rewrite_asset_path 2011-08-22 11:12:54 -05:00
Daniel Schierbeck
db181bddb6 Refactor Sprockets::Helpers::RailsHelper#performing_caching? 
No need for them lines to get so long! Also, move that comment into
the method body where it belongs!
 2011-08-22 16:50:33 +02:00
Aaron Patterson
aae5ebf3eb Merge pull request #2618 from FLOChip/unicode_j 
fix escape_javascript for unicode character \u2028.
 2011-08-21 18:42:17 -07:00
Andrey A.I. Sitnik
18b2223b32 Allow to debug assets by config.assets.debug 2011-08-22 09:36:36 +11:00
Joshua Peek
63d3809e31 Fix sprockets warnings 
Fixes #2598
 2011-08-21 16:42:06 -05:00
Teng Siong Ong
f6ceb944ea fix escape_javascript for unicode character \u2028. 2011-08-21 15:14:45 -05:00
Xavier Noria
f25d65d2fb Merge pull request #2610 from asmega/documentation 
added link to url_for in documentation
 2011-08-21 09:17:47 -07:00
asmega
ebe9155313 Use typewriter styling on url_for in documentation 2011-08-21 16:40:56 +01:00
Santiago Pastorino
165fb830d0 Merge pull request #2596 from dharmatech/patch-1 
ActionController::Redirecting : fix docs typo
 2011-08-20 14:16:15 -07:00
Santiago Pastorino
71ef72c3d0 Merge pull request #2597 from dharmatech/patch-2 
actionpack/lib/action_controller/base.rb: docs typo
 2011-08-20 14:14:54 -07:00
Vijay Dev
7da70a431c params wrapper docs correction 2011-08-21 00:25:58 +05:30
dharmatech
dfd03fdbd3 actionpack/lib/action_controller/base.rb: docs typo 2011-08-20 00:17:44 -05:00
dharmatech
31d38d37d3 ActionController::Redirecting : fix docs typo 2011-08-20 00:07:34 -05:00
Guillermo Iguaran
7223f10acd Debug assets by default in development and test environments 2011-08-18 15:35:41 -05:00
Xavier Noria
cc90adfd2a minor details revised in a gsub 
Regexps have a construct to express alternation of characters, which
is character classes. In addition to being the most specific idiom to
write this pattern, it reads better without the backslashes. Also, it
is better not to use a capture if none is needed. As a side-effect of
these changes, the gsub is marginally faster, but speed is not the
point of this commit.
 2011-08-18 03:09:18 -07:00
Aaron Patterson
5f94b93279 Properly escape glob characters. 2011-08-16 15:28:27 -07:00
Aaron Patterson
586a944ddd Tags with invalid names should also be stripped in order to prevent 
XSS attacks.  Thanks Sascha Depold for the report.
 2011-08-16 15:24:48 -07:00
Jon Leighton
8e23615245 Use lazy load hooks to set parameter wrapping configuration. This means that it doesn't force Action Controller / Active Record to load, but it doesn't fail if they have already loaded. Thanks @josevalim for the hint. 2011-08-16 19:14:20 +01:00
Jon Leighton
5902391567 Fix assets tests in railties 2011-08-16 16:41:01 +01:00
Jon Leighton
6c5f67cac1 Don't refer to ActionController::Base in the wrap_parameters initializer - use config object instead. Cuts about 15% off the load time. (#734) 2011-08-16 00:59:59 +01:00
Santiago Pastorino
4ca605b71b rake assets:precompile executes in production environment as default if RAILS_ENV was not provided 2011-08-15 15:31:47 -03:00
José Valim
652ab436db Ensure changing RAILS_GROUPS will load the proper dependencies. 2011-08-14 10:52:46 -07:00
Franck Verrot
75dd33a0ae Methods like status and location are interfering with redirect_to [Closes #2511] 2011-08-14 19:00:30 +02:00
Xavier Noria
bf2b9d2de3 Merge branch 'master' of github.com:lifo/docrails 
Conflicts:
	RELEASING_RAILS.rdoc
	actionpack/lib/sprockets/railtie.rb
	actionpack/test/template/sprockets_helper_test.rb
	activerecord/test/cases/calculations_test.rb
	railties/guides/source/3_1_release_notes.textile
	railties/guides/source/active_resource_basics.textile
	railties/guides/source/command_line.textile
 2011-08-13 16:30:07 -07:00
Oge Nnadi
aa0d3cece8 Typo fix 2011-08-13 16:22:35 -07:00
geemus
53e1a9d411 update abstract_controller callbacks to document meta-programmed filters 2011-08-13 16:22:35 -07:00
Casebook Developer
ebfca248f9 ActionView::Helpers::TextHelper#simple_format should not change the text in place. Now it duplicates it. 2011-08-13 16:22:29 -07:00
Waynn Lue
68c4b66015 fix stringify_keys destructive behavior for most FormTagHelper functions 
add four new tests to verify that the other three methods that called stringify_keys! are fixed. verified that the tests break in master without the code patch. Closes #2355
 2011-08-13 16:22:29 -07:00
thoefer
5f3265c471 Fix the issue where default_url_options is being cached on test cases. Closes #1872. Closes #2031. 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2011-08-13 16:22:26 -07:00
José Valim
b6b6e81a5c Rename new method to_path to to_partial_path to avoid conflicts with File#to_path and similar. 2011-08-13 16:22:26 -07:00
Waynn Lue
759815547b remove redundant calls to stringify_keys 2011-08-13 16:22:25 -07:00
Franck Verrot
018b1315b5 We don't need to require erb here. 2011-08-13 16:22:23 -07:00
thedarkone
a53ef97206 Make use of the inherited initializer. 2011-08-13 16:22:23 -07:00
thedarkone
37b30d4b4e There is no need to be destructive with the passed-in options. 
This fixes a bug that is caused by Resource/SingletonResource mangling resource options when using inline "multi"-resource declarations.
 2011-08-13 16:22:23 -07:00
José Valim
554ea3c37b Move the cache to a nested hash which performs better than a hash with array as keys. 2011-08-13 16:22:21 -07:00
José Valim
91ca214ca0 Rename class method to_path to _to_path and make it explicit that it is an internal method. 2011-08-13 16:22:21 -07:00
Grant Hutchins & Peter Jaros
6e671a8536 Let ActiveModel instances define partial paths. 
Deprecate ActiveModel::Name#partial_path. Now you
should call #to_path directly on ActiveModel
instances.
 2011-08-13 16:22:21 -07:00
Joshua Peek
a636a9358e Make Rails.application.assets available in initializers 2011-08-13 16:22:21 -07:00
Christos Zisopoulos
035d31bd93 Improve performance and memory usage for options_for_select with Ruby 1.8.7 2011-08-13 16:22:20 -07:00
Aaron Patterson
ed09aef1a3 simplify conditionals by assuming hash values will never be false 2011-08-13 16:22:19 -07:00
Aaron Patterson
a704fd4ea9 use regular ruby rather than clever ruby 2011-08-13 16:22:19 -07:00
Aaron Patterson
f445bb2671 fixing wildcard path matching when wildcard is inside parenthesis 2011-08-13 16:22:19 -07:00
Santiago Pastorino
1d64041d59 Remove blank line 2011-08-13 16:22:19 -07:00
thoefer
39183f4ede refactored 'assert_redirected_to': local call to validate_request! will be called in assert_response already. changed names of local variables in order to recognize the semantics a bit easier. 2011-08-13 16:22:18 -07:00
Dan Gebhardt
f87b33daaf fixed problem in which options[:html][:remote] would be overridden in form_for() - fixes #2094 2011-08-13 16:22:18 -07:00
Santiago Pastorino
16e3c40426 use_sprockets is not used anymore 2011-08-13 16:22:16 -07:00
Erik Michaels-Ober
710c5eaf2f Allow a route to have :format => true 
When format is true, it is mandatory (as opposed to :format => false).
This is currently not possible with resource routes, which automatically
make format optional by default.
 2011-08-13 16:22:15 -07:00
Santiago Pastorino
5b5b22acb5 Remove unused use_sprockets config 2011-08-13 16:22:15 -07:00