Sven Fuchs
931f366ffc
merge forward to current rails/master
2008-07-16 03:41:11 +02:00
Sven Fuchs
8691e25540
reverting changes to form_options_helper for merge
2008-07-16 03:28:44 +02:00
Joshua Peek
aca246ab25
Get buffer for fragment cache from template's @output_buffer
2008-07-15 14:43:52 -05:00
Michael Koziarski
24a8ae4e08
Try to get more useful errors out of the test_line_offset failures
2008-07-15 20:39:36 +02:00
Jeremy Kemper
3c282f3a0a
Ruby 1.9 compat: only eval with block.binding in 1.9, uses more memory than eval with block
2008-07-15 10:42:50 -07:00
Jeremy Kemper
4d76bad387
Ruby 1.9 compat: account for different String#hash
2008-07-15 10:40:33 -07:00
松田 明
bb33432b0f
Ruby 1.9 compat: call Proc#binding explicitly. [ #623 state:resolved]
2008-07-15 10:39:02 -07:00
Joshua Peek
001c8beb4d
memorize typo
2008-07-14 20:02:59 -05:00
Joshua Peek
dd41f66af5
Include Memoizable in ActionView::Template
2008-07-14 19:51:43 -05:00
Tarmo Tänav
d27dd860c7
Use sub instead of gsub
...
Signed-off-by: Joshua Peek <josh@joshpeek.com >
2008-07-14 18:02:59 -05:00
Joshua Peek
9dc258d614
Eager load Partial variable_name and counter_name. Tidy up render_partial_collection.
2008-07-14 17:40:58 -05:00
Jeremy Kemper
2d6562d51b
Move dead recompile_template? also
2008-07-14 13:51:59 -07:00
Jeremy Kemper
3fbefecc9c
Remove dead code from merge
2008-07-14 13:47:51 -07:00
Jeremy Kemper
4e323f6ef0
Fix bad merge
2008-07-14 11:50:07 -07:00
Jeremy Kemper
425de8db6a
Use instance_method(...) to check whether the method exists
2008-07-14 10:46:15 -07:00
Jeremy Kemper
2167f95d85
Restore the more readable before_ and after_filters methods since they aren't called frequently
2008-07-14 10:11:53 -07:00
rsl
95812d5eaf
Ensure :index works with fields_for select methods. [ #518 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2008-07-14 00:55:57 +01:00
Joshua Peek
68fe898189
Check first render format and extension. Fixes failing ActionMailer test.
2008-07-13 14:05:21 -05:00
Joshua Peek
26bc867151
Small tweak to e0fef66
2008-07-13 14:00:40 -05:00
Joshua Peek
e0fef66149
Made ActionView::Base#first_render a little more private. And added _last_render to track the most recent render. Will fix #609 as a side effect. [ #609 state:resolved]
2008-07-13 13:26:48 -05:00
Joshua Peek
99cc85bc09
Set config.action_view.warn_cache_misses = true to receive a warning if you perform an action that results in an expensive disk operation that could be cached
2008-07-12 15:31:50 -05:00
Joshua Peek
73b34e9f75
Refactor template preloading. New abstractions include Renderable mixins and a refactored Template class.
2008-07-12 14:33:46 -05:00
Joshua Peek
30204c4e66
Set global ActionController::Base.view_paths for test cases
2008-07-12 14:11:51 -05:00
Joshua Peek
65fb2e76f2
Removed a few implementation specific view path tests
2008-07-12 12:17:10 -05:00
Joshua Peek
b603de0882
Improve test coverage and create fixtures for RenderPartialWithRecordIdentificationTests
2008-07-12 12:17:10 -05:00
Michael Koziarski
e53f5fe696
Restore support for partial matches in assert_redirected_to
...
If both the actual redirection and the asserted redirection are hashes, succeed if the asserted redirection is a strict subset of the actual redirection.
2008-07-12 11:42:41 +02:00
Johan Sørensen
50b5c6845e
Ensure mail_to label is obfuscated for javascript encoding. [ #294 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2008-07-12 01:04:18 +01:00
Joshua Peek
6ebdd0e32b
Changed ActionView::TemplateHandler#render API method signature to render(template, local_assigns = {})
2008-07-11 15:40:41 -05:00
Michael Koziarski
6b9f8adb3e
Whitespace
2008-07-11 19:23:21 +02:00
Joshua Peek
04a87af5b7
Ensure use_accept_header is enabled for test_action_cache_conditional_options
2008-07-11 11:51:35 -05:00
Joshua Peek
d106f2d08a
Ensure use_accept_header is enabled for test_action_cache_conditional_options
2008-07-11 11:49:22 -05:00
Joshua Peek
15b2175426
Fixed teardown method typo (plus whitespace)
2008-07-11 11:44:24 -05:00
Joshua Peek
68289693f7
Check for response in builder template since ActionMailer does not have one
2008-07-11 11:14:59 -05:00
Clemens Kofler
feb08984ea
Added notes to Routing documentation and routes.rb regarding defaults routes opening the whole application for GET requests
...
Signed-off-by: Michael Koziarski <michael@koziarski.com >
2008-07-10 09:29:27 +02:00
Jeremy Kemper
d37e641336
Move accept header parsing shortcut to Mime::Type.parse
2008-07-09 11:30:18 -07:00
Jeremy Kemper
0ce7fe5308
Don't repeatedly convert only/except options
2008-07-09 10:42:30 -07:00
Cheah Chu Yeow
ce4a1bb853
Remove some Symbol#to_proc usage in runtime code. [ #484 state:resolved]
2008-07-09 10:42:30 -07:00
Jeremy Kemper
f82bd31cb0
Request#accepts special-cases a single mime type
2008-07-09 10:42:30 -07:00
Jeremy Kemper
a6d0ae28e3
Fix teardown method name typo
2008-07-09 10:42:30 -07:00
Jeremy Kemper
ee6bbcb6ae
Put a newline rather than a semicolon at the end of RJS source to avoid parse errors with embedded heredocs
2008-07-09 10:42:29 -07:00
Jeremy Kemper
7dc10478e5
Use ActionController::Base.logger to report template compilation errors since there is no AV::Base.logger
2008-07-09 10:42:29 -07:00
Jeremy Kemper
4354aa36fb
Rendering default template for missing actions works with non-word characters in action name
2008-07-09 10:42:29 -07:00
Jeremy Kemper
350faf14e8
Pass caller to concat deprecation warning
2008-07-09 10:42:29 -07:00
Michael Koziarski
4ce9931f4f
Reenable the use of the Accept header to give people a chance to update their applications and provide feedback.
2008-07-09 18:36:15 +02:00
David Heinemeier Hansson
6b61e95dc8
Changed PrototypeHelper#submit_to_remote to PrototypeHelper#button_to_remote to stay consistent with link_to_remote (submit_to_remote still works as an alias) (clemens) [ #8994 status:closed]
2008-07-09 09:13:24 -05:00
Cheah Chu Yeow
96708af6a5
Ensure url_for(nil) falls back to url_for({}). [ #472 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2008-07-09 13:02:14 +01:00
Luca Guidi
dc77359c16
Removed unnecessary or condition in #error_messages_for
2008-07-08 17:41:18 +02:00
Damian Janowski
91320f2a80
Add :recursive option to javascript_include_tag and stylesheet_link_tag to be used along with :all. [ #480 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2008-07-08 13:50:59 +01:00
Luca Guidi
cf5d6ab9a8
Added localize helper method
2008-07-08 12:37:49 +02:00
Luca Guidi
2949918b4c
Make sure object name is translated in #error_messages_for
2008-07-08 11:53:19 +02:00
