github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-02-04 19:25:10 -05:00
Code Issues Packages Projects Releases Wiki Activity
7,627 Commits 34 Branches 105 Tags
fc0358ae16d5631dd1d996b2cf95a8987f9d0c8d
Commit Graph

2286 Commits

Author SHA1 Message Date
Iain Hecker
fc0358ae16 Added :value as interpolation variable available to error messages 2008-08-20 17:57:53 +02:00
Sven Fuchs
e43cdb93f0 fix activerecord i18n_test to work with backend classes 2008-08-20 17:57:46 +02:00
Iain Hecker
12d7872071 Introduced AR::Base.human_name to validations 2008-08-20 17:53:04 +02:00
Iain Hecker
81e14fada1 Added Base.human_name method 2008-08-20 17:53:04 +02:00
Iain Hecker
ffeab4e0c1 Cleaned up ActiveRecord i18n scoping 2008-08-14 10:48:33 +02:00
Sven Fuchs
d0ee883e7c fixing unit tests for active_record validations_i18n 2008-08-13 14:02:26 +02:00
Sven Fuchs
e3ecc3375f provide more useful feedback on missing translations for validation error messages 2008-08-13 13:52:07 +02:00
Sven Fuchs
aae9f91659 fix validations_i18n tests for changed locale file format 2008-08-13 10:00:54 +02:00
Sven Fuchs
f26380b775 switch to using I18n.load_translations instead of requiring plain ruby files 2008-08-13 09:53:25 +02:00
Sven Fuchs
bdf783b5a8 update i18n usage for pluralization hashes (api change) 2008-08-10 21:29:02 +02:00
Ernie Miller
7f6e7ba1f7 Fixed AssociationCollection#<< resulting in unexpected values in @target when :uniq => true 
Signed-off-by: Michael Koziarski <michael@koziarski.com>
 2008-08-08 15:19:08 +02:00
Ryan Bates
1db7c9cf4a fixing "test_any_should_not_load_results" so it doesn't depend on latest version of Mocha 
Signed-off-by: Michael Koziarski <michael@koziarski.com>
 2008-08-08 10:33:29 +02:00
Nik Wakelin
0809747845 Added MigrationProxy to defer loading of Migration classes until they are actually required by the migrator 
Signed-off-by: Michael Koziarski <michael@koziarski.com>
[#747 state:resolved]
 2008-08-06 12:46:52 +02:00
Tarmo Tänav
82343859d5 Added missing fixtures for tests which fail to run independently if run after schema reset 
Signed-off-by: Michael Koziarski <michael@koziarski.com>
 2008-08-04 11:50:15 +02:00
Tarmo Tänav
656f0e7c6c Fix file permissions 
Signed-off-by: Joshua Peek <josh@joshpeek.com>
 2008-07-31 16:36:23 -05:00
Tarmo Tänav
f7eaab96d3 validates_uniqueness_of uses database case sensitivity support instead of using ruby 
Signed-off-by: Michael Koziarski <michael@koziarski.com>
 2008-07-31 21:33:11 +02:00
Tarmo Tänav
cb68b21a52 Fixed negative default integer parsing for Postgresql 8.3.3 
Signed-off-by: Michael Koziarski <michael@koziarski.com>
 2008-07-31 20:58:42 +02:00
Tarmo Tänav
68b207b087 Cast value to string in validates_uniqueness_of if the column is of text type 
This fixes an error for postgresql where "text_column = 100" fails in version 8.3

Signed-off-by: Michael Koziarski <michael@koziarski.com>
 2008-07-31 20:28:39 +02:00
Tarmo Tänav
896a3b9ab8 Fixed test_joins_with_namespaced_model_should_use_correct_type for postgresql 
Signed-off-by: Michael Koziarski <michael@koziarski.com>
 2008-07-31 19:02:32 +02:00
miloops
fb5cc19707 Fix HasManyThroughAssociationsTest tests. [#733 state:resolved] 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2008-07-31 17:01:22 +01:00
Pratik Naik
108db00aa9 Raise UnknownAttributeError when unknown attributes are supplied via mass assignment 2008-07-31 15:56:46 +01:00
Pratik Naik
6e75455125 Merge docrails changes 2008-07-28 12:33:24 +01:00
Joshua Peek
490178c930 Revert "Ensure adapater specific code is loaded on ActiveRecord::Base.establish_connection" 
This reverts commit 8b858782fa.
 2008-07-27 16:06:51 -05:00
George Ogata
e8fc894f66 Make observers define #after_find in the model only if needed. 
[#676 state:resolved]
Signed-off-by: Michael Koziarski <michael@koziarski.com>
 2008-07-26 16:26:08 +02:00
Jan De Poorter
93e10f9911 Ensure NamedScope#any? uses COUNT query wherever possible. [#680 state:resolved] 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2008-07-23 12:02:17 +01:00
Joshua Peek
8b858782fa Ensure adapater specific code is loaded on ActiveRecord::Base.establish_connection 2008-07-21 22:41:38 -05:00
Daniel Guettler
c67713a2fe Use klass.sti_name to make sure associations take store_full_sti_class into account. [#671 state:resolved] 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2008-07-22 01:24:47 +01:00
Joshua Peek
3fdd1acab6 Dropped SQLite 2 from default test runner 2008-07-19 11:30:15 -05:00
Tom Ward
f205939348 Ensure checked value is a string when validating case-sensitive uniqueness [#361 state:resolved] 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2008-07-19 16:14:39 +01:00
Joachim Garth
a1fcbd971d Make sure association preloading works with full STI class name [#465 state:Resolved] 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2008-07-18 03:44:44 +01:00
Jeremy Kemper
1e0f94a77c Introduce simple internationalization support 2008-07-17 14:56:12 -07:00
Jeremy Kemper
636e6b7138 Merge branch 'master' into i18n-merge 
Conflicts:

	actionpack/lib/action_view/helpers/form_options_helper.rb
	activerecord/lib/active_record/validations.rb
 2008-07-17 11:52:56 -07:00
Nik Wakelin
bbab639136 Set config.active_record.timestamped_migrations = false to have migrations with numeric prefix instead of UTC timestamp. [#446 state:resolved] 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2008-07-17 02:54:45 +01:00
Pratik Naik
0432d15164 Merge with docrails. 2008-07-16 13:01:23 +01:00
Sven Fuchs
2e74ddbd73 missed to remove a call to to_s while resolving conflicts in validations.rb 2008-07-16 04:35:00 +02:00
Sven Fuchs
931f366ffc merge forward to current rails/master 2008-07-16 03:41:11 +02:00
Stefan Kaes
fbef982e4b Observers not longer add an after_find method to the observed class. 
[#625 state:resolved]
 2008-07-15 16:48:16 -07:00
miloops
459e5817a5 update_counters should update nil values. 
This allows counter columns with default null instead of requiring default 0.

[#493 state:resolved]
 2008-07-15 16:21:11 -07:00
Jonathan Viney
4f72feb84c Move the transaction counter to the connection object rather than maintaining it on the current Thread. 
Signed-off-by: Michael Koziarski <michael@koziarski.com>
[#533 state:resolved]
 2008-07-15 21:25:12 +02:00
Tarmo Tänav
c1531ae00d SQLite: rename_column raises if the column doesn't exist. 
[#622 state:resolved]
 2008-07-14 22:58:22 -07:00
Tarmo Tänav
8c91b767c0 Fixed postgresql limited eager loading for the case where scoped :order was present 2008-07-14 22:44:58 -07:00
Tiago Macedo
76df9fa068 Fix integer quoting issues in association preload. [#602 state:resolved] 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2008-07-14 23:34:19 +01:00
Gabe da Silveira
cd9b24286a Add assert_sql helper method to check for specific SQL output in Active Record test suite. [#325 state:resolved] 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2008-07-14 23:22:39 +01:00
Tarmo Tänav
07578ac855 Fixed mysql change_column_default to not make the column always nullable. 
Also added change_column_null to both mysql and sqlite to keep the api features closer to postgresql.

[#617 state:resolved]
 2008-07-14 12:42:01 -07:00
Tarmo Tänav
8f72bc92e2 Fixed test_rename_nonexistent_column for PostgreSQL 
Also fixed ability to run migration_test.rb alone

[#616 state:resolved]
 2008-07-14 12:22:27 -07:00
Jeremy Kemper
c760dbfd31 PostgreSQL: don't dump :limit => 4 for integers 2008-07-14 11:59:46 -07:00
Jeremy Kemper
cdf0f1aa2e Faster and clearer value_to_boolean 2008-07-14 11:41:56 -07:00
David Heinemeier Hansson
3037022789 Fixed that create database statements would always include "DEFAULT NULL" (Nick Sieger) [#334 status:committed] 2008-07-14 10:12:54 -05:00
Sebastian A. Espindola
0176e6adb3 Added db:charset support to PostgreSQL. [#556 state:resolved] 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2008-07-14 04:11:52 +01:00
David Dollar
e0750d6a5c Add :accessible option to Associations for allowing mass assignments using hash. [#474 state:resolved] 
Allows nested Hashes (i.e. from nested forms) to hydrate the appropriate
ActiveRecord models.

class Post < ActiveRecord::Base
  belongs_to :author,   :accessible => true
  has_many   :comments, :accessible => true
end

post = Post.create({
  :title    => 'Accessible Attributes',
  :author   => { :name => 'David Dollar' },
  :comments => [
    { :body => 'First Post!' },
    { :body => 'Nested Hashes are great!' }
  ]
})

post.comments << { :body => 'Another Comment' }

Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2008-07-14 02:53:21 +01:00