github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity
8,282 Commits 34 Branches 105 Tags
ff4ccb8334e4f5b5bdccbd5dc6876b4e43d9565e
Commit Graph

72 Commits

Author SHA1 Message Date
Kevin Glowacz
1b4b1aa725 Fixed index and auto index for nested fields_for [#327 state:resolved] 
Signed-off-by: Joshua Peek <josh@joshpeek.com>
 2008-07-19 15:10:12 -05:00
Jeremy Kemper
ff5f155f8d Use output_buffer reader and writer methods exclusively instead of hitting the instance variable so others can override the methods. 2008-06-08 20:05:39 -07:00
Jeremy Kemper
0bdb7d353b Work with @output_buffer instead of _erbout 2008-06-02 21:32:50 -07:00
Erkki Eilonen
6e3521e613 Improve check_box_checked? to use include? for Array values. [#193 state:resolved] 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2008-05-21 20:23:58 +01:00
Andrew Vit
04f52219f1 Fixed form helper's name attribute for question methods 2008-05-06 00:03:32 -07:00
David Heinemeier Hansson
f6ec296ad8 Fixed that TextHelper#text_field would corrypt when raw HTML was used as the value (mchenryc, Kevin Glowacz) [#80 state:resolved] 2008-05-01 17:56:32 -05:00
Kevin Glowacz
c83f75812e Fixed labels that have a bracketed name and an index [#68 state:resolved] 
Signed-off-by: Joshua Peek <josh@joshpeek.com>
 2008-04-30 17:21:18 -05:00
Joshua Peek
96d9691e71 FormHelper#label_tag accepts :for option [encoded] [#38 state:resolved] 2008-04-30 17:14:28 -05:00
Joshua Peek
17d4164a16 Introduce ActionView::TestCase for testing view helpers. 2008-04-19 13:08:24 -05:00
David Heinemeier Hansson
b0bfcca16e Fixed that FormHelper#radio_button would produce invalid ids (closes #11298) [harlancrystal] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@9088 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-03-24 21:32:50 +00:00
Jeremy Kemper
0da2aa6d11 Introduce the :index option for form_for and fields_for to simplify multi-model forms (see http://railscasts.com/episodes/75). Closes #9883. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8786 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-02-02 06:16:04 +00:00
Jeremy Kemper
9d755f1983 require abstract_unit directly since test is in load path 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8564 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-05 13:32:06 +00:00
David Heinemeier Hansson
84ca7e6ef7 Deal with nested fields_for too [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8253 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-02 01:10:50 +00:00
David Heinemeier Hansson
d0ce7cd4c7 Added the same record identification guessing rules to fields_for as form_for has [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8252 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-02 00:46:43 +00:00
Jeremy Kemper
a55caf666c Tested FormHelper#label. Closes #9850 [jarkko] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8045 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-27 20:30:05 +00:00
Rick Olson
d5a93b6241 FormHelper's auto_index should use #to_param instead of #id_before_type_cast. Closes #9994 [mattly] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8033 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-26 04:48:19 +00:00
Jeremy Kemper
8091ed5420 Disabled checkboxes don't submit a form value. Closes #9301. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8007 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-23 19:25:28 +00:00
Jeremy Kemper
459cc1ecb8 error_messages_for and friends also work with local variables. Closes #9699. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7779 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-07 19:50:30 +00:00
Rick Olson
5edc81dcc2 Allow ability to disable request forgery protection, disable it in test mode by default. Closes #9693 [lifofifo] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7668 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-28 15:55:45 +00:00
Rick Olson
4e3ed5bc44 Merge csrf_killer plugin into rails. Adds RequestForgeryProtection model that verifies session-specific _tokens for non-GET requests. [Rick] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7592 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-23 02:32:55 +00:00
David Heinemeier Hansson
a7764d8fd4 Added FormHelper#label (closes #8641) [jcoglan] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7541 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-22 17:17:22 +00:00
Tobias Lütke
9014bf3f26 * url_for now accepts a series of symbols representing the namespace of the record [Josh Knowles]. Closes #8640 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7197 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-07-19 13:42:11 +00:00
Jeremy Kemper
71b77a3d6a Improve helper test coverage. Closes #7215, #7233, #7234, #7235, #7236, #7237, #7238. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7011 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-06-13 01:20:55 +00:00
Jeremy Kemper
c7df5bd6ac More nested polymorphic url helper fixes. Closes #6432, references #8601. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6960 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-06-07 21:35:01 +00:00
Jeremy Kemper
5600776e30 Fix incomplete work from [6951] that was hidden by test stubs. Closes #6432. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6959 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-06-06 16:52:37 +00:00
Jeremy Kemper
5dd3db8615 Resources: url_for([parent, child]) generates /parents/1/children/2 for the nested resource. Likewise with the other simply helpful methods like form_for and link_to. Closes #6432. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6951 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-06-05 19:10:59 +00:00
Jeremy Kemper
f80468c3c3 Remove junk form helper test. Closes #8416 [eric_oconnell] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6941 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-06-05 04:09:39 +00:00
David Heinemeier Hansson
74d1512b99 Added option to suppress :size when using :maxlength for FormTagHelper#text_field #3112 [rails@tpope.info] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6830 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-24 20:47:03 +00:00
Jeremy Kemper
1ac7cd56fe Clean up the simply_helpful merge. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6751 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-18 00:36:14 +00:00
David Heinemeier Hansson
6e7b593992 Added record identifications to FormHelper#form_for and PrototypeHelper#remote_form_for [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6731 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-14 17:30:35 +00:00
David Heinemeier Hansson
c769ad8533 Removed deprecated parameters_for_method_reference concept (legacy from before named routes) [DHH] Added record identification with polymorphic routes for ActionController::Base#url_for and ActionView::Base#url_for [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6729 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-12 21:12:31 +00:00
Rick Olson
7a49cb058f fix form_for example in ActionController::Resources documentation. Closes #7362 [gnarg], Added enhanced docs to routing assertions. Closes #7359 [Rob Sanheim], improve error message for Routing for named routes. Closes #7346 [Rob Sanheim] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6113 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-02-04 19:07:08 +00:00
David Heinemeier Hansson
6b5238aade Added FormBuilder#submit as a delegate for FormTagHelper#submit_tag [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6089 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-29 20:42:46 +00:00
Jeremy Kemper
0eacdcf9a3 Use a consistent load path to avoid double requires. Fix some scattered Ruby warnings. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6057 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-28 07:16:55 +00:00
Michael Koziarski
768b60e60d Add error_messages and error_message_on to the default FormBuilder. Closes #6939 [nik.wakelin] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6040 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-26 03:38:23 +00:00
Jamis Buck
b0a1aa7e7e Allow fields_for to be nested in form_for 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5965 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-17 00:04:02 +00:00
Jeremy Kemper
0eabcfd856 Revert failing test from [5847]. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5873 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-08 02:45:57 +00:00
David Heinemeier Hansson
73499158df Fixed that webrick would strip leading newlines and hang connection (closes #4156) [psross] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5847 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-05 04:09:38 +00:00
David Heinemeier Hansson
033a5148eb Premature commit 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5653 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-11-30 22:01:58 +00:00
David Heinemeier Hansson
8dca6586de Fixed that script/server running against Mongrel should tail the proper log regardless of the environment [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5652 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-11-30 21:45:31 +00:00
Jeremy Kemper
7f6c5a5654 Set ActionView::Base.default_form_builder once rather than passing the :builder option to every form or overriding the form helper methods. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5422 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-11-03 04:16:58 +00:00
Rick Olson
f7c916ece6 Added block-usage to PrototypeHelper#form_remote_tag, document block-usage of FormTagHelper#form_tag [Rick] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5346 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-24 03:06:57 +00:00
David Heinemeier Hansson
211ffd3f79 Fixed that FormHelper#radio_button didn't respect an :id being passed in (closes #6266) [evansj] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5247 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 00:53:59 +00:00
Rick Olson
101ebc996a Allow form_for and fields_for to work with indexed form inputs. [Jeremy Kemper, Matt Lyon] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4613 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-07-18 15:42:22 +00:00
David Heinemeier Hansson
062845b4da Expanded :method option in FormHelper#form_tag to allow for verbs other than GET and POST by automatically creating a hidden form field named _method, which will simulate the other verbs over post [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4371 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-05-28 01:04:27 +00:00
Jeremy Kemper
c069f361f0 form.text_area handles the :size option just like the original text_area (:size => '60x10' becomes cols="60" rows="10") 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4334 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-05-11 16:36:59 +00:00
Rick Olson
666537572d finish form_for change, allow hash as the second param: form_for :post, :url => { }. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4051 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-26 20:21:27 +00:00
Rick Olson
4238666627 Change #form_for and #fields_for so that the second argument is not required [Dave Thomas] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4047 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-26 19:45:56 +00:00
David Heinemeier Hansson
6a83ebfe70 Fixed form_for regression (closes #3962) [t.lucas@toolmantim.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3666 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-26 07:23:42 +00:00
David Heinemeier Hansson
231a464d4e Fixed that form elements would strip the trailing [] from the first parameter (closes #3545) [ruby@bobsilva.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3661 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-26 01:07:05 +00:00