github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-02-02 10:15:03 -05:00
Code Issues Packages Projects Releases Wiki Activity
10,265 Commits 34 Branches 105 Tags
github30
Commit Graph

10265 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
David Heinemeier Hansson
955fa6151a The examples are outdated and misleading 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7424 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-09 17:55:26 +00:00
David Heinemeier Hansson
73c7083651 Rename fieldset_tag to field_set_tag to follow the conventions from text_area and text_field [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7423 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-09 15:58:12 +00:00
Michael Koziarski
fa602bb86d Use attribute pairs instead of the migration name to create add and remove column migrations. Closes #9166 [lifofifo] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7422 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-09 05:40:34 +00:00
Michael Koziarski
80ff0b9f1c Optimise named route generation when using positional arguments. Closes #9450 [Koz] 
This change delivers significant performance benefits for the most
  common usage scenarios for modern rails applications by avoiding the
  costly trip through url_for.  Initial benchmarks indicate this is
  between 6 and 20 times as fast.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7421 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-09 00:18:55 +00:00
Jeremy Kemper
7ace0a654c Match Fixnum and Float in particular. Rescue dup error and return result. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7420 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-08 04:53:29 +00:00
Jeremy Kemper
2894887925 Explicitly require active_record/query_cache before using it. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7419 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-08 04:31:26 +00:00
Jeremy Kemper
f1b12b62f4 Fix layout overriding response status. Closes #9476. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7418 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-08 03:12:03 +00:00
Michael Koziarski
32553a2d76 Fix assert_select for XML documents. Closes #8173. [dasil003] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7417 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-08 01:32:16 +00:00
Michael Koziarski
fe31f0e066 Add a user_agent to TestRequest 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7416 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-07 03:45:54 +00:00
Tobias Lütke
68d685056a Remove deprecated named routes [pixeltrix] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7415 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-06 14:28:32 +00:00
Michael Koziarski
0e6c8e5f6c Add fieldset_tag for generating fieldsets, closes #9477. [djanowski] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7413 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-06 05:53:29 +00:00
Michael Koziarski
8a9f43ecbb Fix activesupport atomic_write tests when Dir.tmpdir is on another partition. Closes #8573 [tpope] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7412 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-06 03:26:14 +00:00
Michael Koziarski
a75d273ece Allow additional parameters to be passed to named route helpers when using positional arguments. Closes #8930 [ian.w.white@gmail.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7411 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-05 23:37:17 +00:00
Michael Koziarski
bc41e8a449 Add credit where due. References #8446 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7410 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-05 23:33:27 +00:00
Michael Koziarski
4917813439 Fix misleading documentation for truncate. [esad] Closes #9104 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7409 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-05 23:14:12 +00:00
Michael Koziarski
0d696f09ac Fix assertion for the mysql default work around committed earlier. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7408 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-05 05:38:19 +00:00
Michael Koziarski
aa32f66ebb Add :allow_blank to validations. Like allow_nil, but for values which are +blank?+. [jnoon] Closes #7383 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7407 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-05 05:37:52 +00:00
Rick Olson
51977bc261 Fix bug where unserializing an attribute attempts to modify a frozen @attributes hash for a deleted record. [Rick] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7406 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-04 17:32:48 +00:00
Michael Koziarski
3bbef581af Work around mysql limitations for defaults on text columns with not null. Closes #9324 [caio] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7405 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-04 02:44:10 +00:00
Michael Koziarski
109bf67f3f Add missing changelog entry 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7404 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-03 00:18:49 +00:00
Michael Koziarski
f81dae3fca Remove deprecated functionality from actionpack. Closes #8958 [lifofifo] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7403 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-03 00:18:30 +00:00
Michael Koziarski
6246fad19a Remove deprecated functionality from edge rails. Closes #9387 [lifofifo] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7402 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-03 00:17:09 +00:00
Michael Koziarski
f0dbd22c46 Allow Float#round to take a precision argument. Closes #8626 [norbert] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7401 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-02 23:54:08 +00:00
Michael Koziarski
21837821a8 Add array support to remote_form_for for polymorphic urls. Closes #8654 [jade] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7400 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-02 23:53:31 +00:00
Michael Koziarski
b18d9568a6 Ensure QueryCache doesn't try to dup numeric results (does not affect the major OS database). Closes #7661 [tomafro, nzkoz] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7399 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-02 23:52:58 +00:00
Michael Koziarski
6b9b511de1 Fix task description for db:sessions:create. Closes #9419 [topfunky] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7398 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-02 23:52:24 +00:00
Michael Koziarski
a79ac12c4e Make auto link behave well with URLs containing email addresses. Closes #7313 [jeremymcnally] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7397 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-02 23:52:01 +00:00
Michael Koziarski
bde8be41fb Properly quote the arguments to visual_effect. Closes #7220 [jeremymcanally] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7396 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-02 23:51:27 +00:00
Michael Koziarski
2fc4be68a6 Remove duplication in test_help.rb Closes #3328 [jarkko] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7395 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-02 23:50:51 +00:00
Jeremy Kemper
ed09b621bd Documentation tweaks and fixes. Closes #9454 [sur, kampers] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7383 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-08-31 19:07:42 +00:00
Jeremy Kemper
33e5e41dda request.host works with IPv6 addresses. Closes #9458. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7382 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-08-31 19:03:42 +00:00
Jeremy Kemper
55efae2387 Performance: absorb instantiate and initialize_with_callbacks into the Base methods. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7380 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-08-31 01:56:39 +00:00
Michael Koziarski
35ade47a30 Fix incorrectly named instance variable. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7372 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-08-29 03:43:08 +00:00
Michael Koziarski
45ea329bcd Remove commented out test which refers to old code, old bugs and uses ObjectSpace in a nasty way. [nzkoz] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7371 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-08-29 03:33:26 +00:00
Michael Koziarski
719d3e8a9a Use mocha to avoid the sleep calls in the compiled_template tests. [tarmo] Closes #9372 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7370 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-08-29 03:14:15 +00:00
Michael Koziarski
c6a18308ef Only reload routes.rb if its been modified. [Dreamer3] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7369 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-08-29 03:01:11 +00:00
Michael Koziarski
18a3333a30 Formatting, grammar and spelling fixes for the associations documentation. [seanhussey] Closes #8899 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7368 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-08-28 23:18:57 +00:00
Michael Koziarski
c11ca0e0bf Fix documentation error in xml serialization. [matt] Closes #9001 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7367 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-08-28 23:18:14 +00:00
Michael Koziarski
5972fd493b Formatting and grammatical fixes for the acts_as_* documentation [seanhussey, kampers] Closes #9107 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7366 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-08-28 23:17:49 +00:00
Michael Koziarski
5840108b6e Pass the right binding when string is passed to :if with validations. [caspercg] Closes #9300 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7365 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-08-28 23:17:17 +00:00
Michael Koziarski
93eaaef43c Use extract_options instead of ad-hoc partial implementations. [norbert] Closes #9313 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7364 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-08-28 23:16:49 +00:00
Michael Koziarski
43ef688d74 Improve documentation for ActionController::Helpers [jardeon] Closes #9359 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7363 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-08-28 23:16:15 +00:00
Michael Koziarski
5cbc782ece Remove unnecessary loop in validates_presence_of. [sur] Closes #9392 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7362 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-08-28 23:15:47 +00:00
Michael Koziarski
016947ceed Make sure create! raises errors on validation when creating multiple records. [hasmanyjosh] Closes #8952 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7361 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-08-28 20:44:51 +00:00
David Heinemeier Hansson
5f163d256c Back out of [7300] -- it screwed up nested XML 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7357 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-08-21 22:59:42 +00:00
David Heinemeier Hansson
d24c73dedb Fix spacing 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7356 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-08-21 22:11:14 +00:00
David Heinemeier Hansson
3566be4728 Fixed that eager loading queries and with_scope should respect the :group option [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7355 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-08-21 21:58:38 +00:00
David Heinemeier Hansson
0e452bb02d Fixed that eager loading queries should respect the :group option as well [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7354 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-08-21 21:29:21 +00:00
Rick Olson
0fc77b3928 correct the ActionCacheTest from [7346] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7348 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-08-20 13:48:13 +00:00
Rick Olson
1a459e8e7d Fix bug where action caching sets the content type to the ActionCachePath object. Closes #9282 [mindforge] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7346 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-08-20 01:12:43 +00:00