10265 Commits

Author SHA1 Message Date
David Heinemeier Hansson
a347d461a8 Be specific about the Ruby on Rails part
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7090 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-23 16:38:21 +00:00
Jeremy Kemper
048dcf31c9 Mock the beginning of the transaction also. References #8642.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7089 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-23 01:58:41 +00:00
Jeremy Kemper
c627590fd4 Rollback if commit raises an exception. Closes #8642.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7088 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-23 00:54:51 +00:00
Jeremy Kemper
40f6e9f8e1 Demote Hash#to_xml to use XmlSimple#xml_in_string so it can't read files or stdin. Closes #8453.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7086 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-23 00:40:53 +00:00
Jeremy Kemper
95c9ece59a Remove deprecated Hash#create_from_xml. Use Hash#from_xml.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7085 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-23 00:30:18 +00:00
Jeremy Kemper
9159489872 Don't mistakenly interpret the request uri as the query string. Closes #8731.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7084 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-23 00:13:40 +00:00
Michael Koziarski
3bf3042a6c Ensure clean_logger fixes are 1.8.2 compatible [mislav] Closes #8396
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7083 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-22 23:09:11 +00:00
Jeremy Kemper
e682fee121 Fix reload error when path prefix is used. Closes #8727.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7082 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-22 18:15:40 +00:00
Jeremy Kemper
dae6108998 Update tests' use of fixtures for the new collections api. Closes #8726.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7081 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-22 17:36:20 +00:00
Jeremy Kemper
989332c734 Save associated records only if the association is already loaded. Closes #8713.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7075 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-21 20:47:26 +00:00
Rick Olson
9e4461438f Added proper handling of arrays. Closes #8537 [hasmanyjosh]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7074 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-21 15:07:15 +00:00
Jeremy Kemper
eb2e30ef24 MySQL: fix show_variable. Closes #8448.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7071 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-20 18:30:35 +00:00
Jeremy Kemper
e963354124 Increase mail delivery test coverage. Closes #8692.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7070 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-20 06:50:43 +00:00
Tobias Lütke
bf280157d9 Ensure that post and put requests pass in Content-Length to the server.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7064 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-19 18:40:28 +00:00
Rick Olson
6af2cbca07 remove extra debug line. Closes #8681 [Giles Bowkett]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7059 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-18 23:57:00 +00:00
Rick Olson
7f517348db Make ActionView#view_paths an attr_accessor for real this time. Also, don't perform an unnecessary #compact on the @view_paths array in #initialize. Closes #8582 [dasil003, julik, rick]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7034 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-15 23:52:37 +00:00
Rick Olson
9d4225f129 Fixed that dispatcher preparation callbacks only run once in production mode. Mock Routes.reload so that dispatcher preparation callback tests run. [Rick]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7033 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-15 23:28:51 +00:00
Jeremy Kemper
1ddaec1e68 Only change date to beginning of month if it isn't nil.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7027 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-15 01:58:32 +00:00
Jeremy Kemper
594581685e Oh please. References #8646.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7021 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-14 01:59:27 +00:00
Jeremy Kemper
164a9ea4c7 Maybe passing an explicit offset mollifies CIA. References #8646.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7020 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-14 01:28:00 +00:00
Jeremy Kemper
50861013c2 Improve Time and Date test coverage. Closes #8646.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7019 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-14 01:17:42 +00:00
Jeremy Kemper
17927cbddc Improve UrlRewriter tests. Improve helper test coverage. Closes #7207, #7208, #7212.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7013 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-13 01:34:16 +00:00
Jeremy Kemper
71b77a3d6a Improve helper test coverage. Closes #7215, #7233, #7234, #7235, #7236, #7237, #7238.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7011 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-13 01:20:55 +00:00
Jeremy Kemper
c0c001839c Take advantage of Mocha support for sequenced returns. Closes #8639 [Josh Peek]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7010 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-13 00:55:11 +00:00
Jeremy Kemper
c5f00580d3 Fix precedence error in failsafe rescue. Closes #8625.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7006 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-12 16:46:25 +00:00
Jeremy Kemper
979c22444d Tolerate missing content type on multipart file uploads. Fix for Safari 3.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7005 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-12 07:44:23 +00:00
Jeremy Kemper
e4e275dde3 Fix syntax error in dispatcher than wrecked failsafe responses. Closes #8625.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7002 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-11 18:05:02 +00:00
Jeremy Kemper
b94f8e1d29 Remove deprecated quote methods, replaced by quote_value so quote can be used as an attribute name.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7000 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-11 08:06:07 +00:00
Jeremy Kemper
7858a32e1b Remove deprecated find_first and find_all.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6998 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-11 07:45:56 +00:00
Jeremy Kemper
800b899f96 Remove deprecated push_with_attributes.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6997 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-11 07:15:59 +00:00
Jeremy Kemper
813e8ba93b Fix Base#inspect when not every attribute is present. Closes #8623.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6995 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-11 05:02:42 +00:00
Jeremy Kemper
de7a626878 Manfred had already patched the same issue. References #6946.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6994 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-11 01:06:04 +00:00
Jeremy Kemper
43c6d7ee95 Deprecation: remove pagination. Install the classic_pagination plugin for forward compatibility, or move to the superior will_paginate plugin. Closes #8157.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6992 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-11 00:51:11 +00:00
Jeremy Kemper
4e23e65964 Get picky about weird Ruby style.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6991 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-10 23:06:47 +00:00
Jeremy Kemper
5179b351c7 Scaffolded validation errors set the appropriate HTTP status for XML responses. Closes #8622.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6990 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-10 23:04:19 +00:00
Jeremy Kemper
fde3d9d8e4 Remove ActiveResource::Struct because it hasn't proven very useful. Creating a new ActiveResource::Base subclass is often less code and always clearer. Closes #8612.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6980 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-09 04:42:32 +00:00
Jeremy Kemper
160af194e4 Routing: improve static segment test coverage. #7117 [Kevin Clark]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6979 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-09 04:39:01 +00:00
Jeremy Kemper
a308ff0cdd Test javascript_tag. Closes #7239.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6977 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-08 22:20:18 +00:00
Jeremy Kemper
29ce2eb9d1 Clean up junk test. Closes #7973 [Rob Sanheim]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6976 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-08 22:19:15 +00:00
Tobias Lütke
bfda4cdc5a Fixed query methods on resources. [Cody Fauser]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6972 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-08 19:32:15 +00:00
Jeremy Kemper
7de21cc1c5 Fix typo in resources documentation. Closes #8607 [yon]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6971 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-08 18:00:11 +00:00
Jeremy Kemper
c9397e684c Action caching is limited to GET requests returning 200 OK status. Closes #3335.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6970 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-08 05:01:35 +00:00
Jeremy Kemper
cd9d1711da Missed svn adds. References #7534.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6969 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-08 04:40:12 +00:00
Jeremy Kemper
b195ed61c8 Improve Text Helper test coverage. Closes #7274.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6968 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-08 04:05:35 +00:00
Jeremy Kemper
34b94de8b8 Improve Action View test coverage. Closes #7241, #7243, #7244.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6967 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-08 04:00:15 +00:00
Jeremy Kemper
9b444fe73b Rollback [6961] which breaks SQLite tests. Reference #7345.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6965 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-08 01:40:05 +00:00
Jeremy Kemper
72401dcbd6 Quote db path so SQLite AR tests work on Windows. Closes #5278 [mislav@nippur.irb.hr]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6964 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-08 01:37:13 +00:00
Jeremy Kemper
bab8966064 Test periodically_call_remote with frequency. Closes #7244 [Rich Collins]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6963 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-08 01:30:47 +00:00
Jeremy Kemper
271404e8b9 Register alternative template engines using ActionMailer::Base.register_template_extension('haml'). Closes #7534.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6962 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-07 23:42:47 +00:00
Jeremy Kemper
869a172a8a Migrations: raise if a column is duplicated. Closes #7345.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6961 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-07 23:25:50 +00:00