10265 Commits

Author SHA1 Message Date
Jamis Buck
0d34c28199 treat create! like create and make sure the target is loaded first
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5882 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-01-11 18:10:42 +00:00
Jamis Buck
c398e83893 fix regression in has_one#create, that caused instances thus created to be orphaned
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5881 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-01-11 18:04:47 +00:00
Rick Olson
ba1225c72b add some more detail on nested resource docs [Rick]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5877 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-01-10 18:08:43 +00:00
Jeremy Kemper
28767075f4 Pass a range in :conditions to use the SQL BETWEEN operator. Closes #6974.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5876 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-01-10 10:13:18 +00:00
Jeremy Kemper
d5f642294c test javascript include with and without application.js
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5875 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-01-08 17:30:46 +00:00
Rick Olson
10d0fcd4ec Lookup the mime type for #auto_discovery_link_tag in the Mime::Type class. Closes #6941 [Josh Peek]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5874 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-01-08 04:09:24 +00:00
Jeremy Kemper
0eabcfd856 Revert failing test from [5847].
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5873 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-01-08 02:45:57 +00:00
Rick Olson
0727af86fc Fix bug where nested resources ignore a parent singleton parent's path prefix. Closes #6940 [Dan Kubb]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5872 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-01-08 01:07:48 +00:00
Michael Koziarski
31fb0deec1 Fix no method error with error_messages_on. Closes #6935 [nik.wakelin Koz]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5870 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-01-07 08:56:57 +00:00
Michael Koziarski
b4282df966 Fix the Oracle adapter for serialized attributes stored in CLOBs. Closes #6825 [mschoen, tdfowler]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5866 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-01-05 23:42:03 +00:00
Rick Olson
2228fdbbae Slight doc tweak to the ActionView::Helpers::PrototypeHelper#replace docs. Closes #6922 [Steven Bristol]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5863 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-01-05 20:59:31 +00:00
Rick Olson
b51727aa49 Slight doc tweak to #prepend_filter. Closes #6493 [Jeremy Voorhis]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5862 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-01-05 20:46:34 +00:00
Rick Olson
6c914d983e Add more extensive documentation to the AssetTagHelper. Closes #6452 [Bob Silva]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5859 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-01-05 20:42:03 +00:00
Rick Olson
730c8e8391 Clean up multiple calls to #stringify_keys in TagHelper, add better documentation and testing for TagHelper. Closes #6394 [Bob Silva]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5857 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-01-05 20:32:03 +00:00
Rick Olson
1400e7f864 [DOCS] Apply more documentation for ActiveRecord Reflection. Closes #4055 [Robby Russell]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5855 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-01-05 20:22:41 +00:00
Rick Olson
606376bd44 [DOCS] Document :allow_nil option of #validate_uniqueness_of. Closes #3143 [Caio Chassot]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5853 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-01-05 20:17:37 +00:00
Rick Olson
f1b45df49a [DOCS] fix reference to ActionController::Macros::AutoComplete for #text_field_with_auto_complete. Closes #2578 [Jan Prill]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5851 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-01-05 20:12:01 +00:00
David Heinemeier Hansson
73499158df Fixed that webrick would strip leading newlines and hang connection (closes #4156) [psross]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5847 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-01-05 04:09:38 +00:00
Sam Stephenson
fbe05067be Update to latest Prototype
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5845 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-01-05 01:37:26 +00:00
Michael Koziarski
84481dd3b4 Sybase adapter fixes. Closes #6926 [jsheets]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5839 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-01-05 00:12:06 +00:00
Rick Olson
8219db5ee2 rollback [5833] and [5835]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5838 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-01-04 21:43:24 +00:00
Rick Olson
1023bc6e86 Allow ActionController::Base.session_store and #fragment_cache_store to lazily load the session class to allow for custom session store plugins. [Rick Olson]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5835 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-01-04 21:31:18 +00:00
Rick Olson
05aa57bc84 Allow ActionController::Base.session_store to lazily load the session class to allow for custom session store plugins. [Rick Olson]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5833 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-01-04 21:18:13 +00:00
Rick Olson
1af2022cc3 Rollback #new_record? and #id values for created records that rollback in an after_save callback. Closes #6910 [Ben Curren]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5830 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-01-02 05:36:30 +00:00
Jamis Buck
b75f28edb4 Make sure html_document is reset between integration test requests (closes #6834)
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5828 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-01-01 03:03:13 +00:00
Jeremy Kemper
a0b1ac2ef8 Fix date helper test when run on 31st day of the month! Closes #6907. [mutru]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5826 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-01-01 01:36:18 +00:00
Jeremy Kemper
e03cd53a7a use stringify_keys
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5824 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-01-01 01:32:24 +00:00
Jeremy Kemper
fe7995f718 Merge [5822] from 1.2 (oops, wrong order).
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5823 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-01-01 01:30:28 +00:00
Jeremy Kemper
0f048a5c98 Set session to an empty hash if :new_session => false and no session cookie or param is present. CGI::Session was raising an unrescued ArgumentError.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5820 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-01-01 01:13:09 +00:00
Jeremy Kemper
0a06ffc08e tighten test_load_once_paths_should_behave_when_recursively_loading
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5816 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-01-01 00:25:30 +00:00
Jeremy Kemper
cbe0c3c54f Check for nil name also. Closes #6561.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5814 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-12-31 23:53:05 +00:00
David Heinemeier Hansson
7ed7930769 Make RDoc not spew errors on install because of HTML comments in code comments
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5813 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-12-31 19:28:28 +00:00
Nicholas Seckar
91b71ed30c Fix Dependencies.autoloaded? to ignore anonymous modules. Closes #6561.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5811 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-12-31 18:53:58 +00:00
Jeremy Kemper
54e56ddb60 Validating save returns boolean; update and create return responses.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5810 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-12-29 22:28:30 +00:00
Jeremy Kemper
73101af6ab prefix_parameters pulls /:path/:params from the URI prefix
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5809 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-12-29 22:16:04 +00:00
Jamis Buck
6a5388b654 try to appease the angry Oracle
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5808 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-12-29 19:05:53 +00:00
Jamis Buck
0bfabaa048 make sure query attributes on custom fields works as it used to
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5807 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-12-29 17:24:35 +00:00
Jeremy Kemper
a8d7215060 doh typo in commit from the hip
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5806 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-12-29 01:38:39 +00:00
Jeremy Kemper
ee1c6c2a7c generate prefix parameters if undefined
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5805 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-12-29 01:37:38 +00:00
Jeremy Kemper
4e57ac3544 Query string support. Closes #6855.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5804 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-12-29 01:18:09 +00:00
Jeremy Kemper
f9f84d9f6d Routing uses URI escaping for path components and CGI escaping for query parameters.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5803 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-12-28 21:04:44 +00:00
Rick Olson
5cf118b138 Ensure plugins are in the Dependencies.load_once_paths collection by default. [Rick]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5801 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-12-27 22:18:38 +00:00
Michael Koziarski
810d0ade2b Make error_message_on handle nil objects. [dan]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5799 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-12-27 20:46:12 +00:00
Michael Koziarski
3b4450bb80 Docs fix for columns_hash [bradediger]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5797 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-12-27 20:41:55 +00:00
Michael Koziarski
58edaaad0b Ensure dynamic finders are anchored to the beginning of the method name to prevent
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5795 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-12-27 20:35:19 +00:00
David Heinemeier Hansson
014fdde93a Attempt at fixing the preparation_callbacks, nzkoz will double check
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5794 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-12-27 00:43:27 +00:00
David Heinemeier Hansson
d88e83f211 False is a reasonable default
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5793 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-12-27 00:42:31 +00:00
Michael Koziarski
c6d47806bf Allow config.to_prepare to work, make the dispatcher safe to 're require'. [Koz, Nicholas Seckar]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5792 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-12-26 23:56:00 +00:00
Rick Olson
29ec023add Fix scaffold_resource generator so it respects the --pretend argument when creating the routes file. Closes #6852 [fearoffish]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5790 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-12-26 19:39:30 +00:00
Rick Olson
ef1232c478 forgot to save CHANGELOG
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5786 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-12-25 09:35:20 +00:00