10265 Commits

Author SHA1 Message Date
Nicholas Seckar
62aa0603b7 Don't allow Reloadable to be included into Modules
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3527 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-02-03 22:36:44 +00:00
Nicholas Seckar
ad9cabd77c Remove LoadingModule
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3526 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-02-03 20:29:39 +00:00
David Heinemeier Hansson
05eb14d55a Using AssociationCollection#build with arrays of hashes should call build, not create [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3525 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-02-03 18:20:19 +00:00
Nicholas Seckar
6d7b0374d1 Add LoadingModule.clear! back temporarily
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3524 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-02-02 16:56:15 +00:00
Nicholas Seckar
1129e5b915 Remove definition of reloadable? from ActiveRecord::Base to make way for new Reloadable code.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3523 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-02-02 06:13:18 +00:00
Nicholas Seckar
52b04e8e74 Reloadable::OnlySubclasses
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3522 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-02-02 06:11:37 +00:00
Nicholas Seckar
1bce58b312 Add Reloadable::OnlySubclasses which handles the common case where a base class should not be reloaded, but its subclasses should be.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3521 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-02-02 05:41:00 +00:00
Nicholas Seckar
4bb6f863b4 Pluralization bites again
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3520 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-02-02 05:08:42 +00:00
Nicholas Seckar
7a43a05a2b Further improvements to reloading code
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3519 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-02-02 04:54:07 +00:00
David Heinemeier Hansson
65c337ac85 Fixed schema handling for DB2 adapter that didn't work: an initial schema could be set, but it wasn't used when getting tables and indexes (closes #3678) [Maik Schmidt]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3518 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-02-01 23:34:18 +00:00
Sam Stephenson
49401f880c Subclasses of ActionController::Caching::Sweeper should be Reloadable
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3517 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-02-01 20:25:27 +00:00
David Heinemeier Hansson
f791fe7621 Silly me
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3513 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-02-01 04:18:07 +00:00
David Heinemeier Hansson
1f8f982ee0 Added Errors#any? to mean !Errors#empty? [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3510 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-02-01 04:11:24 +00:00
David Heinemeier Hansson
26761d6d32 If included_modules doesnt take a parameter, we shouldnt either
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3509 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-02-01 03:58:37 +00:00
Michael Koziarski
e398045774 Fix Syntax problems which were preventing webrick from starting
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3508 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-02-01 03:54:37 +00:00
Marcel Molina
59d29811c5 Document the :xhr option for verifications. Closes #3666.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3507 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-02-01 03:22:18 +00:00
David Heinemeier Hansson
aee8db1584 ActiveRecordStore::Session shouldnt be reloadable
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3506 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-02-01 03:08:43 +00:00
David Heinemeier Hansson
15da1cf2ca Dont mark Sweepers as reloadables
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3505 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-02-01 02:58:22 +00:00
David Heinemeier Hansson
2504982945 Added :only and :except controls to skip_before/after_filter just like for when you add filters [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3504 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-01-31 23:55:04 +00:00
Marcel Molina
2bf3fa076e Support the :column option for remove_index with the PostgreSQL adapter. Closes #3661.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3499 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-01-31 14:31:16 +00:00
Nicholas Seckar
d2adec438e Ensure assigns are copied to the template when using render :update. Closes #3620.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3497 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-01-30 04:49:17 +00:00
David Heinemeier Hansson
f8bcfa6e04 Added check for RAILS_FRAMEWORK_ROOT constant that allows the Rails framework to be found in a different place than vendor/rails. Should be set in boot.rb. [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3496 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-01-30 04:08:05 +00:00
Jamis Buck
34df9be0e5 Template paths with dot chars in them no longer mess up implicit template selection for multipart messages (closes #3332)
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3495 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-01-29 02:25:15 +00:00
David Heinemeier Hansson
01b1a87729 Added reusable reloading support through the inclusion of the Relodable module that all subclasses of ActiveRecord::Base, ActiveRecord::Observer, ActiveController::Base, and ActionMailer::Base automatically gets [DHH]. Added auto-loading support for classes in modules, so Conductor::Migration will look for conductor/migration.rb and Conductor::Database::Settings will look for conductor/database/settings.rb [Nicholas Seckar]. Refactored extensions to module, class, and object in active support [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3493 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-01-29 00:37:39 +00:00
Marcel Molina
94046542e2 Add documentation for add_index and remove_index. Closes #3600.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3487 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-01-25 22:17:59 +00:00
Marcel Molina
463d208277 If the OCI library is not available, raise an exception indicating as much. Closes #3593.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3486 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-01-25 20:50:33 +00:00
Tobias Lütke
2dc16df10c give helpful error messages when fixtures accessed style table_name(:name) cannot be found [Tobias Luetke]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3480 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-01-25 02:40:25 +00:00
Sam Stephenson
9c52a41241 Add the ability to call JavaScriptGenerator methods from helpers called in update blocks
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3476 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-01-23 17:09:15 +00:00
Jamis Buck
185cca238b Make sure anything with content-disposition of "attachment" is passed to the attachment presenter when parsing an email body
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3475 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-01-23 16:48:24 +00:00
Jamis Buck
acfb8b6191 Make sure TMail#attachments includes anything with content-disposition of "attachment", regardless of content-type
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3474 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-01-23 16:37:46 +00:00
Sam Stephenson
7d0d0f0edd Add render(:update) to ActionView::Base
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3473 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-01-23 16:36:40 +00:00
Sam Stephenson
4d49f2ca09 Fix render(:update) to not render layouts
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3472 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-01-23 16:29:37 +00:00
Sam Stephenson
5f44411d94 Backing out of [3470] until visual_effect, et al can work
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3471 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-01-23 07:27:24 +00:00
Sam Stephenson
8436147825 Add the ability to call JavaScriptGenerator methods from helpers called in update blocks
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3470 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-01-23 06:52:26 +00:00
Sam Stephenson
d921b79974 Add Object#instance_exec and Proc#bind
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3469 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-01-23 06:40:43 +00:00
David Heinemeier Hansson
9c24899ab0 Fix merge and dup for hashes with indifferent access (closes #3404) [kenneth.miller@bitfield.net]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3468 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-01-23 05:38:02 +00:00
David Heinemeier Hansson
010e999092 Fixed that SSL would not correctly be detected when running lighttpd/fcgi behind lighttpd w/mod_proxy (closes #3548) [stephen_purcell@yahoo.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3467 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-01-23 05:32:59 +00:00
David Heinemeier Hansson
c3cfc2636b AR should run schema.rb for tests when building test DBs (closes #3578) [Rick Olson]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3466 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-01-23 05:29:17 +00:00
David Heinemeier Hansson
6236d518f2 Added the possibility to specify atomatic expiration for the memcachd session container (closes #3571) [Stefan Kaes]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3465 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-01-22 22:21:26 +00:00
Marcel Molina
554aa2e1e9 Add explicit :order in finder tests as postgresql orders results differently by default. Closes #3577.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3464 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-01-22 20:55:14 +00:00
Marcel Molina
297618bddc Make dynamic finders honor additional passed in :conditions. Closes #3569.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3463 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-01-22 09:34:41 +00:00
Marcel Molina
8d4d88a4f0 Change layout discovery to take into account the change in semantics with File.join and nil arguments.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3462 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-01-22 07:41:27 +00:00
Nicholas Seckar
cffd1a9c3a Show a meaningful error when the DB2 adapter cannot be loaded due to missing dependencies.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3460 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-01-22 06:28:49 +00:00
David Heinemeier Hansson
ea30f7353b Raise a RedirectBackError if redirect_to :back is called when theres no HTTP_REFERER defined (closes #3049) [kevin.clark@gmail.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3459 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-01-22 01:52:23 +00:00
Sam Stephenson
039a90f535 Fix the requires in option_merger_test to unbreak AS tests
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3458 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-01-21 23:52:40 +00:00
David Heinemeier Hansson
5436ffa840 Treat timestamps like datetimes for scaffolding purposes (closes #3388) [Maik Schmidt]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3457 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-01-21 23:46:56 +00:00
David Heinemeier Hansson
1facce6c24 allow has_many :through to work with custom :foreign key (closes #3422) [Rick Olson]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3456 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-01-21 23:40:20 +00:00
David Heinemeier Hansson
13cd6135cd Fixed that static requests could unlock the mutex guarding dynamic requests in the WEBrick servlet (closes #3433) [tom@craz8.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3455 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-01-21 23:38:51 +00:00
David Heinemeier Hansson
fab2fd6398 Fixed that static requests could unlock the mutex guarding dynamic requests in the WEBrick servlet (closes #3433) [tom@craz8.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3454 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-01-21 23:38:41 +00:00
David Heinemeier Hansson
50e2df4268 Fix IE bug with link_to "something", :post => true (closes #3443) [Justin Palmer]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3453 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-01-21 23:36:38 +00:00