10265 Commits

Author SHA1 Message Date
David Heinemeier Hansson
caaf40d535 Added AbstractAdapter#select_value and AbstractAdapter#select_values as convenience methods for selecting single values, instead of hashes, of the first column in a SELECT #2283
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2323 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-24 19:50:57 +00:00
David Heinemeier Hansson
66820a4aa7 Just include activerecord/schema with AR so it doesnt need to be dumped
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2322 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-24 17:50:07 +00:00
David Heinemeier Hansson
6d336753b9 Added prevention of duplicate migrations from the generator #2240 [fbeausoleil@ftml.net]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2320 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-24 08:42:38 +00:00
David Heinemeier Hansson
df95567598 Added native, faster implementations of .blank? for the core types #2286 [skae]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2319 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-24 05:14:04 +00:00
Jamis Buck
1f4dc25250 Make the sqlite adapter preserve not-null constraints and index names when altering tables
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2318 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-24 00:33:47 +00:00
Jamis Buck
11411effde Allow the postgresql adapter to work with the SchemaDumper.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2317 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-23 17:27:59 +00:00
Jamis Buck
9838a5f8b3 Post the postgresql adapter (and hopefully other adapters) pass all tests
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2316 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-23 15:46:04 +00:00
Jamis Buck
6d4a4a0d2e Make sqlite adapter pass all tests
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2315 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-23 15:00:56 +00:00
Jamis Buck
119855c438 Add db_schema_dump and db_schema_import rake tasks to work with the new ActiveRecord::SchemaDumper (for dumping a schema to and reading a schema from a ruby file).
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2313 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-23 13:45:32 +00:00
Jamis Buck
7dc45818dc Add ActiveRecord::SchemaDumper for dumping a DB schema to a pure-ruby file, making it easier to consolidate large migration lists and port database schemas between databases.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2312 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-23 13:29:33 +00:00
David Heinemeier Hansson
436d54c3f1 Only configure settings for loaded frameworks
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2304 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-22 14:11:13 +00:00
David Heinemeier Hansson
2a31691ee2 Fixed that auto_discovery_link_tag couldn't take a string as the URL
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2296 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-22 11:37:16 +00:00
David Heinemeier Hansson
0b54f18c47 Fixed clean logger to work with Ruby 1.8.3 Logger class #2245
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2286 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-21 13:45:16 +00:00
David Heinemeier Hansson
2d4fe31af6 Fixed migrations for Windows when using more than 10 [David Naseby]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2285 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-21 13:27:45 +00:00
David Heinemeier Hansson
d616b86025 Asserts now need html/document so it should require it
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2284 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-21 09:04:05 +00:00
David Heinemeier Hansson
66ecf31ffe Fixed that the create_x method from belongs_to wouldn't save the association properly #2042 [Florian Weber]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2279 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-20 18:36:14 +00:00
Jamis Buck
5213a1f733 Fixed saving a record with two unsaved belongs_to associations pointing to the same object #2023 [Tobias Luetke]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2278 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-20 16:12:13 +00:00
Jamis Buck
4fa9a2bfe2 Require 'pp' early to prevent the pretty-print methods being mixed in too late and messing up a test
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2277 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-20 13:55:27 +00:00
David Heinemeier Hansson
6a51940117 Fixed memory leak with Active Record classes when Dependencies.mechanism = :load #1704 [c.r.mcgrath@gmail.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2276 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-20 11:23:13 +00:00
David Heinemeier Hansson
8a35865b74 Added small note about how longtext might be needed for large session data
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2275 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-20 10:54:11 +00:00
David Heinemeier Hansson
3754822f43 Fixed problem with send_file and WEBrick using stdout #1812
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2274 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-20 10:53:33 +00:00
David Heinemeier Hansson
3c0129af6d Fixed memory leak with Active Record classes when Dependencies.mechanism = :load #1704 [c.r.mcgrath@gmail.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2273 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-20 10:33:26 +00:00
David Heinemeier Hansson
a41619681f Include suggestion for using different socket #1951 [NVRS]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2272 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-20 10:04:12 +00:00
David Heinemeier Hansson
7f26415d3c Optimized tag_options to not sort keys, which is no longer necessary when assert_dom_equal and friend is available #1995 [skae]. Added assert_dom_equal and assert_dom_not_equal to compare tags generated by the helpers in an order-indifferent manner #1995 [skae]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2271 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-20 07:54:55 +00:00
David Heinemeier Hansson
47292cdef7 Fixed that Request#domain caused an exception if the domain header wasn't set in the original http request #1795 [Michael Koziarski]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2270 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-20 06:44:53 +00:00
Nicholas Seckar
3e2bac428d Improved migrations' behavior when the schema_info table is empty.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2269 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-20 01:33:43 +00:00
Jamis Buck
390280b842 Make the truncate() helper multi-byte safe (assuming $KCODE has been set to something other than "NONE") #2103
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2265 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-19 21:36:36 +00:00
David Heinemeier Hansson
5da4c39782 Make the reaper slightly more robust in the nudging department
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2264 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-19 16:40:53 +00:00
David Heinemeier Hansson
6f95c49a15 Fixed that Observers didn't observe sub-classes #627 [Florian Weber]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2263 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-19 16:34:34 +00:00
David Heinemeier Hansson
9cc624df73 Include ActionView as a configurable framework
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2261 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-19 08:18:21 +00:00
David Heinemeier Hansson
2eb29c231a Include libs/ in rake stats #2223 [Marcel Molina]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2260 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-19 06:50:47 +00:00
Nicholas Seckar
251a5d4508 Fix eager loading error messages, allow :include to specify tables using strings or symbols. Closes #2222
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2258 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-18 20:41:44 +00:00
Nicholas Seckar
b9c79f195f Add routing tests from #1945
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2257 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-18 14:37:43 +00:00
Nicholas Seckar
57e0cf8e95 Add a routing test case covering #2101
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2256 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-18 14:11:24 +00:00
David Heinemeier Hansson
7a4c88157f Doc fix #2197
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2255 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-17 06:39:54 +00:00
David Heinemeier Hansson
620726f844 Add "#:nodoc:" for ActionController::Routing::PathComponent::Result #2209 [l.francke@gmx.de]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2254 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-17 06:37:50 +00:00
David Heinemeier Hansson
dfd0bdf1a0 Fixed that generate scaffold claims all words are reserved #2200, #2211 [alancfrancis@gmail.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2253 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-17 06:36:04 +00:00
David Heinemeier Hansson
9acb1f95c9 Make upload progress not throw JavaScript errors when there is no progress bar #2208 [Thomas Fuchs]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2252 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-16 08:44:38 +00:00
Jamis Buck
1fb8ba7592 Don't set the :MimeTypes option if it is nil (causes routing errors on stylesheets and javascripts, somehow)
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2251 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-15 22:51:43 +00:00
David Heinemeier Hansson
3e7b597ff4 Cant use silence_warnings before active support is loaded
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2250 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-15 08:25:46 +00:00
David Heinemeier Hansson
428e0f4e63 Added check for RAILS_CONNECTION_ADAPTERS on startup and only load the connection adapters specified within if its present (available in Rails through config.connection_adapters using the new config) #1958 [skae]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2249 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-15 06:42:07 +00:00
David Heinemeier Hansson
40b7809de5 Added check for RAILS_CONNECTION_ADAPTERS on startup and only load the connection adapters specified within if its present (available in Rails through config.connection_adapters using the new config) #1958 [skae]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2248 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-15 06:40:39 +00:00
David Heinemeier Hansson
5dbf5ded5c Only attempt to require Active Support if it hasnt been already #1959
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2247 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-15 05:34:59 +00:00
David Heinemeier Hansson
e9504bb6f7 Cache relative_url_root for all webservers, not just Apache #2193 [skae]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2246 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-15 05:32:16 +00:00
David Heinemeier Hansson
b37d7a70f9 Speed up cookie use by decreasing string copying #2194 [skae]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2245 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-15 05:30:56 +00:00
David Heinemeier Hansson
c1505e3e2b Included UrlRewriter tests in rake run and made them not depend on Hash order
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2244 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-15 05:24:29 +00:00
David Heinemeier Hansson
d985260ed7 Made base_tests.rb run as part of rake
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2243 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-15 05:20:32 +00:00
David Heinemeier Hansson
7c042e09b4 Fixed access to "Host" header with requests made by crappy old HTTP/1.0 clients #2124 [Marcel Molina]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2242 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-14 18:35:31 +00:00
Jamis Buck
5e3364ef45 More auto-link fixes (to include query strings in autolinked text)
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2241 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-14 12:07:05 +00:00
David Heinemeier Hansson
a20ad655b5 Moved session and fragment options out
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2238 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-13 19:46:42 +00:00