10265 Commits

Author SHA1 Message Date
David Heinemeier Hansson
c81af992e8 Added the option of passing a block to ActiveRecordHelper#form in order to add more to the auto-generated form #469 [dom@sisna.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@422 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-15 18:57:17 +00:00
David Heinemeier Hansson
31901a5939 Fixed errors thrown to namespace collision
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@421 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-15 18:28:10 +00:00
David Heinemeier Hansson
2aac6d90fe Flipped code-to-test ratio around to be more readable #468 [Scott Baron]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@420 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-15 18:19:51 +00:00
David Heinemeier Hansson
bb92382424 Fixed that unit tests for MySQL are now run as the "rails" user instead of root #455 [Eric Hodel]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@419 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-15 17:54:45 +00:00
David Heinemeier Hansson
51390b8524 Added validates_associated that enables validation of objects in an unsaved association #398 [Tim Bates]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@418 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-15 17:52:08 +00:00
David Heinemeier Hansson
823554eafe Added support for associating unsaved objects #402 [Tim Bates]
Added replace to associations, so you can do project.manager.replace(new_manager) or project.milestones.replace(new_milestones) #402 [Tim Bates]
Added build and create methods to has_one and belongs_to associations, so you can now do project.manager.build(attributes) #402 [Tim Bates]
Fixed that Base#== wouldn't work for multiple references to the same unsaved object #402 [Tim Bates]
Added that if a before_* callback returns false, all the later callbacks and the associated action are cancelled. If an after_* callback returns false, all the later callbacks are cancelled. Callbacks are generally run in the order they are defined, with the exception of callbacks defined as methods on the model, which are called last. #402 [Tim Bates]

git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@417 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-15 17:45:16 +00:00
David Heinemeier Hansson
62f0512e54 Fixed log file permissions to be 666 instead of 777 (so they're not executable) #471 [Lucas Carlson]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@416 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-15 17:28:01 +00:00
David Heinemeier Hansson
f3965af649 Dont polute the load path more than necessary
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@415 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-15 17:03:31 +00:00
David Heinemeier Hansson
a66b321bb0 Added the meat for String inflection
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@414 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-15 16:48:12 +00:00
David Heinemeier Hansson
d8805988a1 Missing something from #475
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@413 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-15 16:46:17 +00:00
David Heinemeier Hansson
38e695037c Added availability of class inheritable attributes to the masses #477 [bitsweat]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@412 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-15 13:52:58 +00:00
David Heinemeier Hansson
f73ecc8626 Added a bit more documentation on how to use the instance methods for acts_as_list #478
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@411 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-15 13:49:23 +00:00
David Heinemeier Hansson
ad63c96ff2 Fixed binary support for PostgreSQL #444 [alex@byzantine.no]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@410 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-15 13:48:39 +00:00
David Heinemeier Hansson
2997f9c788 Added Inflections as an extension on String, so Inflector.pluralize(Inflector.classify(name)) becomes name.classify.pluralize #476 [bitsweat]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@409 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-15 13:43:48 +00:00
David Heinemeier Hansson
6c1fe632a3 Fixed that auto reloading would some times not work or would reload the models twice #475 [Tobias Luetke]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@408 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-15 13:26:48 +00:00
David Heinemeier Hansson
c755b29a86 Fixed page caching problems with saving cached file fails for the index action and that it shouldnt cache files with GET/POST parameters #462
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@407 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-15 13:22:58 +00:00
David Heinemeier Hansson
4a0695996f Removed silly change caused by inability to grok own code at 3 am
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@406 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-14 02:12:00 +00:00
David Heinemeier Hansson
023227d78d Changed add_to_list_top and add_to_list_bottom to be public
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@405 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-14 01:24:57 +00:00
David Heinemeier Hansson
52251baae4 Added the option to specify a controller name to "generate scaffold" and made the default controller name the plural form of the model.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@404 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-13 15:49:26 +00:00
David Heinemeier Hansson
9c09f81bc6 Added arrays as a value option for params in url_for and friends #467 [Eric Anderson]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@403 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-13 14:06:33 +00:00
David Heinemeier Hansson
1d61071e7c Fixed that controller tests can now assert on the use of cookies #466 [Alexey]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@402 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-13 14:01:17 +00:00
David Heinemeier Hansson
4cee51e1cc Refactored ActiveRecord::Base#clone to use Base#attributes #463 [atyp]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@401 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-13 13:56:00 +00:00
David Heinemeier Hansson
96e54780b3 Fixed that send_file would "remember" all the files sent by adding to the headers again and again #458 [bitsweat]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@400 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-13 13:29:49 +00:00
David Heinemeier Hansson
5f5b053ce8 Fixed that bcc and cc should be settable through @bcc and @cc -- not just @headers["Bcc"] and @headers["Cc"] #453 [Eric Hodel]. Fixed Action Mailer to be "warnings safe" so you can run with ruby -w and not get framework warnings #453 [Eric Hodel]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@399 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-13 13:05:51 +00:00
David Heinemeier Hansson
d3a8d5f93c Fixed url rewriter confusion when the controller or action name was a substring of the controller_prefix or action_prefix
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@398 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-12 16:23:18 +00:00
David Heinemeier Hansson
cb8a020ec9 Fixed url rewriter confusion when the controller name was a substring of the controller_prefix
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@397 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-12 15:21:09 +00:00
David Heinemeier Hansson
8d5d7161eb Remove length alias of size
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@396 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-11 22:36:16 +00:00
David Heinemeier Hansson
1497522ab0 Fixed the half applied 393 changeset
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@395 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-11 22:06:05 +00:00
David Heinemeier Hansson
d44deadd39 Added option to turn off caching
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@394 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-11 22:03:27 +00:00
David Heinemeier Hansson
876a1a1fa3 Added Byte operations to Numeric, so 5.5.megabytes + 200.kilobytes #461 [Marcel Molina]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@393 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-11 21:37:02 +00:00
David Heinemeier Hansson
fe8fb574c0 Added a differenciation between AssociationCollection#size and -length. Now AssociationCollection#size returns the size of the collection by executing a SELECT COUNT(*) query if the collection hasn't been loaded and calling collection.size if it has. If it's more likely than not that the collection does have a size larger than zero and you need to fetch that collection afterwards, it'll take one less SELECT query if you use length.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@392 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-11 13:21:17 +00:00
David Heinemeier Hansson
45ea2bd452 Fixed the 4.11 changes to the mysql adapter
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@391 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-11 10:59:49 +00:00
David Heinemeier Hansson
2182a8203f Tweaks and tinkering
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@390 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-11 02:11:24 +00:00
David Heinemeier Hansson
efdabfb8f5 Updated to new naming style
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@389 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-11 01:54:55 +00:00
David Heinemeier Hansson
0f4cba7b86 git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@388 5ecf4fe2-1ee6-0310-87b1-e25e094e27de 2005-01-11 00:53:04 +00:00
David Heinemeier Hansson
e38ee7cd7f Added conditional layouts like <tt>layout "weblog_standard", :except => :rss</tt> #452 [Marcel Molina] -- We are still missing unit tests for layouts in general, so please do contribute if you want some testing workout
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@387 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-11 00:50:11 +00:00
David Heinemeier Hansson
b067bf7884 Added Base#attributes that returns a hash of all the attributes with their names as keys and clones of their objects as values #433 [atyp.de]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@386 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-11 00:45:26 +00:00
David Heinemeier Hansson
18e945d887 Added MemCacheStore to fragment caching #449 [Lucas Carlson]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@385 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-11 00:30:53 +00:00
David Heinemeier Hansson
0d1e3846d6 Fixed that MemCacheStore wasn't included by default and added default MemCache object pointing to localhost #447 [Lucas Carlson]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@384 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-11 00:29:55 +00:00
David Heinemeier Hansson
98c16a3320 Added fourth argument to render_collection_of_partials that allows you to specify local_assigns -- just like render_partial #432 [zenspider]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@383 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-11 00:27:33 +00:00
David Heinemeier Hansson
79365a0184 Fixed that foreign keys named the same as the association would cause stack overflow #437 [Eric Anderson]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@382 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-11 00:24:19 +00:00
David Heinemeier Hansson
bcb8116796 Fixed that host would choke when cgi.host returned nil #432 [Tobias Luetke]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@381 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-11 00:15:02 +00:00
David Heinemeier Hansson
a971dc5e4a Fixed default scope of acts_as_list from "1" to "1 = 1", so itll work in PostgreSQL (among other places) #427 [Alexey]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@380 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-11 00:13:42 +00:00
David Heinemeier Hansson
dbb5341691 Added that rake clone_structure_to_test, db_structure_dump, and purge_test_database tasks now pick up the source database to use from RAILS_ENV instead of just forcing development #424 [Tobias Luetke]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@379 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-11 00:07:35 +00:00
David Heinemeier Hansson
2594f2abe9 Added that form helpers now take an index option #448 [Tim Bates]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@378 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-10 23:57:36 +00:00
David Heinemeier Hansson
445f89ccb5 Fixed that Dependencies.reload can't load the same file twice #420 [Kent Sibilev]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@377 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-10 23:52:37 +00:00
David Heinemeier Hansson
3ff5c5805f Added Base#reload that reloads the attributes of an object from the database #422 [Andreas Schwarz]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@376 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-10 23:49:57 +00:00
David Heinemeier Hansson
59c2a4d511 Fixed script/console to work with Windows (that requires the use of irb.bat) #418 [octopod]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@375 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-10 23:47:32 +00:00
David Heinemeier Hansson
a133f3e64f Added SQLite3 compatibility through the sqlite3-ruby adapter by Jamis Buck #381 [bitsweat]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@374 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-10 23:09:51 +00:00
David Heinemeier Hansson
903dcefbaf Fixed random ordering of test cases that would cause errors on some systems #446 [Josh]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@373 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-10 22:58:06 +00:00