github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-01-23 13:28:04 -05:00
Code Issues Packages Projects Releases Wiki Activity
10,265 Commits 34 Branches 105 Tags
github30
Commit Graph

10265 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Russ Smith
f2c7508bef Update bundled Rack to fix Litespeed compatibility [#2198 state:resolved] 
Signed-off-by: Joshua Peek <josh@joshpeek.com>
 2009-03-11 12:50:24 -05:00
Pratik Naik
106976df09 Ensure ActiveRecord::Base.find_in_batches fires doesnt fire an extra query unless needed 2009-03-11 15:24:30 +00:00
Pratik Naik
f23adf0ed4 Add tests for AssociationCollection#find_each and AssociationCollection#find_in_batches 2009-03-11 15:07:24 +00:00
Pratik Naik
0b6f514947 Add NamedScope#find_each tests [#2201 state:resolved] 2009-03-11 15:07:24 +00:00
Pratik Naik
04333482bd Rename ActiveRecord::Base.each to ActiveRecord::Base.find_each 2009-03-11 15:07:23 +00:00
Jeremy Kemper
19ad375e7a Don't duplicate :order from scope and options, it makes mysql do extra work 2009-03-10 23:11:05 -07:00
Jeremy Kemper
cfde60575a Strip invalid leading whitespace error uncovered by nokogiri 2009-03-10 22:17:05 -07:00
Aaron Patterson
b9e021df97 adding more nokogiri tests and making the main rails tests pass 
[#2190 state:resolved]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2009-03-10 22:11:15 -07:00
Mislav Marohnić
fa45540cdb Ensure correct content type is declared after cache hits on actions with string cache keys [#1585 state:resolved] 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2009-03-10 23:31:19 +00:00
Henrik N
ea0e41d8fa Make Inflector#parameterize correctly squeeze multi-character separators [#1489 state:resolved] 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2009-03-10 21:36:46 +00:00
Ken Collins
4b4e7caffa The latest trunk of Mocha > 0.9.5 which addresses issue with MiniUnit compatibility uses namespaced integration classes. 
[#2060 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2009-03-10 14:07:40 -07:00
Joshua Peek
0a887e2386 check for rack 1.0 gem before falling back to bundled version 2009-03-10 15:09:44 -05:00
Joshua Peek
572e0aac80 update bundled version of rack before 2.3 final 2009-03-10 15:05:38 -05:00
Joshua Peek
8970f8ace5 remove rack gem dependency 2009-03-10 15:02:58 -05:00
Jeremy Kemper
37cf224fdb Make it easier to swap XmlMini backends. Require Nokogiri >= 1.1.1 for XmlMini backend tests. 2009-03-10 12:08:42 -07:00
Aaron Patterson
694998ee4f Nokogiri backend for XmlMini 
[#2190 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2009-03-10 11:56:19 -07:00
Jeremy Kemper
d4091d3bc7 Properly set up libxml includes. Don't include LibXML in toplevel. 
[#2084 state:resolved]
 2009-03-10 11:37:23 -07:00
Jeff Schwab
e609d83f1a Fixed an incompatibility with Ruby 1.9. 
Ruby 1.8 strings are Enumerable, but there is no String#lines method. In
Ruby 1.9, the situation is reversed.  To work around this disparity, the
RailsEnvironment#externals method now explicitly checks whether a String
responds_to? :lines.

[#2130 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2009-03-10 11:37:23 -07:00
Pratik Naik
affe50105f Remove untested part from 9b9b2937ce 2009-03-10 18:16:10 +00:00
Tim Pope
9b9b2937ce Properly decode \u escape sequences in JSON [#1100 state:resolved] [Tim Pope, Philip Hallstrom] 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2009-03-10 17:05:17 +00:00
Pratik Naik
0464254430 Add a missing CHANGELOG entry 2009-03-10 16:52:40 +00:00
Eugene Pimenov
bdfa733d04 Ensure auto_link doesnt linkify URLs in the middle of a tag [#1523 state:resolved] 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2009-03-10 16:52:21 +00:00
Sean Dague
1dff106888 Allow custom type for multipart emails [#1691 state:resolved] 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2009-03-10 16:38:37 +00:00
Joshua Peek
e8b07dc340 Ensure public folder structure is setup correctly if the tests are ran out of order, fixes tests in 0c9bbf8 2009-03-10 11:19:32 -05:00
Manfred Stienstra
c3aa2bcdcf Ensure nested with_scope merges conditions inside out [#2193 state:resolved] 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2009-03-10 11:49:58 +00:00
Bruce Krysiak
8272630ce8 Ensure ActiveRecord#to_xml respects :skip_types for included associations [#1632 state:resolved] 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2009-03-10 11:17:16 +00:00
Joshua Peek
0c9bbf8c9d Fix serving index files with rack static file server [#2180 state:resolved] 2009-03-09 23:31:04 -05:00
Joshua Peek
224a534400 reset_session should force a new session id to be generated [#2173] 2009-03-09 22:46:03 -05:00
Jeremy Kemper
4458edc882 Use the REXML parser by default. XmlMini.backend = 'LibXML' to use libxml-ruby. 2009-03-09 13:42:42 -07:00
Jeremy Kemper
87d82ef76e Require libxml-ruby 0.9.4 or 0.9.7 pending a segfault bugfix for 1.0. 
Delegate parsing to a switchable backend.
 2009-03-09 13:00:57 -07:00
Jeremy Kemper
146511e018 Revert "Revert "XmlMini supports different backend parsers, starting with libxml"" 
Will change to require a known-working libxml-ruby.

This reverts commit a995a738ca.
 2009-03-09 12:39:20 -07:00
David Heinemeier Hansson
a995a738ca Revert "XmlMini supports different backend parsers, starting with libxml" 
Spews a ton undefined method `default_keep_blanks=' for XML:Module errors.

This reverts commit 822c41d69d.
 2009-03-09 19:00:21 +01:00
Andrew Bloom
90dba00822 Ensure blank path_prefix works as expected [#2122 state:resolved] 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2009-03-09 15:27:13 +00:00
Andrew Timberlake
1d88a111b5 Ensure TemplateRunner#ask? works with the rake task to apply a template [#1655 state:resolved] 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2009-03-09 14:58:12 +00:00
Curtis Hawthorne
0d922885fb Ensure Model#destroy respects optimistic locking [#1966 state:resolved] 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2009-03-09 14:56:09 +00:00
Jim Remsik and Tim Pope
1e6c50e21b Ensure has_many :through works with changed primary keys [#736 state:resolved] 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2009-03-09 13:43:28 +00:00
rpheath
1ab2ff58ed Fixed number_to_phone to work with 7 digit numbers [#2176 state:resolved] 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2009-03-09 12:53:44 +00:00
Rob Anderton
faf4ba6b79 Allow find(:last) :order be a symbol [#2024 state:resolved] 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2009-03-09 12:52:14 +00:00
Jan De Poorter
277c799d58 Fix find_by_last when order is given [#2127 state:committed] 
Signed-off-by: David Heinemeier Hansson <david@loudthinking.com>
 2009-03-09 13:02:31 +01:00
David Heinemeier Hansson
9442d843ff Merge branch 'master' of git@github.com:rails/rails 2009-03-09 12:50:47 +01:00
Matt Jones
0da8e45baf Correctly clean backtraces from vendor/gems and gems in alternate install locations 
Signed-off-by: David Heinemeier Hansson <david@loudthinking.com>
 2009-03-09 12:49:58 +01:00
Matt Jones
f4bd0fbc91 Correctly clean backtraces from vendor/gems and gems in alternate install locations 
Signed-off-by: David Heinemeier Hansson <david@loudthinking.com>
 2009-03-09 12:09:40 +01:00
Jeremy Kemper
a3e67a15ed Prototype helpers support the onCreate callback. 
[#1074 state:committed]
 2009-03-08 13:41:51 -07:00
Bart ten Brinke
822c41d69d XmlMini supports different backend parsers, starting with libxml 
[#2084 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2009-03-08 13:41:25 -07:00
Jeremy Kemper
1c36172c13 Ruby 1.9 compat: rename deprecated assert_raises to assert_raise. 
[#1617 state:resolved]
 2009-03-08 13:11:58 -07:00
Jeremy Kemper
0c407891fb Ensure Active Support is loaded locally rather than from RubyGems. [#1620 state:committed] 2009-03-08 11:04:23 -07:00
Yury Kotlyarov
9b8cde41bc Remove duplicate test [#2136 state:resolved] 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2009-03-08 15:50:38 +00:00
Jeffrey Hardy
96eaeee446 Add ActiveRecord::Base#invalid? as the opposite of #valid? [#2159 state:resolved] 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2009-03-08 15:20:23 +00:00
John Aughey
7a26a67b42 Ensure SQLite adapters stores the config [#1947 state:resolved] [John Aughey, Pratik Naik] 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2009-03-08 14:47:32 +00:00
Mike Gunderloy
5e0f6214d2 Support OPTIONS verb in route conditions [#1727 state:resolved] 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2009-03-08 12:37:17 +00:00