github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-01-26 06:48:59 -05:00
Code Issues Packages Projects Releases Wiki Activity
10,265 Commits 34 Branches 105 Tags
github30
Commit Graph

10265 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Nick Sieger
395369bc2b Provide alternate implementation of Object#subclasses_of for JRuby 
Signed-off-by: Michael Koziarski <michael@koziarski.com>

[#1144 state:committed]
 2008-10-03 21:28:47 +02:00
Eloy Duran
8d337e9ec2 Dynamic finders should use the ActiveRecord::Base::find method instead of ::find_initial, :find_last, and ::find_all. 
This is so when people override ActiveRecord::Base::find, the new ::find method will also be invoked by the dynamic finders.
Associations for instance do go through ::find, so this makes it more consistent.
Also removed the unnecessary deprecation silence blocks.

Signed-off-by: Michael Koziarski <michael@koziarski.com>

[#1162 state:committed]
 2008-10-03 21:28:11 +02:00
David Masover
e69b506abd Call controller_path instance method so it can be easily overridden [#1141 state:resolved] 
Signed-off-by: Joshua Peek <josh@joshpeek.com>
 2008-09-30 12:07:21 -05:00
Michael Koziarski
0eefa7058a Fix etag! and last_modified! to work as advertised. 
Add tests too.
 2008-09-30 17:00:38 +02:00
Michael Koziarski
0b46503254 Remove unneeded interning. 2008-09-30 11:34:05 +02:00
Will Bryant
35d731ef0a fix eager loading's :condition sanitizing expanding against the wrong table 
Signed-off-by: Michael Koziarski <michael@koziarski.com>
 2008-09-29 17:49:44 +02:00
Will Bryant
8233f8314b wrote a test showing eager loading's misbehavior (sanitizing against the wrong table) when the association has a :conditions hash 
Signed-off-by: Michael Koziarski <michael@koziarski.com>
 2008-09-29 17:49:44 +02:00
Andrew Kaspick
8c105ee0c8 Add options to field_set_tag 
Signed-off-by: Michael Koziarski <michael@koziarski.com>
[#1116 state:committed]
 2008-09-29 17:47:29 +02:00
Joshua Peek
28bf2fa038 Protect body ivar from being clobbered by the mailer template assigns 2008-09-28 12:31:45 -05:00
Tarmo Tänav
ea609b265f Ignore all exceptions for validates_acceptance_of columns fetch so it can run even without a database connection 
Signed-off-by: Michael Koziarski <michael@koziarski.com>
 2008-09-26 20:09:39 +02:00
Adam Milligan
4d9a7ab5f5 Changed ActiveRecord attributes to respect access control. 
Signed-off-by: Michael Koziarski <michael@koziarski.com>
[#1084 state:committed]
 2008-09-24 19:40:07 +02:00
Michael Koziarski
a78ec93036 Partially revert 185fe2e9cc 
We shouldn't quote the unpack command's requirement as it's passed through GemRunner which takes care of it for us.
 2008-09-24 18:46:45 +02:00
Michael Koziarski
025736de8e Use ActiveSupport::SecureRandom instead of the strange fallback code. 2008-09-24 16:24:02 +02:00
Hongli Lai (Phusion)
72b772ae9b Refactor configure_dependency_for_has_many to use a few more methods. 
Add an additional conditions option to make it slightly easier for certain plugins.

Signed-off-by: Michael Koziarski <michael@koziarski.com>
[#1087 state:committed]
 2008-09-24 13:27:39 +02:00
Pivotal Labs
487758b3b8 Allowed passing arrays-of-strings to :join everywhere. Merge duplicate join strings to avoid table aliasing problems. 
Signed-off-by: Michael Koziarski <michael@koziarski.com>
[#1077 state:committed]
 2008-09-24 13:26:06 +02:00
Hongli Lai (Phusion)
70b8ea4fa6 Make AssociationCollection start transactions in the correct database. 
AssociationCollection now starts transactions by calling
AssociationCollection#transaction instead of @owner.transaction or
@reflection.klass.transaction.

Signed-off-by: Michael Koziarski <michael@koziarski.com>

[#1081 state:committed]
 2008-09-23 20:32:01 +02:00
adam
2e75bd0808 slice now returns indifferent hash if called on one 
Signed-off-by: Michael Koziarski <michael@koziarski.com>

[#1096 state:committed]
 2008-09-23 14:04:20 +02:00
adam
c452e49e76 Adds failed test case for slicing hash with indifferent access with symbol keys 
Signed-off-by: Michael Koziarski <michael@koziarski.com>
 2008-09-23 14:04:13 +02:00
Adam Cigánek
a4f2ba8fb3 Modified ActiveSupport::Inflector#parameterize with code from slugalizer (http://github.com/henrik/slugalizer) 
Handles trailing and leading slashes, and squashes repeated separators into a single character.

Signed-off-by: Michael Koziarski <michael@koziarski.com>
[#1034 state:committed]
 2008-09-23 08:08:21 +02:00
Michael Koziarski
961e2b8610 Changelog entry for manfred's multibyte changes 2008-09-22 21:52:21 +02:00
Michael Koziarski
638bd19c7f Merge branch 'patches' into multibyte 2008-09-22 21:35:35 +02:00
Michael Koziarski
5f86451a4c Bump the Version constants to align with the *next* release rather than the previous release. 
This allows people tracking non-release gems or git submodules to use the constants.
 2008-09-22 21:32:12 +02:00
Martin Rehfeld
10380a22a6 Fixed AssetTag cache with with relative_url_root [#1022 state:resolved] 
Signed-off-by: Joshua Peek <josh@joshpeek.com>
 2008-09-22 13:23:23 -05:00
Joshua Peek
900fd6eca9 Refactor AssetTagHelper and fix remaining threadsafe issues. 2008-09-22 13:12:32 -05:00
Jan De Poorter
050e58441b Association#first and last should not load the association if not needed. [#1091 state:resolved] 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2008-09-22 18:22:30 +01:00
Hongli Lai (Phusion
46939a9b5a Add Model#delete instance method, similar to Model.delete class method. [#1086 state:resolved] 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2008-09-21 22:53:44 +01:00
Manfred Stienstra
5795c509a7 Set encoding of the multibyte test helpers file to UTF-8 so the strings can be read by Ruby 1.9. 2008-09-21 18:31:15 +02:00
Manfred Stienstra
1585a7ed02 Change all calls to String#chars to String#mb_chars. 2008-09-21 18:01:15 +02:00
Manfred Stienstra
00a4286551 Change call to String#chars in inflector to String#mb_chars. 2008-09-21 17:51:01 +02:00
Manfred Stienstra
44e44b42d9 Deprecated String#chars in favor of String#mb_chars. 2008-09-21 17:47:19 +02:00
Manfred Stienstra
3c9eedec3c Move multibyte test helpers to a separate file and make the conformance tests run again. 2008-09-21 17:37:38 +02:00
Manfred Stienstra
85c05b5394 Add tests for u_unpack to make sure it raises an EncodingError on invalid UTF-8 strings. 2008-09-21 17:30:45 +02:00
Manfred Stienstra
52f8c04e1e Fix a test that assumes .mb_chars to always return an instance of the proxy_class. 2008-09-21 17:30:16 +02:00
Manfred Stienstra
809af7f558 Non-string results from forwarded methods should be returned vertabim. 2008-09-21 17:29:22 +02:00
Manfred Stienstra
b8eec5ac33 Remove special 1.9 version of excerpt helper. 2008-09-21 17:28:46 +02:00
Manfred Stienstra
bfc73852b1 Improve documentation. 2008-09-21 17:28:05 +02:00
Manfred Stienstra
7329990d86 Change all calls to String#chars to String#mb_chars. Remove a exception for Ruby <= 1.9. 2008-09-21 17:27:25 +02:00
Manfred Stienstra
8abef4fd0d All methods which normally return a string now return a proxy instance. 2008-09-21 17:25:36 +02:00
Manfred Stienstra
520c3f33c3 Change all calls to String#chars to String#mb_chars. 2008-09-21 17:23:37 +02:00
Manfred Stienstra
0211722088 Move with_kcode helper to abstract_unit. Add tests for multibyte string extensions. 2008-09-21 17:22:55 +02:00
Manfred Stienstra
042fd97127 Add a test for ActiveSupport::Multibyte::Chars.consumes?. 2008-09-21 17:22:26 +02:00
Manfred Stienstra
22f75d539d Simplify ActiveSupport::Multibyte and make it run on Ruby 1.9. 
* Unicode methods are now defined directly on Chars instead of a handler
* Updated Unicode database to Unicode 5.1.0
* Improved documentation
 2008-09-21 17:21:30 +02:00
Claudio Poli
5f83e1844c Fixed missing template paths on exception [#1082 state:resolved] 
Signed-off-by: Joshua Peek <josh@joshpeek.com>
 2008-09-20 22:57:45 -05:00
Adeh DeSandies
de96a8666d applied patch to fix the associations with blocks in modules bug from an old trac ticket 2008-09-20 13:46:09 -07:00
rick
22e830f883 Merge branch 'master' of git@github.com:rails/rails 2008-09-20 13:00:20 -07:00
Sven Fuchs
a3b7fa78bf I18n: Introduce I18n.load_path in favor of I18n.load_translations and change Simple backend to load translations lazily. [#1048 state:resolved] 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2008-09-20 19:26:16 +01:00
Sven Fuchs
8cb7d46043 I18n: move old-style interpolation syntax deprecation to Active Record. [#1044 state:resolved] 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2008-09-20 19:13:50 +01:00
Nathaniel Talbott
9d7f186f74 Fixed an error triggered by a reload followed by a foreign key assignment. 
Signed-off-by: Michael Koziarski <michael@koziarski.com>
 2008-09-20 14:16:43 +02:00
Carlos Brando
79f55de9c5 Fixed Time#end_of_quarter to not blow up on May 31st [#313 state:resolved] 
Signed-off-by: Joshua Peek <josh@joshpeek.com>
 2008-09-19 09:06:35 -05:00
Michael Koziarski
2d27b82d4c Remove the country_select helper. 
We're in no position to mediate disputes on this matter, and the previous change to use ISO 3166 has offended just as many people as the ad-hoc list did.

If you want the old list back you can install the plugin:

ruby script/plugin install git://github.com/rails/country_select.git
 2008-09-18 21:30:52 +02:00