Michael Koziarski
b7cd4ded93
Formally deprecate the old secret key generator
2008-08-27 15:18:07 +02:00
Hongli Lai (Phusion
b3411ff59e
Deprecate Rails::SecretKeyGenerator in favor of ActiveSupport::SecureRandom.
...
SecureRandom has a few minor security enhancements and can be used as a drop-in replacement
Signed-off-by: Michael Koziarski <michael@koziarski.com >
[#913 state:committed]
2008-08-27 15:08:16 +02:00
Marko Seppae
cba83ede5d
I18n: remove #populate from Simple backend as well
2008-08-27 12:00:14 +02:00
pivotal
9dbde4f5cb
Fix two has_one :through errors
...
* Set the association target on assignment;
* Reset target to nil on reset, rather than empty array.
Signed-off-by: Michael Koziarski <michael@koziarski.com >
[#895 state:committed]
2008-08-27 11:22:15 +02:00
Marko Seppae
2d03a4c668
i18n: fixed failing tests after removing #populate and #store_translations
2008-08-27 10:37:01 +02:00
Marko Seppae
0fcd5b5466
I18n: removed call to #populate from main library files
2008-08-27 10:36:00 +02:00
Marko Seppae
44de71ba94
I18n: removed #populate and #store_translations from api
2008-08-27 10:16:25 +02:00
Joshua Peek
6ec07e0737
Store application and other context specific helper modules in ActionView::Base#helpers
2008-08-26 16:17:58 -05:00
Joshua Peek
cd91a8d3ad
defined? has no bounds
2008-08-26 15:21:06 -05:00
Joshua Peek
9853134b4f
Require missing libraries and check for defined ActionController constant so ActionView can be used standalone
2008-08-26 15:13:28 -05:00
Joshua Peek
8756dd75b2
Performance: reduce garbage created by ActiveRecord::Calculations#column_alias_for
2008-08-26 14:24:52 -05:00
rick
0aef9d1a26
Merge branch 'master' of git@github.com:rails/rails
2008-08-26 11:53:33 -07:00
Joshua Peek
229eedfda8
Cache JavaScriptGenerator's helper module set on the template
2008-08-26 12:17:55 -05:00
Hongli Lai (Phusion
c111522d5b
The 'rails' command was broken by the last commit. Fix that.
...
Signed-off-by: Michael Koziarski <michael@koziarski.com >
2008-08-26 16:28:41 +02:00
Hongli Lai (Phusion
f9f1ab4e3d
When an unexpected exception is caught, tell the administrator to read the log file for more information about the error. This should make things less confusing for developers who are new to Rails.
...
Signed-off-by: Michael Koziarski <michael@koziarski.com >
2008-08-26 14:30:19 +02:00
Tarmo Tänav
eec5eb2e44
Fix yet another implicit order dependant test
...
Signed-off-by: Michael Koziarski <michael@koziarski.com >
2008-08-26 13:16:55 +02:00
Tarmo Tänav
3dfecfe773
Print the queries that were executed if assert_queries fails
2008-08-26 12:45:04 +02:00
Michael Koziarski
bb557b44e9
Be more careful
2008-08-26 12:21:48 +02:00
Michael Koziarski
86bf279b89
Re enable CI for postgresql
2008-08-26 12:14:07 +02:00
Tarmo Tänav
ce3c76de7c
Just look at sql_type when testing that the correct database-specific type was used
...
Signed-off-by: Michael Koziarski <michael@koziarski.com >
2008-08-26 12:11:01 +02:00
Jeremy Kemper
e06878c22b
Merge branch 'master' of git@github.com:rails/rails
2008-08-26 03:04:14 -07:00
Tarmo Tänav
00d2165f74
Back to fetching all versions in ruby instead of letting SQL do it as it's difficult to get all databases to convert the text value to a number with the same SQL
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2008-08-26 03:00:36 -07:00
Jeremy Kemper
ab1e82b8f7
Include people and readers fixtures to fix test isolation error
2008-08-26 02:38:48 -07:00
Jeremy Kemper
0c7bbc72fc
fix tests relying on implicit ordering
2008-08-26 02:17:36 -07:00
Jeremy Kemper
b319e69ecb
PostgreSQL: pg driver expects nil instead of empty string for missing user/pass
2008-08-26 01:54:14 -07:00
Jeremy Kemper
d2d739fd06
Merge branch 'master' of git@github.com:rails/rails
2008-08-26 01:50:32 -07:00
Tarmo Tänav
973c0ef26d
Create mysql binary_fields table with latin1 character set as with utf8 all the limits would have to be divided by 3 to get the expected text types
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2008-08-26 01:49:19 -07:00
Jeremy Kemper
11612bf956
Merge branch 'master' of git@github.com:rails/rails
2008-08-26 00:55:25 -07:00
Tarmo Tänav
fa795ccfad
Include mysql older than 5.1.23 in the 5.1 series in the list of those that can't handle NULL defaults
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2008-08-26 00:53:19 -07:00
Chad Woolley
289e3b9072
use double quotes
2008-08-26 09:40:19 +02:00
Jeremy Kemper
52e15abbed
um.. yeah
2008-08-26 00:10:16 -07:00
Jeremy Kemper
6d66ddaa34
typo
2008-08-26 00:02:30 -07:00
Jeremy Kemper
842d55cb16
fix another ordering failure
2008-08-26 00:02:22 -07:00
Jeremy Kemper
ca48da6300
fix tests relying on implicit ordering
2008-08-25 23:53:31 -07:00
Josh Susser
1092c181b5
add dynamic finder bang version to raise RecordNotFound
...
[#905 state:resolved]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2008-08-25 23:33:16 -07:00
Josh Susser
143f5fbb21
refactor dynamic finder name matching into its own class
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2008-08-25 23:32:20 -07:00
Jeremy Kemper
3beed9cdb7
ensure tests load sibling Active Support instead of a gem
2008-08-25 23:32:03 -07:00
Tarmo Tänav
77b003fb61
Use DECIMAL instead of INTEGER when casting as mysql doesn't work with just "INTEGER" and other databases don't like "UNSIGNED" which mysql requires
...
And don't mask exceptions.
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2008-08-25 23:23:34 -07:00
Tarmo Tänav
3d2ac918b9
Cache migrated versions list in Migrator and use it to fetch the latest migrated version name [ #845 state:resolved]
...
Also optimized Migrator#current_version class method to fetch
only the latest version number and not all of them.
With this change no matter how many migrations there are the
schema_migrations table is only SELECTed from once.
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2008-08-25 22:03:47 -07:00
Jeremy Kemper
4bcd64c9e9
Ruby 1.9 compat: switch profile_options to superclass_delegating_accessor
2008-08-25 22:01:02 -07:00
Tarmo Tänav
a445cdd884
Load the first and not the last has_one result when doing join-based eager loading
...
This matters when the has_one is defined with an order in which case
there is an expectation that the first one will be loaded.
[#904 state:resolved]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2008-08-25 21:23:35 -07:00
Frederick Cheung
2dbda11945
Implement old-skool eagerloading for has_one :through
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2008-08-25 21:23:15 -07:00
Jeremy Kemper
172606e21f
Harmonize framework require strategy. Don't add self to load path since Rails initializer and RubyGems handle it.
2008-08-25 21:22:34 -07:00
Frederick Cheung
b7a37b742c
Fix preloading of has_one through associations
...
[#903 state:resolved]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2008-08-25 20:49:55 -07:00
Joshua Peek
f2d8d13c64
Performance: Cache modules that extend the view context for JavaScriptGenerator
2008-08-25 21:50:26 -05:00
Joshua Peek
ba0d621695
Include all helpers into ActionView::Helper
2008-08-25 21:50:26 -05:00
Jeremy Kemper
e5cad34916
strip trailing whitespace
2008-08-25 18:16:58 -07:00
Jeremy Kemper
1c54ca4f75
Ruby 1.9 compat: fix test error masked by old String#each behavior
2008-08-25 18:16:21 -07:00
Jeremy Kemper
5e1ceb153c
Work around frozen Date memoization
2008-08-25 17:05:50 -07:00
Joshua Peek
a916c2e3d3
The view context always responds to controller, check if controller available instead
2008-08-25 15:37:19 -05:00
