github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-01-27 23:38:11 -05:00
Code Issues Packages Projects Releases Wiki Activity
10,265 Commits 34 Branches 105 Tags
github30
Commit Graph

10265 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Pratik Naik
89eec91e67 Add tests for CgiRequest#content_type 2008-07-16 03:31:45 +01:00
Pratik Naik
0f8206104e RackRequest#content_type should return Mime::Type 2008-07-16 03:18:35 +01:00
Sven Fuchs
fbe1823117 add i18n lib files 2008-07-16 04:16:08 +02:00
Sven Fuchs
731fca8cf6 remove i18n lib subproject 2008-07-16 04:15:31 +02:00
Joshua Peek
8b306bf24c Improved test coverage for fragment cache helper 2008-07-15 20:54:17 -05:00
Jeremy Kemper
ecc0543525 JavaScriptGenerator should only sets output_buffer for the duration of the update block 2008-07-15 18:42:22 -07:00
Sven Fuchs
931f366ffc merge forward to current rails/master 2008-07-16 03:41:11 +02:00
Sven Fuchs
8691e25540 reverting changes to form_options_helper for merge 2008-07-16 03:28:44 +02:00
Stefan Kaes
fbef982e4b Observers not longer add an after_find method to the observed class. 
[#625 state:resolved]
 2008-07-15 16:48:16 -07:00
David Lowenfels
c7acfbb25d requiring rubygems version 1.1.1 2008-07-15 16:28:41 -07:00
miloops
459e5817a5 update_counters should update nil values. 
This allows counter columns with default null instead of requiring default 0.

[#493 state:resolved]
 2008-07-15 16:21:11 -07:00
Jeremy Kemper
1edb5c85b5 Give more info on missing gems and abort instead of printing a warning. App can begin in incomplete state otherwise. 2008-07-15 15:50:37 -07:00
Pratik Naik
b337ab0221 Move performance test helper settings to railties 2008-07-15 21:07:25 +01:00
Joshua Peek
aca246ab25 Get buffer for fragment cache from template's @output_buffer 2008-07-15 14:43:52 -05:00
Jonathan Viney
4f72feb84c Move the transaction counter to the connection object rather than maintaining it on the current Thread. 
Signed-off-by: Michael Koziarski <michael@koziarski.com>
[#533 state:resolved]
 2008-07-15 21:25:12 +02:00
Michael Koziarski
24a8ae4e08 Try to get more useful errors out of the test_line_offset failures 2008-07-15 20:39:36 +02:00
Jeremy Kemper
3c282f3a0a Ruby 1.9 compat: only eval with block.binding in 1.9, uses more memory than eval with block 2008-07-15 10:42:50 -07:00
Jeremy Kemper
4d76bad387 Ruby 1.9 compat: account for different String#hash 2008-07-15 10:40:33 -07:00
松田 明
bb33432b0f Ruby 1.9 compat: call Proc#binding explicitly. [#623 state:resolved] 2008-07-15 10:39:02 -07:00
Adrian Mugnolo
fc89a95193 Add in_groups to ActiveSupport::CoreExtensions::Array::Grouping. [#579 state:resolved] 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2008-07-15 15:04:26 +01:00
Tarmo Tänav
c1531ae00d SQLite: rename_column raises if the column doesn't exist. 
[#622 state:resolved]
 2008-07-14 22:58:22 -07:00
Tarmo Tänav
8c91b767c0 Fixed postgresql limited eager loading for the case where scoped :order was present 2008-07-14 22:44:58 -07:00
gbuesing
3451045658 Fix TimeWithZone unmarshaling: coerce unmarshaled Time instances to utc, because Ruby's marshaling of Time instances doesn't respect the zone 2008-07-14 23:16:39 -05:00
Joshua Peek
7f0346237e Append a "_" to memoized instance variables 2008-07-14 20:25:09 -05:00
Tarmo Tänav
911c2c3813 Some performance tweaks to ActiveSupport::Memoizable 
Signed-off-by: Joshua Peek <josh@joshpeek.com>
 2008-07-14 20:23:23 -05:00
Joshua Peek
001c8beb4d memorize typo 2008-07-14 20:02:59 -05:00
Joshua Peek
dd41f66af5 Include Memoizable in ActionView::Template 2008-07-14 19:51:43 -05:00
Joshua Peek
8a9934a9d9 Added Memoizable mixin for caching simple lazy loaded attributes 2008-07-14 19:50:32 -05:00
Tarmo Tänav
d27dd860c7 Use sub instead of gsub 
Signed-off-by: Joshua Peek <josh@joshpeek.com>
 2008-07-14 18:02:59 -05:00
Joshua Peek
9dc258d614 Eager load Partial variable_name and counter_name. Tidy up render_partial_collection. 2008-07-14 17:40:58 -05:00
Tiago Macedo
76df9fa068 Fix integer quoting issues in association preload. [#602 state:resolved] 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2008-07-14 23:34:19 +01:00
Gabe da Silveira
cd9b24286a Add assert_sql helper method to check for specific SQL output in Active Record test suite. [#325 state:resolved] 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2008-07-14 23:22:39 +01:00
Jeremy Kemper
2d6562d51b Move dead recompile_template? also 2008-07-14 13:51:59 -07:00
Jeremy Kemper
3fbefecc9c Remove dead code from merge 2008-07-14 13:47:51 -07:00
Tarmo Tänav
07578ac855 Fixed mysql change_column_default to not make the column always nullable. 
Also added change_column_null to both mysql and sqlite to keep the api features closer to postgresql.

[#617 state:resolved]
 2008-07-14 12:42:01 -07:00
Tarmo Tänav
8f72bc92e2 Fixed test_rename_nonexistent_column for PostgreSQL 
Also fixed ability to run migration_test.rb alone

[#616 state:resolved]
 2008-07-14 12:22:27 -07:00
Jeremy Kemper
c760dbfd31 PostgreSQL: don't dump :limit => 4 for integers 2008-07-14 11:59:46 -07:00
Jeremy Kemper
4e323f6ef0 Fix bad merge 2008-07-14 11:50:07 -07:00
Jeremy Kemper
cdf0f1aa2e Faster and clearer value_to_boolean 2008-07-14 11:41:56 -07:00
Jeremy Kemper
269c6c6bcf Cache Module#parent_name 2008-07-14 10:46:16 -07:00
Jeremy Kemper
ae9356ae9e Cache template loading for performance tests 2008-07-14 10:46:16 -07:00
Jeremy Kemper
425de8db6a Use instance_method(...) to check whether the method exists 2008-07-14 10:46:15 -07:00
Jeremy Kemper
2167f95d85 Restore the more readable before_ and after_filters methods since they aren't called frequently 2008-07-14 10:11:53 -07:00
David Heinemeier Hansson
3037022789 Fixed that create database statements would always include "DEFAULT NULL" (Nick Sieger) [#334 status:committed] 2008-07-14 10:12:54 -05:00
Sebastian A. Espindola
0176e6adb3 Added db:charset support to PostgreSQL. [#556 state:resolved] 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2008-07-14 04:11:52 +01:00
Tim Pope
5c08607082 Make script/plugin install <plugin> -r <revision> option work with git based plugins. [#257 state:resolved] 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2008-07-14 03:47:22 +01:00
David Dollar
e0750d6a5c Add :accessible option to Associations for allowing mass assignments using hash. [#474 state:resolved] 
Allows nested Hashes (i.e. from nested forms) to hydrate the appropriate
ActiveRecord models.

class Post < ActiveRecord::Base
  belongs_to :author,   :accessible => true
  has_many   :comments, :accessible => true
end

post = Post.create({
  :title    => 'Accessible Attributes',
  :author   => { :name => 'David Dollar' },
  :comments => [
    { :body => 'First Post!' },
    { :body => 'Nested Hashes are great!' }
  ]
})

post.comments << { :body => 'Another Comment' }

Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2008-07-14 02:53:21 +01:00
Jason Dew
c6f397c5ce Add block syntax to HasManyAssociation#build. [#502 state:resolve] 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2008-07-14 02:24:12 +01:00
Rhett Sutphin
d72c66532f Make fixture accessors work when fixture name is not same as the table name. [#124 state:resolved] 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2008-07-14 02:01:52 +01:00
Jacek Becela
697ee1a50d Enable loading fixtures from arbitrary locations. [#586 state:resolved] 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2008-07-14 01:32:01 +01:00