github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-01-31 17:27:57 -05:00
Code Issues Packages Projects Releases Wiki Activity
10,265 Commits 34 Branches 105 Tags
github30
Commit Graph

10265 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Rick Olson
8afb4e136b Fix TemplateError so it doesn't bomb on exceptions while running tests [rick] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8210 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-26 03:35:04 +00:00
David Heinemeier Hansson
5ae821a7fe Add documentation about asset timestamps (just for koz) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8209 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-25 23:24:36 +00:00
David Heinemeier Hansson
18c663eb12 Allow validates_acceptance_of to use a real attribute instead of only virtual (so you can record that the acceptance occured) (closes #7457) [ambethia] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8208 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-25 22:34:46 +00:00
David Heinemeier Hansson
8a59ee921a Docfix (closes #10252) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8207 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-25 22:25:21 +00:00
David Heinemeier Hansson
9e76b59c85 Fixed that named routes living under resources shouldn't have double slashes (closes #10198) [isaacfeliu] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8206 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-25 22:24:23 +00:00
David Heinemeier Hansson
f4b5ca1ff0 Fixed that create table with :id => false and fixtures don't play nice together (closes #10154) [jbarnette] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8205 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-25 22:08:38 +00:00
David Heinemeier Hansson
ea713b6bb9 No trailing whitespace in migration generation (closes #10235) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8204 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-25 22:03:45 +00:00
David Heinemeier Hansson
566903484c Docfix (closes #10256) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8203 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-25 21:59:17 +00:00
David Heinemeier Hansson
4d96ece6ec Fix that empty collections should be treated as empty arrays regardless of whitespace for Hash#from_xml (closes #10255) [adamj] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8202 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-25 21:58:24 +00:00
David Heinemeier Hansson
ccebac9d1f Dont mind the pkg dir 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8201 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-25 21:54:18 +00:00
Michael Koziarski
7aab8b9a15 Improve error messages when providing a secret that is too short. Closes #10238 [Henrik N] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8200 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-24 22:41:16 +00:00
Geoff Buesing
becdb49186 Honor Ruby's default calendar reform setting when creating DateTime objects via ActiveRecord's Time -> DateTime overflow, Time#time_with_datetime_fallback, Time#to_datetime, Date#to_datetime and String#to_datetime. Closes #10201 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8199 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-24 04:59:21 +00:00
Geoff Buesing
d84846a636 Change Time and DateTime #end_of_month to return last second of month instead of beginning of last day of month. Closes #10200 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8198 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-24 03:57:11 +00:00
Jeremy Kemper
96add62ecc Document that the cookie store is the default session store. Mention the memcached store. Closes #10241 [Josh Susser, Jeremy Kemper] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8189 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-22 05:48:45 +00:00
Michael Koziarski
e0ce691187 Add missing sub template fixtures. References #10130 [java] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8188 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-22 05:01:43 +00:00
Michael Koziarski
155eb47cf3 Tests and fix for extension extraction. References #10130 [tarmo] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8187 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-22 05:01:07 +00:00
Jeremy Kemper
9afbf875eb Add example.log for binary escaping test. References #10176. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8186 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-22 01:30:22 +00:00
Jeremy Kemper
dd27c4e5fb PostgreSQL: correct binary escaping. References #8049, closes #10176 [jbasdf, tmacedo] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8185 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-22 01:29:19 +00:00
Michael Koziarski
ec93d61fb9 Make sure that cookie sessions use a secret that is at least 30 chars in length. [Koz] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8184 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-21 21:31:45 +00:00
David Heinemeier Hansson
13ab54db48 Cleanup documentation a bit and be more specific 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8183 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-21 20:54:43 +00:00
David Heinemeier Hansson
86883a87cc Cleanup documentation a bit and be more specific 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8182 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-21 15:55:57 +00:00
David Heinemeier Hansson
8a086c590f Emphasize the importance of a dictionary attack-proof secret for the cookie store 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8181 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-21 15:47:50 +00:00
David Heinemeier Hansson
9b83e33961 Ousted ActionWebService from Rails 2.0 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8180 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-21 15:17:04 +00:00
Jeremy Kemper
440f2890af Dynamic finders on association collections respect association :limit. Closes #10227 [Jack Danger Canty] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8178 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-21 07:32:44 +00:00
Michael Koziarski
41fb4904e2 Refactor cookie_only option to survive multiple requests and add regression tests. References #10048. [theflow] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8176 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-21 04:28:59 +00:00
Michael Koziarski
6967b422ab Make sure script/plugin doesn't skip files beginning with http (i.e. the old http_authentication plugin). Closes #7887 [choonkeat] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8175 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-21 01:53:31 +00:00
Michael Koziarski
7d459203ee Make Dynamic Finders on Association Collections Respect Association :order [patrick.t.joyce, technoweenie]. Closes #10211 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8174 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-21 01:51:57 +00:00
Michael Koziarski
cf1217a742 mailer_class is a class method not an instance method. [josh] Closes #10041 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8173 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-21 01:08:06 +00:00
Jeremy Kemper
8ed83b9b1e validates_inclusion_of and validates_exclusion_of allow formatted :message strings. Closes #8132 [devrieda, Mike Naberezny] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8172 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-20 22:01:04 +00:00
Jeremy Kemper
609a03fd2a Fix typo in generator usage blurb. Closes #10217 [Mike Naberezny] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8171 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-20 22:00:32 +00:00
Michael Koziarski
c95f066bf5 Add 'foxy' support for fixtures of polymorphic associations. Closes #10183 [jbarnette, David Lowenfels] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8170 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-20 21:53:22 +00:00
Michael Koziarski
0c12d6c6dc Ensure that the routing optimisation code isn't used when additional arguments are passed to the named route. Closes #10209 [bscofield, Koz] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8169 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-20 21:25:25 +00:00
Michael Koziarski
e1a2f3c898 Remove unnecessary route reload in integration tests, obsoleted by [7676]. Closes #10094. [Koz] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8168 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-19 23:11:26 +00:00
Rick Olson
24e6cbc724 Don't cache net/http object so that ActiveResource is more thread-safe. Closes #10142 [kou] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8167 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-19 00:06:23 +00:00
David Heinemeier Hansson
a76490d917 Fixed that partial rendering should look at the type of the first render to determine its own type if no other clues are available (like when using text.plain.erb as the extension in AM) (closes #10130) [java] Fixed that partials would be broken when using text.plain.erb as the extension #10130 [java] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8166 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-18 22:01:33 +00:00
David Heinemeier Hansson
713ca5196d Docfix (closes #10155) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8165 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-18 21:51:09 +00:00
Michael Koziarski
6d0e5eaf06 memoize host with port and refactor the tests which depend on it changing 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8164 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-17 05:41:47 +00:00
Michael Koziarski
c07eae4d40 Remove unneeded code to disable optimisations. the defined?(request) stuff takes care of this now. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8163 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-17 03:57:42 +00:00
Michael Koziarski
d7ff645e31 Use debug, not info as log_info will discard the information if info is used. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8162 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-17 03:57:19 +00:00
Jeremy Kemper
129b3bdcea Clarify Array#in_groups_of implementation, don't dup unless needed, only require enumerator once. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8161 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-17 02:48:08 +00:00
Jeremy Kemper
bff217272d RAILS_GEM_VERSION may be set to any valid gem version specifier. Closes #10057. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8160 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-17 01:39:19 +00:00
Jeremy Kemper
4249ffe249 Load config/preinitializer.rb, if present, before loading the environment. Closes #9943. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8159 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-17 01:38:58 +00:00
Jeremy Kemper
24c9250968 Table names aren't nested: replace / with _ to match the likely table name. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8158 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-16 23:01:24 +00:00
Jeremy Kemper
ace7518fcb Resource and scaffold generators pass on the full name to the dependent model, so nested resources give a corresponding nested model. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8157 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-16 22:56:40 +00:00
Jeremy Kemper
473202df83 attr_readonly behaves well with optimistic locking. Closes #10188. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8156 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-16 20:31:24 +00:00
Jeremy Kemper
32602acdb7 Remove components mention from railties README. Closes #10182 [sjgman9] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8155 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-16 20:31:01 +00:00
Jeremy Kemper
9f43627d2f Use the new TestCase subclasses in the scaffold and resource generators also. Closes #10174 [bscofield] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8154 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-16 20:30:28 +00:00
Jeremy Kemper
65a29b3433 MacOS X -> Mac OS X. Closes #10171 [henrik@nyh.se] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8153 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-16 20:29:45 +00:00
Jeremy Kemper
aa9e5a4339 Use Leopard's native mysql_config. Closes #10167 [Robert Evans] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8146 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-15 00:25:19 +00:00
Jeremy Kemper
1225b2f76e Remove warning about fixture loading order from test_helper since we disable foreign key checks now. [Mike Clark] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8145 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-14 22:50:56 +00:00