github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity
17,908 Commits 34 Branches 105 Tags
v3.0.0_RC2
Commit Graph

4896 Commits

Author SHA1 Message Date
David Heinemeier Hansson
8931dd17a9 Prep for RC2 2010-08-23 21:15:48 -05:00
Andrew White
df0a7bfb8f Cache the symbolized path parameters using a instance variable in the request object rather than the environment hash. This it to prevent stale parameters in later routing constraints/redirects as only the normal path parameters are set by Rack::Mount. 
Also if a constraint proc arity is more than one, pass the symbolized path parameters
as the first argument to match redirect proc args and provide easier access.

[#5157 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-08-22 16:18:42 -03:00
Nick Sieger
b4a520874a Fix hash modification during iteration in Mapper [#5420] 
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2010-08-20 18:28:19 -03:00
Andrew White
47f6d8b880 Support routing constraints in functional tests 
Extend assert_recognizes and assert_generates to support passing
full urls as the path argument. This allows testing of routing
constraints such as subdomain and host within functional tests.

[#5005 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-08-20 14:51:50 -03:00
Andrew White
47280f083a Don't add the standard https port when using redirect in routes.rb and ensure that request.scheme returns https when using a reverse proxy. 
[#5408 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-08-20 10:41:43 -03:00
Andrew White
c6391e6676 Allow symbols for :path resource(s) option [#5306 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-08-20 09:33:33 -03:00
José Valim
8f2b2781b0 Use attribute readers as they are faster in general. 2010-08-19 15:15:46 -03:00
Andrew White
6b52a58f72 Move regexps in options hash to :constraints hash so that they are pushed into the scope [#5208 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-08-19 15:09:46 -03:00
Andrew White
1031fe1478 Move edit route before show route so that it will have precedence if the :id parameter allows slashes [#5409 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-08-19 15:09:40 -03:00
wycats
06632578c2 Revert "It's snowing!" 
This reverts commit e4283007d6.
 2010-08-18 16:49:34 -07:00
Javier Martín
12f7f7a714 Don't pluralize resource methods [#4704 state:resolved] 
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2010-08-18 13:58:21 -03:00
Andre Arko
c40856c46c Allow member actions (get, etc) to accept strings, with test 2010-08-18 07:36:49 +08:00
José Valim
047e411fd2 annoted_source_code may return nil if an erro rhappens during template compiling. 2010-08-16 14:12:07 -03:00
wycats
b8ec4eaac5 find .text.html and .text.plain files, and deprecate it 2010-08-15 15:27:57 -07:00
Subba Rao Pasupuleti
dbe5ae488e select tags coerce the :selected option, options to strings before comparison [#5056 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-08-15 16:54:31 -03:00
Bryce Thornton
1091a6e9b7 Allow for any possible TLD when using the :all option with the cookie session store. This works for subdomain.mysite.local, google.co.uk, google.com.au, etc. [#5147 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-08-15 16:54:31 -03:00
Mikel Lindsaar
88fc37ff03 Making time_zone_options_for_select return a html_safe string 
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2010-08-15 09:59:24 -03:00
Mark Hayes
f6f7ae4020 in Rendering objects with RecordIdentifier example, locals should reference @account not @buyer 2010-08-14 13:26:03 +02:00
Santiago Pastorino
3270c58ebb Deletes trailing whitespaces (over text files only find * -type f -exec sed 's/[ \t]*$//' -i {} \;) 2010-08-14 04:20:06 -03:00
Aaron Patterson
79e15f0340 removing a lolinject 2010-08-13 14:45:06 -07:00
Santiago Pastorino
3698da65e5 Moves local_request? to require.local? 
[#5361 state:committed]
 2010-08-13 18:17:26 -03:00
Jeremy Kemper
e4283007d6 It's snowing! 2010-08-12 13:32:39 -07:00
wycats
f2d22ecbb3 Replace snowman with utf8=✓ 2010-08-11 18:37:06 -07:00
Xavier Noria
bfd728182c no need to assign if we are gonna return 2010-08-12 00:15:43 +02:00
José Valim & Carlos Antonio da Silva
1fbcd5f5fc layout_for works again with objects as specified in the documentation and Rails 2.3 [#5357 state:resolved] 2010-08-11 10:27:11 -03:00
wycats
dd7e872e85 Properly deprecate register_javascript_include_default and reset_javascript_include_default 2010-08-09 12:42:09 -07:00
wycats
f85b206e7a rename _snowman to _e 2010-08-09 12:06:51 -07:00
wycats
22cbc3f0fa Improve best_standards_support to use only IE=Edge in development mode 2010-08-09 11:48:53 -07:00
Xavier Noria
efb2bd0409 adds missing requires for Object#try 2010-08-09 15:14:00 +02:00
Xavier Noria
28d82bd2e9 adds URL to the body generated by the redirect macro in the routes mapper as per the RFC, extracts common test pattern into a test macro, adds a test to cover the :status option 2010-08-09 13:32:45 +02:00
Łukasz Strzałkowski
18bcc548bf Typo in class name 2010-08-05 05:28:39 +08:00
Piotr Sarnacki
4da32babdf Reload action_methods in AbstractController after defining new method. 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-08-04 14:45:55 -03:00
wycats
32d840d98a Concernify SanitizeHelper and TextHelper so including TextHelper correctly include SanitizeHelper and extends its ClassMethods 2010-08-04 03:20:44 -07:00
wycats
bd1cf94a29 Add a fake UrlRewriter, since instantiating it in tests happens, but is basically crazysauce 2010-08-04 03:20:08 -07:00
wycats
109dc3c39c Deprecate the @controller instance variable 2010-08-03 14:23:46 -07:00
wycats
af8e085190 Move the deprecations before the load hooks 2010-08-03 12:50:41 -07:00
wycats
84703be5ff Deprecate ActionController::UrlWriter properly 2010-08-03 12:41:18 -07:00
wycats
43cc69cb65 Fix the session= deprecation to include the secret key 2010-08-03 12:31:39 -07:00
wycats
01186652cc Even though exempt_from_layout is no longer needed, some people are still using it. Deprecate it instead of removing. 2010-08-03 12:29:03 -07:00
Samuel Lebeau
a44779e9bb Avoid potentially expensive inspect call in router. [#4491 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-08-03 12:03:45 +02:00
Carlos Antonio da Silva
11614bddc0 Fix label form helper to use I18n and html options, without the need of 'nil' text param: 
Before: f.label :title, nil, :class => 'title'
  After : f.label :title, :class => 'title'

[#5267 state:committed]

Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2010-08-01 21:51:54 -03:00
Santiago Pastorino
fb0bd8c109 Makes form_helper use overriden model accessors 
[#3374 state:committed]
 2010-08-01 19:32:22 -03:00
Rohit Arondekar
48d85a61bc API Docs: Use 'HTTP_AUTHORIZATION' and not :authorize as key in integration tests. 2010-07-30 02:12:35 -07:00
Xavier Noria
755af49755 edit pass to apply API guideline wrt the use of "# =>" in example code 2010-07-30 02:30:04 +02:00
José Valim
0f0bdaea7b Revert "Avoid uneeded queries in session stores if sid is not given." 
First step to merge Rails and Rack session stores. Rack always expects to receive the SID since it may have different behavior if the SID is nil.

This reverts commit e210895ba9.
 2010-07-29 09:10:01 +02:00
wycats
aa24ea41d0 Forgot to check in this new file 2010-07-27 20:38:26 -07:00
wycats
123eb25fd1 Add a header that tells Internet Explorer (all versions) to use the best available standards support. This ensures that IE doesn't go into quirks mode because it has been blacklisted by too many users pressing the incompatible button. It also tells IE to use the ChromeFrame renderer, if the user has installed the plugin. 
This guarantees that the best available standards support will be used on the client.
 2010-07-27 19:25:07 -07:00
David Heinemeier Hansson
856fc4bbc3 Prep for RC 2010-07-26 12:53:25 -05:00
Wincent Colaiuta
c819c131f2 doc: cleanup respond_to documentation 
Signed-off-by: Wincent Colaiuta <win@wincent.com>
 2010-07-26 18:55:51 +02:00
Łukasz Strzałkowski
da845275dd Removed deprecated APIs in text and number helpers [#5156 state:resolved] 
They're deprecated since 2008. It's time to get rid of them.

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-26 17:26:59 +02:00