Jeroen van Dijk bc1c8d58ec Make ActiveModel::Errors#add_on_blank and #add_on_empty accept an options hash and make various Validators pass their (filtered) options. ...

This makes it possible to pass additional options through Validators to message
generation. E.g. plugin authors want to add validates_presence_of :foo, :format
=> "some format".

Also, cleanup the :default vs :message options confusion in ActiveModel
validation message generation.

Also, deprecate ActiveModel::Errors#add_on_blank(attributes, custom_message) in
favor of ActiveModel::Errors#add_on_blank(attributes, options).

Original patch by Sven Fuchs, some minor changes and has been changed to be applicable to master again

[#4057 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>

2010-05-15 11:17:58 -07:00

..

associations

Fix for get_ids when including a belongs_to association on a has_many association [#2896 state:resolved]

2010-05-15 16:53:59 +01:00

validations

Make ActiveModel::Errors#add_on_blank and #add_on_empty accept an options hash and make various Validators pass their (filtered) options.

2010-05-15 11:17:58 -07:00

active_schema_test_mysql.rb

Revert "Revert "Add index length support for MySQL [#1852 state:open]""

2010-05-09 12:42:48 +01:00

active_schema_test_postgresql.rb

Revert "When creating database with rake, create schemas in schema_search_path if it doesn't exist."

2010-04-09 11:30:40 +12:00

adapter_test.rb

Revert "When creating database with rake, create schemas in schema_search_path if it doesn't exist."

2010-04-09 11:30:40 +12:00

aggregations_test.rb

Cherry-pick core extensions

2009-05-13 12:00:15 -07:00

ar_schema_test.rb

ActiveRecord should raise an error on invalid migration types.

2010-02-28 11:53:48 +01:00

associations_test.rb

restricts a test to < 1.9, and rewrites it using a proper expectation

2010-03-13 17:04:08 -06:00

attribute_methods_test.rb

1=2 is invalid expression in Oracle SELECT

2009-08-06 23:40:59 +03:00

autosave_association_test.rb

Drop AR I18n deprecation and simple use errors.messages as fallback.

2010-01-30 13:12:12 +01:00

base_test.rb

Reset quoted_table_name after set_table_name [#4568 state:resolved]

2010-05-15 18:53:47 +01:00

batches_test.rb

corrected AR find_each and find_in_batches to raise when the user uses select but does not specify the primary key

2010-05-09 13:14:47 +03:00

binary_test.rb

Remove SQL Server cases from tests for latest adapter work to pass rails expected behavior.

2008-11-19 18:00:56 +01:00

calculations_test.rb

type_cast_calculated_value refactor: value is never a Fixnum here. Fix test since SQLite returns Float.

2010-05-11 22:29:26 -07:00

callbacks_test.rb

Remove test ordering bug by using another class

2010-03-22 10:00:03 -07:00

column_alias_test.rb

Merge branch 'ar-test-cleanup' of git://git.geeksomnia.com/rails

2008-01-21 17:20:51 +00:00

column_definition_test.rb

Add tests for postgresql column type mapping updates [#4270 state:resolved]

2010-03-31 19:22:54 -03:00

connection_pool_test.rb

Add test case for ActiveRecord::ConnectionAdapters::ConnectionManagement.

2009-02-25 12:48:53 -06:00

connection_test_firebird.rb

Merge branch 'ar-test-cleanup' of git://git.geeksomnia.com/rails

2008-01-21 17:20:51 +00:00

connection_test_mysql.rb

Enable use of MySQL stored procedures by default.

2009-09-17 10:57:03 -07:00

copy_table_test_sqlite.rb

Missing customers fixture

2009-11-13 10:38:23 -08:00

database_statements_test.rb

Oracle needs sequence value for primary key in INSERT statement

2009-08-06 23:40:59 +03:00

datatype_test_postgresql.rb

clearing up many warnings, removing unnecessary regular expresion comparisons [#4365 state:resolved]

2010-04-10 22:13:42 -07:00

date_time_test.rb

Revert "fallback_string_to_date sets Date._parse comp arg to true, so that strings with two-digit years, e.g. '1/1/09', are interpreted as modern years" [#2019 state:wontfix]

2009-08-05 08:26:12 -05:00

default_test_firebird.rb

Merge branch 'ar-test-cleanup' of git://git.geeksomnia.com/rails

2008-01-21 17:20:51 +00:00

defaults_test.rb

cleaning up a bunch of parse time warnings in AR [#4186 state:resolved]

2010-03-15 18:22:31 -07:00

deprecated_finder_test.rb

Fix file permissions

2008-07-31 16:36:23 -05:00

dirty_test.rb

Dirty datetime attributes should be aware of time zone info [#3658 state:resolved]

2010-04-08 10:26:16 -07:00

finder_respond_to_test.rb

Ensure that respond_to? considers dynamic finder methods. Closes #11538. [floehopper]

2008-04-06 22:26:15 +00:00

finder_test.rb

Make find_or_create and find_or_initialize work mixing explicit parameters and a hash [#4457 state:committed]

2010-05-07 09:40:02 -07:00

fixtures_test.rb

Support fixtures for namespaced models [#2965 state:resolved]

2010-04-25 16:04:38 +02:00

helper.rb

restricts a test to < 1.9, and rewrites it using a proper expectation

2010-03-13 17:04:08 -06:00

i18n_test.rb

Move validator, human_name and human_attribute_name to ActiveModel, remove deprecated error messages and add i18n_scope and lookup_ancestors.

2009-10-20 17:52:32 -07:00

inheritance_test.rb

Changed ActiveRecord::Base.store_full_sti_class to be true by default reflecting the previously announced Rails 3 default [DHH]

2010-01-03 19:30:28 -08:00

invalid_date_test.rb

Oracle adapter returns Time value for DATE columns

2009-08-06 23:40:59 +03:00

json_serialization_test.rb

Reset class attribute after changing it

2010-03-22 10:00:04 -07:00

lifecycle_test.rb

ActiveModel::Observing: stop using Observable Ruby module, re-implement notify_observers

2010-04-16 13:09:07 -07:00

locking_test.rb

eliminate alias_method_chain from ActiveRecord

2010-05-09 02:37:52 +03:00

log_subscriber_test.rb

cleaning up a bunch of parse time warnings in AR [#4186 state:resolved]

2010-03-15 18:22:31 -07:00

method_scoping_test.rb

Modified default_scope to merge with any pre-existing default_scope

2010-05-15 08:38:28 +02:00

migration_test_firebird.rb

Merge branch 'ar-test-cleanup' of git://git.geeksomnia.com/rails

2008-01-21 17:20:51 +00:00

migration_test.rb

Revert "Revert "Add index length support for MySQL [#1852 state:open]""

2010-05-09 12:42:48 +01:00

mixin_test.rb

Force timestamp update

2008-03-31 03:57:25 +00:00

modules_test.rb

Refactor compute_type to handle situations where the correct class is already loaded

2010-04-12 21:31:20 -07:00

multiple_db_test.rb

Rename active_relation_engine -> arel_engine and active_relation_table -> arel_table

2010-01-16 16:02:30 +05:30

named_scope_test.rb

STI should not ignore type condition while applying scopes from parent class scopes

2010-05-15 09:48:49 +02:00

nested_attributes_test.rb

Use primary key in conditions, not 'id' [#4395 state:resolved]

2010-05-04 22:45:08 +01:00

pk_test.rb

Fix dom_id for ActiveRecord [#4296 state:resolved]

2010-03-30 01:32:26 +02:00

pooled_connections_test.rb

Move AR logging responsibilities to ActiveRecord::Railties::Subscriber.

2010-01-13 01:19:23 +01:00

query_cache_test.rb

Clear the query cache between tests that test the query cache

2010-03-22 10:00:04 -07:00

readonly_test.rb

Don't publicize with_scope for tests since it may shadow public misuse

2009-12-28 14:07:23 -08:00

reflection_test.rb

removing dead code from activerecord tests. [#4187 state:resolved]

2010-03-15 18:36:08 -07:00

relations_test.rb

Add Relation extensions

2010-04-02 17:38:02 +01:00

reload_models_test.rb

Add missing fixture to allow reload models test to run isolated [#1609 state:resolved]

2008-12-20 20:39:25 +00:00

reserved_word_test_mysql.rb

Merge branch 'ar-test-cleanup' of git://git.geeksomnia.com/rails

2008-01-21 17:20:51 +00:00

sanitize_test.rb

Change all calls to String#chars to String#mb_chars.

2008-09-21 18:01:15 +02:00

schema_authorization_test_postgresql.rb

In PostgreSQLAdapter, switch tables query to use current_schemas function [#918 state:resolved]

2010-03-26 17:18:33 -07:00

schema_dumper_test.rb

Revert "primary_key now supports :limit for MySQL". Break Sam Ruby app.

2010-03-27 14:39:43 +01:00

schema_test_postgresql.rb

mode postgresql adapters table_exists? method take the schema in to account. [#4341 state:resolved]

2010-04-11 14:53:24 -07:00

serialization_test.rb

to_xml with :include should skip_instruct on the included records [#4506 state:resolved]

2010-04-30 14:22:57 +02:00

synonym_test_oracle.rb

Merge branch 'ar-test-cleanup' of git://git.geeksomnia.com/rails

2008-01-21 17:20:51 +00:00

timestamp_test.rb

Revert "Changed behavior of touch and added touch! Originally implemented by Obie Fernandez, updated touch! to act as a thin wrapper to touch. [#2520 state:resolved]"

2010-03-27 08:22:32 +00:00

transaction_callbacks_test.rb

Update after_commit and after_rollback docs and tests to use new style API with an :on options instead of on_* suffix.

2010-04-29 18:26:19 -07:00

transactions_test.rb

Add after_commit and after_rollback callbacks to ActiveRecord that are called after transactions either commit or rollback on all records saved or destroyed in the transaction.

2010-04-29 12:24:15 -07:00

unconnected_test.rb

Fix file permissions

2008-07-31 16:36:23 -05:00

validations_repair_helper.rb

Simplify repair_validations on AR and make it work with new callbacks.

2010-01-01 03:20:38 +01:00

validations_test.rb

Remove undocumented save_without_validation!

2010-05-11 15:39:29 +01:00

xml_serialization_test.rb

test cases for record.to_xml [#458 state:resolved]

2010-04-30 13:19:30 +02:00

yaml_serialization_test.rb

Added #to_i to DateTime in ActiveSupport so #to_yaml works correctly on ActiveRecord models with DateTime attributes.

2009-12-15 08:15:21 -06:00