diff --git a/r2/r2/controllers/api.py b/r2/r2/controllers/api.py index fa6390e31..7a7a8e0f2 100644 --- a/r2/r2/controllers/api.py +++ b/r2/r2/controllers/api.py @@ -2272,7 +2272,8 @@ class ApiController(RedditController): VModhash(), flair_enabled = VBoolean("flair_enabled"), flair_position = VOneOf("flair_position", ("left", "right")), - link_flair_position = VOneOf("link_flair_position", ("left", "right")), + link_flair_position = VOneOf("link_flair_position", + ("", "left", "right")), flair_self_assign_enabled = VBoolean("flair_self_assign_enabled")) @api_doc(api_section.flair) def POST_flairconfig(self, form, jquery, flair_enabled, flair_position, diff --git a/r2/r2/models/link.py b/r2/r2/models/link.py index a78e6e6ef..e115fe871 100644 --- a/r2/r2/models/link.py +++ b/r2/r2/models/link.py @@ -259,6 +259,12 @@ class Link(Thing, Printable): s.append(getattr(wrapped, 'media_object', {})) s.append(wrapped.flair_text) s.append(wrapped.flair_css_class) + + # if browsing a single subreddit, incorporate link flair position + # in the key so 'flair' buttons show up appropriately for mods + if hasattr(c.site, '_id'): + s.append(c.site.link_flair_position) + return s def make_permalink(self, sr, force_domain = False): diff --git a/r2/r2/models/subreddit.py b/r2/r2/models/subreddit.py index 0776364d9..d6fe4e20d 100644 --- a/r2/r2/models/subreddit.py +++ b/r2/r2/models/subreddit.py @@ -75,7 +75,7 @@ class Subreddit(Thing, Printable): link_type = 'any', # one of ('link', 'self', 'any') flair_enabled = True, flair_position = 'right', # one of ('left', 'right') - link_flair_position = 'left', # one of ('left', 'right') + link_flair_position = '', # one of ('', 'left', 'right') flair_self_assign_enabled = False, ) _essentials = ('type', 'name', 'lang') diff --git a/r2/r2/templates/flairpane.html b/r2/r2/templates/flairpane.html index 3de969c26..1ce5d6210 100644 --- a/r2/r2/templates/flairpane.html +++ b/r2/r2/templates/flairpane.html @@ -62,6 +62,9 @@ %utils:line_field> <%utils:line_field title="${_('link flair position')}">